hanged, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern
+
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern
On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote:
> Added new procfs flag to toggle the automatic addition of prefix
> routes on a per device basis. The new flag is accept_ra_prefix_route.
>
> A value of 0 for the flag maybe used in some forwarding scenarios
> when a userspace daemon is m
sed is to add a variant of nexthop_fib6_nh() to use
> rcu_dereference_bh_rtnl() for ipv6_route_seq_show().
>
...
>
> Fixes: f88d8ea67fbdb ("ipv6: Plumb support for nexthop object in a fib6_info")
> Reported-by: syzbot
> Signed-off-by: Wei Wang
> Cc: David Ahern
>
On 3/9/21 1:02 PM, Steven Rostedt wrote:
> On Tue, 9 Mar 2021 12:53:37 -0700
> David Ahern wrote:
>
>> Changing the order of the fields will impact any bpf programs expecting
>> the existing format
>
> I thought bpf programs were not API. And why are they not parsi
On 3/9/21 1:02 PM, Steven Rostedt wrote:
> On Tue, 9 Mar 2021 12:53:37 -0700
> David Ahern wrote:
>
>> Changing the order of the fields will impact any bpf programs expecting
>> the existing format
>
> I thought bpf programs were not API. And why are they not parsi
On 3/9/21 10:40 AM, Steven Rostedt wrote:
> The order of the fields is important. Don't worry about breaking API by
> fixing it. The parsing code uses this output to find where the binary data
> is.
Changing the order of the fields will impact any bpf programs expecting
the existing format.
On 3/9/21 10:40 AM, Steven Rostedt wrote:
> The order of the fields is important. Don't worry about breaking API by
> fixing it. The parsing code uses this output to find where the binary data
> is.
Changing the order of the fields will impact any bpf programs expecting
the existing format.
On 3/9/21 10:32 AM, Wei Wang wrote:
> Thanks David and Ido.
> To clarify, David, you suggest we add a separate function instead of
> adding an extra parameter, right?
for this case I think it is the better way to go.
3 insertions(+)
>
Reviewed-by: David Ahern
3 insertions(+)
>
Reviewed-by: David Ahern
3 insertions(+)
>
Reviewed-by: David Ahern
___
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
[ cc Ido and Petr ]
On 3/8/21 12:21 PM, Wei Wang wrote:
> diff --git a/include/net/nexthop.h b/include/net/nexthop.h
> index 7bc057aee40b..48956b144689 100644
> --- a/include/net/nexthop.h
> +++ b/include/net/nexthop.h
> @@ -410,31 +410,39 @@ static inline struct fib_nh *fib_info_nh(struct
> fib_
On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
>> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>>>> index b1690149b6fa..cc1b6457fc93 100644
>>>>
On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
>> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>>>> index b1690149b6fa..cc1b6457fc93 100644
>>>>
On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
>> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>>>> index b1690149b6fa..cc1b6457fc93 100644
>>>>
On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>> index b1690149b6fa..cc1b6457fc93 100644
>> --- a/net/mpls/mpls_gso.c
>> +++ b/net/mpls/mpls_gso.c
>> @@ -27,7 +27,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff
>> *skb,
>>
>>
On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>> index b1690149b6fa..cc1b6457fc93 100644
>> --- a/net/mpls/mpls_gso.c
>> +++ b/net/mpls/mpls_gso.c
>> @@ -27,7 +27,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff
>> *skb,
>>
>>
On 3/8/21 9:07 AM, Willem de Bruijn wrote:
>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
>> index b1690149b6fa..cc1b6457fc93 100644
>> --- a/net/mpls/mpls_gso.c
>> +++ b/net/mpls/mpls_gso.c
>> @@ -27,7 +27,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff
>> *skb,
>>
>>
On 3/8/21 12:21 AM, ze wang wrote:
> mlxconfig tool from mft tools version 4.16.52 or higher to set number of SF.
>
> mlxconfig -d b3:00.0 PF_BAR2_ENABLE=0 PER_PF_NUM_SF=1 PF_SF_BAR_SIZE=8
> mlxconfig -d b3:00.0 PER_PF_NUM_SF=1 PF_TOTAL_SF=192 PF_SF_BAR_SIZE=8
> mlxconfig -d b3:00.1 PER_PF_NUM_
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote:
> Main goal is that 100.255.254.3 should be reachable from vrf2. But
> after this setup it doesn’t work. When i run `ping -I vrf2
> 100.255.254.3` it sends packets from source address that belongs to
> vlan1 enslaved by vrf1. I can see in tcpdump that ICM
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote:
> Hi. I need a help to understand why VRF leaking doesn’t work in my situation.
> I want to set up leaking between 2 VRFs, that are set up by following
> commands:
>
> # Setup bridge
> sudo ip link add bridge type bridge
>
> # Setup V
On 3/1/21 3:56 AM, Parav Pandit wrote:
> This series uses utils helper for socket operations, string
> processing and print error messages.
>
> Patch summary:
> Patch-1 uses utils library helper for string split and string search
> Patch-2 extends library for socket receive operation
> Patch-3 con
quivalent to me. Code wise:
Reviewed-by: David Ahern
The commit message needs more words about the change.
On 2/28/21 5:53 PM, Henry Shen wrote:
> When an IPv4 packet with a destination address of broadcast is received
> on an ingress interface, it will not be forwarded out of the egress
> interface if the ingress interface is not configured with bc_forwarding
> but the egress interface is. If both the
On 2/28/21 5:53 PM, Henry Shen wrote:
> When an IPv4 packet with a destination address of broadcast is received
> on an ingress interface, it will not be forwarded out of the egress
> interface if the ingress interface is not configured with bc_forwarding
> but the egress interface is. If both the
On 2/19/21 1:42 PM, Paolo Abeni wrote:
> The feature is supported by the kernel since 5.11-net-next,
> let's allow user-space to use it.
>
> Just parse and dump an additional, per endpoint, u16 attribute
>
> Signed-off-by: Paolo Abeni
> ---
> ip/ipmptcp.c| 16 ++--
> man/man
gt; + run_cmd "$IP link set dev lo down"
> + check_nexthop "id 2" "id 2 blackhole"
> + log_test $? 0 "Blackhole nexthop with loopback device down"
> +
> + run_cmd "$IP link set dev lo up"
> +
> #
> # groups
> #
>
Thanks for adding a test.
Reviewed-by: David Ahern
TDEV_UNREGISTER:
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGE:
> if (!(dev_get_flags(dev) & (IFF_RUNNING | IFF_LOWER_UP)))
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGEMTU:
> info_ext = ptr;
>
LGTM. I suggest submitting without the RFC.
Reviewed-by: David Ahern
On 2/22/21 9:32 AM, Kaustubh Pandey wrote:
> When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised.
>
> addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route ->
> fib6_nh_mtu_change
>
> As part of handling NETDEV_CHANGEMTU notification we land up on a
> condition where if rout
On 2/22/21 9:32 AM, Kaustubh Pandey wrote:
> When netdevice MTU is increased via sysfs, NETDEV_CHANGEMTU is raised.
>
> addrconf_notify -> rt6_mtu_change -> rt6_mtu_change_route ->
> fib6_nh_mtu_change
>
> As part of handling NETDEV_CHANGEMTU notification we land up on a
> condition where if rout
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF:
On 2/22/21 1:37 AM, Eric Dumazet wrote:
>
>
> On 2/22/21 4:15 AM, Yejune Deng wrote:
>> The arp_hh_ops structure is similar to the arp_generic_ops structure.
>> but the latter is more general,so remove the arp_hh_ops structure.
>>
>> Fix when took out the neigh->ops assignment:
>> 8.973653] #PF:
On 2/19/21 9:32 PM, Yejune Deng wrote:
> static const struct neigh_ops arp_direct_ops = {
> .family = AF_INET,
> .output = neigh_direct_output,
> @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh)
> memcpy(neigh->
On 2/19/21 9:32 PM, Yejune Deng wrote:
> static const struct neigh_ops arp_direct_ops = {
> .family = AF_INET,
> .output = neigh_direct_output,
> @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh)
> memcpy(neigh->
On 2/17/21 9:06 AM, Муравьев Александр wrote:
> Hi
>
> A noob question that I haven't found an answer.
>
> Just wanted to clarify a piece of iproute2 code.
>
> ip/iplink.c:
>
>> 1058 addattr_l(&req.n, sizeof(req), IFLA_INFO_KIND, type,
>> 1059 strlen(type));
>
> also ip/ip
On 2/17/21 7:01 AM, Or Gerlitz wrote:
>>> @@ -1136,6 +1265,10 @@ static int nvme_tcp_try_send_cmd_pdu(struct
>>> nvme_tcp_request *req)
>>> else
>>> flags |= MSG_EOR;
>>>
>>> + if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) &&
>>> + blk_rq_nr_phys_segments(rq) && r
On 2/15/21 11:16 PM, Leon Romanovsky wrote:
> On Mon, Feb 15, 2021 at 06:56:26PM -0700, David Ahern wrote:
>> On 2/14/21 10:40 PM, Leon Romanovsky wrote:
>>> On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote:
>>>> what does iproute2-rc mean?
>&g
On 2/14/21 10:40 PM, Leon Romanovsky wrote:
> On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote:
>> what does iproute2-rc mean?
>
> Patch target is iproute2.git:
> https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/
so you are asking them to be committed fo
On 2/15/21 5:03 AM, Dan Carpenter wrote:
> Hi Arjun,
>
> url:
> https://github.com/0day-ci/linux/commits/Arjun-Roy/tcp-Sanitize-CMSG-flags-and-reserved-args-in-tcp_zerocopy_receive/20210212-052537
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> e4b62cf7559f2ef9a
On 2/14/21 1:09 AM, Thayne McCombs wrote:
> Doh! Sorry about that, here it is with the sign-off.
>
> -- >8 --
Don't put text here.
>
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided
what does iproute2-rc mean?
On 2/11/21 2:10 PM, Boris Pismenny wrote:
>
> +static int nvme_tcp_teardown_ddp(struct nvme_tcp_queue *queue,
> + u16 command_id,
> + struct request *rq)
> +{
> + struct nvme_tcp_request *req = blk_mq_rq_to_pdu(rq);
> + struct net_
On 2/11/21 2:10 PM, Boris Pismenny wrote:
> @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct
> nvme_tcp_request *req,
> return nvme_tcp_pdu_data_left(req) <= len;
> }
>
> +#ifdef CONFIG_TCP_DDP
> +
> +static bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u3
On 2/14/21 4:40 AM, Taehee Yoo wrote:
>
>
> On 21. 2. 14. 오전 4:58, David Ahern wrote:
>> your patches still show up as 8 individual emails.
>>
>> Did you use 'git send-email --thread --no-chain-reply-to' as Jakub
>> suggested? Please read the git-sen
On 2/5/21 11:36 PM, Thayne McCombs wrote:
> The sport and dport conditions in expressions were inconsistent on
> whether there should be a ":" at the beginning of the port when only a
> port was provided depending on the family. The link and netlink
> families required a ":" to work. The vsock fami
On 2/9/21 2:12 AM, Amit Cohen wrote:
> The kernel signals when offload fails using the 'RTM_F_OFFLOAD_FAILED'
> flag. Print it to help users understand the offload state of the route.
> The "rt_" prefix is used in order to distinguish it from the offload state
> of nexthops, similar to "rt_offload"
your patches still show up as 8 individual emails.
Did you use 'git send-email --thread --no-chain-reply-to' as Jakub
suggested? Please read the git-send-email man page for what the options do.
On 2/8/21 1:42 PM, Petr Machata wrote:
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index 5d560d381070..4ce282b0a65f 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c> @@ -734,6 +834,22 @@ static struct nexthop
*nexthop_select_path_mp(struct nh_group *nhg, int hash)
> r
On 2/8/21 1:42 PM, Petr Machata wrote:
> @@ -212,7 +254,7 @@ static inline bool nexthop_is_multipath(const struct
> nexthop *nh)
> struct nh_group *nh_grp;
>
> nh_grp = rcu_dereference_rtnl(nh->nh_grp);
> - return nh_grp->mpath;
> + return nh_g
On 2/13/21 12:16 PM, Ido Schimmel wrote:
> On Sat, Feb 13, 2021 at 11:57:03AM -0700, David Ahern wrote:
>> On 2/8/21 1:42 PM, Petr Machata wrote:
>>> To illustrate the usage, consider the following commands:
>>>
>>> # ip nexthop add id 1 via 192.0.2.2 dev d
On 2/8/21 1:42 PM, Petr Machata wrote:
> @@ -52,8 +53,50 @@ enum {
> NHA_FDB,/* flag; nexthop belongs to a bridge fdb */
> /* if NHA_FDB is added, OIF, BLACKHOLE, ENCAP cannot be set */
>
> + /* nested; resilient nexthop group attributes */
> + NHA_RES_GROUP,
> + /
On 2/8/21 1:42 PM, Petr Machata wrote:
> To illustrate the usage, consider the following commands:
>
> # ip nexthop add id 1 via 192.0.2.2 dev dummy1
> # ip nexthop add id 2 via 192.0.2.3 dev dummy1
> # ip nexthop add id 10 group 1/2 type resilient \
> buckets 8 idle_timer 60 unbalanced_t
On 2/9/21 3:31 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Signed-off-by: Oleksandr Mazur
> ---
applied to iproute2-next.
In the future, please add example commands - g
On 2/9/21 3:31 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Signed-off-by: Oleksandr Mazur
> ---
applied to iproute2-next.
In the future, please add example commands - g
On 2/10/21 11:34 AM, Parav Pandit wrote:
> Linux vdpa interface allows vdpa device management functionality.
> This includes adding, removing, querying vdpa devices.
>
> vdpa interface also includes showing supported management devices
> which support such operations.
>
> This patchset includes k
On 2/10/21 11:34 AM, Parav Pandit wrote:
> Linux vdpa interface allows vdpa device management functionality.
> This includes adding, removing, querying vdpa devices.
>
> vdpa interface also includes showing supported management devices
> which support such operations.
>
> This patchset includes k
On 2/9/21 4:46 PM, Arjun Roy wrote:
> On Tue, Feb 9, 2021 at 8:59 AM Jakub Kicinski wrote:
>>
>> On Mon, 8 Feb 2021 20:20:29 -0700 David Ahern wrote:
>>> On 2/8/21 7:53 PM, Jakub Kicinski wrote:
>>>> On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote:
On 2/8/21 7:53 PM, Jakub Kicinski wrote:
> On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote:
>> On 2/8/21 11:41 AM, Jakub Kicinski wrote:
>>> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote:
>>>> There is a check that len is not larger than zs and user
On 2/8/21 11:41 AM, Jakub Kicinski wrote:
> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote:
>> On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote:
>>> On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote:
From: Arjun Roy
Explicitly define reserved field and requ
On 2/8/21 7:05 PM, Taehee Yoo wrote:
> Thanks, I understand why the arrays have been using.
> I will send a v2 patch, which contains only the necessary changes.
please send v2 as a patch series and not 8 individual patches + cover
letter.
Thanks,
On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value
> false cmode runtime
On 2/5/21 11:10 AM, Parav Pandit wrote:
> diff --git a/vdpa/include/uapi/linux/vdpa.h b/vdpa/include/uapi/linux/vdpa.h
> new file mode 100644
> index ..66a41e4e
> --- /dev/null
> +++ b/vdpa/include/uapi/linux/vdpa.h
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-sysca
On 2/5/21 11:10 AM, Parav Pandit wrote:
> diff --git a/vdpa/include/uapi/linux/vdpa.h b/vdpa/include/uapi/linux/vdpa.h
> new file mode 100644
> index ..66a41e4e
> --- /dev/null
> +++ b/vdpa/include/uapi/linux/vdpa.h
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-sysca
On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value
> false cmode runtime
On 2/7/21 10:49 AM, David Ahern wrote:
> On 2/6/21 1:36 PM, Arjun Roy wrote:
>> From: Arjun Roy
>>
>> Explicitly define reserved field and require it to be 0-valued.
>>
>> Fixes: 7eeba1706eba ("tcp: Add receive timestamp support for receive
>> zeroco
c Dumazet
> Signed-off-by: Soheil Hassas Yeganeh
> Suggested-by: David Ahern
> Suggested-by: Leon Romanovsky
> Suggested-by: Jakub Kicinski
> ---
> include/uapi/linux/tcp.h | 2 +-
> net/ipv4/tcp.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
t; Thanks to Colin Ian King for catching the overflow problem, providing a
> solution and inspiring this patch.
> Thanks to Jakub Kicinski for his useful suggestions during the design of
> this patch.
>
> v2:
> - remove the SEG6_LOCAL_MAX_SUPP which is not strictly needed: it c
t; Thanks to Colin Ian King for catching the overflow problem, providing a
> solution and inspiring this patch.
> Thanks to Jakub Kicinski for his useful suggestions during the design of
> this patch.
>
> v2:
> - remove the SEG6_LOCAL_MAX_SUPP which is not strictly needed: it c
c Dumazet
> Signed-off-by: Soheil Hassas Yeganeh
> Suggested-by: David Ahern
> Suggested-by: Leon Romanovsky
> Suggested-by: Jakub Kicinski
> ---
> include/uapi/linux/tcp.h | 2 +-
> net/ipv4/tcp.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: David Ahern
c Dumazet
> Signed-off-by: Soheil Hassas Yeganeh
> Suggested-by: David Ahern
> Suggested-by: Leon Romanovsky
> Suggested-by: Jakub Kicinski
> ---
> include/uapi/linux/tcp.h | 2 +-
> net/ipv4/tcp.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
On 2/2/21 5:24 AM, Paul Blakey wrote:
> Matches on conntrack rpl ct_state.
>
> Example:
> $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
> ct_state +trk+est+rpl \
> action mirred egress redirect dev ens1f0_1
> $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip
On 2/4/21 7:51 AM, Maxim Mikityanskiy wrote:
> This commit adds support for configuring HTB in offload mode. HTB
> offload eliminates the single qdisc lock in the datapath and offloads
> the algorithm to the NIC. The new 'offload' parameter is added to
> enable this mode:
>
> # tc qdisc replac
On 2/1/21 8:32 PM, Thayne McCombs wrote:
> I've fixed the indentation to use tabs instead of spaces.
>
> -- >8 --
> ss accepts an address family both with the -f option and as part of a
> host condition. However, if the family in the host condition is
> different than the the last -f option, then
Jiri/Parav: does this look ok to you?
Jiri/Parav: does this look ok to you?
On 2/3/21 12:04 PM, Oliver Hartkopp wrote:
> My only fault was, that I did not send the patch for iproute2-next at
> the time when the len8_dlc patches were in net-next, right?
yes
On 2/3/21 7:27 PM, Andrea Mayer wrote:
>
> I think there is an issue here because BITS_PER_TYPE(unsigned long) is greater
> than the SEG6_LOCAL_MAX (currently = 9).
>
> I think it should be like this:
>
> BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > BITS_PER_TYPE(unsigned long))
>
> I will send a v2 with
On 2/3/21 7:27 PM, Andrea Mayer wrote:
>
> I think there is an issue here because BITS_PER_TYPE(unsigned long) is greater
> than the SEG6_LOCAL_MAX (currently = 9).
>
> I think it should be like this:
>
> BUILD_BUG_ON(SEG6_LOCAL_MAX + 1 > BITS_PER_TYPE(unsigned long))
>
> I will send a v2 with
++
> include/trace/events/netlink.h | 29 +
> net/netlink/af_netlink.c | 8
> 3 files changed, 43 insertions(+)
> create mode 100644 include/trace/events/netlink.h
>
Reviewed-by: David Ahern
On 2/2/21 3:35 AM, Parav Pandit wrote:
> Add kernel headers to commit from kernel tree [1].
>79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices")
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch:
> linux-next
>
Thinking about this flow a bit mo
On 2/2/21 3:35 AM, Parav Pandit wrote:
> Add kernel headers to commit from kernel tree [1].
>79991caf5202c7 ("vdpa_sim_net: Add support for user supported devices")
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git branch:
> linux-next
>
Thinking about this flow a bit mo
On 2/2/21 11:56 AM, Andrea Mayer wrote:
> diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
> index b07f7c1c82a4..7cc50d506902 100644
> --- a/net/ipv6/seg6_local.c
> +++ b/net/ipv6/seg6_local.c
> @@ -31,6 +31,9 @@
> #include
> #include
>
> +#define SEG6_F_ATTR(i) BIT(i)
On 2/2/21 11:56 AM, Andrea Mayer wrote:
> diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c
> index b07f7c1c82a4..7cc50d506902 100644
> --- a/net/ipv6/seg6_local.c
> +++ b/net/ipv6/seg6_local.c
> @@ -31,6 +31,9 @@
> #include
> #include
>
> +#define SEG6_F_ATTR(i) BIT(i)
On 2/2/21 10:30 AM, Oliver Hartkopp wrote:
>
>
> On 02.02.21 16:35, David Ahern wrote:
>> On 2/2/21 3:48 AM, Oliver Hartkopp wrote:
>>>
>>> Are you sure this patch is correctly assigned to iproute2-next?
>>>
>>> IMO it has to be applied to ip
On 2/2/21 5:30 AM, Marcelo Ricardo Leitner wrote:
>
> Also, if the message is a common one, one may not be able to easily
> distinguish them. Ideally this shouldn't happen, but when debugging
> applications such as OVS, where lots of netlink requests are flying,
> it saves us time. I can, for exam
On 2/2/21 3:48 AM, Oliver Hartkopp wrote:
>
> Are you sure this patch is correctly assigned to iproute2-next?
>
> IMO it has to be applied to iproute2 as the functionality is already in
> v5.11 which is in rc6 right now.
>
new features land in iproute2-next just as they do for the kernel with
n
On 2/2/21 4:46 AM, Maxim Mikityanskiy wrote:
> On 2021-01-29 18:05, David Ahern wrote:
>> On 12/15/20 12:42 AM, Maxim Mikityanskiy wrote:
>>> This commit adds support for configuring HTB in offload mode. HTB
>>> offload eliminates the single qdisc lock in the da
On 2/1/21 2:35 PM, Parav Pandit wrote:
> This patchset implements devlink port add, delete and function state
> management commands.
>
> An example sequence for a PCI SF:
>
> Set the device in switchdev mode:
> $ devlink dev eswitch set pci/:06:00.0 mode switchdev
>
> View ports in switchdev
On 1/31/21 1:17 AM, Thayne McCombs wrote:
> diff --git a/misc/ss.c b/misc/ss.c
> index 0593627b..2a5e056a 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -2119,24 +2119,39 @@ void *parse_hostcond(char *addr, bool is_port)
> int fam = preferred_family;
> struct filter *f = ¤t_filter;
>
On 1/24/21 11:15 PM, Leon Romanovsky wrote:
> On Fri, Jan 22, 2021 at 10:55:45PM -0700, David Ahern wrote:
>> On 1/22/21 9:07 PM, Jakub Kicinski wrote:
>>> On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote:
>>>> diff --git a/include/uapi/linux/tcp.h b/inclu
gned-off-by: Ido Schimmel
> ---
> drivers/net/netdevsim/fib.c | 55 ++---
> 1 file changed, 27 insertions(+), 28 deletions(-)
>
Reviewed-by: David Ahern
On 2/1/21 2:20 AM, Schmid, Carsten wrote:
> Hi,
>
> on kernel 4.14(.147) i have seen something weird. The stack trace:
>
> [65064.457920] BUG: unable to handle kernel NULL pointer dereference at
> 0604
> [65064.466677] IP: ip_route_output_key_hash_rcu+0x755/0x850
> [65064.472599] PGD
On 1/29/21 9:56 AM, Parav Pandit wrote:
> @@ -1420,6 +1423,22 @@ static int port_flavour_parse(const char *flavour,
> uint16_t *value)
> }
> }
>
> +static int port_function_state_parse(const char *statestr, uint8_t *state)
> +{
> + if (!statestr)
> + return -EINVAL;
> +
>
On 1/29/21 9:56 AM, Parav Pandit wrote:
> @@ -1383,6 +1389,37 @@ static int reload_limit_get(struct dl *dl, const char
> *limitstr,
> return 0;
> }
>
> +static int port_flavour_parse(const char *flavour, uint16_t *value)
> +{
> + if (!flavour)
> + return -EINVAL;
> +
> +
[ cc David Lebrun, author of the original code ]
On 1/31/21 6:08 AM, Suprit Japagal wrote:
> From: "Suprit.Japagal"
>
> According to the standard IETF RFC 8754, section 4.3.1.1
> (https://tools.ietf.org/html/rfc8754#section-4.3.1.1)
> When the segments left in SRH equals to 0, proceed to process
ossibility of updating gc_list. This is what the
> patch intends to achieve.
>
> Fixes: 9c29a2f55ec0 ("neighbor: Fix locking order for gc_list changes")
always Cc the author(s) of commits in Fixes tag.
> Signed-off-by: Chinmay Agarwal
> ---
> net/core/neighbour.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Reviewed-by: David Ahern
On 1/25/21 6:48 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
Add example commands here - both set and show. Include a json version of
the show.
> Signed-off-by: Oleksandr Maz
On 1/25/21 6:48 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters getting/setting.
> Add bash completion for port param.
> Add man description for port param.
>
Add example commands here - both set and show. Include a json version of
the show.
> Signed-off-by: Oleksandr Maz
On 1/26/21 10:39 AM, Jesper Dangaard Brouer wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed together with stats (struct net_device_stats),
> although most modern driv
201 - 300 of 8206 matches
Mail list logo
