https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/95449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/95582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/95449
This test is explicitly checking for dwarf 4 behavior on Apple platforms, so we
should explicitly use the dwarf4 flag.
Related to https://github.com/llvm/llvm-project/pull/95164
>From
felipepiovezan wrote:
> LGTM, may be we could also support this for the command line
Just keep in mind that those are very different queries w.r.t. speed: one goes
through a fast path in the accelerator table, the other one doesn't.
https://github.com/llvm/llvm-project/pull/95350
felipepiovezan wrote:
Pushed a fix
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-06-12T09:32:54-07:00
New Revision: c5790206f719c8fac168ae488420f31800d55cf0
URL:
https://github.com/llvm/llvm-project/commit/c5790206f719c8fac168ae488420f31800d55cf0
DIFF:
felipepiovezan wrote:
@dzhidzhoev I think @labath 's suggestion might fix this (LD_EXTRAS)
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
hi @dzhidzhoev, I think this commit is causing the arm lldb incremental bots to
fail.
Could you have a look or revert if you think the fix is not obvious? This is
our most important bot, so it would be nice to get it green again
Author: Felipe de Azevedo Piovezan
Date: 2024-06-11T09:28:10-07:00
New Revision: 2e007b89c65eeb33baf1b40103284d8937700cf0
URL:
https://github.com/llvm/llvm-project/commit/2e007b89c65eeb33baf1b40103284d8937700cf0
DIFF:
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes ) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName _method, const DWARFDIE ,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes ) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName _method, const DWARFDIE ,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes ) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName _method, const DWARFDIE ,
+CompilerType clang_type, const
https://github.com/felipepiovezan approved this pull request.
It's say something that, even after this refactor, the methods are still pretty
big. But this is still a win
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes ) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName _method, const DWARFDIE ,
+CompilerType clang_type, const
@@ -975,6 +975,219 @@ ConvertDWARFCallingConventionToClang(const
ParsedDWARFTypeAttributes ) {
return clang::CC_C;
}
+bool DWARFASTParserClang::ParseObjCMethod(
+const ObjCLanguage::MethodName _method, const DWARFDIE ,
+CompilerType clang_type, const
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/95015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-06-07T10:14:58-07:00
New Revision: adcf33f8fbcc0f068bd4b8254994b16dda525009
URL:
https://github.com/llvm/llvm-project/commit/adcf33f8fbcc0f068bd4b8254994b16dda525009
DIFF:
felipepiovezan wrote:
@oontvoo I'm going to revert this for now as the incremental bots are our first
line of defense against failures
https://github.com/llvm/llvm-project/pull/94625
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
Oops, I commented on the old PR instead of the new one, so let me copy paste it
here:
@oontvoo I think this broke the bots again:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/5341/console
Would you mind reverting it until you have a chance to look
felipepiovezan wrote:
Would you mind reverting it until you have a chance to look at the failures?
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
@oontvoo I think this broke the bots again:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/5341/console
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/94400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
>Should we allow such entries in the index? And does this warrant rephrasing in
>the DWARF spec?
It's fine to have those as _nameless_ entries (which we don't emit today), but
the entries that are reaching "process entry" are not nameless by definition.
That if
felipepiovezan wrote:
> @felipepiovezan I have another question. For the same example. I see:
>
> ```
> Name 4 {
> Hash: 0x2F94396D
> String: 0x0049 "_Z9get_statev"
> Entry @ 0x112 {
> Abbrev: 0x2
> Tag: DW_TAG_subprogram
> DW_IDX_die_offset:
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
Yeah, we definitely need to clean all of these up.
There might be one inside
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
thanks for well-written summary @dwblaikie !
https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> > Discussed with Pavel, I applied this change to #92328 so we can ensure the
> > DIEs from the index is always definition DIEs and avoid duplicate/expensive
> > checks later.
>
> To elaborate, I suggested Zequan does this, because I think there's consensus
> that this
https://github.com/felipepiovezan approved this pull request.
I think this should probably be fine (perf-wise)!
https://github.com/llvm/llvm-project/pull/93296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -183,27 +181,22 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass(
llvm::function_ref callback) {
// Keep a list of incomplete types as fallback for when we don't find the
// complete type.
- DIEArray incomplete_types;
+ std::vector incomplete_types;
felipepiovezan wrote:
These types of changes touching a lot of projects at once can benefit from
multiple PRs, one per project, as it makes partial reverts a lot easier and
doesn't cause as much churn downstream (plus we can get more targeted comments
from individual project owners)
felipepiovezan wrote:
> Current BOLT behavior is to skip that DIE and reference it's parent:
This, on the other hand, is concerning. It needs to reflect the debug_info
section, otherwise we can't use debug_names to answer queries like "find
A::B::C::D".
It would be better if the BOLT compiler
felipepiovezan wrote:
Ohhh ok, I just inspected the debug_names/debug_info sections; there is no
parent at all for the InnerState debug_names entry. In this case, the
debug_names section is valid. Unfortunate, as this may cause entire CUs/TUs to
be parsed (because of all the calls to
felipepiovezan wrote:
>Since clang no longer emits entry for:
But what does the `debug_info` section look like? In particular, what is the
_parent_ of the class DIE?
If the parent of `InnerState` is not some kind of entry for `State` (either a
declaration or a definition), IMO Clang is
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -195,17 +195,17 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass(
if (!ref)
continue;
-DWARFUnit *cu = m_debug_info.GetUnit(*ref);
-if (!cu || !cu->Supports_DW_AT_APPLE_objc_complete_type()) {
- incomplete_types.push_back(*ref);
- continue;
-
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for catching this
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
> I think #77696 is justification enough to add this check, but I don't think
> we should be implicating DW_IDX_parent_entries until we know how those came
> about.
This is pretty much my point, the workaround is fine, but I don't think the
source-code comment in this
https://github.com/felipepiovezan approved this pull request.
Great catch and fix! Thanks for doing this
https://github.com/llvm/llvm-project/pull/92745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -9,7 +9,7 @@
#include "Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h"
#include "Plugins/SymbolFile/DWARF/DWARFDebugInfo.h"
#include "Plugins/SymbolFile/DWARF/DWARFDeclContext.h"
-#include "Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h"
+#include
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/92618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Ok, minor correction: if there is no complete parent chain, it just defaults to
the older implementation (which calls ProcessEntry). But my point still stands:
I don't believe this is related to the presence of IDX_parent.
```
void
felipepiovezan wrote:
> > we should probably fix the underlying issue instead: #77696
>
> We still have binaries that are floating around for now that contain this
> issue and this was causing crashes. So it would be nice to fix this in LLDB
> for now and back this out after we have a stable
felipepiovezan wrote:
we should probably fix the underlying issue instead:
https://github.com/llvm/llvm-project/issues/77696
https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
AFAICT we never added new entries -- definitely not forward declarations -- to
the table when doing the idx_parent work. Either they were already there, or
the entry would have no parent. Would be nice to have an example to see this in
action.
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/91371
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Hi @feg208 , I noticed that your [previous commit
](https://github.com/llvm/llvm-project/pull/89267) has a very.. unusual commit
title and message. The same thing applies to this PR.
I'd appreciate it if you could follow a more standard commit title and message,
so that
@@ -406,5 +426,13 @@ function(llvm_ExternalProject_Add name source_dir)
WORKING_DIRECTORY ${BINARY_DIR}
VERBATIM
USES_TERMINAL)
+if (ARG_FOLDER)
+ set_target_properties(${target} PROPERTIES FOLDER "${ARG_FOLDER}")
+endif ()
endforeach()
+
+
https://github.com/felipepiovezan approved this pull request.
This LGTM!
I like the wording in the sense that it uses a slightly less "systemy"
language, and so it becomes less cryptic to a wider audience.
https://github.com/llvm/llvm-project/pull/89433
@@ -1339,6 +1339,13 @@ enum AddressMaskRange {
eAddressMaskRangeAll = eAddressMaskRangeAny,
};
+/// Useful for callbacks whose return type indicates
+/// whether to continue iteration or short-circuit.
+enum class IterationMarker {
felipepiovezan wrote:
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for doing it, this was much needed
https://github.com/llvm/llvm-project/pull/87344
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/86740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/86740
This was made unused by d9ec4b24a84addb8bd77b5d9dd990181351cf84c.
>From 1ab938c815d0a1d89520cd8dcc8705bf80f8f89c Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 26 Mar 2024 14:08:17
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/85855
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -50,6 +50,11 @@ static constexpr OptionDefinition g_variable_options[] = {
"Specify a summary string to use to format the variable output."},
};
+static constexpr auto g_num_frame_options = 4;
felipepiovezan wrote:
Sadly it seems we need to
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/85855
This option doesn't exist. It is currently displayed by `help target var` due
to a bug introduced by 41ae8e7445 in 2018.
Some code for `target var` and `frame var` is shared, and some hard-code
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/85669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/85669
>From baa85a25548546679bf2b54fb723b51a2fb50e82 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 18 Mar 2024 10:14:49 -0700
Subject: [PATCH 1/2] [lldb][nfc] Factor out repeated code in
felipepiovezan wrote:
Rebased, address review comments
https://github.com/llvm/llvm-project/pull/85669
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/85669
>From baa85a25548546679bf2b54fb723b51a2fb50e82 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 18 Mar 2024 10:14:49 -0700
Subject: [PATCH] [lldb][nfc] Factor out repeated code in DWIM
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/85669
>From ddc9c22765623f88051ce1f2407603a9065c7cd1 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 18 Mar 2024 10:14:49 -0700
Subject: [PATCH] [lldb][nfc] Factor out repeated code in DWIM
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/85669
The code that prints ValueObjects is duplicated across two different cases of
the dwim-print command, and a subsequent commit will add a third case. As such,
this commit factors out the common code into
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/83908
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/7] [lldb] Allow languages to filter
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/6] [lldb] Allow languages to filter
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/5] [lldb] Allow languages to filter
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/5] [lldb] Allow languages to filter
@@ -339,6 +339,15 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
+ /// Returns true if this SymbolContext should be ignored when setting
+ /// breakpoints by line (number or regex). This is useful for
felipepiovezan wrote:
address review comments from Adrian.
I think I have a better name for the target option and language method now
https://github.com/llvm/llvm-project/pull/83908
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/4] [lldb] Allow languages to filter
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/84071
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
+
@@ -90,6 +90,15 @@ def breakpoint_options_language_test(self):
num_expected_locations=1,
)
felipepiovezan wrote:
Nice! this works really well
https://github.com/llvm/llvm-project/pull/84071
___
felipepiovezan wrote:
I believe I've addressed all the feedback here.
Tried really hard to come up with a shorter name for that target option, but
could not find something both short and descriptive. If you can think of
anything better, please let me know
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/83908
>From 51307b548d09c34ee06037ccf459110e451970a9 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 4 Mar 2024 09:56:18 -0800
Subject: [PATCH 1/2] [lldb] Allow languages to filter
@@ -524,6 +524,9 @@ void BreakpointLocation::GetDescription(Stream *s,
s->EOL();
s->Indent("function = ");
s->PutCString(sc.function->GetName().AsCString(""));
+ s->EOL();
+ s->Indent("mangled function = ");
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/84071
When debugging LLDB itself, it can often be useful to know the mangled name of
the function where a breakpoint is set. Since the `--verbose` setting of `break
--list` is aimed at debugging LLDB, this
@@ -199,13 +200,24 @@ bool operator<(const SourceLoc lhs, const SourceLoc rhs) {
}
} // namespace
+static void
+ApplyLanguageFilters(llvm::SmallVectorImpl _list) {
+ llvm::erase_if(sc_list, [](SymbolContext ) {
+if (Language *lang =
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> Also, are these 100% uninteresting line table entries? At present, there's no
> way to get lldb to not filter them out, so they either really need to be
> totally uninteresting, or we need a setting to turn them back on again.
They should be 100% uninteresting, but I
felipepiovezan wrote:
@JDevlieghere I believe you were the last one to touch this test, so I'll let
you approve this :D
https://github.com/llvm/llvm-project/pull/83925
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/83925
According to the git log (d9442afba1bd6), this test has never been
enabled/disabled, it was checked in without being called anywhere. But it
passes and it is useful, so this commit enables it.
>From
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/83908
Some languages may create artificial functions that have no real user code,
even though there is line table information for them. One such case is with
coroutine code that receives the CoroSplitter
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> > This seems akin to running clang-format on the entire project, which last
> > time we talked about still faced opposition
>
> My impression (I admit I haven't reviewed the whole thread lately) is that
> the opposition has mostly to do with how clang-format mangles
felipepiovezan wrote:
Juuust to make sure, was this discussed before? This seems akin to running
clang-format on the entire project, which last time we talked about still faced
opposition:
https://discourse.llvm.org/t/rfc-clang-format-all-the-things/76614/11
felipepiovezan wrote:
> > This LGTM!
> > I don't think I can see far enough ahead on what you are planning here, but
> > I was just wondering if the ultimate goal is to have the
> > `option_arg.getAsT` return an `Expected`. In this case, wouldn't all
> > these arguments (short option, long
https://github.com/felipepiovezan approved this pull request.
This LGTM!
I don't think I can see far enough ahead on what you are planning here, but I
was just wondering if the ultimate goal is to have the `option_arg.getAsT`
return an `Expected`. In this case, wouldn't all these arguments
https://github.com/felipepiovezan approved this pull request.
Thanks for doing this
https://github.com/llvm/llvm-project/pull/82066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,33 +1,33 @@
"""
-This is a sanity check that verifies that test can be sklipped based on
settings.
+This is a sanity check that verifies that test can be skipped based on
settings.
"""
-
import lldb
from lldbsuite.test.lldbtest import *
from
@@ -308,13 +308,21 @@ def expectedCompilerVersion(compiler_version):
return operator in [">", ">=", "!", "!=", "not"]
if operator == ">":
-return LooseVersion(test_compiler_version) > LooseVersion(version)
+return
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/82074
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan approved this pull request.
nice!
https://github.com/llvm/llvm-project/pull/82073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 314 matches
Mail list logo
