Re: [OS-BUILD PATCHv17 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-08-02 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_2027764394 Whoops, sorry, didn't look at enough context around the addition. -- ___ kernel mailing list -- kernel@lists.fedoraproject.o

Re: [OS-BUILD PATCHv17 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons

2024-08-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_2026569502 Can you wrap this with an `%if %{with_efiuki}` perhaps, so that people can skip the requirement if building without the UKI bits of the build

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild: make it possible to not include SPEC tag (rpm-4.17 compat behavior) (Issue #2727)

2024-03-06 Thread Jarod Wilson
How do you know if the package was built with an older rpm vs. the new rpm? If you can ascertain that, then you can surely have the latest rpm complain/warn if it finds an rpm built with the latest rpm that doesn't have the tags, while older rpm would be blissfully unaware, happy, and able to us

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild: make it possible to not include SPEC tag (rpm-4.17 compat behavior) (Issue #2727)

2024-03-05 Thread Jarod Wilson
What if a current RPM version complained about a package created w/o the tags? It's already possible to generate them by simply using an older RPM version, so I don't really see how "latest RPM always creates them" guarantees this feature any more than latest RPM if patched to allow creation of

Re: [OS-BUILD PATCHv2 0/5] redhat: introduce versioning for Gemini kernels

2023-04-10 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2386#note_1347159845 Some of the var names are a bit long and difficult to read (SPECKVERSION ready "speck version", but is meant to be "spec kay version", etc), but ... yeah

Re: [OS-BUILD PATCHv2 0/5] redhat: introduce versioning for Gemini kernels

2023-04-10 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2386#note_1347157765 Interesting that @prarit talked about NOT wanting to use EPOCH, but... this change already does use 'em. :smile: (For sub-packages that share names w/packages from non-gemini k

Re: [OS-BUILD PATCHv2 0/5] redhat: introduce versioning for Gemini kernels

2023-04-10 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2386#note_1347121525 Oh, hrm. It's possible rpm grew some additional intelligence since then, or I'm having a senior moment. Either way, hysteric

Re: [OS-BUILD PATCHv2 0/5] redhat: introduce versioning for Gemini kernels

2023-04-10 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2386#note_1346758298 But also, if the kernel builds aren't 100% in lock-step, you could have a technically "newer" kernel in the latest release with a lower NVR than the prior release, bec

Re: [OS-BUILD PATCHv2 0/5] redhat: introduce versioning for Gemini kernels

2023-04-10 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2386#note_1346751724 I believe the problem ages ago in Fedora that necessitated the 100/200/300 was when we were moving from Fedora 9 to Fedora 10. '.fc9' was rpm-version-compare newer t

Re: [OS-BUILD PATCHv2] Revert "redhat: fix elf got hardening for vm tools"

2023-01-25 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2236#note_1252697186 Yeah, this MR was the catalyst for adding that message. This should generally only trigger for a fresh block attempt by an MR author, and the weird rule will never be created, things

Re: [OS-BUILD PATCHv4 0/6] redhat: Cleanup scripts

2022-10-31 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2095#note_1154732498 LGTM now, thank you for that change. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCHv3] redhat/configs: Disable fbdev drivers and use simpledrm everywhere

2022-10-24 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1533#note_1146727128 Pardon our noisy bot, it looks like some python-gitlab api changes have caused an issue for us here, but we're working on fixi

Re: [OS-BUILD PATCH 0/8] redhat: Cleanup scripts

2022-10-17 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2095#note_1138682445 Not a big fan of the "put all files with .yaml suffix under yaml dir" part of this change. The file type doesn't actually have any bearing on what the file content re

Re: [OS-BUILD PATCH] redhat: Remove parallel_xz.sh

2022-10-07 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2068#note_1128502994 Shouldn't this commit/MR also remove the parallel_xz.sh file from the tree? ___ kernel mailing list -- kernel@lists.fedoraproject.o

Re: [OS-BUILD PATCH] redhat: Remove parallel_xz.sh

2022-10-07 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2068#note_1128501600 @dvlasenk I think we should definitely have your eyes on this, since I believe this was your addition and it definitely improved build times when it was added

Re: [OS-BUILD PATCH] redhat/configs: change so watchdog is module versus builtin

2022-10-06 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2044#note_1127494553 This merge request needs a rebase on latest os-build. It's got merge conflicts, and gitlab thinks there are 3202 patches and over 3000 files modified

Re: [OS-BUILD PATCH] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC

2022-10-03 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1123065015 Hm. For some reason, this is showing up as 3189 patches instead of just one, so I think it needs to be rebased on the latest os-build or some such thing

Re: [OS-BUILD PATCH 0/2] Reduce disk space requirements of the kernel build

2022-10-03 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1950#note_1122814217 Okay, fair enough. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCH] redhat: set LC_ALL=C before sorting config content

2022-10-03 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2011#note_1122772792 For the record, I remember nothing, that was a LONG time ago, so it probably paged out of my brain several years back. :smile: ___ kernel

Re: [OS-BUILD PATCH 0/2] Reduce disk space requirements of the kernel build

2022-08-29 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1950#note_1081478493 Would it make sense to use a hardlink here instead of a symlink? My only other concern would be someone trying to debug a build failure and finding those intermediate files gone, but I

Re: [OS-BUILD PATCH] spec: add cpupower daemon reload on install/upgrade

2022-08-05 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1960#note_1052585461 Wait a minute... kernel-tools is built stand-alone in Fedora. I was just looking at the cs9 kernel spec and not finding it, and that's because it's in kernel-tools. https://

[OS-BUILD PATCH] spec: add cpupower daemon reload on install/upgrade

2022-08-05 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson spec: add cpupower daemon reload on install/upgrade Signed-off-by: Jarod Wilson diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++ b/redhat/kernel.spec.template @@ -2700,6 +2700,15

Re: [OS-BUILD PATCH 0/0] [redhat] New configs in drivers/net/ethernet/sfc

2022-06-13 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1815#note_989249542 I believe the old thinking was that then-always-pci-less s390x would never need to build it (but I think some s390x variants have pci now?) and most embedded arm64 systems had no pci as

Re: [OS-BUILD PATCHv6] redhat: indicate HEAD state in tarball/rpm name

2022-05-09 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_939795847 Rebased this on the now-merged !1727 (not 1735, this IS 1735). I think this is ready to go? ___ kernel mailing list -- kernel

[OS-BUILD PATCHv6] redhat: indicate HEAD state in tarball/rpm name

2022-05-09 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson redhat: indicate HEAD state in tarball/rpm name For the non-Fedora (RHEL) case, we are looking to move to a setup where we include Merge Requests as soon as they are ready, and thus the head of main may not always be a tagged build. This gives some indication to someone

[OS-BUILD PATCHv5 0/0] redhat: indicate HEAD state in tarball/rpm name

2022-05-02 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735 NOTE: Truncated patchset since committer email 'pra...@redhat.com' does not match the submitter's GitLab public email address 'ja...@redhat.com'.

Re: [OS-BUILD PATCHv4 0/0] redhat: indicate HEAD state in tarball/rpm name

2022-04-28 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_928154428 Now rebased on https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735 and adjusted so that the RHEL_EXTRAVERSION bits are passed along to the spec properly, based on some irc

[OS-BUILD PATCHv4 0/0] redhat: indicate HEAD state in tarball/rpm name

2022-04-28 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735 NOTE: Truncated patchset since committer email 'pra...@redhat.com' does not match the submitter's GitLab public email address 'ja...@redhat.com'.

[OS-BUILD PATCHv3 0/0] redhat: indicate HEAD state in tarball/rpm name

2022-04-28 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735 NOTE: Truncated patchset since committer email 'pra...@redhat.com' does not match the submitter's GitLab public email address 'ja...@redhat.com'.

[OS-BUILD PATCH] redhat: disable tv/radio media device infrastructure

2022-04-14 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson redhat: disable tv/radio media device infrastructure Upstream Status: RHEL-only The analog and digital tv tuners and (FM) radio devices don't see much play in RHEL server environments. We've never really updated them in any major release, and have no eviden

Re: [OS-BUILD PATCHv2] redhat: indicate HEAD state in tarball/rpm name

2022-04-11 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_908523131 @prarit I believe you were updating the tests here and on irc said to ignore this, at least until the update was done. Should I be revisiting this now

Re: [OS-BUILD PATCHv2] redhat: indicate HEAD state in tarball/rpm name

2022-04-11 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_908522484 @jmflinuxtx does the above scheme work at least for now? This should only affect one-off custom builds people do of a RHEL-based build, so far as I know

Re: [OS-BUILD PATCHv2] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_901860003 Latest version only brings in the RHEL_EXTRAVERSION in the (not (Fedora or CentOS)) case, and shortens the extra bits to just ".g". (4-char sha hash o

[OS-BUILD PATCHv2] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson redhat: indicate HEAD state in tarball/rpm name For the non-Fedora (RHEL) case, we are looking to move to a setup where we include Merge Requests as soon as they are ready, and thus the head of main may not always be a tagged build. This gives some indication to someone

Re: [OS-BUILD PATCH] redhat: indicate HEAD state in tarball/rpm name

2022-04-05 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1735#note_901540472 Hm. I forgot you're doing both a Fedora and a RHEL-ish pass on things here every build. This is primarily meant for later use by RHEL, when the only builds the maintainer doe

[OS-BUILD PATCH] redhat: indicate HEAD state in tarball/rpm name

2022-04-04 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson redhat: indicate HEAD state in tarball/rpm name For the non-Fedora (RHEL) case, we are looking to move to a setup where we include Merge Requests as soon as they are ready, and thus the head of main may not always be a tagged build. This gives some indication to someone

Re: [OS-BUILD PATCH 0/18] Forward port rh_kabi.h macros

2022-02-02 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1530#note_829715823 Yeah, all good now, thanks much. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCH] rtw89: enable new driver rtw89 and device RTK8852AE

2022-01-14 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1570#note_811537415 I'm uncertain why the commitrefs hook was not run on this one already, will have to investigate logs, but ... not tonight. :) ___ k

Re: [OS-BUILD PATCH] rtw89: enable new driver rtw89 and device RTK8852AE

2022-01-14 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1570#note_811537264 **Upstream Commit ID Readiness Error(s)!** This report indicates how backported commits compare to the upstream source commit. Matching (or not matching) is not a guarantee of

Re: [OS-BUILD PATCHv3] kernel/rh_taint.c: Update to new messaging

2021-12-02 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1459#note_750590022 Ouch. Fair enough. We can bear the burden of three extra characters to prevent a year delay in deployment, I thinkā€¦ ___ kernel mailing list

Re: [OS-BUILD PATCHv2 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-12-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_749885948 @dzickusrh can you help @kheib out with perms to have an approve button in ark? ___ kernel mailing list -- kernel@lists.fedoraproject.org To

Re: [OS-BUILD PATCHv2 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-12-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_749623224 @kheib: Note: we've eliminated support for comment-based approvals, and only track gitlab's built-in approvals now. If you don't have the approve button showing up,

Re: [OS-BUILD PATCHv3] kernel/rh_taint.c: Update to new messaging

2021-11-29 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1459#note_746794714 On all of these messages, the "is" doesn't really serve much purpose. I'd just said "unmaintained hardware detected", and save the

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733805832 Fair point. :) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733797260 I've attempted to comment on the overall diff, but I keep getting a "failed to save comment" message from gitlab, so... Here's one of the two "added" file

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733793141 Oh, ha, I didn't look at the individual commits, just the overall. Looking at the overall, those two additions are because they were named incorrectly and removed by the initial

Re: [OS-BUILD PATCH 0/3] redhat/configs/evaluate_configs: Add find dead configs option

2021-11-15 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1498#note_733746242 Which ones are added? I see two files moved/renamed, because the actual config option name changed, and only the contents of the file were updated, while the file name wasn't.

Re: [OS-BUILD PATCH] New configs in drivers/media

2021-11-11 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1487#note_731216225 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCHv3 0/2] redhat/configs: enable KEXEC_SIG for aarch64 RHEL

2021-11-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1442#note_720083675 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] redhat: configs: Update configs for vmware

2021-11-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1449#note_720055451 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCHv3] Enable KUNIT tests for redhat kernel-modules-internal

2021-10-11 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1422#note_700659297 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] Use common config for NODES_SHIFT

2021-10-08 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1333#note_699402656 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] redhat/configs: Enable Hyper-V guests on ARM64

2021-10-01 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1394#note_692854032 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported

2021-09-30 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_691851133 Yeah, what Justin said. Some of this was already done in another MR... was that for CentOS Stream 9? Do we want to sync the CONFIG_RHEL_DIFFERENCES bit into there as well

Re: [OS-BUILD PATCHv2] Revert "redhat/configs: Enable genet and brcmfmac wlan"

2021-08-26 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1330#note_662025156 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH 0/0] wireless: rtw88: a few minor cleanups

2021-08-24 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1323#note_659358331 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH 0/0] [redhat] New configs in net/netfilter

2021-08-04 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_643491258 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH 0/0] [redhat] New configs in net/netfilter

2021-08-04 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_643491091 Okay, fair enough. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le

Re: [OS-BUILD PATCH 0/0] [redhat] New configs in net/netfilter

2021-07-19 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1209#note_630063444 Is there a reason this is broken out into two commits instead of just being one? And should there be something further in the series explaining why the second patch is toggling this

Re: [OS-BUILD PATCH] redhat/configs: Enable stmmac NIC for x86_64

2021-07-16 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1262#note_629080900 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCHv2] netfilter: Add deprecation notices for xtables

2021-07-12 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1226#note_624076873 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] [redhat] Flip some diag modules from m to y

2021-05-27 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1151#note_587368363 Acked-by: Jarod Wilson (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel

Re: [OS-BUILD PATCH] [redhat] Disable CONFIG_NETFILTER_XTABLES_COMPAT

2021-05-11 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1126#note_572755224 I'm fine with it, approval was based largely on it already having been on for a while. There's an admittedly rather narrow use case for this though (we all have 64-bit binar

Re: [OS-BUILD PATCHv2 0/5] nvme: update error handling and ana_state to work well with device-mapper-multipath

2021-04-13 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1024#note_550918573 Theoretically, the ack spam should stop now, we believe we have a fix that just went live. ___ kernel mailing list -- kernel

Re: [OS-BUILD PATCH 0/2] enable CONFIG_CMA on x86_64 in ARK

2021-04-13 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1023#note_550918407 Theoretically, the ack spam should stop now, we believe we have a fix that just went live. ___ kernel mailing list -- kernel

Re: [OS-BUILD PATCH] [redhat] New configs in drivers/thunderbolt

2021-04-12 Thread Jarod Wilson (via Email Bridge)
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/721#note_550135609 I think it should actually be Torez doing this review, but I'm not sure where we're at with gitlab setup for her, and this is simple enough, I can just approve i

Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-15 Thread Jarod Wilson
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote: > > Jarod Wilson writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: err

Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-15 Thread Jarod Wilson
On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote: > > Jarod Wilson writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: err

[PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-12 Thread Jarod Wilson
tialize wdev_id to 0, since it's value doesn't otherwise matter unless have_wdev_id is true. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") CC: Johannes Berg CC: "David S. Miller" CC: Jakub Kicinski CC: linux-wirel...@vger.kernel.org CC:

[PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-12 Thread Jarod Wilson
tialize wdev_id to 0, since it's value doesn't otherwise matter unless have_wdev_id is true. Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver") CC: Johannes Berg CC: "David S. Miller" CC: Jakub Kicinski CC: linux-wirel...@vger.kernel.org CC:

[PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

[PATCH net-next v4] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst > > b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documenta

Re: [PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-18 Thread Jarod Wilson
On Mon, Jan 18, 2021 at 04:10:38PM -0700, David Ahern wrote: > On 1/15/21 12:21 PM, Jarod Wilson wrote: > > diff --git a/Documentation/networking/bonding.rst > > b/Documentation/networking/bonding.rst > > index adc314639085..36562dcd3e1e 100644 > > --- a/Documenta

[PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-15 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

[PATCH iproute2 v2] bond: support xmit_hash_policy=vlan+srcmac

2021-01-15 Thread Jarod Wilson
table|bandwidth|count Cc: Stephen Hemminger Cc: Jay Vosburgh Signed-off-by: Jarod Wilson --- ip/iplink_bond.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index 585b6be1..b9470b98 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_b

[PATCH net-next v3] bonding: add a vlan+srcmac tx hashing option

2021-01-15 Thread Jarod Wilson
atch for iproute2 is also posted, to properly support the new mode there as well. Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink inte

Re: [PATCH iproute2] bond: support xmit_hash_policy=vlan+mac

2021-01-15 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 06:41:17PM -0500, Jarod Wilson wrote: > There's a new transmit hash policy being added to the bonding driver that > is a simple XOR of vlan ID and source MAC, xmit_hash_policy vlan+mac. This > trivial patch makes it configurable and queryable via iproute

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-15 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:54:31PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > >> On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > >> > This comes from an end-user request, w

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-15 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:54:31PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > >> On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > >> > This comes from an end-user request, w

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:23:14PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote: > > In truth, this code started out as a copy of bond_eth_hash(), which also > > only uses the last byte, though of both source and destination macs. In > >

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Thu, Jan 14, 2021 at 01:23:14PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 16:11:41 -0500 Jarod Wilson wrote: > > In truth, this code started out as a copy of bond_eth_hash(), which also > > only uses the last byte, though of both source and destination macs. In > >

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > > This comes from an end-user request, where they're running multiple VMs on > > hosts with bonded interfaces connected to some interest switch topologie

Re: [PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-14 Thread Jarod Wilson
On Wed, Jan 13, 2021 at 05:58:18PM -0800, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 17:35:48 -0500 Jarod Wilson wrote: > > This comes from an end-user request, where they're running multiple VMs on > > hosts with bonded interfaces connected to some interest switch topologie

[PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jarod Wilson
lav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: net...@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Documentation, changed tx hash mode name to vlan+mac for consistency and clarity. Docume

[PATCH iproute2] bond: support xmit_hash_policy=vlan+mac

2021-01-13 Thread Jarod Wilson
width|count Cc: Stephen Hemminger Cc: Jay Vosburgh Signed-off-by: Jarod Wilson --- ip/iplink_bond.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index 585b6be1..b9470b98 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_bond.c @@ -70,6

[PATCH net-next v2] bonding: add a vlan+mac tx hashing option

2021-01-13 Thread Jarod Wilson
lav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- v2: verified netlink interfaces working, added Documentation, changed tx hash mode name to vlan+mac for consistency and clarity. Docume

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > >> > Jarod Wilson wrote: > >&

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > >> > Jarod Wilson wrote: > >&

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >This comes from an end-user request, where they're running multiple VMs on > > >hosts with bonded

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >This comes from an end-user request, where they're running multiple VMs on > > >hosts with bonded

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-08 Thread Jarod Wilson
b w/o team's userspace footprint". I think this one is kind of hard for team to do anything about, bonding really does have a smaller userspace footprint, which is a plus for embedded type applications and high-security environments looking to keep things as minimal as possible. I think I've heard a few "we tried team years ago and it didn't work" as well, which of course is ridiculous as a reason not to try something again, since a lot can change in a few years in this world. -- Jarod Wilson ja...@redhat.com

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-08 Thread Jarod Wilson
b w/o team's userspace footprint". I think this one is kind of hard for team to do anything about, bonding really does have a smaller userspace footprint, which is a plus for embedded type applications and high-security environments looking to keep things as minimal as possible. I think I've heard a few "we tried team years ago and it didn't work" as well, which of course is ridiculous as a reason not to try something again, since a lot can change in a few years in this world. -- Jarod Wilson ja...@redhat.com

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn&#

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >This comes from an end-user request, where they're running multiple VMs on > >hosts with bonded interfaces connected to some interest switch topologies, > >where 802.3ad isn&#

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
nsider using team driver instead ? :) That's actually one of the things that was suggested, since team I believe already has support for this, but the user really wants to use bonding. We're finding that a lot of users really still prefer bonding over team. -- Jarod Wilson ja...@redhat.com

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-07 Thread Jarod Wilson
nsider using team driver instead ? :) That's actually one of the things that was suggested, since team I believe already has support for this, but the user really wants to use bonding. We're finding that a lot of users really still prefer bonding over team. -- Jarod Wilson ja...@redhat.com

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-18 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: ... > >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat > >separate from the fix for the actual hang, but it eliminates a constant > >"invalid new link 3 on slave&

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-18 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: ... > >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat > >separate from the fix for the actual hang, but it eliminates a constant > >"invalid new link 3 on slave&

[RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2020-12-18 Thread Jarod Wilson
Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Thomas Davis Cc: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/bonding/bond_main.c| 27 +-- drivers/net/bonding/bond_options.c |

  1   2   3   4   5   6   7   8   9   10   >