On Mon, 2020-08-24 at 21:55 -0700, Joe Perches wrote:
> Use semicolons and braces.
ping?
>
> Signed-off-by: Joe Perches
> ---
> arch/alpha/kernel/pci_iommu.c | 8 +---
> arch/alpha/oprofile/op_model_ev4.c | 22 ++
> arch/alpha/oprofil
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +---
> drivers/gpu/drm/i915/gt/intel_gt_requests.c| 6 --
> drive
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +---
> 1 file changed, 28 insertions(+), 16 deletions(-)
>
> diff --git a/d
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/dma-buf/st-dma-fence.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/d
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +---
> drivers/gpu/drm/i915/gt/intel_gt_requests.c| 6 --
> drive
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +---
> 1 file changed, 28 insertions(+), 16 deletions(-)
>
> diff --git a/d
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
Ping?
> Signed-off-by: Joe Perches
> ---
> drivers/dma-buf/st-dma-fence.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence.c b/d
On Fri, 2021-01-29 at 18:20 -0800, mgr...@linux.intel.com wrote:
> From: "C, Udhayakumar"
>
> Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> platforms.
[]
> diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c
> b/drivers/misc/intel_tsens/intel_tsens_host.c
[]
> +static
On Fri, 2021-01-29 at 23:10 +0200, Andy Shevchenko wrote:
> On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote:
[]
> > @@ -37,7 +37,7 @@
> > #define GENMASK(h, l) \
> > (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
> >
> > -#define BITS_FIRST(nr) GENMASK(nr), 0)
> > +#define
Add newline terminations to the sysfs_emit uses added by -next
commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
Signed-off-by: Joe Perches
---
drivers/misc/pvpanic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/pvpanic.c
On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> Drop a mistaken comma in the pr_info() args to prevent the
> build warning.
>
> ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> ../include/linux/kern_levels.h:5:18: warning: too many arguments for format
>
On Thu, 2021-01-28 at 17:37 +, Colin King wrote:
> From: Colin Ian King
>
> The variable result is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
Isn't WIMAX dead? Shouldn't it be
On Thu, 2021-01-28 at 17:37 +, Colin King wrote:
> From: Colin Ian King
>
> The variable result is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
Isn't WIMAX dead? Shouldn't it be
On Thu, 2021-01-28 at 20:08 +0530, Dwaipayan Ray wrote:
> Add a new verbose mode to checkpatch.pl to emit additional verbose
> test descriptions. The verbose mode is optional and can be enabled
> by the flag -v or --verbose.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>
On Thu, 2021-01-28 at 00:52 -0300, Thiago Jung Bauermann wrote:
> The problem is that this patch implements only part of the suggestion,
> which isn't useful in itself. So the patch series should either drop
> this patch or consolidate the FDT allocation between the arches.
>
> I just tested on
On Thu, 2021-01-28 at 00:52 -0300, Thiago Jung Bauermann wrote:
> The problem is that this patch implements only part of the suggestion,
> which isn't useful in itself. So the patch series should either drop
> this patch or consolidate the FDT allocation between the arches.
>
> I just tested on
On Thu, 2021-01-28 at 10:19 +0800, Yafang Shao wrote:
> Currently the pGp only shows the names of page flags, rather than
> the full information including section, node, zone, last cpupid and
> kasan tag. While it is not easy to parse these information manually
> because there're so many flavors.
On Thu, 2021-01-28 at 00:05 +0900, Tomoyuki Matsushita wrote:
> Signed-off-by: Tomoyuki Matsushita
checkpatch is pretty stupid so whatever it recommends needs to
be looked at carefully by a human and fixed appropriately.
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
> Comments are the exception to the "no spaces at the start of a line"
> rule. I was expecting that the kbuild-bot would send a Smatch warning
> for inconsistent indenting, but comments are not counted there either.
>
> I'm sort of surprised that we don't have checkpatch rule about the
> missing
On Wed, 2021-01-27 at 19:23 +0100, Paolo Bonzini wrote:
> On 27/01/21 18:25, Joe Perches wrote:
> >
> > -#ifdef MMU_DEBUG
> > -bool dbg = 0;
> > -module_param(dbg, bool, 0644);
> > -#endif
> > -
> > #define PTE_PREFETCH_NUM 8
> >
> Comments are the exception to the "no spaces at the start of a line"
> rule. I was expecting that the kbuild-bot would send a Smatch warning
> for inconsistent indenting, but comments are not counted there either.
>
> I'm sort of surprised that we don't have checkpatch rule about the
> missing
> Comments are the exception to the "no spaces at the start of a line"
> rule. I was expecting that the kbuild-bot would send a Smatch warning
> for inconsistent indenting, but comments are not counted there either.
>
> I'm sort of surprised that we don't have checkpatch rule about the
> missing
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote:
> On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote:
> > Andy and Joe, there's something wrong here that is missing the fact that
> > a line is being indented with spaces and not tabs in the patch
> > at
> >
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote:
> On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote:
> > Andy and Joe, there's something wrong here that is missing the fact that
> > a line is being indented with spaces and not tabs in the patch
> > at
> >
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote:
> On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote:
> > Andy and Joe, there's something wrong here that is missing the fact that
> > a line is being indented with spaces and not tabs in the patch
> > at
> >
On Wed, 2021-01-27 at 11:54 +0100, Paolo Bonzini wrote:
> On 27/01/21 03:08, Stephen Zhang wrote:
> > Given the common pattern:
> >
> > rmap_printk("%s:"..., __func__,...)
> >
> > we could improve this by adding '__func__' in rmap_printk().
Currently, the MMU_DEBUG control is not defined so
On Wed, 2021-01-27 at 01:57 +0530, Dwaipayan Ray wrote:
> On Wed, Jan 27, 2021 at 1:41 AM Joe Perches wrote:
> > On Wed, 2021-01-27 at 00:05 +0530, Dwaipayan Ray wrote:
> > > Add a new verbose mode to checkpatch.pl to emit additional verbose
> > > test descriptions.
&g
Signed-off-by: Masahiro Yamada
Acked-by: Joe Perches
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3390,13 +3390,6 @@ sub process {
> }
> }
>
> -# discourage the use of boolean for type definition attributes of
On Wed, 2021-01-27 at 00:05 +0530, Dwaipayan Ray wrote:
> Add a new verbose mode to checkpatch.pl to emit additional verbose
> test descriptions.
>
> The verbose mode is optional and can be enabled by the flag
> --verbose.
>
> The test descriptions are itself loaded from the checkpatch
On Tue, 2021-01-26 at 16:31 +0800, Jiapeng Zhong wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/ps.c:798:7-21: WARNING:
> Comparison to bool
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3848:7-17:
> WARNING: Comparison of 0/1 to bool variable
[]
One of the linux-mentees, Dwaipayan Ray, asked me in a private
email for ideas for improvements to checkpatch.
Though I am not his nominal mentor, my response to him was the below.
Does anyone have any more ideas for checkpatch improvements or
enhancements?
---
On Fri, 2021-01-15 at 21:02
>
> Suggested-by: Mark Brown
> Link: https://lore.kernel.org/lkml/20210112210154.gi4...@sirena.org.uk
> Signed-off-by: Aditya Srivastava
Acked-by: Joe Perches
> ---
> * Applies perfectly on next-20210122
>
> Changes in v3:
> - Modify regex for SYM_*_START/END pa
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c
> b/drivers/usb/typec/tcpm/tcpci_maxim.c
On Sat, 2021-01-23 at 18:14 +0800, angkery wrote:
> From: Junlin Yang
>
> PTR_ERR(chip->tcpci) has been used as a return value,
> it is not necessary to assign it to ret, so remove it.
[]
[]
> @@ -461,7
On Sat, 2021-01-23 at 20:44 +0530, Aditya Srivastava wrote:
> objtool requires that all code must be contained in an ELF symbol.
> Symbol names that have a '.L' prefix do not emit symbol table entries, as
> they have special meaning for the assembler.
>
> '.L' prefixed symbols can be used within
commit 5799b255c491 ("include/linux/slab.h: add kmalloc_array_node() and
kcalloc_node()") was added in 2017. Update the unnecessary OOM message
test to include it.
Signed-off-by: Joe Perches
Reported-by: Jakub Kicinski
---
Maybe not worth fixing, but no real effort to fix either.
On Fri, 2021-01-22 at 18:48 +0530, Aditya wrote:
> On 21/1/21 12:13 am, Joe Perches wrote:
> > I believe the test should be:
> >
> > if ($realfile =~ /\.S$/ &&
> > $line =~ /^\+\s*SYM_[A-Z]+_(?:START|END)(?:_[A-Z_]+)?\s*\(\s*\.L/) {
>
> Joe, w
On Sat, 2021-01-23 at 02:16 +0900, Masahiro Yamada wrote:
> On Sat, Jan 23, 2021 at 12:51 AM Joe Perches wrote:
> >
> > On Fri, 2021-01-22 at 07:06 +0900, Masahiro Yamada wrote:
> > > I use Ubuntu, where /usr/bin/python is a symlink
> > > to /us
On Fri, 2021-01-22 at 07:06 +0900, Masahiro Yamada wrote:
> I use Ubuntu, where /usr/bin/python is a symlink
> to /usr/bin/python3.
Odd, here:
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 20.10
Release:20.10
Codename: groovy
$ ls
On Fri, 2021-01-22 at 05:25 +0900, Masahiro Yamada wrote:
> On Fri, Jan 22, 2021 at 2:17 AM Scott Branden
> wrote:
> >
> > Use python3 instead of python in diffconfig Shebang line.
> > python2 was sunset January 1, 2000 and environments do not need
> > to support python any more.
python2 was
On Thu, 2021-01-21 at 18:14 +0900, Naoki Hayama wrote:
> On 2021/01/21 17:41, Luca Ceresoli wrote:
> > On 21/01/21 04:21, Chunyou Tang wrote:
> > > On Wed, 20 Jan 2021 19:09:05 -0800 Joe Perches wrote:
> > > > On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote
On Wed, 2021-01-20 at 19:02 -0800, Randy Dunlap wrote:
> On 1/20/21 6:07 PM, ChunyouTang wrote:
> > From: tangchunyou
> >
> > Increase direcly,maping,manger spelling error check
>
> Hi,
> I don't see all of those in the patch below.
> What happened?
I think mostly it's just a poor commit
On Wed, 2021-01-20 at 20:55 -0800, Bart Van Assche wrote:
> On 1/20/21 7:57 PM, Jiapeng Zhong wrote:
> > - return snprintf(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
> > + return sysfs_emit_at(buf, PAGE_SIZE, "%d.%02d.%02d (%x)\n",
> >
On Thu, 2021-01-21 at 11:29 +0800, ChunyouTang wrote:
> From: tangchunyou
>
> Increase maping spelling error check
Hi again. Thank you. I appreciate the addition.
Your word choice here is slightly odd English.
When you 'increase' a spelling error check, you might better use another
word
On Wed, 2021-01-20 at 19:56 +0100, Rafael J. Wysocki wrote:
> This series cleans up messaging in some source files under drivers/acpi/
> and get rids of some debug code pieces that aren't needed any more.
Thanks Rafael.
On Wed, 2021-01-20 at 18:23 +0530, Aditya wrote:
> On 20/1/21 2:51 pm, Joe Perches wrote:
> > On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote:
> > > Local symbols prefixed with '.L' do not emit symbol table entries, as
> > > they have special meaning for the
On Wed, 2021-01-20 at 14:15 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The CSR SiRF prima2/atlas platforms are getting removed, so this driver
> is no longer needed.
Should this platform really be removed?
While I followed the removal thread just a little,
isn't prima still in use
On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote:
> Local symbols prefixed with '.L' do not emit symbol table entries, as
> they have special meaning for the assembler.
>
> '.L' prefixed symbols can be used within a code region, but should be
> avoided for denoting a range of code via
On Mon, 2021-01-18 at 15:53 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 12:34:28AM +, Daniel Scally wrote:
> > This driver only covered one scenario in which ACPI devices with _HID
> > INT3472 are found, and its functionality has been taken over by the
> > intel-skl-int3472 module,
On Mon, 2021-01-18 at 20:56 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 10:43:14AM -0800, Joe Perches wrote:
> > On Mon, 2021-01-18 at 15:39 +0200, Andy Shevchenko wrote:
> > > On Mon, Jan 18, 2021 at 12:34:25AM +, Daniel Scally wrote:
> > > > We
On Mon, 2021-01-18 at 15:39 +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2021 at 12:34:25AM +, Daniel Scally wrote:
> > We want to refer to an i2c device by name before it has been
>
> I²C
Andy, are you next going to suggest renaming all the files with i2c?
$ git ls-files | grep i2c | wc
Improve the TYPECAST_INT_CONSTANT test by showing the suggested
conversion for various type of uses like (unsigned int)1 to 1U.
Signed-off-by: Joe Perches
---
Douglas Gilbert sent me a private email (and in that email said he
'loves to hate checkpatch' ;) complaining that checkpatch warned
On Mon, 2021-01-18 at 11:18 +0800, Chengyang Fan wrote:
> I'm doing the work.
Good, thank you.
> Should I submit patches individually or together?
I believe you should submit multiple patches, one for each subsystem.
For instance, a single patch should change all of:
>
On Mon, 2021-01-18 at 09:52 +0800, Chengyang Fan wrote:
> Remove superfluous semicolons after function definitions.
Are you intending to submit patches for all of these?
(there are probably many more)
$ git grep -P 'static\s+inline.*\(.*\)\s*\{\s*;?\s*\}\s*;' -- '*.[ch]'
w this hasn't been tested or
compiled in 5+ years...
commit 0fec65130b9f11a73d74f47025491f97f82ba070
Author: Joe Perches
Date: Tue May 5 10:06:06 2015 -0700
Acked-by: Joe Perches
> Signed-off-by: Tom Rix
> ---
> drivers/net/arcnet/com20020_cs.c | 2 +-
>
f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to
sysfs_emit")
Reported-by: James Bottomley
Signed-off-by: Joe Perches
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/u
On Fri, 2021-01-15 at 14:15 -0800, James Bottomley wrote:
> On Fri, 2021-01-15 at 13:23 -0800, Joe Perches wrote:
> > In commit e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs
> > _show
> > uses to sysfs_emit") I mistakenly used len = sysfs_emit_at to
>
ed. Do so.
Fixes: e28bf1f03b01 ("RDMA: Convert various random sprintf sysfs _show uses to
sysfs_emit")
Reported-by: James Bottomley
Signed-off-by: Joe Perches
---
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Fri, 2021-01-15 at 09:10 +0100, Mauro Carvalho Chehab wrote:
> The phy USB3 driver for Hisilicon 970 (hi3670) is ready
> for mainstream. Mode it from staging into the main driver's
> phy/ directory.
[]
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
>
On Fri, 2021-01-15 at 09:10 +0100, Mauro Carvalho Chehab wrote:
> The phy USB3 driver for Hisilicon 970 (hi3670) is ready
> for mainstream. Mode it from staging into the main driver's
> phy/ directory.
[]
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml
>
On Thu, 2021-01-14 at 13:18 -0800, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 11:52 AM Joe Perches wrote:
> >
> > Given the upgrade requirement, and how clang version requirements
> > constantly change, how much more difficult would it be for others
> > to use gc
On Thu, 2021-01-14 at 10:43 -0800, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 12:18 AM Ard Biesheuvel wrote:
> >
> > So if the arguments are piling up, what is holding us back, other than
> > inertia?
>
> I think we can most certainly just try increasing the minimum version
> to 5.1 in the
On Thu, 2021-01-14 at 18:35 +0100, Mauro Carvalho Chehab wrote:
> Instead of using 1/0 for true/false, change the type to boolean
> and change the returned value.
[]
> diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
[]
> @@ -326,24 +326,24 @@
On Thu, 2021-01-14 at 18:35 +0100, Mauro Carvalho Chehab wrote:
> Instead of using 1/0 for true/false, change the type to boolean
> and change the returned value.
[]
> diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c
> b/drivers/staging/hikey9xx/phy-hi3670-usb3.c
[]
> @@ -326,24 +326,24 @@
On Thu, 2021-01-14 at 09:57 +, Jankowski, Konrad0 wrote:
> > -Original Message-
> > From: Intel-wired-lan On Behalf Of Wei
> > Xu
[]
> > Use the ARRAY_SIZE macro to calculate the size of an array.
> > This code was detected with the help of Coccinelle.
[]
> > diff --git
On Thu, 2021-01-14 at 11:39 +0800, Leo Yan wrote:
> When sort on the respective metrics (lcl_hitm, rmt_hitm, tot_hitm),
> macro FILTER_HITM is to filter out the cache line entries if its
> overhead is less than 1%.
>
> This patch introduces static function filter_display() to replace macro;
> and
On Thu, 2021-01-14 at 02:57 +0900, Masahiro Yamada wrote:
> On Thu, Jan 14, 2021 at 1:08 AM Catalin Marinas
> wrote:
> >
> > On Tue, 12 Jan 2021 22:48:32 +, Will Deacon wrote:
> > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references
> > > beyond the stack pointer,
commit 989e43c7ec34 ("mpt3sas: Added OEM Gen2 PnP ID branding names")
consolidated individual functions for OEM branding into a single function
but left a test for intel only at the top so no other vendor branding
was output. Remove the test.
Signed-off-by: Joe Perches
---
If no o
On Tue, 2021-01-12 at 17:40 +, Johannes Thumshirn wrote:
> On 12/01/2021 18:38, Joe Perches wrote:
> > static void
> > _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
> > {
> > + const char *b = NULL; /* brand */
> > + const char *v = NULL;
/mpt3sas_base.o.new
72285 88 288 72661 11bd5 drivers/scsi/mpt3sas/mpt3sas_base.o.old
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 144 ++--
1 file changed, 54 insertions(+), 90 deletions(-)
diff --git a/drivers/scsi/mpt3sas
On Mon, 2021-01-11 at 14:51 -0800, Ben Widawsky wrote:
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -4459,6 +4459,16 @@ F: fs/configfs/
> F: include/linux/configfs.h
> F: samples/configfs/
>
> +COMPUTE EXPRESS LINK (CXL)
> +M: Vishal Verma
> +M: Ira Weiny
> +M: Ben Widawsky
$line | cut -f1 -d':')
link=$(echo $line | cut -f2- -d':')
newlink=$(cvt_lkml_to_lore $link)
if [[ -n "$newlink" ]] ; then
sed -i -e "s#\b$link\b#$newlink#" $file
fi
done
Link: https://lore.kernel.org/patchwork/patch/1265849/#14626
Prefer using ftrace over function entry/exit logging messages.
Warn with various function entry/exit only logging that only
use __func__ with or without descriptive decoration.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 35 +++
1 file changed, 35
On Fri, 2021-01-08 at 10:53 +, Lee Jones wrote:
> On Fri, 08 Jan 2021, Zheng Yongjun wrote:
>
> You're still not using the correct subject format.
>
> It should be:
>
> "mfd: : Description starting with an uppercase char"
IMO: overly pedantic
On Thu, 2021-01-07 at 13:16 -0800, Kees Cook wrote:
> On Tue, Jan 05, 2021 at 01:28:18AM -0800, Joe Perches wrote:
> > On Tue, 2021-01-05 at 14:29 +0530, Dwaipayan Ray wrote:
> > > On Tue, Jan 5, 2021 at 2:14 PM Joe Perches wrote:
> > > >
> > > > On Tue
On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote:
> On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote:
> > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > > > On 06-Ja
On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote:
> On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote:
> > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > > > On 06-Ja
On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote:
> Signed-off-by: Thomas Bogendoerfer
[]
> diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h
[]
> @@ -26,11 +26,6 @@
> * DMA channel.
> */
>
>
> -#ifdef CONFIG_MACH_TX49XX
> -static inline bool
On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> > > > There is a debug message using hardcoded
On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote:
> > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote:
> > > > There is a debug message using hardcoded
On Wed, 2021-01-06 at 18:48 +0530, Bhaskar Chowdhury wrote:
> Good point Randy, there were several driver file witch have "defautly" in it
> and I tried to correct that.Only that spell made it a "de-faulty" as dic
> suggested . But I think it should be "by default" as you said.
What tool
On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote:
> The snprintf() function returns the number of characters which would
> have been printed if there were enough space, but the scnprintf()
> returns the number of characters which were actually printed. If the
> buffer is not large enough, then
On Wed, 2021-01-06 at 14:36 +0800, YANG LI wrote:
> The snprintf() function returns the number of characters which would
> have been printed if there were enough space, but the scnprintf()
> returns the number of characters which were actually printed. If the
> buffer is not large enough, then
On Tue, 2021-01-05 at 17:11 +0530, Bhaskar Chowdhury wrote:
> On 22:24 Tue 05 Jan 2021, Julian Calaby wrote:
> > Hi Bhaskar,
[]
> > and your change is just making this comment worse.
> really??? Not sure about it.
I agree with Julian. I'm fairly sure it's worse.
The change you suggest doesn't
On Tue, 2021-01-05 at 10:35 +, David Laight wrote:
> From: Joe Perches
> > Sent: 05 January 2021 10:01
> >
> > On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> > > Perl 5.22 onwards require that "A literal "{" should now be
> > >
On Tue, 2021-01-05 at 16:00 +0530, Dwaipayan Ray wrote:
> Indentations should use tabs wherever possible.
> Replace spaces by tabs for indents.
Thanks.
Acked-by: Joe Perches
>
> Signed-off-by: Dwaipayan Ray
> ---
> scripts/checkpatch.pl | 18 +-
&g
On Tue, 2021-01-05 at 15:05 +0530, Dwaipayan Ray wrote:
> Perl 5.22 onwards require that "A literal "{" should now be
> escaped in a pattern".
Not quite correct.
> checkpatch contains several literal "{". Fix such instances
> by preceding them with a backslash.
Not all literal left braces need
On Tue, 2021-01-05 at 14:29 +0530, Dwaipayan Ray wrote:
> On Tue, Jan 5, 2021 at 2:14 PM Joe Perches wrote:
> >
> > On Tue, 2021-01-05 at 13:53 +0530, Dwaipayan Ray wrote:
> > > strcpy() performs no bounds checking on the destination buffer.
> > > This could
On Mon, 2021-01-04 at 14:09 -0800, Joe Perches wrote:
> On Sun, 2021-01-03 at 08:50 +0100, Nicolai Fischer wrote:
> > Adds a new warning in case the indentation level of the
> > first line of a Kconfig help message is not at least two spaces
> > higher than the keyword it
On Tue, 2021-01-05 at 13:53 +0530, Dwaipayan Ray wrote:
> strcpy() performs no bounds checking on the destination buffer.
> This could result in linear overflows beyond the end of the buffer.
>
> strlcpy() reads the entire source buffer first. This read
> may exceed the destination size limit.
On Sun, 2021-01-03 at 08:50 +0100, Nicolai Fischer wrote:
> Adds a new warning in case the indentation level of the
> first line of a Kconfig help message is not at least two spaces
> higher than the keyword itself.
> Blank lines between the message and the help keyword
> are ignored.
>
>
q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/
Signed-off-by: Joe Perches
---
Resend adding alsa-devel as requested by Takashi Iwai
sound/aoa/codecs/onyx.c| 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/aoa/codecs/toonie.c | 2 +-
sound/aoa
e existing tests to avoid these false positives.
Miscellanea:
o Add volatile to $Attribute
This also reduces checkpatch runtime a bit by moving the indentation
comparison test to the start of the block to avoid multiple unnecessary
regex tests.
Signed-off-by: Joe Perches
---
scripts/checkpat
On Thu, 2020-12-31 at 23:04 +0100, Jonathan Neuschäfer wrote:
> Hi,
>
> I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
> emitted even though I didn't change anything outside of Documentation/
> devicetree/bindings. I just converted a binding from plain text to YAML.
Rob?
On Thu, 2020-12-31 at 22:21 +0100, Julia Lawall wrote:
> It seems that the problem is not really the for_each, but the * in front
> of a "function call" on the left side of an assignment. Without the *,
> everything is fine. So it is indeed probably not worth doing anything
> about.
Maybe a
On Thu, 2020-12-31 at 11:04 -0800, Joe Perches wrote:
> strlcpy is deprecated. see: Documentation/process/deprecated.rst
>
> Change the calls that do not use the strlcpy return value to the
> preferred strscpy.
>
> Done with cocci script:
>
> @@
> expression e1, e2,
On Thu, 2020-12-31 at 21:27 +0100, Julia Lawall wrote:
> On Thu, 31 Dec 2020, Joe Perches wrote:
> > On Thu, 2020-12-31 at 11:04 -0800, Joe Perches wrote:
> > > strlcpy is deprecated. see: Documentation/process/deprecated.rst
> > >
> > > Change the calls that
q3JFkr_i_uTL=v6a6g1ouzcprm...@mail.gmail.com/
Signed-off-by: Joe Perches
---
sound/aoa/codecs/onyx.c| 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/aoa/codecs/toonie.c | 2 +-
sound/aoa/core/alsa.c | 8
sound/aoa/fabr
On Wed, 2020-12-30 at 14:36 +0100, Jan Schlien wrote:
> Hi,
>
> I found some odd behavior of checkpatch.pl, which I'm currently using
> for own projects outside the kernel, but I verified that kernel patches
> can be affected as well.
Hello Jan.
I've had this patch locally for awhile that I
/^.\s*\.\w+\s*=\s*.*\bNR_CPUS\b/)
> {
> WARN("NR_CPUS",
> "usage of NR_CPUS is often wrong - consider using
> cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .
> $herecurr);
Thanks.
Acked-by: Joe Perches
401 - 500 of 25402 matches
Mail list logo