:
> https://github.com/0day-ci/linux/commits/Joe-Perches/mm-Convert-sysfs-sprintf-family-to-sysfs_emit/20201102-041456
[]
> on test machine: 8 threads Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz with 32G
> memory
>
> caused below changes (please refer to attached dmesg/kmsg for entir
On Fri, 2020-11-13 at 19:27 +0530, Dwaipayan Ray wrote:
> Delete repeated word in scripts/checkpatch.pl:
> "are are" -> "are"
>
> Fix typos:
> "commments" -> "comments"
> "falsly" -> "falsely"
>
> Signed-off-by: Dwaipayan Ray
> ---
style: this should have subject prefix:
"[PATCH V2]
On Thu, 2020-11-12 at 11:30 -0800, Nick Desaulniers wrote:
> On Thu, Nov 12, 2020 at 7:13 AM Moore, Robert wrote:
> > -Original Message-
> > From: Nick Desaulniers
> > On Wed, Nov 11, 2020 at 7:15 AM Moore, Robert
> > wrote:
> > > Yes, but: isn't the "fallthrough" keyword
On Wed, 2020-11-11 at 16:39 +0530, Aditya wrote:
> On 11/11/20 4:00 pm, Lukas Bulwahn wrote:
> > On Wed, Nov 11, 2020 at 10:01 AM Aditya Srivastava
> > wrote:
> > >
> > > Currently checkpatch warns us if there is no 'Signed-off-by' line
> > > for the patch.
> > >
> > > E.g., running checkpatch
On Tue, 2020-11-10 at 14:00 -0800, Nick Desaulniers wrote:
> Yeah, we could go through and remove %h and %hh to solve this, too, right?
Yup.
I think one of the checkpatch improvement mentees is adding
some suggestion and I hope an automated fix mechanism for that.
On Wed, 2020-11-11 at 00:36 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns us if there is no 'Signed-off-by' line
> for the patch.
trivial style and a comment:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2755,6 +2757,10 @@ sub process {
> if
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
> The clang warning -Wextra-semi-stmt produces about 10k
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
> The clang warning -Wextra-semi-stmt produces about 10k
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
> The clang warning -Wextra-semi-stmt produces about 10k
On Tue, 2020-10-27 at 09:42 -0700, t...@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
> The clang warning -Wextra-semi-stmt produces about 10k
On Sat, 2020-11-07 at 00:11 -0800, Nick Desaulniers wrote:
> Clang is more aggressive about -Wformat warnings when the format flag
> specifies a type smaller than the parameter. Turns out, struct
> Scsi_Host's member can_queue is actually an int. Fixes:
>
> warning: format specifies type 'short'
On Sun, 2020-11-08 at 14:34 +0800, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> Fix the following coccinelle report:
>
> ./drivers/s390/net/qeth_l3_main.c:107:2-4: WARNING: possible condition with
> no effect (if == else)
>
> Both branches are the same, so remove them.
[]
> diff --git
On Sun, 2020-11-08 at 19:13 +0530, Aditya Srivastava wrote:
> Currently, checkpatch warns us if the author of the commit signs-off
> as co-developed-by.
[]
> A quick manual check found out that all fixes were correct in those
> cases.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
.org/lkml/20201108100632.75340-1-dwaipayanr...@gmail.com/T/#u
Thanks Dwaipayan.
Acked-by: Joe Perches
> Signed-off-by: Dwaipayan Ray
> ---
You should start to add changelog blocks to these
versioned patches so it's easier to look for what
changed between versions.
here...
> diff --git a/scr
On Sun, 2020-11-08 at 08:34 +0100, Lukas Bulwahn wrote:
> On Sat, 7 Nov 2020, Joe Perches wrote:
> > On Fri, 2020-11-06 at 23:55 -0800, Nick Desaulniers wrote:
> > > Clang is more aggressive about -Wformat warnings when the format flag
> > > specifies a type smaller
On Sat, 2020-11-07 at 20:54 +0800, Alex Shi wrote:
> 在 2020/11/7 上午12:39, Florian Fainelli 写道:
> > > It is good to remember that there are multiple readers of source
> > > files. There is the compiler which generates code from it, and there
> > > is the human trying to understand what is going on,
On Fri, 2020-11-06 at 23:55 -0800, Nick Desaulniers wrote:
> Clang is more aggressive about -Wformat warnings when the format flag
> specifies a type smaller than the parameter. Fixes 8 instances of:
>
> warning: format specifies type 'unsigned short' but the argument has
> type 'int' [-Wformat]
On Sat, 2020-11-07 at 10:11 +0530, Dwaipayan Ray wrote:
> On Sat, Nov 7, 2020 at 3:34 AM Joe Perches wrote:
> >
> > On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote:
> > > checkpatch doesn't report warnings for many common mistakes
> > > in emails.
On Sat, 2020-11-07 at 03:15 +0530, Dwaipayan Ray wrote:
> checkpatch doesn't report warnings for many common mistakes
> in emails. Some of which are trailing commas and incorrect
> use of email comments.
Assuming it all works, this looks good. I haven't tested it.
How did you test the $fix
On Fri, 2020-11-06 at 13:32 -0800, Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 11:12 PM wrote:
> > Fix following warning from coccinelle:
> > ./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed
> > here
[]
> > diff --git a/tools/lib/bpf/libbpf.c
On Fri, 2020-11-06 at 16:28 +0800, Alex Shi wrote:
>
> 在 2020/11/6 下午2:36, Joe Perches 写道:
> > On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> > > There are some macros unused, they causes much gcc warnings. Let's
> > > remove them to tame gcc.
> >
> &
On Thu, 2020-11-05 at 23:26 -0800, Dmitry Torokhov wrote:
> On Wed, Nov 04, 2020 at 04:24:17PM +, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
> >
On Fri, 2020-11-06 at 13:37 +0800, Alex Shi wrote:
> There are some macros unused, they causes much gcc warnings. Let's
> remove them to tame gcc.
I believe these to be essentially poor warnings.
Aren't these warnings generated only when adding W=2 to the make
command line?
Perhaps it's better
On Fri, 2020-11-06 at 02:46 +0530, Dwaipayan Ray wrote:
> > Can you send me a file with the BAD_SIGN_OFF messages generated
> > and if possible the git SHA-1s of the commits?
> Yes sure, am attaching the file for data tested on about 27k commits
> from v5.4.
Thanks.
> Excluded the duplicate
On Wed, 2020-11-04 at 13:24 +0800, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> Fix the gcc warning:
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this
> 'for' clause does not guard... [-Wmisleading-indentation]
> 2673 | for (i = 0; i < n; ++i) \
On Thu, 2020-11-05 at 10:50 +0100, Ricardo Ribalda wrote:
> Hi Joe
Rehi Ricardo.
> On Thu, Nov 5, 2020 at 12:59 AM Joe Perches wrote:
> > It looks as if all the pr_cont uses in the code are odd and repetitive.
> >
> > Perhaps it'd be sensible to add something like:
(adding stable and Greg KH for additional review)
On Thu, 2020-11-05 at 17:29 +0530, Dwaipayan Ray wrote:
> checkpatch doesn't report warnings for many common mistakes
> in emails. Some of which are trailing commas and incorrect
> use of email comments.
I presume you've tested this against the
On Thu, 2020-11-05 at 07:44 +0100, Miguel Ojeda wrote:
> There are a few important new features:
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
> - AlignConsecutiveMacros is probably one of the biggest one for the
> kernel that we were missing so far.
There's no control as to
On Thu, 2020-11-05 at 00:01 +0100, Ricardo Ribalda wrote:
> Hi Joe
>
> On Thu, Nov 5, 2020 at 12:00 AM Joe Perches wrote:
> >
> > On Wed, 2020-11-04 at 23:31 +0100, Ricardo Ribalda wrote:
> >
> > > I have updated my tree with the dev_ variants
> >
On Wed, 2020-11-04 at 23:31 +0100, Ricardo Ribalda wrote:
> I have updated my tree with the dev_ variants
>
> https://github.com/ribalda/linux/commit/b8785fd8efb4f2e5bbf5d0f2df3e0d69a5439015
I looked at this link and was confused so you made me look.
I think you meant:
On Wed, 2020-11-04 at 23:42 +0200, Laurent Pinchart wrote:
> Hi Joe,
Hi Laurent.
> On Wed, Nov 04, 2020 at 11:29:30AM -0800, Joe Perches wrote:
> > On Wed, 2020-11-04 at 19:07 +0100, Ricardo Ribalda wrote:
> > > Replace all the uses of printk(KERN_CONT ... with pr_cont().
&g
On Wed, 2020-11-04 at 19:07 +0100, Ricardo Ribalda wrote:
> Replace all the uses of printk(KERN_CONT ... with pr_cont().
Perhaps remove the uvc_printk macro and uses and use the more
common pr_fmt and pr_ mechanisms.
Something like:
---
drivers/media/usb/uvc/uvc_ctrl.c | 5 +++--
On Wed, 2020-11-04 at 16:48 +0100, Maximilian Luz wrote:
> On 11/4/20 6:13 AM, Joe Perches wrote:
>
> [...]
>
> > > Yes. I scanned drivers/acpi for trailing whitespaces after I noticed a
> > > couple of them. I did not explicitly scan for other stuff like spaces
&g
On Wed, 2020-11-04 at 10:16 +0100, Johan Hovold wrote:
> Running scrips/get_maintainer.pl on this series [1] gave the wrong
> address for Nick Desaulniers:
>
> Nick Desaulniers
> (commit_signer:1/2=50%,commit_signer:1/8=12%)
>
> It seems he recently misspelled his address in a
On Tue, 2020-11-03 at 22:30 +0100, Maximilian Luz wrote:
> On 11/3/20 10:12 PM, Bjorn Helgaas wrote:
> > On Mon, Nov 02, 2020 at 02:36:41PM +0100, Maximilian Luz wrote:
> > > Remove trailing whitespace and fix some whitespace inconsitencies while
> > > at it.
> >
> > I'm OK with this as long as
On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 4:15 AM Joe Perches wrote:
> >
> > No one ever will use clang-format on the current kernel sources
> > without having a recent version of clang and clang-format.
>
> Why? Many distros
On Wed, 2020-11-04 at 04:10 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 1:56 AM Joe Perches wrote:
> >
> > Do remember that this patch is for the current kernel and
> > not any old version that someone might be compiling.
> >
> > The current kernel _req
On Tue, 2020-11-03 at 17:08 -0800, Nick Desaulniers wrote:
> On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda
> wrote:
> > On Tue, Nov 3, 2020 at 7:29 PM Joe Perches wrote:
> > >
> > > Now that the clang minimum supported version is > 10.0, enable the
> > &
On Tue, 2020-11-03 at 22:33 +0100, Miguel Ojeda wrote:
> It is, yeah; however, the concern is that there may be developers
> running an old clang-format from their distro (i.e. not using it for
> compiling the kernel).
I expect that'd be extremely unusual.
> We need to compare the functionality
On Tue, 2020-11-03 at 09:10 +0100, Lukas Bulwahn wrote:
> Maybe you can coordinate among each other who would want to create
> suitable fix rules here?
Yes please.
> Also, start with the class of the most frequent mistakes for
> unexpected content after email addresses.
>
> I imagine that a
Now that the clang minimum supported version is > 10.0, enable the
commented out conditional reformatting key:value lines in the file.
Signed-off-by: Joe Perches
---
Hey Miguel.
I don't use this, but on its face it seems a reasonable change
if the commented out key:value lines are corr
On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote:
> On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > > pixel formats denoted by
On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote:
> On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > > pixel formats denoted by
On Tue, 2020-11-03 at 11:28 +0530, Dwaipayan Ray wrote:
> On Tue, Nov 3, 2020 at 11:18 AM Dwaipayan Ray wrote:
> >
> > checkpatch doesn't report warnings for many common mistakes
> > in emails. Some of which are trailing commas and incorrect
> > use of email comments.
> >
> > At the same time
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Andy brought to my attention the fact that users allocating an array of
> equally sized elements should check if the size multiplication doesn't
> overflow. This is why we have helpers like
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Andy brought to my attention the fact that users allocating an array of
> equally sized elements should check if the size multiplication doesn't
> overflow. This is why we have helpers like
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> Andy brought to my attention the fact that users allocating an array of
> equally sized elements should check if the size multiplication doesn't
> overflow. This is why we have helpers like
On Mon, 2020-11-02 at 17:50 -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 2:58 PM, Alejandro Colomar wrote:
> > Changes:
> > - Consistently use 'unsigned int', instead of 'unsigned'.
> > - Add a blank line after variable declarations.
> > - Move variable declarations to the top of functions.
On Mon, 2020-11-02 at 14:40 +, Matthew Wilcox wrote:
> For someone who's used to C "strings", it's pretty common to do
> something like:
>
> buf += sprintf(buf, "foo ");
> buf += sprintf(buf, "bar ");
It's not equivalent code.
What was actually necessary was using scnprintf
On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with
Add __alias and __weak to the suggested __attribute__(()) conversions.
Signed-off-by: Joe Perches
---
This depends on the patch to remove stringification from the __alias macro.
scripts/checkpatch.pl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b
On Sun, 2020-11-01 at 22:06 +, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 01:43:13PM -0800, Joe Perches wrote:
> > > Why did you change this?
> >
> > Are you asking about the function argument alignment or the commit message?
>
> The indentation. Don't
On Sun, 2020-11-01 at 22:06 +, Matthew Wilcox wrote:
> Oh, ugh, sysfs_emit() should be able to work on a buffer that isn't
> page aligned. Greg, how about this?
>
> +++ b/fs/sysfs/file.c
> @@ -722,13 +722,13 @@ int sysfs_emit(char *buf, const char *fmt, ...)
> {
> va_list args;
>
On Sun, 2020-11-01 at 22:06 +, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 01:43:13PM -0800, Joe Perches wrote:
> > > Why did you change this?
> >
> > Are you asking about the function argument alignment or the commit message?
>
> The indentation. Don't
On Sun, 2020-11-01 at 21:19 +, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 01:04:35PM -0800, Joe Perches wrote:
> > On Sun, 2020-11-01 at 20:48 +, Matthew Wilcox wrote:
> > > On Sun, Nov 01, 2020 at 12:12:51PM -0800, Joe Perches wrote:
> > > > @@
On Sun, 2020-11-01 at 20:48 +, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 12:12:51PM -0800, Joe Perches wrote:
> > @@ -4024,7 +4024,7 @@ int __init shmem_init(void)
> >
> >
> > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) && defined(CONFIG_SYSFS)
>
Use the new sysfs_emit family and not the sprintf family.
Joe Perches (5):
mm: Use sysfs_emit for struct kobject * uses
mm: huge_memory: Convert remaining use of sprintf to sysfs_emit and neatening
mm:backing-dev: Use sysfs_emit in macro defining functions
mm: shmem: Convert
Convert the unbounded uses of sprintf to sysfs_emit.
A few conversions may now not end in a newline if the output buffer
is overflowed.
Signed-off-by: Joe Perches
---
mm/slub.c | 148 --
1 file changed, 76 insertions(+), 72 deletions(-)
diff
Update the function to use sysfs_emit_at while neatening the uses
of sprintf and overwriting the last space char with a newline.
Signed-off-by: Joe Perches
---
mm/shmem.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index
Convert the only use of sprintf with struct kobject * that the cocci
script could not convert.
Miscellanea:
o Neaten the uses of a constant string with sysfs_emit to use a const
char * to reduce overall object size
Signed-off-by: Joe Perches
---
mm/huge_memory.c | 52
The cocci script used in commit bdacbb8d04f ("mm: Use sysfs_emit
for struct kobject * uses") does not convert the name##_show macro
because the macro uses concatenation via ##.
Convert it by hand.
Signed-off-by: Joe Perches
---
mm/backing-dev.c | 8
1 file changed, 4 insert
Use the sysfs_emit function instead of the sprintf family.
Done with cocci script as in commit 3c6bff3cf988
("RDMA: Convert sysfs kobject * show functions to use sysfs_emit()")
Signed-off-by: Joe Perches
---
mm/huge_memory.c | 28
mm/hugetlb.
On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with
On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with
On Sat, 2020-10-31 at 11:41 +0530, Dwaipayan Ray wrote:
> Names which have must quote characters without any comments are
> not warned about right now:
>
> D. Ray doesn't throw any warning, while
> D. Ray (Dwai) does.
I agree that a comment in parentheses after the name and before
the email
On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote:
>
> On Fri, 30 Oct 2020, Joe Perches wrote:
>
> > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote:
> > > checkpatch has limited support for parsing email comments. It only
> > > support single name
On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote:
> On Fri, 30 Oct 2020, Joe Perches wrote:
> > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote:
> > > checkpatch has limited support for parsing email comments. It only
> > > support single name comments or si
after
this change-id is also blank to remove one of those blank lines.
On second thought:
A quick check shows less than 20 of those in kernel git history
so it might not be too worthwhile.
Acked-by: Joe Perches
On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote:
> checkpatch has limited support for parsing email comments. It only
> support single name comments or single after address comments.
> Whereas, RFC 5322 specifies that comments can be inserted in
> between any tokens of the email fields.
>
quotes to define the aliased symbol.
Remove the stringification and add quotes and when necessary a stringification
when existing uses have a ## concatenation.
Signed-off-by: Joe Perches
---
Unlike the __section macro conversion in commit 33def8498fdd
("treewide: Convert macro and
On Thu, 2020-10-29 at 18:01 -0700, James Bottomley wrote:
> On Thu, 2020-10-29 at 17:11 -0700, Joe Perches wrote:
> > This file still does not have an SPDX line. What should it be?
>
> It's old style MIT with a slight variation:
>
> https://fedoraproject.org/wiki/Licensi
current_device != 1 and unindent code block
o Add and remove braces where appropriate
Signed-off-by: Joe Perches
---
Uncompiled/untested.
On top of Christoph's changes.
This file still does not have an SPDX line. What should it be?
Is this still used by anyone?
drivers/block/z2ram.c | 304
On Thu, 2020-10-29 at 12:34 -0700, Nick Desaulniers wrote:
> On Mon, Oct 26, 2020 at 2:31 PM Arnd Bergmann wrote:
> >
> > From: Arnd Bergmann
> >
> > The returned string from rsxx_card_state_to_str is 'const',
> > but the other qualifier doesn't change anything here except
> > causing a
(SPDX mismatches found using this grep)
$ git grep --name-only 'MODULE_LICENSE("GPL and add' -- '*.c' | xargs grep SPDX
drivers/char/agp/hp-agp.c:// SPDX-License-Identifier: GPL-2.0-only
drivers/dma-buf/selftest.c:/* SPDX-License-Identifier: MIT */
drivers/gpu/drm/ttm/ttm_module.c:/*
On Thu, 2020-10-29 at 16:11 +0100, Jean Delvare wrote:
> On Thu, 29 Oct 2020 07:55:25 -0700, Joe Perches wrote:
> > On Thu, 2020-10-29 at 14:32 +0100, Jean Delvare wrote:
> > > WARNING: Possible repeated word: 'git'
> > > #20: FILE: MAINTAINERS:5289:
> > > +T:
On Thu, 2020-10-29 at 14:32 +0100, Jean Delvare wrote:
> Hi Andy, Joe,
> > I have hit this false positive from checkscript:
>
> WARNING: Possible repeated word: 'git'
> #20: FILE: MAINTAINERS:5289:
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging.git
> dmi-for-next
>
>
commit e098bc9612c2 ("drm/amd/pm: optimize the power related source code
layout")
moved the directory, update the F: file pattern to match.
Signed-off-by: Joe Perches
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAI
ute types are now
left as-is and known types are converted and moved before
__attribute__ and removed from within the __attribute__((list...)).
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 46 --
1 file changed, 16 insertions(+), 30 deletions(
On Tue, 2020-10-27 at 14:09 -0700, Tom Rix wrote:
> On 10/27/20 12:51 PM, Joe Perches wrote:
[]
> > I hope a scripted patches mechanism will be established.
>
> I would be interested in this as well.
> I already have a repo tracking next.
> I can code up a script to do the c
(Adding Stephen Rothwell)
On Tue, 2020-10-27 at 12:33 -0700, Tom Rix wrote:
> On 10/27/20 11:42 AM, Nick Desaulniers wrote:
> > (cutting down the CC list to something more intimate)
[]
> I am interested in treewide fixes.
As am I, but here the definition of fixes is undefined though.
On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote:
> >
> > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> >
On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote:
> >
> > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> >
On Tue, 2020-10-27 at 17:58 +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 27, 2020 at 5:50 PM Joe Perches wrote:
> >
> > On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> > > On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> >
On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > Use the helper that checks for overflows internally instead of manually
> > calculating the size of the new array.
> >
> >
On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > Use the helper that checks for overflows internally instead of manually
> > calculating the size of the new array.
> >
> >
On Tue, 2020-10-27 at 11:28 -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski
> >
> > Use the helper that checks for overflows internally instead of manually
> > calculating the size of the new array.
> >
> >
On Mon, 2020-10-26 at 08:03 +0100, Mauro Carvalho Chehab wrote:
[]
> Well, this can help:
> my $typedef_type = qr { ((?:\w+\s+){1,}) }x;
unbounded captures are generally bad, I suggest a limit like {1,5}
> if ($x =~ /typedef\s+((?:\w+\s+){1,})\(\*?\s*(\w\S+)\s*\)\s*\((.*)\);/ ||
>
On Mon, 2020-10-26 at 13:49 +0100, Vasily Gorbik wrote:
> Currently s390 build is broken.
>
> SECTCMP .boot.data
> error: section .boot.data differs between vmlinux and
> arch/s390/boot/compressed/vmlinux
> make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1
> SECTCMP
On Mon, 2020-10-26 at 12:47 +0100, Johannes Berg wrote:
> From: Johannes Berg
>
> Joe's commit didn't only convert uses of __section(...) to add
> the quotes, but _also_ converted 'raw' uses of __attribute__(())
> for setting the section to use __section, but didn't update the
> includes where
On Mon, 2020-10-26 at 01:01 +0530, Dwaipayan Ray wrote:
> It is generally preferred that the macros from
> include/linux/compiler_attributes.h are used, unless there
> is a reason not to.
>
> checkpatch currently checks __attribute__ for each of
> packed, aligned, section, printf, scanf, and
On Sun, 2020-10-25 at 12:17 -0700, Andrew Morton wrote:
> On Mon, 26 Oct 2020 02:15:37 +0800 kernel test robot wrote:
> > vim +/ltv350qv_power +192 drivers/video/backlight/ltv350qv.c
>
> Odd - the code looks pretty normal. It is possible that your compiler
> is (crazily) inlining
On Sun, 2020-10-25 at 23:40 +0530, Dwaipayan Ray wrote:
> On Sun, Oct 25, 2020 at 11:29 PM Joe Perches wrote:
[]
> > Using $rawline would also change comments and that seems wrong.
> > Any reason to use $rawline instead of $line?
> Yes I used $line initially but changed
On Sun, 2020-10-25 at 15:45 +0530, Dwaipayan Ray wrote:
> It is generally preferred that the macros from
> include/linux/compiler_attributes.h are used, unless there
> is a reason not to.
>
> checkpatch currently checks __attribute__ for each of
> packed, aligned, section, printf, scanf, and
On Sun, 2020-10-25 at 14:12 +0530, Dwaipayan Ray wrote:
> Suppose we have non handled attributes in one such
> multi attribute macro. (not present in our hash)
>
> Like __attribute__((__packed, __something_not_handled))
>
> For this case, do I skip the warning totally? Or something else?
Emit
On Sun, 2020-10-25 at 14:02 +0530, Dwaipayan Ray wrote:
> And also do you think there should be a separate check
> for __alias__(#symbol)? I think it expects a string and that should
> be trimmed in the fix.
For now, I think you should avoid both alias and section.
There are patches to convert
On Sun, 2020-10-25 at 12:21 +0530, Dwaipayan Ray wrote:
> It is generally preferred that the macros from
> include/linux/compiler_attributes.h are used, unless there
> is a reason not to.
>
> checkpatch currently checks __attribute__ for each of
> packed, aligned, printf, scanf, and weak. Other
On Sun, 2020-10-25 at 06:51 +0100, Lukas Bulwahn wrote:
> We can identify a set of rules and clear automatic fixes that
> maintainers can simply run this script over the patches they pick
> up when they pick them up.
checkpatch --fix-inplace does that now.
But realistically, this is more an
On Sat, 2020-10-24 at 14:35 +0530, Dwaipayan Ray wrote:
> It is generally preferred that the macros from
> include/linux/compiler_attributes.h are used, unless there
> is a reason not to.
>
> checkpatch currently checks __attribute__ for each of
> packed, aligned, printf, scanf, and weak. Other
On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
> > Would you like to work on
> > further rules that can be improved with your evaluation approach?
>
> Yes, I would like work on further rules.
Some generic ideas:
How about working to reduce runtime and complexity by
making the rules
On Sat, 2020-10-24 at 15:52 +0530, Aditya Srivastava wrote:
> Presence of hexadecimal address or symbol results in false warning
> message by checkpatch.pl.
Thanks Aditya, this looks OK to me.
Andrew can you please pick up this patch on top of Dwaipayan's?
1:
801 - 900 of 25402 matches
Mail list logo
