[
https://issues.apache.org/jira/browse/KAFKA-15770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15770:
Component/s: unit tests
Only committers can login using their ASF account.
-Matthias
On 10/30/23 10:19 PM, Arpit Goyal wrote:
Hi
Can anyone help me provide access to Apache Pony Mail. I tried login using
the jira credential but it didn't work.
Thanks and Regards
Arpit Goyal
8861094754
[
https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15768:
Description:
Calling `StateQueryResult#getOnlyPartitionResult` crashes with an incorrect
Matthias J. Sax created KAFKA-15768:
---
Summary: StateQueryResult#getOnlyPartitionResult should not throw
for FailedQueryResult
Key: KAFKA-15768
URL: https://issues.apache.org/jira/browse/KAFKA-15768
Matthias J. Sax created KAFKA-15768:
---
Summary: StateQueryResult#getOnlyPartitionResult should not throw
for FailedQueryResult
Key: KAFKA-15768
URL: https://issues.apache.org/jira/browse/KAFKA-15768
Matthias J. Sax created KAFKA-15765:
---
Summary: Remove task level metric "commit-latency"
Key: KAFKA-15765
URL: https://issues.apache.org/jira/browse/KAFKA-15765
Project: Kafka
Matthias J. Sax created KAFKA-15765:
---
Summary: Remove task level metric "commit-latency"
Key: KAFKA-15765
URL: https://issues.apache.org/jira/browse/KAFKA-15765
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15672.
-
Resolution: Duplicate
> Add 3.6 to streams system te
[
https://issues.apache.org/jira/browse/KAFKA-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15672.
-
Resolution: Duplicate
> Add 3.6 to streams system te
[
https://issues.apache.org/jira/browse/KAFKA-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15672:
---
Assignee: Matthias J. Sax
> Add 3.6 to streams system te
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15594:
---
Assignee: Matthias J. Sax
> Add 3.6.0 to streams upgrade/compatibility te
[
https://issues.apache.org/jira/browse/KAFKA-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15595:
---
Assignee: Hao Li
> Session window aggregate drops records head
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15602.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15602.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-4852:
Assignee: (was: LinShunkang)
> ByteBufferSerializer not compatible with offs
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4852:
---
Labels: needs-kip (was: )
> ByteBufferSerializer not compatible with offs
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-4852:
Assignee: (was: LinShunkang)
> ByteBufferSerializer not compatible with offs
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4852:
---
Fix Version/s: (was: 3.4.0)
> ByteBufferSerializer not compatible with offs
Congrats!
On 10/27/23 10:01 AM, Viktor Somogyi-Vass wrote:
Congrats Satish!
On Fri, Oct 27, 2023, 18:48 Ivan Yurchenko wrote:
Congrats Satish!
Ivan
On Fri, Oct 27, 2023, at 19:02, Kamal Chandraprakash wrote:
Congratulations Satish!
On Fri, Oct 27, 2023, 21:10 Jorge Esteban Quilcate
[
https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15319:
Fix Version/s: 3.5.2
> Upgrade rocksdb to fix CVE-2022-37
[
https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15690:
Component/s: streams
unit tests
> EosIntegrationTest is fl
Hanyu
On Fri, Oct 20, 2023 at 10:40 AM Matthias J. Sax
wrote:
Thanks for the KIP Hanyu,
One questions:
To address this inconsistency, we propose that KeyQuery should
be
restricted to querying kv-stores only, ensuring that it always
returns
a
plain V type, making the be
+1 (binding)
On 10/25/23 4:06 PM, Sophie Blee-Goldman wrote:
Happy to see this -- that's a +1 (binding) from me
On Mon, Oct 23, 2023 at 6:33 AM Bill Bejeck wrote:
This is a great addition
+1(binding)
-Bill
On Fri, Oct 20, 2023 at 2:29 PM Almog Gavra wrote:
+1 (non-binding) - great
end
offset within the same release, ie without any deprecations. There are
plenty of paths forward here, so don't let us drag this out forever if
you
know what you want
Cheers,
Sophie
On Fri, Oct 20, 2023 at 10:57 AM Matthias J. Sax
wrote:
Forgot one thing:
We could also pass `curren
[
https://issues.apache.org/jira/browse/KAFKA-12550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780015#comment-17780015
]
Matthias J. Sax commented on KAFKA-12550:
-
Hmmm... Aren't both things kinda independent
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780013#comment-17780013
]
Matthias J. Sax commented on KAFKA-15602:
-
> Ah, nah, ByteBuffer.wrap("test".getBy
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779216#comment-17779216
]
Matthias J. Sax commented on KAFKA-15602:
-
{quote}I'm not entirely sure I understand Matthias's
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778731#comment-17778731
]
Matthias J. Sax edited comment on KAFKA-15602 at 10/23/23 4:20 PM
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778731#comment-17778731
]
Matthias J. Sax commented on KAFKA-15602:
-
Btw: also left a comment on K4852:
https
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778727#comment-17778727
]
Matthias J. Sax commented on KAFKA-4852:
As reported on https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778719#comment-17778719
]
Matthias J. Sax commented on KAFKA-15602:
-
Sounds fair. – Let me revert K4852 in all applicable
[
https://issues.apache.org/jira/browse/KAFKA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15666.
-
Resolution: Invalid
[~noraverba] – We can only take tickets in English. – Also piped
[
https://issues.apache.org/jira/browse/KAFKA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15666.
-
Resolution: Invalid
[~noraverba] – We can only take tickets in English. – Also piped
Matthias J. Sax created KAFKA-15672:
---
Summary: Add 3.6 to streams system tests
Key: KAFKA-15672
URL: https://issues.apache.org/jira/browse/KAFKA-15672
Project: Kafka
Issue Type: Test
Matthias J. Sax created KAFKA-15672:
---
Summary: Add 3.6 to streams system tests
Key: KAFKA-15672
URL: https://issues.apache.org/jira/browse/KAFKA-15672
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778511#comment-17778511
]
Matthias J. Sax edited comment on KAFKA-15602 at 10/23/23 4:09 AM
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778511#comment-17778511
]
Matthias J. Sax edited comment on KAFKA-15602 at 10/23/23 4:06 AM
[
https://issues.apache.org/jira/browse/KAFKA-15664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15664:
Component/s: streams
system tests
> Add 3.4.0 streams upgr
[
https://issues.apache.org/jira/browse/KAFKA-15664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15664:
Priority: Critical (was: Major)
> Add 3.4.0 streams upgrade/compatibility te
[
https://issues.apache.org/jira/browse/KAFKA-15664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15664:
Affects Version/s: 3.5.0
> Add 3.4.0 streams upgrade/compatibility te
[
https://issues.apache.org/jira/browse/KAFKA-15664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15664:
Fix Version/s: 3.5.2
3.7.0
3.6.1
> Add 3.
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778511#comment-17778511
]
Matthias J. Sax commented on KAFKA-15602:
-
Hey, [~pnee] pointed me to this ticket. I am
[
https://issues.apache.org/jira/browse/KAFKA-15662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15662:
Component/s: streams
> Implement support for clientInstanceIds in Kafka Str
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15378.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15378.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
Thanks for the info Luke.
We did backport all but one PR in the mean time. The missing PR is a
RocksDB version bump. We want to consider it for 3.5.2, because it
addresses a CVE.
Cf https://github.com/apache/kafka/pull/14216
However, RocksDB versions bumps are a little bit more tricky, and
Forgot one thing:
We could also pass `currentLag()` into `onBachLoaded()` instead of
end-offset.
-Matthias
On 10/20/23 10:56 AM, Matthias J. Sax wrote:
Thanks for digging into this Bruno.
The JavaDoc on the consumer does not say anything specific about
`endOffset` guarantees:
Get
ds
within the state. That is clearly not the meaning of the event for which
the listener should be called.
Best,
Bruno
On 10/19/23 2:12 AM, Matthias J. Sax wrote:
Thanks for the KIP. Seems I am almost late to the party.
About naming (fun, fun, fun): I like the current proposal overall,
except `on
Thanks for the KIP Hanyu,
One questions:
To address this inconsistency, we propose that KeyQuery should be restricted
to querying kv-stores only, ensuring that it always returns a plain V type,
making the behavior of the aforementioned code more predictable. Similarly,
RangeQuery should
[
https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13973:
Fix Version/s: 3.5.2
> block-cache-capacity metrics worth twice as much as nor
[
https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1550#comment-1550
]
Matthias J. Sax commented on KAFKA-7699:
Happy to support you. The KIP wiki page describes how
You would need to unsubscribe from the dev list.
I would recommend to setup a filter with you email provider if you don't
want these and re-direct them directly to trash.
-Matthias
On 10/19/23 4:49 AM, Shyam P wrote:
how to unsubscribe this ?
On Thu, Oct 19, 2023 at 1:30 PM Apache Jenkins
[
https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1368#comment-1368
]
Matthias J. Sax commented on KAFKA-7699:
[~hermankj] – thanks for your comment. – This change
[
https://issues.apache.org/jira/browse/KAFKA-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15616:
Fix Version/s: 3.7.0
> Define client telemetry states and their transiti
[
https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13973:
Fix Version/s: 3.6.1
> block-cache-capacity metrics worth twice as much as nor
[
https://issues.apache.org/jira/browse/KAFKA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15338:
Affects Version/s: (was: 3.4.0)
(was: 3.3.1
[
https://issues.apache.org/jira/browse/KAFKA-15338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15338:
Fix Version/s: 3.3.3
3.4.2
3.5.2
> The metric gr
[
https://issues.apache.org/jira/browse/KAFKA-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15629:
Description:
KIP-992:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A
[
https://issues.apache.org/jira/browse/KAFKA-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15629:
Labels: kip (was: )
> proposal to introduce IQv2 Query Types: TimeStampKeyQu
Thanks for the KIP. Seems I am almost late to the party.
About naming (fun, fun, fun): I like the current proposal overall,
except `onBachLoaded`, but would prefer `onBatchUpdated`. It better
aligns to everything else:
- it's an update-listener, not loaded-listener
- `StateRestoreListener`
[
https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776381#comment-17776381
]
Matthias J. Sax commented on KAFKA-6520:
Could we use Admin.describeCluster() which returns
Thanks -- there is a few fixed for Kafka Streams we are considering to
cherry-pick to get into 3.5.2 release -- what timeline do you target for
the release?
-Matthias
On 10/17/23 8:47 AM, Divij Vaidya wrote:
Thank you for volunteering Luke.
--
Divij Vaidya
On Tue, Oct 17, 2023 at 3:26
+1 (binding)
On 10/13/23 9:24 AM, Hanyu (Peter) Zheng wrote:
Hello everyone,
I would like to start a vote for KIP-985 that Add reverseRange and
reverseAll query over kv-store in IQv2.
Sincerely,
Hanyu
On Fri, Oct 13, 2023 at 9:15 AM Hanyu (Peter) Zheng
wrote:
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775325#comment-17775325
]
Matthias J. Sax commented on KAFKA-13152:
-
[~guozhang] would you have interest to help getting
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775323#comment-17775323
]
Matthias J. Sax commented on KAFKA-15594:
-
This ticket is to include upgrade test from 3.6
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775324#comment-17775324
]
Matthias J. Sax commented on KAFKA-15594:
-
This ticket is to include upgrade test from 3.6
[
https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775322#comment-17775322
]
Matthias J. Sax commented on KAFKA-15593:
-
This ticket is to include upgrade test from 3.6
Done. You should be all set.
-Matthias
On 10/13/23 8:21 AM, Apoorv Mittal wrote:
Hi,
Can I please get permission to contribute KIP and assign Jiras to myself.
Wiki and Jira Id: apoorvmittal10
Email: apoorvmitta...@gmail.com
Regards,
Apoorv Mittal
+44 7721681581
Thanks -- there is a few fixed for Kafka Streams we are considering to
cherry-pick to get into 3.5.2 release -- can you give us a few more days
for this?
-Matthias
On 10/12/23 6:20 PM, Sophie Blee-Goldman wrote:
Thanks for volunteering Luke!
On Thu, Oct 12, 2023 at 2:55 AM Levani Kokhreidze
to javadocs for range() and reverseRange():
range(): *@return The iterator for this range, from smallest to largest
bytes.*
reverseRange(): * @return The reverse iterator for this range, from largest
to smallest key bytes.
Cheers,
Alieh
On Thu, Oct 12, 2023 at 7:32 AM Matthias J. Sax wrote:
Quick
[
https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15601:
Component/s: streams
> Client metrics and observabil
[
https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15601:
Component/s: admin
clients
consumer
[
https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15601:
Labels: kip (was: )
> Client metrics and observabil
network:type=RequestMetrics,name=RequestsPerSec,request=*) that
report Request rate for every request type?
Thanks,
Jun
On Wed, Oct 11, 2023 at 1:47 PM Matthias J. Sax
wrote:
Thanks!
On 10/10/23 11:31 PM, Andrew Schofield wrote:
Matthias,
Yes, I think that’s a sensible way forward and the interface
or not) could
change in the future, but the API can remain the same. Another slight
benefit is that there is no need for returning Optional. If the
global consumer is not used, it just won't be included in the map.
Thanks,
Jun
On Thu, Oct 12, 2023 at 9:30 AM Matthias J. Sax wrote:
Thanks Sophie
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15594:
Component/s: streams
system tests
> Add 3.6.0 to streams upgr
le.
Meanwhile within the method we would issue separate calls to each of the
clients using
the default or user-configured value of their `default.api.timeout.ms` as
the timeout
parameter.
So the API as proposed makes sense to me.
On Wed, Oct 11, 2023 at 6:48 PM Matthias J. Sax wrote:
In ca
()`, and
and I assume also `prefixScan()` (even if there is no "reverse" version
for it).
On 10/11/23 10:22 PM, Matthias J. Sax wrote:
Thanks for raising this question Hanyu. Great find!
My interpretation is as follows (it's actually a warning signal that the
API contract is not bett
to != null && from.compareTo(to) > 0) {
This section performs the necessary checks.
Sincerely,
Hanyu
On Thu, Oct 5, 2023 at 9:52 AM Hanyu (Peter) Zheng <
pzh...@confluent.io>
wrote:
Hi, Hao,
In this case, it will return an empty set or list in the end.
Sincerely,
Ha
: I do not get what you mean by your second comment. Isn't
the KIP already explicit about that?
> I assume, results are returned by timestamp for each key. The KIP
should be explicit about it.
Cheers,
Alieh
On Tue, Oct 3, 2023 at 6:07 AM Matthias J. Sax wrote:
Thanks for updating
me". If I do that, then it is not consistent with KIP-960.
Moreover, the input parameter is clearly a timestamp, which explains
enough. What do you think about that?
5. I was asked to add more examples to the example section. My
question
is, what is the main purpose of that?
return Optional?
132. ClientMetricsSubscriptionRequestCount: Do we need this since we have a
set of generic metrics
(kafka.network:type=RequestMetrics,name=RequestsPerSec,request=*) that
report Request rate for every request type?
Thanks,
Jun
On Wed, Oct 11, 2023 at 1:47 PM Matthias J. Sax wrote
+1 (binding)
On 9/13/23 5:48 PM, Jason Gustafson wrote:
Hey Andrew,
+1 on the KIP. For many users of Kafka, it may not be fully understood how
much of a challenge client monitoring is. With tens of clients in a
cluster, it is already difficult to coordinate metrics collection. When
there are
Thanks!
On 10/10/23 11:31 PM, Andrew Schofield wrote:
Matthias,
Yes, I think that’s a sensible way forward and the interface you propose looks
good. I’ll update the KIP accordingly.
Thanks,
Andrew
On 10 Oct 2023, at 23:01, Matthias J. Sax wrote:
Andrew,
yes I would like to get
[
https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773849#comment-17773849
]
Matthias J. Sax commented on KAFKA-15571:
-
Ups... Thanks to reporting and the PR
can also be included in the proposed Kafka Streams
follow-on KIP, or would you prefer that I add it to KIP-714?
I have a slight preference for the former to put all of the KS enhancements
into a separate KIP.
Thanks,
Andrew
On 7 Oct 2023, at 02:12, Matthias J. Sax wrote:
Thanks Andrew. SGTM.
One
it was an accident using getX in the IQv2 KIPs since
somebody would have brought it up, otherwise.
I am fine with both types of getters.
If we think, we need to discuss this in a broader context, let's start a
separate thread.
Best,
Bruno
On 10/5/23 7:44 AM, Matthias J. Sax wrote:
I agree
One more nit: as discussed on the related KIP-698 thread, we should not
use `get` as prefix for the getters.
So it should be `K key()` and `Optional asOfTimestamp()`.
Otherwise the KIP LGTM.
+1 (binding)
-Matthias
On 10/6/23 2:50 AM, Alieh Saeedi wrote:
Hi everyone,
Since KIP-960 is
[
https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15569:
Issue Type: Test (was: Improvement)
> Update test and add test ca
[
https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15569:
Component/s: streams
unit tests
> Update test and add test ca
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772748#comment-17772748
]
Matthias J. Sax commented on KAFKA-15378:
-
This is a partial fix with regard to versions
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15378:
---
Assignee: Matthias J. Sax
> Rolling upgrade system tests are fail
not universally support them. I don’t think the KIP is improved by adding
one now.
I have also added constants for the various Config classes for
ENABLE_METRICS_PUSH_CONFIG, including to
StreamsConfig. It’s best to be explicit about this.
Thanks,
Andrew
On 2 Oct 2023, at 23:47, Matthias J. Sax wr
[
https://issues.apache.org/jira/browse/KAFKA-15437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15437.
-
Resolution: Duplicate
> Add metrics about open iterat
[
https://issues.apache.org/jira/browse/KAFKA-15437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15437.
-
Resolution: Duplicate
> Add metrics about open iterat
, if specified
*/
public Optional getAsOfTimestamp();
Other than that I didn't have too much to add. Overall I like the
direction
of the KIP and think the funcatinlyt is all there!
best,
Walker
On Mon, Oct 2, 2023 at 10:46 PM Matthias J. Sax wrote:
Thanks for the updated KIP. Overa
**(How is this implemented/guaranteed in an
`inMemoryKeyValueStore`? I
don't know about that implementation).
Colt McNealy
*Founder, LittleHorse.dev*
On Tue, Oct 3, 2023 at 1:35 PM Hanyu (Peter) Zheng
wrote:
ok, I will update it. Thank you Matthias
Sincerely,
Hanyu
On Tue, Oct 3, 2
[
https://issues.apache.org/jira/browse/KAFKA-15541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772072#comment-17772072
]
Matthias J. Sax commented on KAFKA-15541:
-
Did not read the KIP yet, but sound very similar
Thanks for the KIP Hanyu!
I took a quick look and it think the proposal makes sense overall.
A few comments about how to structure the KIP.
As you propose to not add `ReverseRangQuery` class, the code example
should go into "Rejected Alternatives" section, not in the "Proposed
Changes"
Thanks for updating the KIP.
Not sure if I agree or not with Bruno's idea to split the query types
further? In the end, we split them only because there is three different
return types: single value, value-iterator, key-value-iterator.
What do we gain by splitting out single-ts-range-key? In
601 - 700 of 11284 matches
Mail list logo