Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

On Mon, Jan 23, 2023 at 09:07:16AM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 11, 2023 at 08:05:04PM -0700, Nathan Chancellor wrote: > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: > >

Re: [PATCH 5/6] hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps

Hi Philippe, On Wed, Jan 04, 2023 at 02:39:34PM +0100, Philippe Mathieu-Daudé wrote: > GT64120's PCI endianness swapping works on little-endian hosts, > but doesn't on big-endian ones. Instead of complicating how > CFGADDR/CFGDATA registers deal with endianness, use the existing > MemoryRegionOps

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Hi Naresh, On Mon, Jan 23, 2023 at 07:28:10PM +0530, Naresh Kamboju wrote: > FYI, > [ please provide comments, feedback and improvements on build/ ltp smoke > tests ] > > LKFT test farm have fetched your patch series [1] > [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Hi Naresh, On Mon, Jan 23, 2023 at 07:28:10PM +0530, Naresh Kamboju wrote: > FYI, > [ please provide comments, feedback and improvements on build/ ltp smoke > tests ] > > LKFT test farm have fetched your patch series [1] > [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Hi Naresh, On Mon, Jan 23, 2023 at 07:28:10PM +0530, Naresh Kamboju wrote: > FYI, > [ please provide comments, feedback and improvements on build/ ltp smoke > tests ] > > LKFT test farm have fetched your patch series [1] > [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

On Mon, Jan 23, 2023 at 02:27:51AM +0900, Masahiro Yamada wrote: > On Fri, Jan 13, 2023 at 3:21 AM Nathan Chancellor wrote: > > > > Hi Sedat, > > > > On Thu, Jan 12, 2023 at 07:02:30PM +0100, Sedat Dilek wrote: > > > On Thu, Jan 12, 2023 at 4:0

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

final:61: > arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1 > make: *** [Makefile:1924: modules] Error 2 > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > arch/powerpc/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. > I’ll have to filter the warnings to see if there are any other instances with > other operators that appear problematic. I count a single warning that triggers for an arithmetic operator (which might be a bug):

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. > In D139114#4053166 , @nathanchance > wrote: > >> For what it’s worth, this triggers a LOT in the Linux kernel for the pattern >> that @MaskRay pointed out: > > Out of curiosity, has it found any true positives that you

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

nathanchance added a comment. For what it’s worth, this triggers a LOT in the Linux kernel for the pattern that @MaskRay pointed out: https://gist.github.com/nathanchance/a76c2ba0a22dda3251c4ec5ee9e3f285 $ rg -c -- -Wconstant-conversion

Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

Hi Sedat, On Thu, Jan 12, 2023 at 07:02:30PM +0100, Sedat Dilek wrote: > On Thu, Jan 12, 2023 at 4:06 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: > > > &g

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

Hi Jocelyn, On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: > This patch does also solve a kernel crash when reading > /sys/class/drm/card1/gt/gt0/* on a skylake machine: > https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Interesting, I wonder what aspect of this patch fixes

Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

Hi Jocelyn, On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: > This patch does also solve a kernel crash when reading > /sys/class/drm/card1/gt/gt0/* on a skylake machine: > https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Interesting, I wonder what aspect of this patch fixes

[PATCH v2 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

that while the flag is one that it recognizes, it is not actually used by this compiler job. To eliminate the warning, remove -fno-stack-clash-protection from vgettimeofday-32.c's CFLAGS when using clang, as has been done for other flags previously. Signed-off-by: Nathan Chancellor Reviewed-by: Nick

[PATCH v2 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

pc64-linux-gnu -fno-integrated-as -m64 -### \ -x assembler-with-cpp -c -o /dev/null /dev/null &| grep gnu-as "/usr/bin/powerpc64-linux-gnu-as" "-a32" "-mppc" "-many" "-o" "/dev/null" "/tmp/null-ab8f8d.s" Remove this

[PATCH v2 07/14] powerpc/vdso: Improve linker flags

;) but now that there is a common ldflags variable, it can be moved there. Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/vdso/Makefile | 18 +++

[PATCH v2 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

when the linker is not invoked by the compiler. The kernel builds all .o files with '-c', which stops the compilation pipeline before linking, so '-s' can be safely dropped from ASFLAGS. Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Reviewed-by: Segher Boessenkool --- Cc: m

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

' into new ldflags-y variable (Nick) - Patch 8: Reword commit message to explain the problem in a clearer manner (Nick) - Link to v1: https://lore.kernel.org/r/20221228-drop-qunused-arguments-v1-0-658cbc8fc...@kernel.org --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

[PATCH v2 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor Acked-by: Alex Deucher --- Cc: amd-gfx@list

[PATCH v2 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor Acked-by: Alex Deucher --- Cc: amd-...@list

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

' into new ldflags-y variable (Nick) - Patch 8: Reword commit message to explain the problem in a clearer manner (Nick) - Link to v1: https://lore.kernel.org/r/20221228-drop-qunused-arguments-v1-0-658cbc8fc...@kernel.org --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

' into new ldflags-y variable (Nick) - Patch 8: Reword commit message to explain the problem in a clearer manner (Nick) - Link to v1: https://lore.kernel.org/r/20221228-drop-qunused-arguments-v1-0-658cbc8fc...@kernel.org --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

On Tue, Jan 10, 2023 at 05:45:23AM -0600, Segher Boessenkool wrote: > On Mon, Jan 09, 2023 at 05:51:23PM -0700, Nathan Chancellor wrote: > > So for this patch, I have > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns: > >

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

: > > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor > > > wrote: > > > > > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > > > warns that ASFLAGS contains '-s', which is a linking phase option, so it

Re: [PATCH 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

On Mon, Jan 09, 2023 at 02:12:55PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns: > > > > clang-16: error: argument unused during co

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

On Mon, Jan 09, 2023 at 04:23:37PM -0600, Segher Boessenkool wrote: > Hi! Happy new year all. > > On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > > > When clang's -

Re: [PATCH 07/14] powerpc/vdso: Improve linker flags

On Mon, Jan 09, 2023 at 02:08:41PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: > > > > c

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns that ASFLAGS contains '-s', which is a linking phase option

[PATCH 07/14] powerpc/vdso: Improve linker flags

are compiler or assembler flags that will be unused during linking. Filter them out from KBUILD_CFLAGS so that they are not used during linking. Signed-off-by: Nathan Chancellor --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org --- arch

[PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

useful when targeting Solaris and it is ignored for the powerpc target so just drop the flag altogether, as it is not needed. Signed-off-by: Nathan Chancellor --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel

[PATCH 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

the flag from vgettimeofday-32.o's CFLAGS when using clang, as has been done for other flags previously. Signed-off-by: Nathan Chancellor --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/kernel/vdso/Makefile | 5

[PATCH 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

pc64-linux-gnu -fno-integrated-as -m64 -### \ -x assembler-with-cpp -c -o /dev/null /dev/null &| grep gnu-as "/usr/bin/powerpc64-linux-gnu-as" "-a32" "-mppc" "-many" "-o" "/dev/null" "/tmp/null-ab8f8d.s" Remove this

[PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

astructure will catch any lurking problems. I would like this series to stay together so that there is no opportunity for breakage so please consider giving acks so that this can be carried via the kbuild tree. --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

[PATCH 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor --- Cc: harry.wentl...@amd.com Cc: s

[PATCH 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

GCC builds. Commit 0f0727d971f6 ("drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") added '-msse2' to prevent clang from emitting software floating point routines. Signed-off-by: Nathan Chancellor --- Cc: harry.wentl...@amd.com Cc: s

[PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

astructure will catch any lurking problems. I would like this series to stay together so that there is no opportunity for breakage so please consider giving acks so that this can be carried via the kbuild tree. --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

[PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

astructure will catch any lurking problems. I would like this series to stay together so that there is no opportunity for breakage so please consider giving acks so that this can be carried via the kbuild tree. --- Nathan Chancellor (12): MIPS: Always use -Wa,-msoft-float and

Re: [PATCH 1/3] KVM: arm64: vgic: Add Apple M2 cpus to the list of broken SEIS implementations

Hi Marc, I have only been lurking on the kvmarm mailing list for a little bit and it has mainly just been reading patches/review to get more familiar with various virtualization concepts so I apologize if the following review is rather shallow but... On Tue, Jan 03, 2023 at 09:50:20AM +,

[PATCH] D140270: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added a comment. This does not show any issues with any of the MIPS configurations that I build in the Linux kernel, thanks for fixing the problems I reported! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140270/new/

Re: [PATCH] fbdev: make offb driver tristate

On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: > On 11/26/22 14:40, Thomas Zimmermann wrote: > > Am 26.11.22 um 01:04 schrieb Randy Dunlap: > > > Make the offb (Open Firmware frame buffer) driver tristate, > > > i.e., so that it can be built as a loadable module. > > > > > >

Re: [PATCH] fbdev: make offb driver tristate

On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: > On 11/26/22 14:40, Thomas Zimmermann wrote: > > Am 26.11.22 um 01:04 schrieb Randy Dunlap: > > > Make the offb (Open Firmware frame buffer) driver tristate, > > > i.e., so that it can be built as a loadable module. > > > > > >

Re: [PATCH] drm/tests: reduce drm_mm_test stack usage

usage and needs to be > disabled, as we do for all other kunit users. > > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drivers/gpu/drm/tests/Makefile | 2 ++ > drivers/gpu/drm/tests/drm_mm_test.c | 2 +- > 2 files changed, 3 insertions(+), 1 deleti

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. For what it's worth, this breaks building the Linux kernel's `ARCH=mips 32r1_defconfig` with clang and GNU as, with thousands of messages along the line of: /tmp/mmc_ops-d329c3.s: Assembler messages:

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

nathanchance added a comment. I can no longer do a two stage build on Fedora after this change. $ cmake \ -B build/stage1 \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_COMPILER=$(command -v clang) \ -DCMAKE_CXX_COMPILER=$(command -v clang++) \ -DLLVM_ENABLE_PROJECTS="clang;lld" \

Re: [PATCH v4] wifi: ath10k: Store WLAN firmware version in SMEM image table

On Thu, Nov 17, 2022 at 11:35:34PM +0530, Youghandhar Chintala wrote: > In a SoC based solution, it would be useful to know the versions of the > various binary firmware blobs the system is running on. On a QCOM based > SoC, this info can be obtained from socinfo debugfs infrastructure. For > this

Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled

; > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > lib/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c3c0b077ade33..82d475168db95 100644 > --- a/lib/Kconfig.debug > +++ b/lib/

Re: [PATCH v2 2/2] Kconfig.debug: Provide a little extra FRAME_WARN leeway when KASAN is enabled

; > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > lib/Kconfig.debug | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c3c0b077ade33..82d475168db95 100644 > --- a/lib/Kconfig.debug > +++ b/lib/

Re: [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang builds due to blown stack-frame

te kernel > panic on most architectures. We'll revert this when the following bug report > has been resolved: https://github.com/llvm/llvm-project/issues/41896. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > drivers/g

Re: [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang builds due to blown stack-frame

te kernel > panic on most architectures. We'll revert this when the following bug report > has been resolved: https://github.com/llvm/llvm-project/issues/41896. > > Suggested-by: Arnd Bergmann > Signed-off-by: Lee Jones Reviewed-by: Nathan Chancellor > --- > drivers/g

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the origin tree

On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote: > Hi Nathan, > > On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor > wrote: > > > > This resolution is not quite right, as pointed out by clang: > > > > drivers/gpu/drm/vc4/vc4_hdmi

Re: linux-next: manual merge of the drm-misc tree with the origin tree

On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote: > Hi Nathan, > > On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor > wrote: > > > > This resolution is not quite right, as pointed out by clang: > > > > drivers/gpu/drm/vc4/vc4_hdmi

Re: [PATCH v2 2/2] drm/vc4: hdmi: Fix pointer dereference before check

On Thu, Nov 17, 2022 at 09:28:49AM -0800, Nick Desaulniers wrote: > On Thu, Nov 10, 2022 at 02:47:52PM +0100, José Expósito wrote: > > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced > > the vc4_hdmi_reset_link() function. This function dereferences the > > "connector"

Re: linux-next: manual merge of the drm-misc tree with the origin tree

Hi Stephen, On Wed, Nov 16, 2022 at 10:57:02AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vc4/vc4_hdmi.c > > between commit: > > 682f99b8ae88 ("drm/vc4: hdmi: Take our lock to reset the link") > > from

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with the origin tree

Hi Stephen, On Wed, Nov 16, 2022 at 10:57:02AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vc4/vc4_hdmi.c > > between commit: > > 682f99b8ae88 ("drm/vc4: hdmi: Take our lock to reset the link") > > from

Re: [PATCH] drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()

Hi all, On Wed, Nov 02, 2022 at 08:56:23AM -0700, Nathan Chancellor wrote: > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > indirect call targets are validated against the expected function > pointer prototype to make sure the call target is valid to help mitig

Re: [PATCH] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

Hi all, On Wed, Nov 02, 2022 at 08:42:15AM -0700, Nathan Chancellor wrote: > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > indirect call targets are validated against the expected function > pointer prototype to make sure the call target is valid to help mitig

Re: [PATCH 11/22] drm/amd/display: Disable phantom OTG after enable for plane disable

Hi Alan, On Thu, Nov 03, 2022 at 12:01:06AM +0800, Alan Liu wrote: > From: Alvin Lee > > [Description] > - Need to disable phantom OTG after it's enabled > in order to restore it to it's original state. > - If it's enabled and then an MCLK switch comes in > we may not prefetch the correct

[PATCH v2] drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid

Signed-off-by: Nathan Huckleberry Reviewed-by: Laurent Pinchart [nathan: Rebase on drm-misc-next and fix conflicts Add note about new clang warning] Signed-off-by: Nathan Chancellor --- Please consider picking this up so that it makes 6.2. v2: - Take over for Nathan, as he is busy

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] drm/sti: Fix return type of sti_{dvo, hda, hdmi}_connector_mode_valid()

num drm_mode_status', not 'int'. Adjust the return type of sti_{dvo,hda,hdmi}_connector_mode_valid() to match the prototype's to resolve the warning and CFI failure. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/sti/sti_dvo.c

[PATCH] drm/meson: Fix return type of meson_encoder_cvbs_mode_valid()

ink: https://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/meson/meson_encoder_cvbs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/

[PATCH] drm/mediatek: Fix return type of mtk_hdmi_bridge_mode_valid()

tps://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c in

[PATCH] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

750 Reported-by: Sami Tolvanen Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c index 4d4a715b429d..2c2b92324

[PATCH 1/2] drm/amdgpu: Fix type of second parameter in trans_msg() callback

up the warnings. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h b

[PATCH 1/2] drm/amdgpu: Fix type of second parameter in trans_msg() callback

up the warnings. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h b

[PATCH 2/2] drm/amdgpu: Fix type of second parameter in odn_edit_dpm_table() callback

of 'enum PP_OD_DPM_TABLE_COMMAND'. Update the type parameter in both the prototype in 'struct amd_pm_funcs' and pp_odn_edit_dpm_table() to 'enum PP_OD_DPM_TABLE_COMMAND', which cleans up the warning. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan C

[PATCH 2/2] drm/amdgpu: Fix type of second parameter in odn_edit_dpm_table() callback

of 'enum PP_OD_DPM_TABLE_COMMAND'. Update the type parameter in both the prototype in 'struct amd_pm_funcs' and pp_odn_edit_dpm_table() to 'enum PP_OD_DPM_TABLE_COMMAND', which cleans up the warning. Link: https://github.com/ClangBuiltLinux/linux/issues/1750 Reported-by: Sami Tolvanen Signed-off-by: Nathan C

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

Re: [PATCH v4 1/1] drm/amd/display: add DCN support for ARM64

On Tue, Nov 01, 2022 at 10:36:08AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-10-31 15:37, Ao Zhong wrote: > > After moving all FPU code to the DML folder, we can enable DCN support > > for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the > > code in the DML folder that

Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid

Hi all, On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode

Re: [PATCH] drm/msm: Fix return type of mdp4_lvds_connector_mode_valid

Hi all, On Tue, Sep 13, 2022 at 01:55:48PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode

Re: [Freedreno] [PATCH] drm/msm: Fix return type of mdp4_lvds_connector_mode_valid

Hi all, On Tue, Sep 13, 2022 at 01:55:48PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode

Re: [PATCH] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid

ted-by: Dan Carpenter > Link: https://github.com/ClangBuiltLinux/linux/issues/1703 > Cc: l...@lists.linux.dev > Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Can someone pick this up? It resolves a new work-in-progress clang warning that we would like to turn on for the ke

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

Hi Rodrigo and Ao, On Fri, Oct 28, 2022 at 08:48:26AM -0700, Nathan Chancellor wrote: > On Fri, Oct 28, 2022 at 11:35:32AM -0400, Rodrigo Siqueira Jordao wrote: > > > > > > On 2022-10-28 11:09, Nathan Chancellor wrote: > > > Hi Ao, > > > > > > On

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

Hi Rodrigo, On Fri, Oct 28, 2022 at 11:35:32AM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-10-28 11:09, Nathan Chancellor wrote: > > Hi Ao, > > > > On Thu, Oct 27, 2022 at 09:52:29PM +0200, Ao Zhong wrote: > > > After moving all FPU code to the D

Re: [PATCH v3 1/1] drm/amd/display: add DCN support for ARM64

Hi Ao, On Thu, Oct 27, 2022 at 09:52:29PM +0200, Ao Zhong wrote: > After moving all FPU code to the DML folder, we can enable DCN support > for the ARM64 platform. Remove the -mgeneral-regs-only CFLAG from the > code in the DML folder that needs to use hardware FPU, and add a control > mechanism

Re: [PATCH RESEND 1/1] drm/amd/display: add DCN support for ARM64

Hi Rodrigo, On Thu, Oct 27, 2022 at 10:29:33AM -0400, Rodrigo Siqueira wrote: > Nathan/Stephen, > > Maybe I'm wrong, but I think you have access to some sort of CI that tests > multiple builds with different compiles and configs, right? Is it possible > to check this patch + amd-staging-drm-next

[PATCH] drm/amdgpu: Fix uninitialized warning in mmhub_v2_0_get_clockgating()

ink: https://github.com/ClangBuiltLinux/linux/issues/1748 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c index 5e

[PATCH] drm/amdgpu: Fix uninitialized warning in mmhub_v2_0_get_clockgating()

ink: https://github.com/ClangBuiltLinux/linux/issues/1748 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c index 5e

Re: [PATCH v4] overflow: Introduce overflows_type() and castable_to_type()

ard (ISO/IEC 9899:2011): 6.7.10 Static assertions > [3] https://gcc.gnu.org/onlinedocs/gcc/Integer-Overflow-Builtins.html > 6.56 Built-in Functions to Perform Arithmetic with Overflow Checking > Built-in Function: bool __builtin_add_overflow (type1 a, type2 b, > > Cc: Luc Va

Re: [Intel-gfx] [PATCH v4] overflow: Introduce overflows_type() and castable_to_type()

ard (ISO/IEC 9899:2011): 6.7.10 Static assertions > [3] https://gcc.gnu.org/onlinedocs/gcc/Integer-Overflow-Builtins.html > 6.56 Built-in Functions to Perform Arithmetic with Overflow Checking > Built-in Function: bool __builtin_add_overflow (type1 a, type2 b, > > Cc: Luc Va

[PATCH] drm/amdkfd: Fix type of reset_type parameter in hqd_destroy() callback

of 'enum kfd_preempt_type'. Update the function pointer prototype to match reality so that there is no more CFI violation. Link: https://github.com/ClangBuiltLinux/linux/issues/1738 Signed-off-by: Nathan Chancellor --- No Fixes tag, as I could not pin down exactly when this started. I suspect

[PATCH] drm/amdkfd: Fix type of reset_type parameter in hqd_destroy() callback

of 'enum kfd_preempt_type'. Update the function pointer prototype to match reality so that there is no more CFI violation. Link: https://github.com/ClangBuiltLinux/linux/issues/1738 Signed-off-by: Nathan Chancellor --- No Fixes tag, as I could not pin down exactly when this started. I suspect

[PATCH] drm/amd/display: Fix build breakage with CONFIG_DEBUG_FS=n

ace within the #ifdef so that the file can be built with or without CONFIG_DEBUG_FS. Fixes: 8799c0be89eb ("drm/amd/display: Fix vblank refcount in vrr transition") Signed-off-by: Nathan Chancellor --- I have sent this to Linus in case he wants to take this directly since this is

[PATCH] drm/amd/display: Fix build breakage with CONFIG_DEBUG_FS=n

ace within the #ifdef so that the file can be built with or without CONFIG_DEBUG_FS. Fixes: 8799c0be89eb ("drm/amd/display: Fix vblank refcount in vrr transition") Signed-off-by: Nathan Chancellor --- I have sent this to Linus in case he wants to take this directly since this is

[Intel-gfx] [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

an be called through both kobject locations without violating kCFI and adjust the attribute groups to account for this. Link: https://github.com/ClangBuiltLinux/linux/issues/1716 Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda Reviewed-by: Kees Cook Signed-off-by: Nathan Chancellor --- v2:

[PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

an be called through both kobject locations without violating kCFI and adjust the attribute groups to account for this. Link: https://github.com/ClangBuiltLinux/linux/issues/1716 Reviewed-by: Andi Shyti Reviewed-by: Andrzej Hajda Reviewed-by: Kees Cook Signed-off-by: Nathan Chancellor --- v2:

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

Hi Andrzej, On Thu, Sep 29, 2022 at 03:44:40PM -0700, Nathan Chancellor wrote: > On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > > On 22.09.2022 21:51, Nathan Chancellor wrote: > > > When booting with clang's kernel control flow integrity series [1], > &

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

Hi Andrzej, On Thu, Sep 29, 2022 at 03:44:40PM -0700, Nathan Chancellor wrote: > On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > > On 22.09.2022 21:51, Nathan Chancellor wrote: > > > When booting with clang's kernel control flow integrity series [1], > &

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

nathanchance added a comment. In D134671#3828197 , @craig.topper wrote: > In D134671#3824644 , > @nickdesaulniers wrote: > >> I don't think it's an issue for us to work around downstream, but this did >>

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nathanchance added a comment. In D134831#3827790 , @samitolvanen wrote: > In D134831#3827730 , > @nickdesaulniers wrote: > >> Please get the patch disabling this warning for the kernel in flight before >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > On 22.09.2022 21:51, Nathan Chancellor wrote: > > When booting with clang's kernel control flow integrity series [1], > > there are numerous violations when accessing the files under > > /sys/devices/pci:00/0

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

On Fri, Sep 30, 2022 at 12:34:41AM +0200, Andrzej Hajda wrote: > On 22.09.2022 21:51, Nathan Chancellor wrote: > > When booting with clang's kernel control flow integrity series [1], > > there are numerous violations when accessing the files under > > /sys/devices/pci:00/0

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

definitely would not mind some additional eyes and testing for this change. > For now I'm quite surprised to see how easily our CI gives green > lights :-P > > On Sat, Sep 24, 2022 at 09:39:30PM -0700, Nathan Chancellor wrote: > > On Fri, Sep 23, 2022 at 09:57:47PM -0700, Kees Cook wrote

Re: [Intel-gfx] [PATCH] drm/i915: Fix CFI violations in gt_sysfs

definitely would not mind some additional eyes and testing for this change. > For now I'm quite surprised to see how easily our CI gives green > lights :-P > > On Sat, Sep 24, 2022 at 09:39:30PM -0700, Nathan Chancellor wrote: > > On Fri, Sep 23, 2022 at 09:57:47PM -0700, Kees Cook wrote

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< kees wrote: > aaron.ballman wrote: >

Re: [objtool] ca5e2b42c0: kernel_BUG_at_arch/x86/kernel/jump_label.c

On Wed, Sep 28, 2022 at 12:13:53PM -0700, Josh Poimboeuf wrote: > On Wed, Sep 28, 2022 at 08:44:27AM -0700, Nathan Chancellor wrote: > > This crash appears to just be a symptom of objtool erroring throughout > > the entire build, which means things like the jump label hacks do not

Re: [objtool] ca5e2b42c0: kernel_BUG_at_arch/x86/kernel/jump_label.c

Hi all, On Wed, Sep 28, 2022 at 08:48:53AM +0800, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit (built with clang-14): > > commit: ca5e2b42c0d4438ba93623579b6860b98f3598f3 ("[PATCH v3 11/16] objtool: > Add --mnop as an option to --mcount") > url: >

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

nathanchance added a comment. Thanks a lot for fixing this! I took it for a spin against the Linux kernel and all instances of `-Wvoid-ptr-dereference` disappeared :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134702/new/

<    1   2   3   4   5   6   7   8   9   10   >