Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()

On Sat, Dec 18, 2021 at 11:25:14AM +0100, Thomas Gleixner wrote: > On Fri, Dec 17 2021 at 15:30, Nathan Chancellor wrote: > > On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: > > I just bisected a boot failure on my AMD test desktop to this patch as > > comm

Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()

Hi Thomas, On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > Replace open coded MSI descriptor chasing and use the proper accessor > functions instead. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jason

Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()

Hi Thomas, On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > Replace open coded MSI descriptor chasing and use the proper accessor > functions instead. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jason

Re: [patch V3 28/35] PCI/MSI: Simplify pci_irq_get_affinity()

Hi Thomas, On Fri, Dec 10, 2021 at 11:19:26PM +0100, Thomas Gleixner wrote: > From: Thomas Gleixner > > Replace open coded MSI descriptor chasing and use the proper accessor > functions instead. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jason

Re: [PATCH v6 21/21] cxl/core: Split decoder setup into alloc + add

ck > to trigger device_unregister() for the decoder rather than it being > implicit in the decoder registration. I.e. the routine that calls alloc > is responsible for calling put_device() if the "add" operation fails. > > Reported-by: kernel test robot > Reported-by: Nathan

Re: [PATCH] powerpc: platforms: cell: pervasive: fix clang -Wimplicit-fallthrough

m sreset") > Reported-by: Naresh Kamboju > Signed-off-by: Anders Roxell Reviewed-by: Nathan Chancellor > --- > arch/powerpc/platforms/cell/pervasive.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/cell/pervasive.c > b/arch/pow

Re: [PATCH v5 5/5] powerpc/inst: Optimise copy_inst_from_kernel_nofault()

On Tue, Dec 07, 2021 at 05:45:08AM +, Christophe Leroy wrote: > > > Le 07/12/2021 à 05:48, Nathan Chancellor a écrit : > > On Tue, Dec 07, 2021 at 02:37:26PM +1100, Michael Ellerman wrote: > >> Bill Wendling writes: > >>> On Tue, Nov 30, 2021 at 10:38 AM

Re: [PATCH v5 5/5] powerpc/inst: Optimise copy_inst_from_kernel_nofault()

On Tue, Dec 07, 2021 at 02:37:26PM +1100, Michael Ellerman wrote: > Bill Wendling writes: > > On Tue, Nov 30, 2021 at 10:38 AM Bill Wendling wrote: > >> On Tue, Nov 30, 2021 at 10:17 AM Nathan Chancellor > >> wrote: > >> > On Tue, Nov 30, 2021 at 1

[PATCH] D114848: [Analysis] Ignore casts and unary ops for uninitialized values

nathanchance added a comment. I tested the problematic Linux kernel configuration that uncovered this issue with this patch and the issue was resolved. I tested an x86_64 allmodconfig build and did not see any warnings. Comment at:

Re: [PATCH v5 5/5] powerpc/inst: Optimise copy_inst_from_kernel_nofault()

On Tue, Nov 30, 2021 at 10:25:43PM +1100, Michael Ellerman wrote: > Christophe Leroy writes: > > Le 29/11/2021 à 23:55, kernel test robot a écrit : > >> Hi Christophe, > >> > >> I love your patch! Perhaps something to improve: > >> > >> [auto build test WARNING on powerpc/next] > >> [also build

Re: [Linux-cachefs] [PATCH 51/64] cachefiles: Implement the I/O routines

On Mon, Nov 29, 2021 at 02:34:39PM +, David Howells wrote: > Implement the I/O routines for cachefiles. There are two sets of routines > here: preparation and actual I/O. > > Preparation for read involves looking to see whether there is data present, > and how much. Netfslib tells us what

Re: [PATCH] powerpc: mm: radix_tlb: rearrange the if-else block

On Fri, Nov 26, 2021 at 02:59:29PM +0100, Arnd Bergmann wrote: > On Fri, Nov 26, 2021 at 2:43 PM Christophe Leroy > wrote: > > Le 25/11/2021 à 16:44, Anders Roxell a écrit : > > Can't you fix CLANG instead :) ? > > > > Or just add an else to the IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) that > >

Re: [PATCH] omapfb: add one more "fallthrough" statement

plicit-fallthrough] > > Add it here as well. > > Signed-off-by: Arnd Bergmann Reviewed-by: Nathan Chancellor > --- > drivers/video/fbdev/omap/omapfb_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/omap/omapfb_main.c > b/drivers/vid

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a comment. Prior to the latest revert (fd9b099906c61e46574d1ea2d99b973321fe1d21 ), the Linux kernel's binary verifier (`objtool`) points out an issue when building with ThinLTO and

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

nathanchance added a comment. I bisected a crash in the Linux kernel down to the reland commit (and it is not fixed as of https://github.com/llvm/llvm-project/commit/2249ecee8d9a6237f51485bd39f01ba031575987): $ git bisect log # bad: [bdaa181007a46d317a1665acb8234eddeee82815]

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nathanchance added a subscriber: peter.smith. nathanchance added a comment. I tested this against `next-20211027`, where it resolved the build error and boots in QEMU master without any visible issues. Disassembly between GCC and clang seems to be good. I'll leave it up to @nickdesaulniers and

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. `check-llvm` does not pass with this revision nor does it resolve the boot failure that Nick mentioned, just in case that was the intention of the revision :) I ran the kernel through `gdb` and it still does not appear to get to `start_kernel`. Repository: rG

[PATCH] drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source()

was not. Do that now so there is no more warning. Fixes: 78d9b458cc21 ("drm/msm/dpu: Add CRC support for DPU") Link: https://github.com/ClangBuiltLinux/linux/issues/1493 Reported-by: "kernelci.org bot" Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/msm/disp/dpu1/dpu_cr

[Freedreno] [PATCH] drm/msm/dpu: Remove commit and its uses in dpu_crtc_set_crc_source()

was not. Do that now so there is no more warning. Fixes: 78d9b458cc21 ("drm/msm/dpu: Add CRC support for DPU") Link: https://github.com/ClangBuiltLinux/linux/issues/1493 Reported-by: "kernelci.org bot" Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/msm/disp/dpu1/dpu_cr

Re: [PATCH] dma-buf: st: fix error handling in test_get_fences()

280:10: note: initialize the variable 'i' to > silence this warning > int r, i; > ^ > = 0 > > Skip cleaning up the bits that have not been allocated at this point. > > Fixes: 1d51775cd3f5 ("dma-buf: add dma_resv selftest v4&qu

Re: [PATCH] dma-buf: fix uninitialized variable usage in selftests

: initialize the variable 'i' to silence this warning int r, i; ^ = 0 1 error generated. This hunk resolves it for me. With that: Reviewed-by: Nathan Chancellor diff --git a/drivers/dma-buf/st-dma-resv.c b/drivers/dma-buf/st-dma-resv.c index bc2

[Intel-gfx] [PATCH] drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk()

nux/linux/issues/1473 Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/intel_pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index f90fe39cf8ca..aaa3a0998e4c 100

[PATCH] drm/i915: Avoid bitwise vs logical OR warning in snb_wm_latency_quirk()

nux/linux/issues/1473 Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/intel_pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index f90fe39cf8ca..aaa3a0998e4c 100

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

nathanchance added a comment. In D110656#3034181 , @nathanchance wrote: > I can test this on the Linux kernel tonight and report the results tomorrow > morning. My apologies, I did not have time to get to this last night or today and I am going to be

Re: [Intel-gfx] [vfio:next 33/38] drivers/gpu/drm/i915/i915_pci.c:975:2: warning: missing field 'override_only' initializer

On Fri, Oct 01, 2021 at 02:04:04PM +0300, Jani Nikula wrote: > On Fri, 27 Aug 2021, Jason Gunthorpe wrote: > > On Fri, Aug 27, 2021 at 03:12:36PM +, kernel test robot wrote: > >> tree: https://github.com/awilliam/linux-vfio.git next > >> head: ea870730d83fc13a5fa2bd0e175176d7ac8a400a > >>

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

nathanchance added a comment. I can test this on the Linux kernel tonight and report the results tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110656/new/ https://reviews.llvm.org/D110656

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. As far as I am aware, this iteration of the patch has no instances in the Linux kernel now. The instances I found with the first iteration of the patch only had a right hand side with side effects, not both sides, so this warning is effectively a no-op now (not

[PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

error generated. Use NULL instead of false since the function is returning a pointer rather than a boolean. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1470 Signed-off-by: Nathan Chancellor --- drive

[PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()

error generated. Use NULL instead of false since the function is returning a pointer rather than a boolean. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1470 Signed-off-by: Nathan Chancellor --- drive

[PATCH] drm/amd: Initialize remove_mpcc in dcn201_update_mpcc()

used uninitialized. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1469 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] drm/amd: Initialize remove_mpcc in dcn201_update_mpcc()

used uninitialized. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1469 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] drm/amd: Guard IS_OLD_GCC assignment with CONFIG_CC_IS_GCC

C 7.1+") for more context. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1468 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dcn201/Makefile | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] drm/amd: Guard IS_OLD_GCC assignment with CONFIG_CC_IS_GCC

C 7.1+") for more context. Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") Link: https://github.com/ClangBuiltLinux/linux/issues/1468 Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/amd/display/dc/dcn201/Makefile | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] drm/kmb: Remove set_test_mode_src_osc_freq_target_{hi, low}_bits()

part of the display driver"). Reported-by: kernel test robot Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/kmb/kmb_dsi.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 17

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

On Thu, Sep 23, 2021 at 04:52:08PM +0200, Maxime Ripard wrote: > Hi Nathan, > > On Wed, Sep 22, 2021 at 08:49:50AM -0700, Nathan Chancellor wrote: > > On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > > > Hi Randy, > > > > > > On Sun, Sep

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > Hi Randy, > > On Sun, Sep 19, 2021 at 09:40:44AM -0700, Randy Dunlap wrote: > > On 8/19/21 6:59 AM, Maxime Ripard wrote: > > > We already depend on runtime PM to get the power domains and clocks for > > > most of the devices

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > DP 2.0 brings some new DPCD addresses for PHY repeaters. > > Cc: dri-de...@lists.freedesktop.org > Reviewed-by: Manasi Navare > Signed-off-by: Jani Nikula > --- > include/drm/drm_dp_helper.h | 4 > 1 file changed, 4

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > DP 2.0 brings some new DPCD addresses for PHY repeaters. > > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Manasi Navare > Signed-off-by: Jani Nikula > --- > include/drm/drm_dp_helper.h | 4 > 1 file changed, 4

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > DP 2.0 brings some new DPCD addresses for PHY repeaters. > > Cc: dri-de...@lists.freedesktop.org > Reviewed-by: Manasi Navare > Signed-off-by: Jani Nikula > --- > include/drm/drm_dp_helper.h | 4 > 1 file changed, 4

Re: [TCWG CI] Regression caused by linux: parisc: Declare pci_iounmap() parisc version only when CONFIG_PCI enabled

On Tue, Sep 21, 2021 at 02:34:47PM +, ci_not...@linaro.org wrote: > [TCWG CI] Regression caused by linux: parisc: Declare pci_iounmap() parisc > version only when CONFIG_PCI enabled: > commit 9caea0007601d3bc6debec04f8b4cd6f4c2394be > Author: Helge Deller > > parisc: Declare

Re: [PATCH v2] x86/setup: call early_reserve_memory() earlier

ot trigger any boot issues on that same machine or an Intel i5-4210U based system that I also test with. Tested-by: Nathan Chancellor > --- > V2: > - update comment (Jan Beulich, Boris Petkov) > - move call down in setup_arch() (Mike Galbraith) > --- > arch/x86/kernel/setup.c |

Re: [PATCH v3] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

get_unaligned16(const unsigned short *p) > ^ > 1 warning generated. > > Fix it, by moving the check from the preprocessor to C, so the compiler > sees the use. > > Signed-off-by: Paul Menzel Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- &

Re: [PATCH] lib/zlib_inflate/inffast: Check config in C to avoid unused function warning

Hi Paul, On 9/16/2021 7:22 AM, Paul Menzel wrote: Building Linux for ppc64le with Ubuntu clang version 12.0.0-3ubuntu1~21.04.1 shows the warning below. arch/powerpc/boot/inffast.c:20:1: warning: unused function 'get_unaligned16' [-Wunused-function] get_unaligned16(const unsigned

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clean up disabled warnings (rev2)

I don't really see how this patch could be responsible for either this or the sparse report that I got... it is a simple build time change, nothing at runtime should be affected. Cheers, Nathan On Wed, Sep 15, 2021 at 03:00:19PM -, Patchwork wrote: > == Series Details == > > Series:

[Intel-gfx] [PATCH v2] drm/i915: Clean up disabled warnings

[1]: https://lore.kernel.org/r/202108210311.cbtcgoul-...@intel.com/ [2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/ Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: https://lore.kernel.org/r/20210824232237.2085342-1-nat...@kernel.org/ * Rebase on drm-

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

On Tue, Sep 14, 2021 at 08:10:14PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Nathan Chancellor wrote: > > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > >&g

Re: [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

On Tue, Sep 14, 2021 at 08:10:14PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Nathan Chancellor wrote: > > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > >&g

[PATCH v2] drm/i915: Clean up disabled warnings

[1]: https://lore.kernel.org/r/202108210311.cbtcgoul-...@intel.com/ [2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/ Reviewed-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: https://lore.kernel.org/r/20210824232237.2085342-1-nat...@kernel.org/ * Rebase on drm-

Re: [PATCH] powerpc: clean up UPD_CONSTR

On 9/14/2021 9:17 AM, Nick Desaulniers wrote: UPD_CONSTR was previously a preprocessor define for an old GCC 4.9 inline asm bug with m<> constraints. Fixes: 6563139d90ad ("powerpc: remove GCC version check for UPD_CONSTR") Suggested-by: Nathan Chancellor Suggested-by:

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > disabled -Wsometimes-uninitialized as noisy but there have been a few > fixes to clang that make the false positive rate fairly low so it

Re: [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > disabled -Wsometimes-uninitialized as noisy but there have been a few > fixes to clang that make the false positive rate fairly low so it

Re: [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR

On 9/10/2021 4:40 PM, Nick Desaulniers wrote: Now that GCC 5.1 is the minimum supported version, we can drop this workaround for older versions of GCC. This adversely affected clang, too. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Segher Boessenkool Cc:

Re: [PATCH 0/4] Fix stack usage of DML

pu with clang in various configurations but this is a great start. Thank you for taking a look at them. For the series: Build-tested-by: Nathan Chancellor > .../gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 55 ++-- > .../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- > .../dc/dml/d

Re: [CI-NOTIFY]: TCWG Bisect tcwg_kernel/llvm-master-aarch64-mainline-allyesconfig - Build # 16 - Successful!

On Fri, Sep 03, 2021 at 11:54:23PM +, ci_not...@linaro.org wrote: > Successfully identified regression in *linux* in CI configuration > tcwg_kernel/llvm-master-aarch64-mainline-allyesconfig. So far, this commit > has regressed CI configurations: > -

Re: [PATCH] powerpc/ptdump: Fix generic ptdump for 64-bit

tely past the end of the kernel > page tables, to limit the page table walk to valid addresses. > > Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") > Reported-by: Nathan Chancellor > Signed-off-by: Michael Ellerman Tested-by: Nathan Chancellor >

Re: [PATCH] powerpc/bug: Cast to unsigned long before passing to inline asm

ister (32 or > 64-bit) we need to ensure the value passed to the inline asm has all > bits defined. So fix it by casting to long. > > We also already cast to long for the similar case in BUG_ENTRY(), which > it turns out was added to fix a similar bug in 2005 in commit > 32818c2eb6

Re: [PATCH v5 17/31] target/arm: Enforce alignment for LDM/STM

Hi Richard, On Mon, Apr 19, 2021 at 01:22:43PM -0700, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/arm/translate.c

Re: [PATCH v4 4/4] powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP

On Sun, Aug 29, 2021 at 09:11:47PM +0200, Christophe Leroy wrote: > Hi Nathan, > > Le 29/08/2021 à 20:55, Nathan Chancellor a écrit : > > Hi Christophe, > > > > On Thu, Jul 08, 2021 at 04:49:43PM +, Christophe Leroy wrote: > > > This patch co

Re: [PATCH v4 4/4] powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP

Hi Christophe, On Thu, Jul 08, 2021 at 04:49:43PM +, Christophe Leroy wrote: > This patch converts powerpc to the generic PTDUMP implementation. > > Signed-off-by: Christophe Leroy This patch as commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") in powerpc/next

Re: [PATCH v2 2/2] powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto

On Thu, Aug 26, 2021 at 11:54:17AM -0700, Nathan Chancellor wrote: > On Thu, Aug 26, 2021 at 01:21:39PM +1000, Michael Ellerman wrote: > > Nathan Chancellor writes: > > > On Tue, Apr 13, 2021 at 04:38:10PM +, Christophe Leroy wrote: > > >> Using asm goto in __WAR

Re: [PATCH v2 2/2] powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto

On Thu, Aug 26, 2021 at 01:21:39PM +1000, Michael Ellerman wrote: > Nathan Chancellor writes: > > On Tue, Apr 13, 2021 at 04:38:10PM +, Christophe Leroy wrote: > >> Using asm goto in __WARN_FLAGS() and WARN_ON() allows more > >> flexibility to GCC. > ..

Re: [Intel-gfx] [PATCH] drm/i915: Clean up disabled warnings

On 8/25/2021 4:03 PM, Nick Desaulniers wrote: On Tue, Aug 24, 2021 at 4:23 PM Nathan Chancellor wrote: i915 enables a wider set of warnings with '-Wall -Wextra' then disables several with cc-disable-warning. If an unknown flag gets added to KBUILD_CFLAGS when building with clang, all

Re: [PATCH] drm/i915: Clean up disabled warnings

On 8/25/2021 4:03 PM, Nick Desaulniers wrote: On Tue, Aug 24, 2021 at 4:23 PM Nathan Chancellor wrote: i915 enables a wider set of warnings with '-Wall -Wextra' then disables several with cc-disable-warning. If an unknown flag gets added to KBUILD_CFLAGS when building with clang, all

Re: [PATCH v2 2/2] powerpc/bug: Provide better flexibility to WARN_ON/__WARN_FLAGS() with asm goto

Hi Christophe, On Tue, Apr 13, 2021 at 04:38:10PM +, Christophe Leroy wrote: > Using asm goto in __WARN_FLAGS() and WARN_ON() allows more > flexibility to GCC. > > For that add an entry to the exception table so that > program_check_exception() knowns where to resume execution > after a

Moving to l...@lists.linux.dev

Hi everyone, We are shifting the ClangBuiltLinux mailing list from clang-built-li...@googlegroups.com to l...@lists.linux.dev. Google Groups has served us well but moving to lists.linux.dev allows for easier archival (as we will be on lore.kernel.org automatically) and allows for people to

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem()

initialize err to zero in this case. Fixes: cdb35d1ed6d2 ("drm/i915/gem: Migrate to system at dma-buf attach time (v7)") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [PATCH 3/3] drm/i915: Enable -Wsometimes-uninitialized

This warning helps catch uninitialized variables. It should have been enabled at the same time as commit b2423184ac33 ("drm/i915: Enable -Wuninitialized") but I did not realize they were disabled separately. Enable it now that i915 is clean so that it stays that way. Signed-off-

[Intel-gfx] [PATCH 1/3] drm/i915/selftests: Do not use import_obj uninitialized

rt_obj; ^ = NULL Shuffle the import_obj initialization above these if statements so that it is not used uninitialized. Fixes: d7b2cb380b3a ("drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8)") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor ---

[Intel-gfx] [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

instances of this warning then enables it for i915 like the rest of the tree. Cheers, Nathan Nathan Chancellor (3): drm/i915/selftests: Do not use import_obj uninitialized drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem() drm/i915: Enable -Wsometimes-uni

[Intel-gfx] [PATCH] drm/i915: Clean up disabled warnings

[1]: https://lore.kernel.org/r/202108210311.cbtcgoul-...@intel.com/ [2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/ Signed-off-by: Nathan Chancellor --- NOTE: This is based on my series to enable -Wsometimes-initialized here: https://lore.kernel.org/r/20210824225427.2065517-1-nat...@

[PATCH] drm/i915: Clean up disabled warnings

[1]: https://lore.kernel.org/r/202108210311.cbtcgoul-...@intel.com/ [2]: https://lore.kernel.org/r/20210824022640.2170859-1-nat...@kernel.org/ Signed-off-by: Nathan Chancellor --- NOTE: This is based on my series to enable -Wsometimes-initialized here: https://lore.kernel.org/r/20210824225427.2065517-1-nat...@

[PATCH 3/3] drm/i915: Enable -Wsometimes-uninitialized

This warning helps catch uninitialized variables. It should have been enabled at the same time as commit b2423184ac33 ("drm/i915: Enable -Wuninitialized") but I did not realize they were disabled separately. Enable it now that i915 is clean so that it stays that way. Signed-off-

[PATCH 2/3] drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem()

initialize err to zero in this case. Fixes: cdb35d1ed6d2 ("drm/i915/gem: Migrate to system at dma-buf attach time (v7)") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/3] drm/i915/selftests: Do not use import_obj uninitialized

rt_obj; ^ = NULL Shuffle the import_obj initialization above these if statements so that it is not used uninitialized. Fixes: d7b2cb380b3a ("drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8)") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor ---

[PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized

instances of this warning then enables it for i915 like the rest of the tree. Cheers, Nathan Nathan Chancellor (3): drm/i915/selftests: Do not use import_obj uninitialized drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem() drm/i915: Enable -Wsometimes-uni

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()

Ping? This is a pretty clear bug and it is not fixed in -next or drm-intel at this point. On Fri, Aug 13, 2021 at 10:11:58AM -0700, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/gpu/drm/i915/gt/intel_reset.c:1514: > drivers/gpu/drm/i915/gt/selftest_hangch

Re: [Intel-gfx] [PATCH] drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()

Ping? This is a pretty clear bug and it is not fixed in -next or drm-intel at this point. On Fri, Aug 13, 2021 at 10:11:58AM -0700, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/gpu/drm/i915/gt/intel_reset.c:1514: > drivers/gpu/drm/i915/gt/selftest_hangch

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. I am still running a series of builds against the Linux kernel but I already see one instance of this warning where the suggestion would change the meaning of the code in an incorrect way: drivers/input/touchscreen.c:81:17: warning: use of bitwise '|' with

Re: [PATCH 4/7] arc: replace cc-option-yn uses with cc-option

On 8/17/2021 11:07 AM, 'Nick Desaulniers' via Clang Built Linux wrote: On Mon, Aug 16, 2021 at 7:05 PM Nathan Chancellor wrote: On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote: cc-option-yn can be replaced with cc-option. ie. Checking for support: ifeq ($(call cc

Re: [PATCH 3/7] powerpc: replace cc-option-yn uses with cc-option

On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote: cc-option-yn can be replaced with cc-option. ie. Checking for support: ifeq ($(call cc-option-yn,$(FLAG)),y) becomes: ifneq ($(call cc-option,$(FLAG)),) Checking for lack of support: ifeq ($(call cc-option-yn,$(FLAG)),n)

Re: [f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

On 8/16/2021 5:33 PM, Jaegeuk Kim wrote: Hi Nathan, On 08/16, Nathan Chancellor wrote: Without this, there is a warning in nearly every fs/f2fs/ file when F2FS_FS_COMPRESSION is not set: In file included from fs/f2fs/super.c:31: fs/f2fs/f2fs.h:4251:13: warning: unused function

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed4a94d6451: [clang] Expose unreachable fallthrough annotation warning (authored by nathanchance). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9ed4a94 - [clang] Expose unreachable fallthrough annotation warning

Author: Nathan Chancellor Date: 2021-08-16T17:14:55-07:00 New Revision: 9ed4a94d6451046a51ef393cd62f00710820a7e8 URL: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8 DIFF: https://github.com/llvm/llvm-project/commit/9ed4a94d6451046a51ef393cd62f00710820a7e8

[f2fs-dev] [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

dnode_of_data *dn) { return false; } ^ 1 warning generated. Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster") Signed-off-by: Nathan Chancellor --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance updated this revision to Diff 366733. nathanchance marked an inline comment as not done. nathanchance edited the summary of this revision. nathanchance added a comment. - Update commit message (forgot to use `arc diff --edit --verbatim`) [David] Repository: rG LLVM Github

[PATCH] powerpc/xive: Do not mark xive_request_ipi() as __init

warning. Fixes: cbc06f051c52 ("powerpc/xive: Do not skip CPU-less nodes when creating the IPIs") Signed-off-by: Nathan Chancellor --- arch/powerpc/sysdev/xive/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/s

Re: [Intel-gfx] [bug report] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8)

On 8/13/2021 4:31 AM, Dan Carpenter wrote: Nathan has probably already sent fixes for these. Nathan, could you CC kernel-janitors on static checker fixes? That way we wouldn't send so many duplicate patches. Sure. I did not send any fixes prior to this email but I just sent

[Intel-gfx] [PATCH] drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()

elftest: Bump selftest timeouts for hangcheck") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/sel

[PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()

: ^ break; 1 warning generated. Clang's version of this warning is a little bit more pedantic than GCC's. Add the missing break to satisfy it to match what has been done all over the kernel tree. Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/radeon/radeon_fb.c | 1 + 1 file

[PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()

: ^ break; 1 warning generated. Clang's version of this warning is a little bit more pedantic than GCC's. Add the missing break to satisfy it to match what has been done all over the kernel tree. Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/radeon/radeon_fb.c | 1 + 1 file

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. I have sent the following patches for the Linux kernel. These were the only instances of the warning that I found across the code base in all of the configurations that we usually test so thank you for the heads up so I could send fixes before this lands.

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance marked an inline comment as done. nathanchance added inline comments. Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:211-214 +case 224: + n += 400; +case 225: // expected-warning{{unannotated fall-through between switch labels}}

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance updated this revision to Diff 366363. nathanchance added a comment. - -Wimplicit-fallthrough-unreachable -> -Wunreachable-code-fallthrough, enabled under -Wunreachable-code (Dávid, Aaron). - Drop "case 225" from new test, as it does not add to test coverage (Nick). - Add

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. In D108003#2944413 , @Quuxplusone wrote: > FWIW, all three of @nathanchance's detected lines look like good true > positives to me: even if they're not //bugs//, they all look like places the > programmer //meant// to

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance added a comment. In D107933#2942430 , @xbolva00 wrote: > Yes, something like that, plus I think you want put > UnreachableCodeFallthrough into group UnreachableCode as well. So you would recommend adding it to `UnreachableCode` rather than

[PATCH] drm/i915/selftest: Fix use of err in igt_reset_{fail, nop}_engine()

elftest: Bump selftest timeouts for hangcheck") Reported-by: Dan Carpenter Signed-off-by: Nathan Chancellor --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_hangcheck.c b/drivers/gpu/drm/i915/gt/sel

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

nathanchance added a comment. With several Linux kernel `defconfig` builds, I see the following instances of the warning: drivers/net/wireless/intel/iwlwifi/mvm/scan.c:835:3: warning: bitwise and of boolean expressions; did you mean logical and? [-Wbool-operation-and]

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance added a comment. So something more along the lines of diff diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td index 1555a9ee2465..0aa9a82e3d11 100644 --- a/clang/include/clang/Basic/DiagnosticGroups.td +++

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance added a comment. > In D107933#2942023 , @xbolva00 > wrote: > >> > > GCC does not warn (with common -Wall) for this case, right? I think Clang > should not as well. Correct, GCC does not warn at all about unreachable fallthrough

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

nathanchance created this revision. nathanchance added reviewers: dblaikie, rsmith, nickdesaulniers. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Linux kernel has a macro called IS_ENABLED(), which evaluates to a

<    3   4   5   6   7   8   9   10   11   12   >