Re: RFR: 8092102: Labeled: truncated property

2024-03-05 Thread Nir Lisker
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote: > Adds Labeled.truncated property which indicates when the text is visually > truncated (and the ellipsis string is inserted) in order to fit the available > width. > > The new property reacts to changes in the following properties: > - el

RFR: 8327179: Update the 3D lighting application

2024-03-03 Thread Nir Lisker
Update for the 3D lighting test tool as described in the JBS issue. - Commit messages: - Whitespaces - Initial commit Changes: https://git.openjdk.org/jfx/pull/1387/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1387&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83

Re: Validation Support

2024-03-02 Thread Nir Lisker
Hi Dirk, JavaFX has some input validation support in terms of focus control and rejecting invalid characters. Can you explain what your proposal adds? Are there JBS issues asking for this? Thanks, Nir On Fri, Mar 1, 2024, 13:50 Dirk Lemmermann wrote: > Hi everyone, > > I updated the validatio

Re: RFR: 8314147: Updated the PhongMaterial documentation [v10]

2024-02-29 Thread Nir Lisker
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote: >> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass >> `Material`). Except for the introduction, I divided the documentation into 3 >> sections: qualitative explanation, mathematical model (I

[jfx22] Integrated: 8314147: Updated the PhongMaterial documentation

2024-02-29 Thread Nir Lisker
On Thu, 29 Feb 2024 11:46:11 GMT, Nir Lisker wrote: > This pull request contains a backport of commit > [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. This pull request has

[jfx22] RFR: 8314147: Updated the PhongMaterial documentation

2024-02-29 Thread Nir Lisker
This pull request contains a backport of commit [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. - Commit messages: - Backport d9645730f1e76e95e0bb93ceaeb5550390bf95c1 Changes

Integrated: 8314147: Updated the PhongMaterial documentation

2024-02-29 Thread Nir Lisker
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote: > Overhaul to the `PhongMaterial` documentation (and a bit to its superclass > `Material`). Except for the introduction, I divided the documentation into 3 > sections: qualitative explanation, mathematical model (I wouldn&#

Re: RFR: 8314147: Updated the PhongMaterial documentation [v10]

2024-02-28 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v9]

2024-02-28 Thread Nir Lisker
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote: >> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass >> `Material`). Except for the introduction, I divided the documentation into 3 >> sections: qualitative explanation, mathematical model (I

Re: RFR: 8314147: Updated the PhongMaterial documentation [v9]

2024-02-28 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v7]

2024-02-28 Thread Nir Lisker
On Wed, 28 Feb 2024 14:21:55 GMT, Kevin Rushforth wrote: > One other thing I noticed is that the file names have spaces in them, which > is not a best practice and causes problems for scripts. Can you change all > spaces to _ in the names of the newly-added files? Yes. What about folders? Also

Re: RFR: 8314147: Updated the PhongMaterial documentation [v8]

2024-02-28 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v6]

2024-02-28 Thread Nir Lisker
On Tue, 27 Feb 2024 12:13:09 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typo > > modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri

Re: RFR: 8314147: Updated the PhongMaterial documentation [v6]

2024-02-28 Thread Nir Lisker
On Tue, 27 Feb 2024 11:24:08 GMT, Ambarish Rapte wrote: > PhongMaterial is not suitable for surfaces that reflect or refract the > incident light. But it does reflect the incident light as explained in the paragraphs before. - PR Review Comment: https://git.openjdk.org/jfx/pull/13

Re: RFR: 8314147: Updated the PhongMaterial documentation [v6]

2024-02-28 Thread Nir Lisker
On Tue, 27 Feb 2024 11:53:35 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed typo > > modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri

Re: RFR: 8314147: Updated the PhongMaterial documentation [v7]

2024-02-28 Thread Nir Lisker
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote: >> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass >> `Material`). Except for the introduction, I divided the documentation into 3 >> sections: qualitative explanation, mathematical model (I

Re: RFR: 8314147: Updated the PhongMaterial documentation [v7]

2024-02-28 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v6]

2024-02-26 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

[jfx22] Integrated: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-24 Thread Nir Lisker
On Sat, 24 Feb 2024 09:53:01 GMT, Nir Lisker wrote: > Backport of commit > [b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. This pull request has now been integrated.

Re: RFR: 8314147: Updated the PhongMaterial documentation [v5]

2024-02-24 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v4]

2024-02-24 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

[jfx22] RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-24 Thread Nir Lisker
Backport of commit [b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. - Commit messages: - Backport b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b Changes: https://git.openjdk.org/jfx

Integrated: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-24 Thread Nir Lisker
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote: > Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in > `Node` and `Scene`. > > Note that the default value for a `Scene`'s `NodeOrientation` depends on a > system property, while for `Node` i

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-23 Thread Nir Lisker
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote: > Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in > `Node` and `Scene`. > > Note that the default value for a `Scene`'s `NodeOrientation` depends on a > system property, while for `Node` i

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Nir Lisker
rent from `Scene`). Not sure if this is intended. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: https://git.openjdk.org/jfx/pull/1379/files - new: https://git.openjdk.org/

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-23 Thread Nir Lisker
On Fri, 23 Feb 2024 19:38:20 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java >> line 187: >> >>> 185: * Returns the child's bottom anchor constraint, if set. >>> 186: * @param child the child node of an anchor pane >>> 187:

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-23 Thread Nir Lisker
On Fri, 23 Feb 2024 19:44:06 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 6272: >> >>> 6270: * of text in both worlds. >>> 6271: * >>> 6272: * @defaultValue if the system property {@code >>> javafx.scene.nodeOrientation.RTL} is

Re: Proposal: RichTextArea Control (Incubator)

2024-02-23 Thread Nir Lisker
Hi all, I don't use RT controls, so I can't comment about the specifics of this or other implementations. However, people raised some good points that I would like to be more specific about. 1. Can the "components" of the RTA be separated out so that other controls can use them? For example, colo

RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc

2024-02-23 Thread Nir Lisker
Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in `Node` and `Scene`. Note that the default value for a `Scene`'s `NodeOrientation` depends on a system property, while for `Node` it isn't (which means `SubScene` will be different from `Scene`). Not sure if this is in

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 23:07:21 GMT, Kevin Rushforth wrote: >> Perhaps the contribution guidelines should mention what resources can be >> included. In all other open source projects I worked on it was enough that >> the resource wasn't licensed (or had something like >> https://en.wikipedia.org/

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:50:06 GMT, Andy Goryachev wrote: >>> also, the first `+` is unnecessary >> >> I think it was done for uniformity with the other properties. I would use a >> `StringJoiner` these days for such a task anyway. > > StringJoiner seems to provide little benefit for maps or key=

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:42:18 GMT, Andy Goryachev wrote: >> OK, it will be after the weekend when I can come back to this. Reviewers can >> assume that only the background will change. > > sorry, Nir. ;-) Perhaps the contribution guidelines should mention what resources can be included. In all

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:20:56 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java >> line 848: >> >>> 846: + ", specularPower=" + getSpecularPower() + ", >>> diffus

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:36:06 GMT, Kevin Rushforth wrote: >> Do I only need to switch the ones in the introduction that show the >> multiplication of the color and the map, or all of the new images that use >> it as a background? The latter will be a lot of work. > > All of them, since they were

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:21:49 GMT, Kevin Rushforth wrote: >> What would an approval require? > > To add to this, such approval would be unlikely, and I am not in favor of > making the request. Perhaps you can find suitable images already in the repo? > Here is one that might work: > > https://g

Re: RFR: 8314147: Updated the PhongMaterial documentation [v3]

2024-02-22 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation [v2]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:18:38 GMT, Andy Goryachev wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year > > modules/javafx.graphics/src/main/java/javafx/scene/paint/

Re: RFR: 8314147: Updated the PhongMaterial documentation [v2]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 22:13:33 GMT, Kevin Rushforth wrote: >> No, it's a standard in image processing: https://en.wikipedia.org/wiki/Lenna. > > But it's still third-party content and cannot go in without approval. What would an approval require? - PR Review Comment: https://git.openj

Re: RFR: 8314147: Updated the PhongMaterial documentation [v2]

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 20:49:20 GMT, Andy Goryachev wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year > > modules/javafx.graphics/src/main/docs/javafx/scene/paint/doc-

Re: RFR: 8314147: Updated the PhongMaterial documentation [v2]

2024-02-22 Thread Nir Lisker
er, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for review

Re: RFR: 8314147: Updated the PhongMaterial documentation

2024-02-22 Thread Nir Lisker
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote: > Overhaul to the `PhongMaterial` documentation (and a bit to its superclass > `Material`). Except for the introduction, I divided the documentation into 3 > sections: qualitative explanation, mathematical model (I wouldn&#

RFR: 8314147: Updated the PhongMaterial documentation

2024-02-22 Thread Nir Lisker
Overhaul to the `PhongMaterial` documentation (and a bit to its superclass `Material`). Except for the introduction, I divided the documentation into 3 sections: qualitative explanation, mathematical model (I wouldn't think it necessary, but the current doc explains it), and examples. The reaso

Re: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-18 Thread Nir Lisker
+1 On Sat, Feb 17, 2024, 15:37 John Hendrikx wrote: > +1 > > On 16/02/2024 23:11, Kevin Rushforth wrote: > > All, > > > > Even though we build JavaFX binaries with JDK 21 as the boot JDK, the > > latest version of JavaFX still runs with JDK 17, although it isn't > > tested with older JDK version

Linking to anchors in the same class

2024-02-15 Thread Nir Lisker
Hi, I have a question after reading https://bugs.openjdk.org/browse/JDK-8294195. If I have a class Chronus.java with a heading in its class javadoc: Time then an anchor Chronus.html#time-heading is auto-generated. How do I link to this anchor from within the class using @see and @link? I have tr

Re: Layout and property bindings question, what is allowed?

2024-02-09 Thread Nir Lisker
You're thinking about the docs of the note in the bounds properties I think: https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInLocalProperty() https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInParentProperty() On Fri, Feb 9, 2024, 03:28 John H

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2024-02-08 Thread Nir Lisker
On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: Binding properties to constant values

2024-02-01 Thread Nir Lisker
to say that)? Perhaps Kevin can weigh in. The question of how to do it is simpler, and can be done with or without breaking changes to StyleOrigin. On Thu, Feb 1, 2024 at 2:27 AM John Hendrikx wrote: > Hi Nir, > > On 31/01/2024 22:36, Nir Lisker wrote: > > > > I would wait w

Re: Binding properties to constant values

2024-01-31 Thread Nir Lisker
> > Specialized methods will be added to `BooleanProperty`, > `DoubleProperty`, `FloatProperty`, `IntegerProperty`, and > `LongProperty`, each with one of the preexisting constant wrappers > that are already in the framework. > Some wrappers can be deduplicated (we only ever need two wrapper > inst

Re: Build artifacts for Linux aarch64

2024-01-30 Thread Nir Lisker
Hi Armin, If I go to https://gluonhq.com/products/javafx/ and filter to linux aarch64, I see both SDK and JMODS for JavaFX 22-ea+16 (latest version, which is early access). If you're talking about commercial support, I don't know. Different companies choose what they support. - Nir On Tue, Jan 3

Re: Platform preferences theme detection

2024-01-30 Thread Nir Lisker
t the last available 22+ea maven release, which is now almost > 3 months old, does not contain the platform preferences API and also does > not contain the kinda important css performance regression fixes. > On 1/30/2024 1:33 PM, Nir Lisker wrote: > > Hi Christopher, > > Lookin

[jfx22] Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Tue, 30 Jan 2024 12:08:41 GMT, Nir Lisker wrote: > Hi all, > > This pull request contains a backport of commit > [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.

Re: Platform preferences theme detection

2024-01-30 Thread Nir Lisker
Hi Christopher, Looking at Maven Central, https://mvnrepository.com/artifact/org.openjfx/javafx, JavaFX releases ea builds there, which I sometimes use myself from Maven/Gradle. Version 21 had 6 ea versions, and 22 has 3. The release cycle is 6 months per final version (aligned with OpenJDK). - N

[jfx22] RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
Hi all, This pull request contains a backport of commit [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Nir Lisker on 30 Jan 2024 and was

Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker wrote: > Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. This pull request has now been integrated. Changeset: c5ab220b Author: Nir Lisker URL:

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v17]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 22:13:25 GMT, Kevin Rushforth wrote: >> I don't think the executor service catches the exception because if it did >> then the `AnimationTimer` test would also always pass. I do get the AIOOB >> exceptions from the background thread caught in the handler (which fails the >>

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:00:46 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > tests/system/src/test/java/test/com/sun/javafx/animation/Synch

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v16]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Use AtomicReferences - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:05:46 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > tests/system/src/test/java/test/com/sun/javafx/animation/Synch

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v15]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with two additional commits since the last revision: - Fix removed methods - Correct meth

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 19:22:17 GMT, Jose Pereda wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > modules/javafx.graphics/src/main/java/javafx/animation/Animati

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > comm

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v14]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v13]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Rename more Animation methods - Chang

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v12]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update Timeline method - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 13:07:21 GMT, Kevin Rushforth wrote: > I don't think this will do what you want. This will return almost > immediately, before any of the animation has run (as soon as the runnable > that sets the uncaught exception handler finished). I observed that this setup works correc

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v11]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Add null parent checks - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 12:44:07 GMT, Kevin Rushforth wrote: >> Probably you won't like `xxImpl` either? >> I'm not sure we should start adding `runMustBeOnFxThread` to every method >> name out there that should run on the FX thread. In this case, maybe we >> could simply add a small javadoc with a

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v10]

2024-01-29 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Change method names - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-28 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v8]

2024-01-28 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Add system test - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v7]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Remove irrelevant tests - Changes: -

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 19:43:22 GMT, Jose Pereda wrote: > However, I'm not sure about the method naming `OnFxThread`, as it might imply > that what it does is already done on the FX thread, therefore not needing to > be wrapped up by `runOnFxThread`. I understand what you mean, but the way I see

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v6]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Move parent check to invoking thread ---

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 19:27:25 GMT, Jose Pereda wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update documentation on AnimationTimer methods > > modules/javafx.graphics/src/main/java/

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 18:06:24 GMT, Kevin Rushforth wrote: > The API looks good now, so you should be able to update the CSR. I think that the update to the CSR from an hour ago included all the changes already. - PR Comment: https://git.openjdk.org/jfx/pull/1352#issuecomment-191328

Re: RFR: 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile

2024-01-27 Thread Nir Lisker
On Wed, 10 Jan 2024 02:36:32 GMT, Philippe Altherr wrote: > 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile By the way, [code snippets](https://openjdk.org/jeps/413) brought a solution to this with external snippets. The example code exists in a standard compiled java

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v5]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update documentation on AnimationTi

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v4]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with two additional commits since the last revision: - Remove whitespace - Include playFr

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v3]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 16:07:54 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Call the correct super method > > modules/javafx.graphics/src/main/java/javafx/animat

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 15:40:53 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Doc changes to AnimationTimer methods > > modules/javafx.graphics/src/main/java/javaf

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v3]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Call the correct super method - Chang

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Doc changes to AnimationTimer methods ---

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-26 Thread Nir Lisker
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker wrote: > Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. The tests from [JDK-8159048](https://bugs.openjdk.org/browse/JDK-8159048) should either be removed

RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-26 Thread Nir Lisker
Added a utility method to run code on the FX thread if it's not already, and changed the animation methods to use it. - Commit messages: - Remove whitespace - Remove whitespace - Run methods on the FX thread Changes: https://git.openjdk.org/jfx/pull/1352/files Webrev: https://we

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced USE CASE

2024-01-25 Thread Nir Lisker
ething like a PauseTransition that doesn't manipulate properties? On Thu, Jan 25, 2024 at 11:02 AM John Hendrikx wrote: > > On 24/01/2024 22:06, Nir Lisker wrote: > > This is the ballpark of what I meant with "the downside might be some > surprise when these meth

Re: Thought experiment: constructing Nodes on a different thread...

2024-01-25 Thread Nir Lisker
Isn't that exactly what the Worker interface and its Task and Service implementations are for? Service says A Service is a non-visual component encapsulating the information required > to perform some work on one or more background threads. As part of the > JavaFX UI library, the Service knows abo

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced USE CASE

2024-01-24 Thread Nir Lisker
tus of the animation. Only the > internal operation of adding the animation to AbstractPrimaryTimer > should be posted to the FX thread. If that is not possible, this > suggests to me that we should choose option 1. Introducing new and > surprising semantics to an existing API is not the way

Re: [External] : Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced USE CASE

2024-01-24 Thread Nir Lisker
tarts something that conceptually happens later on the FX animation thread > anyway, so wrapping it in a runLater (if not already on the right thread) > doesn't really change the semantics in an appreciable way. > > -- Kevin > > > On 1/24/2024 10:26 AM, Nir Lisker wrote

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced USE CASE

2024-01-24 Thread Nir Lisker
e would be a fair bit of work to do it right without a > clear benefit. > > We will proceed with the current approach and let JDK-8159048 stand. > Further, we will proceed with https://bugs.openjdk.org/browse/JDK-8324219 > which is under review in https://github.com/openjdk/jfx/pull/1342 > >

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced USE CASE

2024-01-24 Thread Nir Lisker
mory +" MB" ); > > }) > > ); > > > updater.setCycleCount(Animation.INDEFINITE); > // This FXML is being loaded on a background thread > > updater.play(); > > } > > } > > > -

Re: My issue seems to be lost

2024-01-22 Thread Nir Lisker
I don't see a ColorPicker bug in JBS that was created in the last 2 weeks, which means it's still in internal triage. Kevin will have to take a look. On Mon, Jan 22, 2024 at 12:20 PM PavelTurk wrote: > Hello all. > > On January 10, 2024 I opened an issue with internal review ID 9076431 > about b

Re: RFR: 8324219: Remove incorrect documentation from Animation methods

2024-01-21 Thread Nir Lisker
On Fri, 19 Jan 2024 16:07:31 GMT, Michael Strauß wrote: > The `Animation` class states in the documentation of various methods that the > method call would be asynchronous, using language similar to: > > > {@code stop()} is an asynchronous call, the {@code Animation} may not stop > immediatel

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced

2024-01-20 Thread Nir Lisker
Hi Jurgen, What I'm confused about the most is what it is you are actually trying to do that necessitates the use of animations outside of the FX thread. You said that you need to initialize controls on another thread, and that you are using Task (both of which are fine), but how does playing anim

Re: HEADS-UP: Threading restriction for Animation play, pause, stop now enforced

2024-01-19 Thread Nir Lisker
to be considered and approved while > we are still in RDP1. I would not consider such a change once we hit > RDP2 on Feb 1. > > Before even considering this, I'd like to hear from Johan Vos, Jose > Pereda (who implemented JDK-8159048), Nir Lisker (who has done a lot of > work on

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-01-19 Thread Nir Lisker
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote: >> The SimpleSelector and CompoundSelector classes are public classes in an >> exported package, javafx.css, but they are not intended to be used by >> applications. They are implementation details. They cannot be constructed >> directly a

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes

2024-01-19 Thread Nir Lisker
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote: > The SimpleSelector and CompoundSelector classes are public classes in an > exported package, javafx.css, but they are not intended to be used by > applications. They are implementation details. They cannot be constructed > directly and n

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes

2024-01-19 Thread Nir Lisker
On Fri, 19 Jan 2024 10:02:19 GMT, John Hendrikx wrote: > The SimpleSelector and CompoundSelector classes are public classes in an > exported package, javafx.css, but they are not intended to be used by > applications. They are implementation details. They cannot be constructed > directly and n

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching

2024-01-04 Thread Nir Lisker
On Thu, 4 Jan 2024 12:21:15 GMT, John Hendrikx wrote: > Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It a

Re: RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

2023-12-29 Thread Nir Lisker
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote: >> Moves the filter setting of the samplers from the device parameters >> configuration to the use-site, allowing for dynamic changes in the sampler. >> This PR does internal plumbing work only to bring it close to the E

<    1   2   3   4   5   6   7   8   9   10   >