[PATCH v2 3/4] util/uri: Remove the uri_string_escape() function

2024-01-23 Thread Thomas Huth
Now that uri_resolve_relative() has been removed, this function is not used in QEMU anymore - and if somebody needs this functionality, they can simply use g_uri_escape_string() from the glib instead. Reviewed-by: Stefan Weil Reviewed-by: "Daniel P. Berrangé" Signed-off-by: T

[PATCH v2 1/4] util/uri: Remove uri_string_unescape()

2024-01-23 Thread Thomas Huth
()] Signed-off-by: Thomas Huth --- include/qemu/uri.h | 1 - util/uri.c | 97 ++ 2 files changed, 11 insertions(+), 87 deletions(-) diff --git a/include/qemu/uri.h b/include/qemu/uri.h index 1855b764f2..f0722b75da 100644 --- a/include/qemu/uri.h

[PATCH v2 2/4] util/uri: Remove unused functions uri_resolve() and uri_resolve_relative()

2024-01-23 Thread Thomas Huth
Reviewed-by: "Daniel P. Berrangé" Signed-off-by: Thomas Huth --- include/qemu/uri.h | 2 - util/uri.c | 689 - 2 files changed, 691 deletions(-) diff --git a/include/qemu/uri.h b/include/qemu/uri.h index f0722b75da..899ce85

[PATCH v2 1/4] util/uri: Remove uri_string_unescape()

2024-01-23 Thread Thomas Huth
()] Signed-off-by: Thomas Huth --- include/qemu/uri.h | 1 - util/uri.c | 97 ++ 2 files changed, 11 insertions(+), 87 deletions(-) diff --git a/include/qemu/uri.h b/include/qemu/uri.h index 1855b764f2..f0722b75da 100644 --- a/include/qemu/uri.h

[PATCH v2 0/4] util/uri: Simplify the code, remove unused functions

2024-01-23 Thread Thomas Huth
uri_string_unescape() with g_uri_unescape_segment(), so we can remove uri_string_unescape() completely now Thomas Huth (4): util/uri: Remove uri_string_unescape() util/uri: Remove unused functions uri_resolve() and uri_resolve_relative() util/uri: Remove the uri_string_escape() function util

[PATCH v2 0/4] util/uri: Simplify the code, remove unused functions

2024-01-23 Thread Thomas Huth
uri_string_unescape() with g_uri_unescape_segment(), so we can remove uri_string_unescape() completely now Thomas Huth (4): util/uri: Remove uri_string_unescape() util/uri: Remove unused functions uri_resolve() and uri_resolve_relative() util/uri: Remove the uri_string_escape() function util

Re: [PATCH v3 00/16] tests: enable meson test timeouts to improve debuggability

2024-01-23 Thread Thomas Huth
On 23/01/2024 17.50, Michael Tokarev wrote: 15.12.2023 10:03, Thomas Huth wrote: This is a respin of Daniel's series that re-enables the meson test runner timeouts. To make sure that we do not get into trouble on older systems, I ran all the tests with "make check SPEED=slow -j32" on

Re: [PATCH 2/5] util/uri: Simplify uri_string_unescape()

2024-01-23 Thread Thomas Huth
On 23/01/2024 11.25, Paolo Bonzini wrote: Il lun 22 gen 2024, 20:18 Thomas Huth <mailto:th...@redhat.com>> ha scritto: uri_string_unescape() basically does the same as the glib function g_uri_unescape_string(), with just an additional length parameter. You can replace it a

[PATCH] tests/qtest: Bump timeout of the boot-serial-test to 360 seconds

2024-01-23 Thread Thomas Huth
which should hopefully really be high enough now. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2097 Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index d22434b14e

Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function

2024-01-22 Thread Thomas Huth
On 22/01/2024 21.59, Stefan Weil wrote: Am 22.01.24 um 20:17 schrieb Thomas Huth: It is not used in QEMU - and if somebody needs this functionality, they can simply use g_uri_escape_string() from the glib instead. Signed-off-by: Thomas Huth ---   include/qemu/uri.h |  1 -   util/uri.c

Re: [PATCH 2/5] util/uri: Simplify uri_string_unescape()

2024-01-22 Thread Thomas Huth
On 22/01/2024 22.22, Stefan Weil wrote: Am 22.01.24 um 20:17 schrieb Thomas Huth: uri_string_unescape() basically does the same as the glib function g_uri_unescape_string(), with just an additional length parameter. So we can simplify this function a lot by limiting the length with g_strndup

[PATCH 4/5] util/uri: Remove unused functions uri_resolve() and uri_resolve_relative()

2024-01-22 Thread Thomas Huth
These rather complex functions have never been used since they've been introduced in 2012, so looks like they are not really useful for QEMU. And since the static normalize_uri_path() function is also only used by uri_resolve(), we can remove that function now, too. Signed-off-by: Thomas Huth

[PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

2024-01-22 Thread Thomas Huth
They are not used anywhere, so there's no need to keep them around. Signed-off-by: Thomas Huth --- util/uri.c | 13 - 1 file changed, 13 deletions(-) diff --git a/util/uri.c b/util/uri.c index 5f5ca79792..2deab91da3 100644 --- a/util/uri.c +++ b/util/uri.c @@ -163,19 +163,6

[PATCH 3/5] util/uri: Remove the uri_string_escape() function

2024-01-22 Thread Thomas Huth
It is not used in QEMU - and if somebody needs this functionality, they can simply use g_uri_escape_string() from the glib instead. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 1 - util/uri.c | 64 -- 2 files changed, 65 deletions

[PATCH 0/5] util/uri: Simplify the code, remove unused functions

2024-01-22 Thread Thomas Huth
). Thomas Huth (5): util/uri: Remove the unused "target" argument from uri_string_unescape() util/uri: Simplify uri_string_unescape() util/uri: Remove the uri_string_escape() function util/uri: Remove unused functions uri_resolve() and uri_resolve_relative() util/uri: Remove unu

[PATCH 1/5] util/uri: Remove the unused "target" argument from uri_string_unescape()

2024-01-22 Thread Thomas Huth
All callers pass NULL as target, so we can simplify the code by dropping this parameter. Signed-off-by: Thomas Huth --- include/qemu/uri.h | 2 +- util/uri.c | 32 ++-- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/include/qemu/uri.h b

[PATCH 2/5] util/uri: Simplify uri_string_unescape()

2024-01-22 Thread Thomas Huth
the string manually. Suggested-by: Stefan Weil Signed-off-by: Thomas Huth --- util/uri.c | 49 +++-- 1 file changed, 3 insertions(+), 46 deletions(-) diff --git a/util/uri.c b/util/uri.c index 33b6c7214e..2a75f535ba 100644 --- a/util/uri.c +++ b/util/uri.c

Re: [PATCH] bswap.h: Fix const_le64() macro

2024-01-22 Thread Thomas Huth
\ + (((_x) & 0xff00ULL) << 8) |\ + (((_x) & 0x00ffULL) >> 8) |\ + (((_x) & 0xff00ULL) >> 24) |\ + (((_x) & 0x00ffULL) >> 40) |\ + (((_x) & 0xff000000ULL) >> 56)) # define const_le32(_x) \ _x) & 0x00ffU) << 24) | \ (((_x) & 0xff00U) << 8) | \ Reviewed-by: Thomas Huth

[PATCH] tests/unit/test-iov: Fix timeout problem on NetBSD and OpenBSD

2024-01-22 Thread Thomas Huth
ear what is going on here. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/unit/test-iov.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/tests/unit/test-iov.c b/tests/unit/test-iov.c index 6f7623d310..75bc3be005 100644 --- a/te

Re: [PATCH] hw/xtensa: require libfdt

2024-01-22 Thread Thomas Huth
itectures. Reviewed-by: Thomas Huth

Re: [PATCH] monitor: add dumpdtb command only in device-tree-enabled targets

2024-01-22 Thread Thomas Huth
On 22/01/2024 10.24, Paolo Bonzini wrote: Remove the command altogether from targets that do not have device tree support, instead of leaving it nonfunctional. Signed-off-by: Paolo Bonzini --- meson.build| 2 -- qapi/machine.json | 2 +- hmp-commands.hx| 2 +-

Re: [PATCH v2 0/3] s390x/pci: fix ISM reset

2024-01-22 Thread Thomas Huth
On 22/01/2024 11.31, Michael Tokarev wrote: 22.01.2024 13:18, Michael Tokarev : .. Is it this a material for -stable, or there's no need to bother? Actually it's been Cc'd to qemu-stable@ already, I haven't noticed. Still there's a question which branches should get which patches. ... So

Re: How can I know Page Table address on RAM?

2024-01-22 Thread Thomas Huth
On 22/01/2024 05.11, Junho wrote: Hello, I'm a QEMU user with PowerPc target architecture. I have some personal modifications related to tb jmp cache and chaining logic to improve the performance of a specific guest code. To verify the safety, I have to guarantee that the page table on RAM

Re: QEMU's tests/unit/test-iov times out on NetBSD and OpenBSD

2024-01-19 Thread Thomas Huth
On 19/01/2024 17.07, Daniel P. Berrangé wrote: On Fri, Jan 19, 2024 at 03:55:49PM +, Thomas Huth wrote: Hi, since we recently introduced test timouts in QEMU's meson set up, I noticed that the tests/unit/test-iov times out when doing "make vm-build-netbsd BUILD_TARGET=check-unit&qu

QEMU's tests/unit/test-iov times out on NetBSD and OpenBSD

2024-01-19 Thread Thomas Huth
Hi, since we recently introduced test timouts in QEMU's meson set up, I noticed that the tests/unit/test-iov times out when doing "make vm-build-netbsd BUILD_TARGET=check-unit" (or vm-build-openbsd). And indeed, when increasing the timeout, you can see that the test-iov runs for multiple

[PULL 11/11] tests/vm/netbsd: Remove missing py311-expat package

2024-01-19 Thread Thomas Huth
://mail-index.netbsd.org/netbsd-announce/2024/01/01/msg000360.html Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2109 Tested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20240117140746.23511-1-phi...@linaro.org> Signed-off-by: Thoma

[PULL 10/11] cli: Remove deprecated '-singlestep' command line option

2024-01-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth

[PULL 08/11] qapi: Remove deprecated 'singlestep' member of StatusInfo

2024-01-19 Thread Thomas Huth
0.29235-2-phi...@linaro.org> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 14 -- qapi/run-state.json| 11 --- system/runstate.c | 8 tests/qemu-iotests/183.out | 4 ++-- tests/qemu-iotests/234.out | 8 tests/qemu-iotests/262.out

[PULL 09/11] hmp: Remove deprecated 'singlestep' command

2024-01-19 Thread Thomas Huth
Reviewed-by: Markus Armbruster Message-ID: <20240117151430.29235-3-phi...@linaro.org> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 - docs/about/removed-features.rst | 6 ++ tests/qtest/test-hmp.c | 1 - hmp-commands.hx | 13 ---

[PULL 02/11] s390x/pci: refresh fh before disabling aif

2024-01-19 Thread Thomas Huth
: 03451953c7 ("s390x/pci: reset ISM passthrough devices on shutdown and system reset") Reported-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Matthew Rosato Message-ID: <20240118185151.265329-3-mjros...@linux.ibm.com> Reviewed-by: Cédric Le Goater Signed-off-by: Thomas Hut

[PULL 05/11] qemu-options: Remove the deprecated -no-acpi option

2024-01-19 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Message-ID: <20240118103759.130748-3-th...@redhat.com> Reviewed-by: Markus Armbruster Reviewed-by: Michael Tokarev Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs

[PULL 06/11] qemu-options: Remove the deprecated -async-teardown option

2024-01-19 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now. Reviewed-by: Claudio Imbrenda Reviewed-by: Markus Armbruster Message-ID: <20240118103759.130748-4-th...@redhat.com> Signed-off-by: Thomas Huth --- docs

[PULL 00/11] s390x fixes, removal of deprecated options, netbsd VM fix

2024-01-19 Thread Thomas Huth
package Thomas Huth (4): qemu-options: Remove the deprecated -no-hpet option qemu-options: Remove the deprecated -no-acpi option qemu-options: Remove the deprecated -async-teardown option qemu-options: Remove the deprecated -chroot option docs/about/deprecated.rst | 62

[PULL 07/11] qemu-options: Remove the deprecated -chroot option

2024-01-19 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Reviewed-by: Markus Armbruster Message-ID: <20240118103759.130748-5-th...@redhat.com> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 5 - docs/about/removed-features.rs

[PULL 03/11] s390x/pci: drive ISM reset from subsystem reset

2024-01-19 Thread Thomas Huth
"s390x/pci: reset ISM passthrough devices on shutdown and system reset") Reported-by: Cédric Le Goater Signed-off-by: Matthew Rosato Message-ID: <20240118185151.265329-4-mjros...@linux.ibm.com> Reviewed-by: Eric Farman Reviewed-by: Cédric Le Goater Signed-off-by: Thomas Huth

[PULL 04/11] qemu-options: Remove the deprecated -no-hpet option

2024-01-19 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Reviewed-by: Markus Armbruster Message-ID: <20240118103759.130748-2-th...@redhat.com> Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.r

[PULL 01/11] s390x/pci: avoid double enable/disable of aif

2024-01-19 Thread Thomas Huth
event notification for interpreted devices") Reported-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Matthew Rosato Message-ID: <20240118185151.265329-2-mjros...@linux.ibm.com> Reviewed-by: Cédric Le Goater Signed-off-by: Thomas Huth --- include/hw/s390x/s390-pci-bus.h | 1

Re: [PATCH 19/24] configure: remove compiler sanity check

2024-01-18 Thread Thomas Huth
On 11/05/2023 11.50, Paolo Bonzini wrote: The comment is not correct anymore, in that the usability test for the compiler and linker are done after probing $cpu, and Meson will redo them anyway. Signed-off-by: Paolo Bonzini --- configure | 14 -- 1 file changed, 14 deletions(-)

Re: [PATCH 0/2] target/s390x: Emulate CVDG

2024-01-18 Thread Thomas Huth
On 15/01/2024 21.21, Ilya Leoshkevich wrote: Hi, Ido reported that we are missing the CVDG emulation (which is very similar to the existing CVD emulation). This series adds it along with a test. Just FYI, your patch made me curious which other instructions we still might be missing from

Re: [PATCH 2/2] tests/tcg/s390x: Test CONVERT TO DECIMAL

2024-01-18 Thread Thomas Huth
tests/tcg/s390x/cvd.c Tested-by: Thomas Huth

Re: [PATCH 1/2] target/s390x: Emulate CVDG

2024-01-18 Thread Thomas Huth
+ target/s390x/tcg/insn-data.h.inc | 1 + target/s390x/tcg/int_helper.c| 11 --- target/s390x/tcg/translate.c | 8 4 files changed, 18 insertions(+), 3 deletions(-) Looks sane to me! Reviewed-by: Thomas Huth

Re: [PATCH v2 7/7] Add tests for the STM32L4x5_RCC

2024-01-18 Thread Thomas Huth
On 18/01/2024 10.14, Arnaud Minier wrote: Maybe add a short patch description about what exactly is being tested here? Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 3 +- tests/qtest/stm32l4x5_rcc-test.c | 210

[PATCH v2 3/4] qemu-options: Remove the deprecated -async-teardown option

2024-01-18 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now. Reviewed-by: Claudio Imbrenda Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 5 - docs/about/removed

[PATCH v2 2/4] qemu-options: Remove the deprecated -no-acpi option

2024-01-18 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 5 + docs/specs/tpm.rst | 4 ++-- hw/i386/pc.c| 4

[PATCH v2 1/4] qemu-options: Remove the deprecated -no-hpet option

2024-01-18 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 8 system/vl.c | 4 qemu

[PATCH v2 4/4] qemu-options: Remove the deprecated -chroot option

2024-01-18 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 5 - docs/about/removed-features.rst | 5 + system/vl.c | 5 - qemu

[PATCH v2 0/4] Remove deprecated command line options

2024-01-18 Thread Thomas Huth
this is handled by Philippe's series: https://lore.kernel.org/qemu-devel/20240117151430.29235-1-phi...@linaro.org/ Thomas Huth (4): qemu-options: Remove the deprecated -no-hpet option qemu-options: Remove the deprecated -no-acpi option qemu-options: Remove the deprecated -async-teardown

Re: [PATCH 0/3] s390x/pci: fix ISM reset

2024-01-17 Thread Thomas Huth
On 18/01/2024 07.03, Michael Tokarev wrote: 17.01.2024 01:31, Matthew Rosato: Commit ef1535901a0 (re-)introduced an issue where passthrough ISM devices on s390x would enter an error state after reboot.  This was previously fixed by 03451953c79e, using device reset callbacks, however the change

Re: [PATCH 2/2] tests/tcg/s390x: Import linux tools/testing/crypto/chacha20-s390

2024-01-17 Thread Thomas Huth
XT3,XT3,XD0 + + vstmXT0,XT3,0(OUT),0 + +.Ldone_4x: + lmg %r6,%r7,6*8(SP) + br %r14 + +.Ltail_4x: FWIW, my "git am" complains about a trailing white space here. Apart from that: Tested-by: Thomas Huth

Re: [PATCH 1/2] tcg/s390x: Fix encoding of VRIc, VRSa, VRSc insns

2024-01-17 Thread Thomas Huth
+tcg_out16(s, (op & 0x00ff) | RXB(0, v3, 0, 0) | (m4 << 12)); } static void tcg_out_insn_VRX(TCGContext *s, S390Opcode op, TCGReg v1, I double-checked the Principles of Operation that VRI-c, VRS-a and VRS-c are the only encodings where this could happen, and yes, your modification looks right to me: Reviewed-by: Thomas Huth Do you want to take it through our TCG branch or shall I pick it up for my s390x branch?

Re: [PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Thomas Huth
On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote: This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Thomas Huth
On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote: This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 3/3] cli: Remove deprecated '-singlestep' command line option

2024-01-17 Thread Thomas Huth
On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote: This option has been deprecated before the 8.1 release, in commit 12fd0f41d0 ("Document that -singlestep command line option is deprecated"). Time to drop it. Inspired-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names

2024-01-17 Thread Thomas Huth
For consistency we should drop the names with a "+" in it in the long run. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index b47763330c..251723d264 100644

[PATCH v2 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules

2024-01-17 Thread Thomas Huth
ut I'd also be fine if we keep the aliases around, so in that case please ignore the second patch. v2: - Use "power5p" / "power7p" instead of "power5plus" / "power7plus" Thomas Huth (2): target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming r

[PATCH v2 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-17 Thread Thomas Huth
ill allow them for compatibility reasons. However, there is a much nicer solution for this: Simply use aliases! This way we can still support the old names without the need for the ugly hack in type_name_is_valid(). Signed-off-by: Thomas Huth --- hw/ppc/spapr_cpu_core.c | 4 ++-- qom/object.c

Re: [PATCH 2/5] qemu-options: Remove the deprecated -no-acpi option

2024-01-17 Thread Thomas Huth
On 17/01/2024 13.38, Markus Armbruster wrote: Thomas Huth writes: It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Signed-off-by: Thomas Huth Leftovers: docs/specs/tpm.rst:-nographic -no-acpi \ hw/i386/pc.c: * When -no-acpi is used with Q35

[PATCH v2 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-17 Thread Thomas Huth
ill allow them for compatibility reasons. However, there is a much nicer solution for this: Simply use aliases! This way we can still support the old names without the need for the ugly hack in type_name_is_valid(). Signed-off-by: Thomas Huth --- hw/ppc/spapr_cpu_core.c | 4 ++-- qom/object.c

[PATCH v2 2/2] docs/about: Deprecate the old "power5+" and "power7+" CPU names

2024-01-17 Thread Thomas Huth
For consistency we should drop the names with a "+" in it in the long run. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index b47763330c..251723d264 100644

[PATCH v2 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules

2024-01-17 Thread Thomas Huth
ut I'd also be fine if we keep the aliases around, so in that case please ignore the second patch. v2: - Use "power5p" / "power7p" instead of "power5plus" / "power7plus" Thomas Huth (2): target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming r

Re: [PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules

2024-01-17 Thread Thomas Huth
On 12/01/2024 13.48, Peter Krempa wrote: On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote: We can get rid of the "power5+" / "power7+" hack in qom/object.c by using CPU aliases for those names instead (first patch). I think in the long run, we should

Re: [PATCH 0/2] ppc: Rename power5+ and power7+ for the new QOM naming rules

2024-01-17 Thread Thomas Huth
On 12/01/2024 13.48, Peter Krempa wrote: On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote: We can get rid of the "power5+" / "power7+" hack in qom/object.c by using CPU aliases for those names instead (first patch). I think in the long run, we should

Re: [PATCH] util/uri: Remove is_hex() function

2024-01-17 Thread Thomas Huth
On 12/01/2024 08.19, Stefan Weil via wrote: Am 12.01.24 um 07:35 schrieb Markus Armbruster: Thomas Huth writes: We can simply use the g_ascii_isxdigit() from the glib instead. ... or even use unescape_string() from the glib? https://docs.gtk.org/glib/type_func.Uri.unescape_string.html

Re: [RFC PATCH] tests/vm/netbsd: Remove missing py311-expat package

2024-01-17 Thread Thomas Huth
age now. Thus I think your patch is fine. It also fixes the problem for me, so: Tested-by: Thomas Huth Reviewed-by: Thomas Huth

Re: [PATCH] tests/docker: Add sqlite3 module to openSUSE Leap container

2024-01-16 Thread Thomas Huth
On 17/01/2024 00.09, Fabiano Rosas wrote: Avocado needs sqlite3: Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not installed. Use: sudo zypper install python311 to install it") Include the appropriate package in the dockerfile. From

Error messages in the "avocado-system-opensuse" QEMU CI job

2024-01-16 Thread Thomas Huth
Hi! I noticed that there are some error messages about a missing python module in the "avocado-system-opensuse" QEMU CI job: https://gitlab.com/qemu-project/qemu/-/jobs/5911721890#L191 Anybody interested in fixing those? Thomas

Re: [PATCH v3 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device()

2024-01-16 Thread Thomas Huth
v_realize_and_unref(dev, bus, _fatal); } } Acked-by: Thomas Huth

Re: [PATCH v3 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device()

2024-01-16 Thread Thomas Huth
v_realize_and_unref(dev, bus, _fatal); } } Acked-by: Thomas Huth

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-16 Thread Thomas Huth
On 16/01/2024 10.46, Philippe Mathieu-Daudé wrote: On 16/1/24 07:27, Markus Armbruster wrote: Daniel P. Berrangé writes: On Mon, Jan 15, 2024 at 05:39:19PM +, Peter Maydell wrote: On Mon, 15 Jan 2024 at 13:54, Thomas Huth wrote: On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: Hi

[PULL 0/5] qtest timeouts and ROP mitigation

2024-01-15 Thread Thomas Huth
qtests * Enable some ROP mitigation compiler switches Daniel P. Berrangé (2): meson: mitigate against ROP exploits with -fzero-call-used-regs meson: mitigate against use of uninitialize stack for exploits Thomas Huth (3

[PULL 1/5] tests/qtest/meson.build: Bump the boot-serial-test timeout to 4 minutes

2024-01-15 Thread Thomas Huth
uot; Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index fd40136fa9..78c298ce97 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -8,7 +8,7 @@ slow_qte

[PULL 3/5] qtest: Bump npcm7xx_watchdog_timer-test timeout to 2 minutes

2024-01-15 Thread Thomas Huth
The npcm7xx_watchdog_timer-test can take more than 60 seconds in SPEED=slow mode on a loaded host system. Bumping to 2 minutes will give more headroom. Message-ID: <20240112164717.1063954-1-th...@redhat.com> Reviewed-by: "Daniel P. Berrangé" Signed-off-by: Thomas Huth

[PULL 5/5] meson: mitigate against use of uninitialize stack for exploits

2024-01-15 Thread Thomas Huth
t.com> Signed-off-by: Thomas Huth --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index 1bda391de6..d0329966f1 100644 --- a/meson.build +++ b/meson.build @@ -559,6 +559,11 @@ hardening_flags = [ # upon its return. This makes it ha

[PULL 4/5] meson: mitigate against ROP exploits with -fzero-call-used-regs

2024-01-15 Thread Thomas Huth
ion is a justifiable hardening / performance tradeoff. Reviewed-by: Thomas Huth Signed-off-by: "Daniel P. Berrangé" Message-ID: <20240103123414.2401208-2-berra...@redhat.com> Signed-off-by: Thomas Huth --- meson.build | 11 +++ 1 file changed, 11 insertions(+) diff --g

[PULL 2/5] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-15 Thread Thomas Huth
, it should be sufficient to test the corner settings of these fields (i.e. 0 and 3), so we can speed up this test in the default mode quite a bit. Message-ID: <20240115070223.30178-1-th...@redhat.com> Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thoma

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-15 Thread Thomas Huth
On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: Hi Thomas +Laurent & Peter On 12/1/24 11:00, Thomas Huth wrote: It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Signed-off-by: Thomas Huth ---   docs/about/deprecated.rst   |  6 --  

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-15 Thread Thomas Huth
On 15/01/2024 12.32, Alex Bennée wrote: Thomas Huth writes: The test_prescaler() part in the npcm7xx_watchdog_timer test is quite repetive, testing all possible combinations of the WTCLK and WTIS bitfields. Since each test spins up a new instance of QEMU, this is rather an expensive test

[PATCH] tests/qtest/meson.build: Bump the boot-serial-test timeout to 4 minutes

2024-01-14 Thread Thomas Huth
When running with TCI, the boot-serial-test can take longer than 3 minutes: https://gitlab.com/qemu-project/qemu/-/jobs/5890481086#L4774 Bump the timeout to 4 minutes to avoid CI failures here. Signed-off-by: Thomas Huth --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-14 Thread Thomas Huth
, it should be sufficient to test the corner settings of these fields (i.e. 0 and 3), so we can speed up this test in the default mode quite a bit. Signed-off-by: Thomas Huth --- tests/qtest/npcm7xx_watchdog_timer-test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests

Re: [RFC 3/3] tests/qtest: Add STM32L4x5 GPIO QTest testcase

2024-01-14 Thread Thomas Huth
/ + * GPIOA->IDR value after reset is not identical + * to the real one ad Alternate Functions aren't s/ad/and/ ? + * implemented + */ With the typos fixed: Acked-by: Thomas Huth

[PATCH] qtest: Bump npcm7xx_watchdog_timer-test timeout to 2 minutes

2024-01-12 Thread Thomas Huth
The npcm7xx_watchdog_timer-test can take more than 60 seconds when running in the gitlab-CI, see for example: https://gitlab.com/qemu-project/qemu/-/jobs/5890481174#L4756 Bumping to 2 minutes will give more headroom. Signed-off-by: Thomas Huth --- Based-on: <20231215070357.10888-1

Re: [PATCH v2 12/43] qtest: bump boot-serial-test timeout to 3 minutes

2024-01-12 Thread Thomas Huth
On 03/01/2024 18.33, Alex Bennée wrote: From: Daniel P. Berrangé The boot-serial-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-ID: <20230717182859.707658-9-be

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Thomas Huth
On 12/01/2024 06.21, Harsh Prateek Bora wrote: On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-12 Thread Thomas Huth
On 12/01/2024 06.21, Harsh Prateek Bora wrote: On 1/12/24 10:42, Thomas Huth wrote: On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to

[PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-12 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 7 +++ system/vl.c | 18 +- qemu-options.hx

[PATCH 4/5] qemu-options: Remove the deprecated -chroot option

2024-01-12 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 5 - docs/about/removed-features.rst | 5 + system/vl.c | 5 - qemu-options.hx | 12

[PATCH 0/5] Remove deprecated command line options

2024-01-12 Thread Thomas Huth
The -no-hpet, -no-acpi, -async-teardown, -chroot and -singlestep options have been deprecated for at least two releases, so it should be fine if we remove them now. Thomas Huth (5): qemu-options: Remove the deprecated -no-hpet option qemu-options: Remove the deprecated -no-acpi option qemu

[PATCH 2/5] qemu-options: Remove the deprecated -no-acpi option

2024-01-12 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 5 + system/vl.c | 4 qemu-options.hx | 9

[PATCH 1/5] qemu-options: Remove the deprecated -no-hpet option

2024-01-12 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.0, so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 8 system/vl.c | 4 qemu-options.hx | 7

[PATCH 3/5] qemu-options: Remove the deprecated -async-teardown option

2024-01-12 Thread Thomas Huth
It's been marked as deprecated since QEMU 8.1 (and was only available since QEMU 8.0 anyway), so it should be fine to remove this now. Signed-off-by: Thomas Huth --- docs/about/deprecated.rst | 5 - docs/about/removed-features.rst | 5 + system/vl.c | 6

[PATCH] util/uri: Remove is_hex() function

2024-01-11 Thread Thomas Huth
We can simply use the g_ascii_isxdigit() from the glib instead. Signed-off-by: Thomas Huth --- util/uri.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/util/uri.c b/util/uri.c index dcb3305236..7411c5ba14 100644 --- a/util/uri.c +++ b/util/uri.c @@ -1561,15

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Thomas Huth
On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+

Re: [PATCH 1/2] target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules

2024-01-11 Thread Thomas Huth
On 12/01/2024 05.57, Harsh Prateek Bora wrote: On 1/11/24 22:16, Thomas Huth wrote: The character "+" is now forbidden in QOM device names (see commit b447378e1217 - "Limit type names to alphanumerical and some few special characters"). For the "power5+

Re: [PATCH v2 2/9] hw/hppa/machine: Disable default devices with --nodefaults option

2024-01-11 Thread Thomas Huth
On 11/01/2024 23.28, Helge Deller wrote: On 1/9/24 17:01, Richard Henderson wrote: On 1/9/24 22:16, Helge Deller wrote: On 1/9/24 10:57, Richard Henderson wrote: On 1/8/24 00:22, del...@kernel.org wrote: From: Helge Deller Add support for the qemu --nodefaults option, which will disable

Re: [PATCH 3/5] hw/s390x: Rename cpu_class_init() to include 'sclp'

2024-01-11 Thread Thomas Huth
, .parent= TYPE_SCLP_EVENT, .instance_size = sizeof(SCLPEvent), -.class_init= cpu_class_init, +.class_init= sclp_cpu_class_init, .class_size= sizeof(SCLPEventClass), }; Reviewed-by: Thomas Huth

Re: [PULL 13/13] tests/avocado: remove skips from replay_kernel

2024-01-11 Thread Thomas Huth
On 08/01/2024 16.13, Alex Bennée wrote: With the latest fixes for #2010 and #2013 these tests look pretty stable now. Of course the only way to be really sure is to run it in the CI infrastructure and see what breaks. Acked-by: Pavel Dovgalyuk Signed-off-by: Alex Bennée Message-Id:

[PULL 17/17] .gitlab-ci.d/buildtest.yml: Work around htags bug when environment is large

2024-01-11 Thread Thomas Huth
@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index cfe737aca2..9b4df24e9a 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml

[PULL 12/17] hw/s390x/ccw: Replace basename() with g_path_get_basename()

2024-01-11 Thread Thomas Huth
() with g_path_get_basename(). [1]: https://lore.kernel.org/all/20231212010228.2701544-1-raj.k...@gmail.com/ Suggested-by: Cédric Le Goater Signed-off-by: Zhao Liu Message-ID: <20231221171921.57784-2-zhao1@linux.intel.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thoma

[PULL 13/17] hw/s390x/ccw: Replace dirname() with g_path_get_dirname()

2024-01-11 Thread Thomas Huth
ce dirname() with g_path_get_dirname(). Suggested-by: Cédric Le Goater Signed-off-by: Zhao Liu Message-ID: <20231221171921.57784-3-zhao1@linux.intel.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- hw/s390x/s390-ccw.c | 4 +++- 1 file changed, 3 insertions(+), 1 d

[PULL 03/17] Revert "netdev: set timeout depending on loadavg"

2024-01-11 Thread Thomas Huth
. Signed-off-by: "Daniel P. Berrangé" Message-ID: <20240104162942.211458-2-berra...@redhat.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Thomas Huth --- tests/qtest/netdev-socket.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/te

<    8   9   10   11   12   13   14   15   16   17   >