ch for hunk that moved to cpu_helper.c]
Signed-off-by: Thomas Huth
---
target/loongarch/cpu.c| 39 -
target/loongarch/cpu_helper.c | 3 +--
target/loongarch/gdbstub.c| 6 ++---
target/loongarch/kvm/kvm.c
Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
ind
commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: David Hildenbrand
Cc: Thomas Huth
Cc: Richard Henderson
Cc: Ilya Leoshkevich
Cc: qemu-s3...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.314
e description in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: "Michael S. Tsirkin"
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-27-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
h
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Cc: Tony Krowiak
Cc: Halil Pasic
Cc: Jason Herne
Cc: Thomas Huth
Cc: qemu-s3...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-19-zhao1....@linux.in
ix this, add missing ERRP_GUARD() at the beginning of this function.
[1]: Issue description in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Jason Wang
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
Message-ID: <20240311033822.3142585-29-zhao
mmit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-9-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
b
ed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-8-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qcow2-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 0e567ed588..87
;
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Acked-by: "Michael S. Tsirkin"
Message-ID: <20240311033822.3142585-14-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/block/virtio-blk.c | 1 +
1 file c
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Reviewed-by: Richard Henderson
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240129164514.73104-17-phi...@linaro.
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240129164514.73104-21-phi...@linaro.org>
Signed-off-by: Thoma
From: Philippe Mathieu-Daudé
Do not accept any Object for CPUArchId::cpu field,
restrict it to CPUState type.
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240129164514.73104-3-phi...@linaro.org>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
include/hw/boards.h
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-25-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/vfio/platform.c | 1 +
1 file changed
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240129164514.73104-8-phi...@linaro.org>
Signed-off-by: Thoma
Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
ind
_GUARD()").
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Message-ID: <20240311033822.3142585-10-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qed.c | 1 +
1 file changed, 1 ins
3142585-3-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
backends/iommufd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/backends/iommufd.c b/backends/iommufd.c
index 1ef683c7b0..62a79fa6b0 100644
--- a/backends/iommufd.c
+++ b/backends/iommufd.c
@@ -43,6 +43,7 @@ static voi
D() at their
beginning.
[1]: Issue description in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-24-zhao1....@lin
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-6-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
: Issue description in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Alex Williamson
Cc: Cédric Le Goater
Signed-off-by: Zhao Liu
Reviewed-by: Cédric Le Goater
Message-ID: <20240311033822.3142585-23-zhao1....@linux.intel.com>
Signed
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 ++
1 file change
GUARD() right at the beginning of the function, because only then
can it guard the whole function.", so clean up the few spots
disregarding the advice.
Inspired-by: Markus Armbruster
Signed-off-by: Zhao Liu
Reviewed-by: Markus Armbruster
Message-ID: <20240312060337.3240965-1-zhao1@linux.inte
ter, it hasn't triggered the bug that dereferencing
the NULL @errp.
To follow the requirement of @errp, add missing ERRP_GUARD() in
cxl_usp_realize().
Suggested-by: Markus Armbruster
Signed-off-by: Zhao Liu
Reviewed-by: Markus Armbruster
Reviewed-by: Thomas Huth
Message-ID: <20240223
ERARD
[thuth: Dropped hunks that need a rebase, and fixed sizeof() in pmu_realize()]
Signed-off-by: Thomas Huth
---
hw/display/ati.c | 2 +-
hw/misc/macio/pmu.c | 3 +--
hw/misc/pvpanic-pci.c | 2 +-
hw/pci-bridge/cxl_root_port.c | 2 +-
h
: <20240223085653.1255438-8-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/intc/ioapic_common.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/intc/ioapic_common.c b/hw/intc/ioapic_common.c
index cb9bf62146..efbe6958c8 100644
--- a/hw/intc/ioapic_common.c
+++ b/h
From: Philippe Mathieu-Daudé
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-ID: <20240129164514.73104-19-phi...@linaro.org>
Signed-off-by: Thoma
ed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-8-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qcow2-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 0e567ed588..87
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 ++
1 file change
mmit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-9-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
b
_GUARD()").
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Message-ID: <20240311033822.3142585-10-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qed.c | 1 +
1 file changed, 1 ins
on in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-4-zhao1....@linux.intel.com>
Signed-off-by: Thomas Hut
Cc: Vladimir Sementsov-Ogievskiy
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-5-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/copy-before-write.c | 1 +
1
tel.com>
Signed-off-by: Thomas Huth
---
hw/mem/cxl_type3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
index b679dfae1c..b0a7e9f11b 100644
--- a/hw/mem/cxl_type3.c
+++ b/hw/mem/cxl_type3.c
@@ -645,6 +645,7 @@ static DOEProtocol doe_cdat_prot[] = {
hao Liu
Reviewed-by: Markus Armbruster
Message-ID: <20240223085653.1255438-2-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/cxl/cxl-host.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c
index 2aa776c79c..c5f5fcfd64 100644
--- a/hw/cxl/cxl-hos
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f:
Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging
(2024-03-09 20:12:21 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-request-2024-03-12
for yo
On 30/01/2024 14.01, Igor Mammedov wrote:
On Mon, 29 Jan 2024 17:44:56 +0100
Philippe Mathieu-Daudé wrote:
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
commenting here since, I'm not expert on coccinelle scripts.
On negative
On 30/01/2024 14.01, Igor Mammedov wrote:
On Mon, 29 Jan 2024 17:44:56 +0100
Philippe Mathieu-Daudé wrote:
Mechanical patch produced running the command documented
in scripts/coccinelle/cpu_env.cocci_template header.
commenting here since, I'm not expert on coccinelle scripts.
On negative
On 29/01/2024 17.44, Philippe Mathieu-Daudé wrote:
Patches missing review: 1, 2, 5, 6, 8, 11, 14, 15, 29
It will be simpler if I get the whole series via my hw-cpus
tree once fully reviewed.
Since v2:
- Rebased
- bsd/linux-user
- Preliminary clean cpu_reset_hold
- Add R-b
Since v1:
- Avoid CPU
On 12/03/2024 11.26, Zhao Liu wrote:
On Tue, Mar 12, 2024 at 09:50:25AM +0100, Thomas Huth wrote:
Date: Tue, 12 Mar 2024 09:50:25 +0100
From: Thomas Huth
Subject: Re: [PATCH v2 00/29] Cleanup up to fix missing ERRP_GUARD() for
error_prepend()
On 12/03/2024 09.43, Zhao Liu wrote:
Hi Thomas
;
PCIEPort *p = PCIE_PORT(d);
CXLUpstreamPort *usp = CXL_USP(d);
CXLComponentState *cxl_cstate = &usp->cxl_cstate;
Reviewed-by: Thomas Huth
RRP_GUARD();
size_t transfer_buf_size = 0;
g_autofree void *transfer_buf = NULL;
g_autoptr(GError) g_err = NULL;
Reviewed-by: Thomas Huth
);
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
VHostVSock *vsock = VHOST_VSOCK(dev);
Reviewed-by: Thomas Huth
On 12/03/2024 09.43, Zhao Liu wrote:
Hi Thomas/Markus/Michael,
For the remaing patches, could you please help me merge them next?
Many thanks!
Yes, I'm currently reviewing the ones that don't have a Reviewed-by yet. I
can pick up the remaining patches if the other maintainers won't pick them
738,7 @@ static int coroutine_fn GRAPH_UNLOCKED
vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size,
Error **errp)
{
+ERRP_GUARD();
BlockdevCreateOptionsVdi *vdi_opts;
int ret = 0;
uint64_t bytes = 0;
Reviewed-by: Thomas Huth
738,7 @@ static int coroutine_fn GRAPH_UNLOCKED
vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size,
Error **errp)
{
+ERRP_GUARD();
BlockdevCreateOptionsVdi *vdi_opts;
int ret = 0;
uint64_t bytes = 0;
Reviewed-by: Thomas Huth
s = NULL;
GList *iterbdrvs;
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp)
{
+ERRP_GUARD();
g_autoptr(GList) bdrvs = NULL;
GList *iterbdrvs;
s = NULL;
GList *iterbdrvs;
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp)
{
+ERRP_GUARD();
g_autoptr(GList) bdrvs = NULL;
GList *iterbdrvs;
or command line arguments" section, which may
cause confusion about the contents of this patch.
---
docs/about/deprecated.rst | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
On 12/03/2024 07.46, Zhao Liu wrote:
Hi Philippe,
On Sat, Mar 09, 2024 at 02:49:17PM +0100, Philippe Mathieu-Daudé wrote:
Date: Sat, 9 Mar 2024 14:49:17 +0100
From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 00/13] Cleanup on SMP and its test
On 9/3/24 01:46, Zhao Liu wrote:
Hi Philippe,
pherAlgorithm_str(test_data[i].alg),
+ QCryptoCipherMode_str(test_data[i].mode));
}
}
Reviewed-by: Thomas Huth
g_assert(cipher != NULL);
} else {
error_free_or_abort(&err);
Reviewed-by: Thomas Huth
(qcrypto_cipher_alg_to_gcry_alg(alg),
+ GCRYCTL_TEST_ALGO, NULL, NULL) != 0) {
+return false;
+}
+
switch (mode) {
case QCRYPTO_CIPHER_MODE_ECB:
case QCRYPTO_CIPHER_MODE_CBC:
Reviewed-by: Thomas Huth
(-)
Reviewed-by: Thomas Huth
On 11/03/2024 11.14, Daniel P. Berrangé wrote:
On Mon, Mar 11, 2024 at 09:32:32AM +, Daniel P. Berrangé wrote:
On Fri, Mar 08, 2024 at 09:30:52PM +0100, Thomas Huth wrote:
On 07/12/2023 16.47, Hyman Huang wrote:
Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
SM4 (GBT.32907
On 08/03/2024 16.07, Alex Bennée wrote:
This avoids fetching blobs and tree references for branches we are not
going to worry about. Also skip tag references which are similarly not
useful and keep the default --prune. This keeps the .git data to
around 100M rather than the ~400M even a shallow c
On 06/03/2024 15.40, Alex Bennée wrote:
For plugins we don't expect the raw opcodes in the disassembly. We
already deal with this by hand crafting our capstone call but for
other diassemblers we need a flag. Introduce show_opcodes which
defaults to off.
Reviewed-by: Richard Henderson
Signed-off
vm.add_source_dir(args.build_qemu)
Reviewed-by: Thomas Huth
---
tests/vm/basevm.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Huth
Am Sat, 9 Mar 2024 10:34:59 +0100
schrieb Angelo Dureghello :
> Add reset support for mcf5208.
>
> Signed-off-by: Angelo Dureghello
> ---
> hw/m68k/mcf5208.c | 44 ++--
> 1 file changed, 42 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
Am Fri, 8 Mar 2024 10:08:12 +0100
schrieb Angelo Dureghello :
> Add reset support for mcf5208.
>
> Signed-off-by: Angelo Dureghello
> ---
> hw/m68k/mcf5208.c | 49 ---
> 1 file changed, 46 insertions(+), 3 deletions(-)
>
> diff --git a/hw/m68k/mcf52
On 07/12/2023 16.47, Hyman Huang wrote:
Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
SM4 (GBT.32907-2016) is a cryptographic standard issued by the
Organization of State Commercial Administration of China (OSCCA)
as an authorized cryptographic algorithms for the use within China.
m/spitz.c| 1 +
hw/arm/tosa.c | 1 +
hw/arm/z2.c | 1 +
8 files changed, 24 insertions(+)
Reviewed-by: Thomas Huth
---
2 files changed, 61 insertions(+), 16 deletions(-)
Reviewed-by: Thomas Huth
On 08/03/2024 09.08, Philippe Mathieu-Daudé wrote:
On 7/3/24 20:43, Thomas Huth wrote:
On 28/02/2024 17.43, Zhao Liu wrote:
Hi Philippe,
+/*
+ * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs.
+ * Virtualized ICH9 allows broadcasting upon negatiation with guest
On 08/03/2024 16.43, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 10:42, Thomas Huth wrote:
Support for these boards has been removed from the Linux kernel
in version 6.3 in 2023, so there are likely no users left for these
boards. Time to mark them as deprecated in QEMU, too!
Signed-off-by
On 08/03/2024 15.00, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 12:54, Thomas Huth wrote:
I gave it a try, but then we end up again with the problem that I already
mentioned in the discussion about patch 1: CONFIG_ARM_V7M is not set for the
linux-user binaries, so m_helper.c would not get
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that require additional functions for linking. Use some
stubs functions that call g_assert_not_reached() instead.
Signed-off-by: Thomas Huth
---
target/arm/tcg/m_helper.c
rom the Kconfig file.
v3:
- Rebase to current master branch
- Make sure that the stubs use g_assert_not_reached() in the second patch
v2:
- Updated a comment
- Avoid #ifdef in cpu-v7m.c, handle it via meson.build instead
Thomas Huth (3):
target/arm: Move v7m-related code from cpu32.c into a se
Now that we made sure that ARM_V7M code only gets compiled if really
needed, we can drop the hard requirement for CONFIG_ARM_V7M in the
Kconfig file.
Signed-off-by: Thomas Huth
---
target/arm/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git a/target/arm/Kconfig b/target/arm/Kconfig
Move the code to a separate file so that we do not have to compile
it anymore if CONFIG_ARM_V7M is not set.
Signed-off-by: Thomas Huth
---
target/arm/tcg/cpu-v7m.c | 290 +
target/arm/tcg/cpu32.c | 261 -
target/arm
test(ms, &data, true);
-
-/* Unsupported parameters can be provided with their values as 1 */
-data.config.has_dies = true;
-data.config.dies = 1;
-smp_parse_test(ms, &data, true);
}
object_unref(obj);
Reviewed-by: Thomas Huth
On 06/03/2024 10.53, Zhao Liu wrote:
From: Zhao Liu
SMPConfiguration initializes its int64_t members as 0 by default.
Can we always rely on that? ... or is this just by luck due to the current
implementation? In the latter case, I'd maybe rather drop this patch again.
Thomas
Therefore,
On 04/03/2024 16.22, Peter Maydell wrote:
On Thu, 1 Feb 2024 at 19:12, Thomas Huth wrote:
On 01/02/2024 15.19, Peter Maydell wrote:
On Mon, 29 Jan 2024 at 08:18, Thomas Huth wrote:
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged
helper functions that re
On 08/03/2024 12.26, Peter Maydell wrote:
On Fri, 8 Mar 2024 at 06:01, Thomas Huth wrote:
If you try to run the configure script on a system without a working
C compiler, you get a very misleading error message:
ERROR: Unrecognized host OS (uname -s reports 'Linux')
We should r
Support for these boards has been removed from the Linux kernel
in version 6.3 in 2023, so there are likely no users left for these
boards. Time to mark them as deprecated in QEMU, too!
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 8
hw/arm/mainstone.c| 1 +
hw
On 08/03/2024 11.12, Zhao Liu wrote:
Hi Thomas,
void s390_realize_cpu_model(CPUState *cs, Error **errp)
{
+ERRP_GUARD();
Error *err = NULL;
I think that function could use an additional clean-up now: Remove the local
"err" variable and use "errp" only instead.
Since many c
On 08/03/2024 09.22, Peter Xu wrote:
On Fri, Mar 08, 2024 at 08:09:15AM +, Alex Bennée wrote:
Peter Xu writes:
On Thu, Mar 07, 2024 at 06:11:01PM +, Alex Bennée wrote:
The kernel-doc script does some pre-processing on structure
definitions before parsing for names. Teach it about QLI
: Christian Borntraeger
Cc: Thomas Huth
Signed-off-by: Cédric Le Goater
---
Reviewed-by: Thomas Huth
ave a hard time to figure
out what was going wrong.
Fixes: 264b803721 ("configure: remove compiler sanity check")
Signed-off-by: Thomas Huth
---
configure | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 3cd736b139..a036923dee 10
On 07/03/2024 22.22, Richard Henderson wrote:
On 3/7/24 07:43, Thomas Huth wrote:
+ /* Fix up legacy names with '+' in it */
+ if (g_str_equal(typename, SPARC_CPU_TYPE_NAME("Sun-UltraSparc-IV+"))) {
+ g_free(typename);
+ typename = g_strdup(SPAR
On 28/02/2024 17.43, Zhao Liu wrote:
Hi Philippe,
+/*
+ * Real ICH9 contains a single SMI output line and doesn't broadcast CPUs.
+ * Virtualized ICH9 allows broadcasting upon negatiation with guest, see
+ * commit 5ce45c7a2b.
+ */
+enum {
+ICH9_VIRT_SMI_BROADCAST,
+ICH9_VIRT_SMI_CURREN
On 04/03/2024 16.12, Anthony Krowiak wrote:
On 2/29/24 12:30 PM, Thomas Huth wrote:
On 29/02/2024 15.39, Zhao Liu wrote:
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD
For consistency we should drop the names with a "+" in it in the
long run.
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 8565644da6..7058341f8f 100644
Remove the unnecessary "Sparc" at the beginning of the line and
put the chip information into parentheses so that it is clearer
which part of the line have to be passed to "-cpu" to specify a
different CPU.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2141
Signed
Add some words about how to enable or disable boolean features,
and remove the note about a Linux kernel being available on the
QEMU website (they have been removed long ago already).
Signed-off-by: Thomas Huth
---
docs/system/target-sparc.rst | 8 ++--
1 file changed, 6 insertions(+), 2
vide
backward compatibility for the old names via some simple checks in the
sparc_cpu_class_by_name() function.
Signed-off-by: Thomas Huth
---
qom/object.c | 8
target/sparc/cpu.c | 14 --
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/qom/objec
s
since this character is now not allowed in device names anymore
(and was worked around with an ugly hack in qom/object.c so far).
Thomas Huth (5):
target/sparc/cpu: Rename the CPU models with a "+" in their names
target/sparc/cpu: Avoid spaces by default in the CPU names
target/s
Buglink: https://gitlab.com/qemu-project/qemu/-/issues/2141
Signed-off-by: Thomas Huth
---
target/sparc/cpu.c | 56 +++---
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 651e49bfeb..ae30cded2
On 06/03/2024 10.53, Zhao Liu wrote:
From: Zhao Liu
Currentlt, it was allowed for users to specify the unsupported
s/Currentlt/Currently/
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp drawers=1,books=
On 06/03/2024 10.53, Zhao Liu wrote:
From: Zhao Liu
Currentlt, it was allowed for users to specify the unsupported
s/Currentlt/Currently/
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp drawers=1,books=
mp-parse.c | 92 +
1 file changed, 92 insertions(+)
Reviewed-by: Thomas Huth
Xiaoling Song
---
tests/unit/test-smp-parse.c | 103
1 file changed, 103 insertions(+)
Reviewed-by: Thomas Huth
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index aea1b2e73a55..0cf611519865 100644
--- a/tests/unit/test-smp-p
RIC(T, 4096, F, 0, F, 0, F, 0, F, 0),
+.expect_error = "Invalid SMP CPUs 4096. The max CPUs supported "
You could maybe use stringify(MAX_CPUS) in above line
(but it won't work for the 4095 below, so it's maybe not worth the effort)
+"by machine '" SMP_MACHINE_NAME "' is 4095",
},
};
Reviewed-by: Thomas Huth
/pc.c | 19 ---
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
/pc.c | 19 ---
2 files changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
X86CPU::kvm_no_smi_migration was only used by the
pc-i440fx-2.3 machine, which got removed. Remove it
and simplify kvm_put_vcpu_events().
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.h | 3 ---
target/i386/cpu.c | 2 --
eviewed-by: Thomas Huth
eviewed-by: Thomas Huth
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
AcpiBuildState::rsdp is always NULL, remove it,
simplifying acpi_build_update().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-build.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Thomas Huth
1301 - 1400 of 5275 matches
Mail list logo
