D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:0d64bdd22e7c: Simplify minimum size handling (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77611=77612 REVISION DETAIL

D27952: Simplify minimum size handling

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77611. vkrause added a comment. Rebase and bump version numbers. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27952?vs=77302=77611 BRANCH arcpatch-D27952 REVISION DETAIL https://phabricator.kde.org/D27952

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:ea1f6c1abeb0: Move barcode image scaling logic to AbstractBarcode (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27909?vs=77158=77610

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:3d4b8780a8d5: Add API to check whether a barcode is one- or two-dimensional (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-14 Thread Volker Krause
vkrause updated this revision to Diff 77607. vkrause added a comment. Rebase and bump version number to 5.69. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=77128=77607 BRANCH arcpatch-D27730 REVISION DETAIL https://phabricator.kde.org/D27730

D28030: Also expose the true minimum size to QML

2020-03-13 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Useful in case you want to implement manual scaling there, for example. REPOSITORY

D27989: Add a new set of barcode size functions

2020-03-11 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY preferredSize() is an improvement over what minimumSize() used to do, with taking

D27916: Add Overpass QL highlighting

2020-03-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fdc762d23fdc: Add Overpass QL highlighting (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27916?vs=77179=77372#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause added a comment. The deprecation version is off by one, but that will be fixed when rebasing the entire patch set on 5.69 once 5.68 is released. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27952 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n,

D27952: Simplify minimum size handling

2020-03-09 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We don't need to track the minimum size separately anymore, so avoid this getting

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause updated this revision to Diff 77179. vkrause added a comment. Highlight the {{bbox}} Overpass Turbo placeholder. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27916?vs=77177=77179 BRANCH master REVISION DETAIL

D27916: Add Overpass QL highlighting

2020-03-07 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D27916 AFFECTED

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-07 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: svuorela. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes any kind of scaling from the specific implementations, they now

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-06 Thread Volker Krause
vkrause updated this revision to Diff 77128. vkrause added a comment. Alternative implementation for the barcode dimension API. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27730?vs=76661=77128 BRANCH pending REVISION DETAIL

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:10054afd8243: Remove empty/unused private classes on internal types (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27727?vs=76657=76965

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27595: Watch for language change events, and forward those to the QML engine

2020-03-04 Thread Volker Krause
vkrause added a comment. I can reproduce only if I set a valid translation catalog. Even more surprising since the affected dialog does not seem to contain any qsTr() translations. I don't think this patch is wrong as such, the layouting glitch is a bug elsewhere that we trigger by the

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

D26749: Support NDK r20 and Qt 5.14

2020-03-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c9ebd3917e59: Support NDK r20 and Qt 5.14 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26749?vs=73822=76876 REVISION DETAIL

[frameworks-kuserfeedback] [Bug 418330] kuserfeedback build looks for qt4 version of qmllint

2020-03-03 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=418330 --- Comment #1 from Volker Krause --- The Qt4 path isn't coming from kuserfeedback, all that's done there is `find_program(QMLLINT_EXECUTABLE qmllint)` (ie. find qmllint in $PATH). What does "which qmllint" report in the shell you trie

D26749: Support NDK r20 and Qt 5.14

2020-03-02 Thread Volker Krause
vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D26749: Support NDK r20 and Qt 5.14

2020-03-02 Thread Volker Krause
vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause
vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause
vkrause added a comment. In D26749#620142 , @apol wrote: > Seems ready to land to me. It does seem to break poppler in the old setup here, not sure yet why though. If we land the docker change as well that is probably acceptable though.

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters for user code doing some more advanced layouting or size computations, especially once we remove the

D27727: Remove empty/unused private classes on internal types

2020-02-28 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids unnecessary allocations. This also un-exports QRCodeBarcode, which is declared in a non-installed header

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R271:417607275368: Deprecate KDBusConnectionPool (authored by vkrause). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76316=76652 REVISION DETAIL

D27607: Deprecate KDBusConnectionPool

2020-02-28 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27607 To: vkrause Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

2020-02-27 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #32 from Volker Krause --- Git commit a092e5fc49c4058aafbfe52d1dad294f813954b4 by Volker Krause. Committed on 27/02/2020 at 17:51. Pushed by vkrause into branch 'master'. Correctly distinguish between SNCF and Ouigo PNRs In a mixed ticket

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-26 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > I did some testing and for me it works for arm64 but not for arm32. I actually didn't test 64bit ARM here, only armv7 and x86, both work. What does break for you there? REPOSITORY R240 Extra CMake Modules

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-26 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > I did some testing and for me it works for arm64 but not for arm32. I actually didn't test 64bit ARM here, only armv7 and x86, both work. What does break for you there? REPOSITORY R240 Extra CMake Modules

D27595: Watch for language change events, and forward those to the QML engine

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b7cae898ed7: Watch for language change events, and forward those to the QML engine (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27525: Support Qt 5.14 on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:8bf5b4675186: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27525?vs=76060=76477 REVISION DETAIL

D27596: Load QM files from assets: URLs on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27596?vs=76212=76476

D27596: Load QM files from assets: URLs on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27596?vs=76212=76476

Re: Regarding KDE Privacy policy

2020-02-25 Thread Volker Krause
Not publishing the raw data right from the start was mainly a safety measure, to give us a chance to review the data and fix de-anonymization issues should any have slipped through. There's also technical limitations, the current system has no fine-grained access control, not even read vs

D27596: Load QM files from assets: URLs on Android

2020-02-24 Thread Volker Krause
vkrause added a comment. In D27596#616554 , @apol wrote: > Don't we need an if Qt 5.13 elseif Qt 5.14? > > In other Qt versions it won't be in the assets... Are you sure about this? I had tested this on my Qt 5.13 setup and the files

D27596: Load QM files from assets: URLs on Android

2020-02-24 Thread Volker Krause
vkrause added a comment. In D27596#616554 , @apol wrote: > Don't we need an if Qt 5.13 elseif Qt 5.14? > > In other Qt versions it won't be in the assets... Are you sure about this? I had tested this on my Qt 5.13 setup and the files

D27595: Watch for language change events, and forward those to the QML engine

2020-02-24 Thread Volker Krause
vkrause added a comment. In D27595#616544 , @apol wrote: > I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. Right, or at least in QQmlApplicationEngine. REPOSITORY

D27607: Deprecate KDBusConnectionPool

2020-02-24 Thread Volker Krause
vkrause updated this revision to Diff 76316. vkrause added a comment. Set EXCLUDE_DEPRECATED_BEFORE_AND_AT. REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27607?vs=76241=76316 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27607

D27594: Remove unused KDBusConnectionPool include

2020-02-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:faace55f0bea: Remove unused KDBusConnectionPool include (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27594?vs=76207=76315 REVISION DETAIL

D27606: Remove usage of KDBusConnectionPool

2020-02-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R161:fa5b3bb382ac: Remove usage of KDBusConnectionPool (authored by vkrause). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27606?vs=76237=76248

D27607: Deprecate KDBusConnectionPool

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly

D27606: Remove usage of KDBusConnectionPool

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly in a

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This works with both the old and the new way of Qt's asset deployment, ie. with Qt 5.13

D27596: Load QM files from assets: URLs on Android

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This works with both the old and the new way of Qt's asset deployment, ie. with Qt 5.13

D27595: Watch for language change events, and forward those to the QML engine

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes a race condition on startup for the Kirigami translation catalog that happens as follows: - QML code triggers

D27594: Remove unused KDBusConnectionPool include

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KDBusConnectionPool is about to be deprecated. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-22 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R249:91c5e2ff604e: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76160=76161 REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-22 Thread Volker Krause
vkrause updated this revision to Diff 76160. vkrause added a comment. Improve compile-time conditional to only build the new code with Qt >= 5.14. REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27550?vs=76117=76160 BRANCH master REVISION DETAIL

D27550: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27550 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27550: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY With Qt 5.14 asset files are no longer extracted into the filesystem, they are only available via assert: or qrc:

D27525: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause added a comment. In D27525#614905 , @apol wrote: > > Assets (QML files and icons) are no longer extracted into the file system, > > but now are available in the android_rcc_bundle QRC file. > > Meaning that we now need to change

D27525: Support Qt 5.14 on Android

2020-02-20 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Assets (QML files and icons) are no longer extracted into the file system, but now are available in the android_rcc_bundle QRC

Re: Banning QNetworkAccessManager

2020-02-20 Thread Volker Krause
On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on

Re: Banning QNetworkAccessManager

2020-02-20 Thread Volker Krause
On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on

Re: Banning QNetworkAccessManager

2020-02-20 Thread Volker Krause
On Wednesday, 19 February 2020 10:04:11 CET Ben Cooksley wrote: > On Wed, Feb 19, 2020 at 9:30 PM Volker Krause wrote: > > On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > > > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > > > I agree on

[KDE Itinerary] [Bug 404451] sncf confirmation email types to help development

2020-02-19 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=404451 --- Comment #31 from Volker Krause --- Git commit 4b58675a4694136ffca0ed6e2f88846d38f4d592 by Volker Krause. Committed on 19/02/2020 at 17:46. Pushed by vkrause into branch 'master'. Add initial support for Ouigo tickets M +23 -1src/extractors

Re: Banning QNetworkAccessManager

2020-02-19 Thread Volker Krause
On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > O

Re: Banning QNetworkAccessManager

2020-02-19 Thread Volker Krause
On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > O

Re: Banning QNetworkAccessManager

2020-02-19 Thread Volker Krause
On Wednesday, 19 February 2020 08:05:01 CET Ben Cooksley wrote: > On Mon, Feb 3, 2020 at 7:42 AM Volker Krause wrote: > > I agree on the problem of QNAM's default, see also > > https://conf.kde.org/en/ > > akademy2019/public/events/135 on that subject. > > > > O

[KDE Itinerary] [Bug 417053] "send" feature fails

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417053 --- Comment #4 from Volker Krause --- Yes. Screenshots: https://kde.org/applications/utilities/org.kde.itinerary Download: https://community.kde.org/KDE_PIM/KDE_Itinerary#Getting_KDE_Itinerary -- You are receiving this mail because: You are watching

[KDE Itinerary] [Bug 416444] Booking.com hotel booking missing useful information

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416444 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[KDE Itinerary] [Bug 416444] Booking.com hotel booking missing useful information

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416444 --- Comment #2 from Volker Krause --- Right, the full extracted data is stored as a custom property in the ical data. Any compliant ical application should preserve that (and e.g. KOrganizer, Nextcloud and DavDroid do). Ideally all of that should also

[KDE Itinerary] [Bug 417053] "send" feature fails

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417053 --- Comment #2 from Volker Krause --- I think that's a misunderstanding, sending the data to the phone via KDE Connect should load it into the KDE Itinerary app there, not add it to the calendar. Shows we need to make this more clear in the UI though

[KDE Itinerary] [Bug 417650] Add booking to calendar

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417650 Volker Krause changed: What|Removed |Added Severity|normal |wishlist Ever confirmed|0

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the

[frameworks-kuserfeedback] [Bug 416061] Console freezes when plotting data

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416061 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

[frameworks-kuserfeedback] [Bug 417597] Parent loop for QLineSeries

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417597 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

Re: New Framework Review: KDAV

2020-02-15 Thread Volker Krause
On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav supp

Re: New Framework Review: KDAV

2020-02-15 Thread Volker Krause
On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav supp

[frameworks-kuserfeedback] [Bug 417597] Parent loop for QLineSeries

2020-02-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417597 --- Comment #2 from Volker Krause --- Is that Qt 5.14? Aleix also reported issues with the charts there I think, I am not seeing that with 5.13 though. -- You are receiving this mail because: You are watching all bug changes.

D27239: [android] Emit defaultActivated when tapping the notification

2020-02-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27187: update travel-family icons

2020-02-07 Thread Volker Krause
vkrause added a comment. Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-05 Thread Volker Krause
vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-05 Thread Volker Krause
vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26713: Adapt to Qt 5.14 Android changes

2020-01-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:41b270f06f6e: Adapt to Qt 5.14 Android changes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26713?vs=73726=73821 REVISION DETAIL

D26713: Adapt to Qt 5.14 Android changes

2020-01-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - Library names now have the ABI as a suffix, dependency files need to follow that. - The Gradle version shipped

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R296:3489a1d049fb: Port away from deprecated IconSize() method (authored by vkrause). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26603?vs=73332=7 REVISION

D26057: Deprecate the top-level IconSize() function

2020-01-12 Thread Volker Krause
vkrause added a comment. In D26057#592147 , @dfaure wrote: > Please port kdeclarative. > > kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope > > pixmap =

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26603

<    3   4   5   6   7   8   9   10   11   12   >