[KDE Itinerary] [Bug 416444] Booking.com hotel booking missing useful information

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416444 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[KDE Itinerary] [Bug 416444] Booking.com hotel booking missing useful information

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416444 --- Comment #2 from Volker Krause --- Right, the full extracted data is stored as a custom property in the ical data. Any compliant ical application should preserve that (and e.g. KOrganizer, Nextcloud and DavDroid do). Ideally all of that should also

[KDE Itinerary] [Bug 417053] "send" feature fails

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417053 --- Comment #2 from Volker Krause --- I think that's a misunderstanding, sending the data to the phone via KDE Connect should load it into the KDE Itinerary app there, not add it to the calendar. Shows we need to make this more clear in the UI t

[KDE Itinerary] [Bug 417650] Add booking to calendar

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417650 Volker Krause changed: What|Removed |Added Severity|normal |wishlist Ever confirmed|0

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the L

Re: New Framework Review: KDAV

2020-02-16 Thread Volker Krause
On Saturday, 15 February 2020 11:42:57 CET Andreas Cord-Landwehr wrote: > Hi, sorry for this very late mail, missed the call for reviews... > > Would it be possible to do some license clarifications before moving kdav > into the frameworks section? > > In mostly all files it is not clear if the L

[frameworks-kuserfeedback] [Bug 416061] Console freezes when plotting data

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=416061 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

[frameworks-kuserfeedback] [Bug 417597] Parent loop for QLineSeries

2020-02-16 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417597 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

Re: New Framework Review: KDAV

2020-02-15 Thread Volker Krause
On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav

Re: New Framework Review: KDAV

2020-02-15 Thread Volker Krause
On Saturday, 9 November 2019 12:33:54 CET Volker Krause wrote: > Hi, > > during Akademy there was a request to promote KDAV from KDE PIM to > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav

[frameworks-kuserfeedback] [Bug 417597] Parent loop for QLineSeries

2020-02-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=417597 --- Comment #2 from Volker Krause --- Is that Qt 5.14? Aleix also reported issues with the charts there I think, I am not seeing that with 5.13 though. -- You are receiving this mail because: You are watching all bug changes.

D27239: [android] Emit defaultActivated when tapping the notification

2020-02-08 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH defa REVISION DETAIL https://phabricator.kde.org/D27239 To: nicolasfella, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27187: update travel-family icons

2020-02-07 Thread Volker Krause
vkrause added a comment. Awesome work indeed, thanks! I've integrated that in the app, now trying to find all remaining uses of the old one elsewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27187 To: mbruchert, #vdg, ndavis Cc: vkrause, ngraham, nicola

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-05 Thread Volker Krause
vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240 Extra

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-05 Thread Volker Krause
vkrause added a comment. Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :) For icons we probably need a similar adjustment, I bet they got affected by the same Qt change. Same for translations I think, in ki18n. REPOSITORY R240 Extra

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned i

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned i

Re: Banning QNetworkAccessManager

2020-02-03 Thread Volker Krause
On Monday, 3 February 2020 10:49:10 CET David Edmundson wrote: > I updated: > > https://community.kde.org/Policies/API_to_Avoid > > Which had no mention of this. Thanks for taking care of this! I'd propose a slightly different approach than the per-request all-or-nothing attribute mentioned i

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a f

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a f

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a f

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a toolch

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a toolch

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsyst

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsyst

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided by

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided by

D26713: Adapt to Qt 5.14 Android changes

2020-01-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:41b270f06f6e: Adapt to Qt 5.14 Android changes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26713?vs=73726&id=73821 REVISION DETAIL

D26713: Adapt to Qt 5.14 Android changes

2020-01-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - Library names now have the ABI as a suffix, dependency files need to follow that. - The Gradle version shipped with

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R296:3489a1d049fb: Port away from deprecated IconSize() method (authored by vkrause). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26603?vs=73332&id=7 REVISI

D26057: Deprecate the top-level IconSize() function

2020-01-12 Thread Volker Krause
vkrause added a comment. In D26057#592147 , @dfaure wrote: > Please port kdeclarative. > > kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope > > pixmap = QIcon::fromTheme(source.at(0)).pixma

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26603 AF

D26532: Don't use KWindowSystem on Android

2020-01-08 Thread Volker Krause
vkrause added a comment. In D26532#590609 , @nicolasfella wrote: > In D26532#590598 , @vkrause wrote: > > > We are already not building a few things here on Android (including public API on other p

D26532: Don't use KWindowSystem on Android

2020-01-08 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an empty

D26472: Add GraphQL highlighting definition

2020-01-06 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e94fbd056539: Add GraphQL highlighting definition (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26472?vs=72913&id=72926 REVISIO

D26472: Add GraphQL highlighting definition

2020-01-06 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D26472 AFFECTED FI

Re: Proposal: Allow REUSE compatible License Statements in License Policy

2020-01-06 Thread Volker Krause
+1! More standardization and structure in the license information should simplify maintenance and validation of this information, even better if it's following a global standard :) Thanks for working on this, Volker On Sunday, 5 January 2020 16:40:20 CET Andreas Cord-Landwehr wrote: > Hi, I wan

Re: List of available sprint venues for 2020 and beyond

2020-01-05 Thread Volker Krause
On Saturday, 4 January 2020 15:01:15 CET Eike Hein wrote: > Dear community, > > Happy new year! > > Recently, we've gotten approached a few times with offers of venues for KDE > events/sprints. One such case was the MBition office, which resulted in the > recent Frameworks 6 sprint held there. An

D26313: Add application/vnd.apple.pkpass icon

2019-12-31 Thread Volker Krause
vkrause added a comment. Awesome, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26313 To: broulik, #vdg, vkrause, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26273: cmake: don't use taglib-config if we are cross compiling

2019-12-29 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this. REPOSITORY R2

Re: KDE Itinerary in kdereview

2019-12-29 Thread Volker Krause
day, 8 December 2019 13:14:43 CET Volker Krause wrote: > Hi, > > KDE Itinerary has been moved to kdereview: > > Code: https://invent.kde.org/kde/itinerary > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > > KDE Itinerary is a Kirigami-based mobile appli

[KDE Itinerary] [Bug 415613] KLM Flight booking not imported from pdf ticket

2019-12-28 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=415613 --- Comment #1 from Volker Krause --- Not much we can do without the ticket indeed (or even better the full email it came with, if it came by email, forwarded as attachment). If you are ok with sharing that privately, please forward it to vkra

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-27 Thread Volker Krause
On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > > On Sunday, 22 December 2019 09:46:02 C

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-27 Thread Volker Krause
On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > > On Sunday, 22 December 2019 09:46:02 C

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-23 Thread Volker Krause
On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > Hi all, > > in any case, maybe the discussed points should go to the KF6 workboard? > https://phabricator.kde.org/project/view/310/ > > I indeed believe that consistency in the KF5 world is an important feature, > so Friedrich does

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-23 Thread Volker Krause
On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > Hi all, > > in any case, maybe the discussed points should go to the KF6 workboard? > https://phabricator.kde.org/project/view/310/ > > I indeed believe that consistency in the KF5 world is an important feature, > so Friedrich does

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Volker Krause
On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote: > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > > > I've pushed a few commits to make it depend on ECM etc. > > > > Once the r

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Volker Krause
On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote: > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > > > I've pushed a few commits to make it depend on ECM etc. > > > > Once the r

Re: KDE Itinerary in kdereview

2019-12-20 Thread Volker Krause
On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote: > Hi, > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/kde/itinerary > > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > > > > KDE Itinerary is a Kirigami-based mobile applicat

D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26103 To: vonreth, sitter, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R295:3f5a2879e99c: Port from KDE::icon to KIconUtils for getting icon overlays (authored by vkrause). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26073?vs=71740&id=7

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R128:39ce0e82856e: Port away from KIconThemes (authored by vkrause). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26072?vs=71738&id=71745 REVISION DETAIL https

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-17 Thread Volker Krause
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraha

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This also removes the last uses of KIconThemes from here. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This was only using the deprecated IconSize() method. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://ph

D26057: Deprecate the top-level IconSize() function

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26057?vs=71689&id=71737 REVISIO

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes the last of the non-namespaced top-level functions here as well. REPOSITORY R302 KIconThemes BRANCH

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R174:ce6699a141a0: Align ECM and Qt setup with Frameworks conventions (authored by vkrause). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71575&id=71576 RE

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause updated this revision to Diff 71575. vkrause added a comment. Remove duplicate include. REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71573&id=71575 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26011 AFFECTED FILES

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This completes the previous commit which provided the hotfix for the ECM version lookup issue breaking the build. REP

D26009: KCoreAddons: fix compilation with qtbase git dev branch

2019-12-15 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26009 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25960: [calendar] Check out of bounds array access in QLocale lookup

2019-12-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25960 To: davidedmundson, #plasma, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, b

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #81 from Volker Krause --- The change has been added to the 5.65.0 KIO release tarball. -- You are receiving this mail because: You are watching all bug changes.

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #79 from Volker Krause --- Thanks for the feedback. I'll see if we can still get that patch into the 5.65 release due tomorrow. The repeated display of this dialog is of course not addressed by this patch, that's an issue in the

Re: KDE Frameworks 5.65.0

2019-12-13 Thread Volker Krause
On Sunday, 8 December 2019 11:45:05 CET David Faure wrote: > Dear packagers, > > KDE Frameworks 5.65.0 has been uploaded to the usual place. > > New frameworks: KQuickCharts. > > Public release next Saturday. > > Thanks for the packaging work! https://bugs.kde.org/show_bug.cgi?id=233628 sugges

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #77 from Volker Krause --- With KIO 5.64/5.65 and a stand-alone test case (https://invent.kde.org/vkrause/http-demo) I can reproduce this against https://untrusted-root.badssl.com/ (and only that, https://self-signed.badssl.com/ works for

Re: Add kdeconnect-kde to release service

2019-12-12 Thread Volker Krause
On Thursday, 12 December 2019 18:44:30 CET Nicolas Fella wrote: > On Donnerstag, 12. Dezember 2019 18:17:45 CET Volker Krause wrote: > > I think in general it would be very nice to have those includable as well, > > following a standardized branching and versioning model and

Re: Add kdeconnect-kde to release service

2019-12-12 Thread Volker Krause
On Wednesday, 11 December 2019 17:09:11 CET Nicolas Fella wrote: > Hi, > > we would like for KDE Connect to be included in the release service > beginning with the 20.04 release. > > As discussed with Jonathan I've moved the metadata to from extragear/network > to kde/kdeutils. > > I'm unsure ab

D25924: fix static linking on e.g. macOS

2019-12-12 Thread Volker Krause
vkrause added a comment. This looks wrong though, QtNetwork is not used in the public interface, is it? And the cmake config files are supposed to propagate private link libraries in case of static linking too I think, otherwise LINK_PRIVATE could basically never work, no? REPOSITORY R216

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-12 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #74 from Volker Krause --- Which versions of KIO and KIMAP do you have? -- You are receiving this mail because: You are watching all bug changes.

D25858: Use QStyle for determining icon sizes

2019-12-11 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:34aeee14693b: Use QStyle for determining icon sizes (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25858?vs=71214&id=71308 REVISION DETAIL htt

D25858: Use QStyle for determining icon sizes

2019-12-11 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-11 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > xmlextractor.cpp:33 > +inline QString rdfNS(){ return > QStringLiteral("https://www.w3.org/1999/02/22-rdf-syntax-ns#";); } > +inline QString ccNS() { return > QStringLiteral("https://creativecommons.org/ns#";); } > sure about those? th

Re: KDE Itinerary in kdereview

2019-12-10 Thread Volker Krause
ry > https://community.kde.org/KDE_PIM/KItinerary Thanks, all of the above should be fixed now. Regards, Volker > On Sun, 8 Dec 2019 at 12:16, Volker Krause wrote: > > Hi, > > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/

D25858: Use QStyle for determining icon sizes

2019-12-10 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This should remove the last use of the IconSize() top-level function from Frameworks, in preparation of deprecating th

Re: KDE Itinerary in kdereview

2019-12-09 Thread Volker Krause
On Sunday, 8 December 2019 14:07:57 CET Christophe Giboudeaux wrote: > Hey, > > On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote: > > Hi, > > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/kde/itinerary >

D25371: Remove porting scaffolding, this is entirely on QSslError now

2019-12-09 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3c9bac61808d: Remove porting scaffolding, this is entirely on QSslError now (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25371?vs=69940&id=7113

KDE Itinerary in kdereview

2019-12-08 Thread Volker Krause
Hi, KDE Itinerary has been moved to kdereview: Code: https://invent.kde.org/kde/itinerary Workboard: https://phabricator.kde.org/project/board/280/query/all/ KDE Itinerary is a Kirigami-based mobile application for managing your itinerary as a timeline, including access to your travel documents

[KDE Itinerary] [Bug 413756] Ad calculation and compensation of CO2-emissions

2019-12-08 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=413756 --- Comment #3 from Volker Krause --- Statistics page with CO2 impact estimation and year-by-year trends has been added now. -- You are receiving this mail because: You are watching all bug changes.

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread Volker Krause
Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message viewer for years. Moving to a faster and, more importantly, predictable release cycle would help us a lot with u

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread Volker Krause
Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message viewer for years. Moving to a faster and, more importantly, predictable release cycle would help us a lot with u

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Volker Krause
On Tuesday, 3 December 2019 22:13:43 CET Allen Winter wrote: > On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > > The complexity of the dependency graph is also a problem for onboarding > > new > > people, and with kdelibs4support gone IMHO the largest te

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Volker Krause
On Tuesday, 3 December 2019 22:13:43 CET Allen Winter wrote: > On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > > The complexity of the dependency graph is also a problem for onboarding > > new > > people, and with kdelibs4support gone IMHO the largest te

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > >

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > >

D25311: Add KColumnHeadersProxyModel

2019-12-02 Thread Volker Krause
vkrause added a comment. In D25311#570700 , @ahiemstra wrote: > @vkrause Is the updated version more what you expected? Yep, thanks, this addresses my concerns. So +1 from me on this. REPOSITORY R275 KItemModels REVISION DETAIL http

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25511: Drop unused broken KGesture support

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson, vkrause Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25671: Fix git builds against Qt 5.14

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25671 To: apol, #frameworks, vkrause Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > sigh... > > > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: > > [...] > > > > > Which is where the problem with PIM

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > sigh... > > > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: > > [...] > > > > > Which is where the problem with PIM

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
sigh... On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > Which is where the problem with PIM comes in - because it currently > has many repositories failing to build from source on all platforms > those builds are enabled for (including Linux and FreeBSD). looking at this ri

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
sigh... On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > Which is where the problem with PIM comes in - because it currently > has many repositories failing to build from source on all platforms > those builds are enabled for (including Linux and FreeBSD). looking at this ri

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R223:6cf2242cd94b: Port away from deprecated Bar|Desktop|SmallIcon methods (authored by vkrause). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25553?vs=70366&id=70599

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-28 Thread Volker Krause
vkrause added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25553 To: vkrause, aacid Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25552: Deprecate top-level UserIcon method, no longer used

2019-11-27 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:312f27f31199: Deprecate top-level UserIcon method, no longer used (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25552?vs=70364&id=70450

<    4   5   6   7   8   9   10   11   12   13   >