Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Ingo Molnar wrote: * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: I had just sent this out for internal review... I think Jan's approach is better if it works (since there's no compromise), but this is better if you want to get something working in the near term. yeah.

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: I think Jan's approach is better if it works (since there's no compromise), but this is better if you want to get something working in the near term. Is Jan dynamically relinking the vdso at runtime? Because that is what we will need. Adding support for

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
PAT_VDSO kernels to relocate the fixmap as well, just disable the VDSO if they do so. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r fad0910252d2 arch/i386/kernel/sysenter.c --- a/arch/i386/kernel/sysenter.c Mon Mar 05 15:24:04 2007 -0800 +++ b/arch/i386/kernel/sysenter.c

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Ingo Molnar wrote: there's no need to disable the VDSO for old userspace ... Well, apart from the obvious question to which nobody actually knows the answer, (how many people run old user space that required CONFIG_COMPAT_VDSO), what do you think of reversing the boot option?

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: The boot option is already there, but boot options for is not my idea of user friendly binary compatibility. Yes, not friendly. Perhaps we can reverse the boot option? I.e make vdso_enable=force re-activate the vdso even if it gets moved by a hypervisor and COMPAT_VDSO

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: But this still means I would need to decide between a PARAVIRT kernel that either supports xen/VMI or cannot boot old user land without weird options. I don't think that's the correct solution. The goal is a single binary that runs everywhere and is still compatible.

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: But this still means I would need to decide between a PARAVIRT kernel that either supports xen/VMI or cannot boot old user land without weird options. I don't think that's the correct solution. The goal is a single binary that runs everywhere and is still compatible.

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: The boot option is already there, but boot options for is not my idea of user friendly binary compatibility. Yes, not friendly. Perhaps we can reverse the boot option? I.e make vdso_enable=force re-activate the vdso even if it gets moved by a hypervisor and COMPAT_VDSO

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
to relocate the fixmap as well, just disable the VDSO if they do so. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r fad0910252d2 arch/i386/kernel/sysenter.c --- a/arch/i386/kernel/sysenter.c Mon Mar 05 15:24:04 2007 -0800 +++ b/arch/i386/kernel/sysenter.c Mon Mar 05 15:27:31 2007

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: I think Jan's approach is better if it works (since there's no compromise), but this is better if you want to get something working in the near term. Is Jan dynamically relinking the vdso at runtime? Because that is what we will need. Adding support for

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: But this still means I would need to decide between a PARAVIRT kernel that either supports xen/VMI or cannot boot old user land without weird options. I don't think that's the correct solution. The goal is a single binary that runs everywhere and is still compatible.

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Andi Kleen wrote: The boot option is already there, but boot options for is not my idea of user friendly binary compatibility. Yes, not friendly. Perhaps we can reverse the boot option? I.e make vdso_enable=force re-activate the vdso even if it gets moved by a hypervisor and COMPAT_VDSO

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Ingo Molnar wrote: there's no need to disable the VDSO for old userspace ... Well, apart from the obvious question to which nobody actually knows the answer, (how many people run old user space that required CONFIG_COMPAT_VDSO), what do you think of reversing the boot option?

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
to relocate the fixmap as well, just disable the VDSO if they do so. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r fad0910252d2 arch/i386/kernel/sysenter.c --- a/arch/i386/kernel/sysenter.c Mon Mar 05 15:24:04 2007 -0800 +++ b/arch/i386/kernel/sysenter.c Mon Mar 05 15:27:31 2007

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: I think Jan's approach is better if it works (since there's no compromise), but this is better if you want to get something working in the near term. Is Jan dynamically relinking the vdso at runtime? Because that is what we will need. Adding support for

Re: [patch] paravirt: VDSO page is essential

2007-03-05 Thread Zachary Amsden
Ingo Molnar wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: I had just sent this out for internal review... I think Jan's approach is better if it works (since there's no compromise), but this is better if you want to get something working in the near term. yeah. (plus

Re: [2.6 patch] make arch/i386/kernel/vmi.c:vmi_pmd_clear() static

2007-03-04 Thread Zachary Amsden
VMI_PAGE_PMD); Acked-by: Zachary Amsden <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [-mm patch] remove arch/i386/kernel/tsc.c:custom_sched_clock

2007-03-04 Thread Zachary Amsden
g long (*custom_sched_clock)(void); int tsc_disable; Acked-by: Zachary Amsden <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [-mm patch] arch/i386/kernel/vmi.c must #include

2007-03-04 Thread Zachary Amsden
. Acked-by: Zachary Amsden <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [-mm patch] arch/i386/kernel/vmi.c must #include asm/kmap_types.h

2007-03-04 Thread Zachary Amsden
. Acked-by: Zachary Amsden [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [-mm patch] remove arch/i386/kernel/tsc.c:custom_sched_clock

2007-03-04 Thread Zachary Amsden
(*custom_sched_clock)(void); int tsc_disable; Acked-by: Zachary Amsden [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [2.6 patch] make arch/i386/kernel/vmi.c:vmi_pmd_clear() static

2007-03-04 Thread Zachary Amsden
); Acked-by: Zachary Amsden [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: I can deal with the change going into -git, but it does seem awkward knowing that it is the wrong change and it will be replaced by something else almost immediately. Well, it is not quite wrong - it is appropriate for -git. That it will be replaced soon is a

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Those are bugs that can occur, but they don't apply in this case. The vmi implementation of kmap_atomic_pte() would be: static void *vmi_kmap_atomic_pte(struct page *page, enum km_type type) { void *ptep = kmap_atomic(page, type);

Re: system call time increase when turning on CONFIG_PARAVIRT

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Tim Chen wrote: I also hope that the performance can be recovered as this option could enabled in distributions' kernels in future. Yes, the intent is that running a CONFIG_PARAVIRT kernel on native hardware will have negligible performance hit compared to

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Yeah, actually that does work, since you pass the km_type, we can use that. But I would rather not respin this for 2.6.21; getting this 100% right can be tricky, and we've already done a good deal of testing on this patch the way

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Yeah, actually that does work, since you pass the km_type, we can use that. But I would rather not respin this for 2.6.21; getting this 100% right can be tricky, and we've already done a good deal of testing on this patch the way

Re: system call time increase when turning on CONFIG_PARAVIRT

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Tim Chen wrote: I also hope that the performance can be recovered as this option could enabled in distributions' kernels in future. Yes, the intent is that running a CONFIG_PARAVIRT kernel on native hardware will have negligible performance hit compared

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Those are bugs that can occur, but they don't apply in this case. The vmi implementation of kmap_atomic_pte() would be: static void *vmi_kmap_atomic_pte(struct page *page, enum km_type type) { void *ptep = kmap_atomic(page, type);

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Yeah, actually that does work, since you pass the km_type, we can use that. But I would rather not respin this for 2.6.21; getting this 100% right can be tricky, and we've already done a good deal of testing on this patch the way

Re: system call time increase when turning on CONFIG_PARAVIRT

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Tim Chen wrote: I also hope that the performance can be recovered as this option could enabled in distributions' kernels in future. Yes, the intent is that running a CONFIG_PARAVIRT kernel on native hardware will have negligible performance hit compared to

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Those are bugs that can occur, but they don't apply in this case. The vmi implementation of kmap_atomic_pte() would be: static void *vmi_kmap_atomic_pte(struct page *page, enum km_type type) { void *ptep = kmap_atomic(page, type);

Re: [PATCH 4/9] Vmi fix highpte

2007-03-02 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: I can deal with the change going into -git, but it does seem awkward knowing that it is the wrong change and it will be replaced by something else almost immediately. Well, it is not quite wrong - it is appropriate for -git. That it will be replaced soon is a

Re: [PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Hm, I don't think this interface will work for Xen. In Xen, whenever a pagetable page gets mapped, it must be mapped RO. map_pt_hook gets called after the mapping has already been created, so its too late for Xen. I was planning on

Re: [PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Hm, I don't think this interface will work for Xen. In Xen, whenever a pagetable page gets mapped, it must be mapped RO. map_pt_hook gets called after the mapping has already been created, so its too late for Xen. I was planning on

[PATCH 7/9] Fix nohz compile.patch

2007-03-01 Thread Zachary Amsden
this is done in the common infrastructure. This actually fixes a timer bug as well, that was caused by do_settimeofday no longer being callable with interrupts disabled due to the use of on_each_cpu(). Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r 5d41588419ab arch/i386/Kconfig --- a/arc

[PATCH 6/9] Pit override.patch

2007-03-01 Thread Zachary Amsden
it, which is the time init function used for native hardware. Paravirt guests have the chance to override this when they setup the paravirt-ops table, and should need no change. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r 2ae8eb19b227 arch/i386/kernel/paravirt.c --- a/arch/i386/ke

[PATCH 9/9] Vmi smp fixes.patch

2007-03-01 Thread Zachary Amsden
Critical fixes for SMP. Fix a couple functions which needed to be __devinit and fix a bogus parameter to AP startup that just so happened to work because the low virtual mapping of memory was still established. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r baf2e278a482 arc

[PATCH 8/9] Vmi apic ops.diff

2007-03-01 Thread Zachary Amsden
done. Basically, we should never assume that the ROM implements a specific set of functions, and always allow fallback to the native implementation. This is critical for future compatibility. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> Signed-off-by: Zachary Amsden <[EMAIL

[PATCH 5/9] Paravirt drop udelay op

2007-03-01 Thread Zachary Amsden
of misvirtualization bugs, and Alan and Pavel argued pretty strongly against it. We were the only client, and now want to clean up this cruft. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r 135d1b73c878 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 16

[PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
for this header. This patch is absolutely required for HIGHPTE kernels to operate properly with VMI. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r 87bf6b2d338d arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 14:14:34 2007 -0800 +++ b/arch/i386/kernel/para

[PATCH 3/9] Vmi cpu cycles.patch

2007-03-01 Thread Zachary Amsden
the guest can make accurate time calculations with the cycle counters. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r b8b315c897bb arch/i386/kernel/vmi.c --- a/arch/i386/kernel/vmi.cTue Feb 27 14:04:43 2007 -0800 +++ b/arch/i386/kernel/vmi.cTue Feb 27 14:06:46 2007 -0800 @@

[PATCH 1/9] Vmi timer fixes round two.patch

2007-03-01 Thread Zachary Amsden
. This is useful as a last minute workaround, or testing measure. 4) The code to skip the IO_APIC timer testing (no_timer_check) should be conditional on IO_APIC, not SMP, since UP kernels can have this configured in as well. Signed-off-by: Dan Hecht <[EMAIL PROTECTED]> Signed-off-by: Z

[PATCH 2/9] Sched clock paravirt op fix.patch

2007-03-01 Thread Zachary Amsden
ashamedly admit I hacked in to try to get this to work earlier, and then even got in the wrong units. Please apply. Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> diff -r d58e6ddfdfa9 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Thu Feb 15 23:52:41 2007 -0800 +++ b/arc

[PATCH 0/9] Bugfix patches for i386/vmi/paravirt-ops

2007-03-01 Thread Zachary Amsden
Andi, Linus, we have some critical bugfixes for the VMI paravirt-ops code. Please apply. If there are objections to certain pieces, they can be reworked, but they are pretty much all needed for correctness. We are hoping to get these in the next 2.6.21-rc release. We had quite a few

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Things like what? Do you mean the %[foo] asm parameter syntax? I think those versions are no longer supported - Arjan posted a patch a few days ago to convert a pile of asms to this form. Or do you mean something else? I meant

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Jeremy Fitzhardinge wrote: Fix a few clobbers to include the return register. The clobbers set is the set of all registers modified (or may be modified) by the code snippet, regardless of whether it was deliberate or accidental. Signed

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Rusty Russell <[EMAIL PROTECTED]> Cc: Zachary Amsden <[EMAIL PROTECTED]> --- include/asm-i386/paravirt.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) === --- a/include/asm-i386/paravirt.h +++ b/include/a

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: The handler for smp_call_function() is called with local interrupts disabled (from the IPI handler). So to provide a consistent call environment for that handler, on_each_cpu() will also disable local interrupts when making the direct call on this CPU. Similarly the

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: On Thu, 01 Mar 2007 03:34:18 -0800 Zachary Amsden <[EMAIL PROTECTED]> wrote: Why is it a bug? Because there's a deadlock where this CPU is waiting for CPU A to take the IPI, but CPU A is waiting (with interrupts disabled) for this CPU to take

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Rusty Russell wrote: On Thu, 2007-03-01 at 03:34 -0800, Zachary Amsden wrote: What would be really, really nice would be to statically check all callsites that issue irq disables actually keep irqs disabled. Presumably, there was a reason they disabled irqs, and re-enabling them

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: On Thu, 01 Mar 2007 02:34:02 -0800 Zachary Amsden <[EMAIL PROTECTED]> wrote: I think on_each_cpu has a serious bug now that hrtimers has been integrated. Basically, there are many callsites of clock_was_set, none of which actually know the current interrupt

Re: Where does vmi_apply_boot_page_allocations ever get called?

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Because I need a hook for do stuff after mem_map is valid too. We didn't add a hook, but I can say it was somewhere in arch/i386/kernel/setup.c - should be after zone_sizes_init(). I'm no longer sure how to resurrect the original

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Things like what? Do you mean the %[foo] asm parameter syntax? I think those versions are no longer supported - Arjan posted a patch a few days ago to convert a pile of asms to this form. Or do you mean something else? I

[PATCH 0/9] Bugfix patches for i386/vmi/paravirt-ops

2007-03-01 Thread Zachary Amsden
Andi, Linus, we have some critical bugfixes for the VMI paravirt-ops code. Please apply. If there are objections to certain pieces, they can be reworked, but they are pretty much all needed for correctness. We are hoping to get these in the next 2.6.21-rc release. We had quite a few

[PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
for this header. This patch is absolutely required for HIGHPTE kernels to operate properly with VMI. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 87bf6b2d338d arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 14:14:34 2007 -0800 +++ b/arch/i386/kernel/paravirt.c

[PATCH 5/9] Paravirt drop udelay op

2007-03-01 Thread Zachary Amsden
of misvirtualization bugs, and Alan and Pavel argued pretty strongly against it. We were the only client, and now want to clean up this cruft. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 135d1b73c878 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 16:23:56 2007

[PATCH 8/9] Vmi apic ops.diff

2007-03-01 Thread Zachary Amsden
done. Basically, we should never assume that the ROM implements a specific set of functions, and always allow fallback to the native implementation. This is critical for future compatibility. Signed-off-by: Anthony Liguori [EMAIL PROTECTED] Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff

[PATCH 9/9] Vmi smp fixes.patch

2007-03-01 Thread Zachary Amsden
Critical fixes for SMP. Fix a couple functions which needed to be __devinit and fix a bogus parameter to AP startup that just so happened to work because the low virtual mapping of memory was still established. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r baf2e278a482 arch/i386

Re: [PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Hm, I don't think this interface will work for Xen. In Xen, whenever a pagetable page gets mapped, it must be mapped RO. map_pt_hook gets called after the mapping has already been created, so its too late for Xen. I was planning on

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: On Thu, 01 Mar 2007 02:34:02 -0800 Zachary Amsden [EMAIL PROTECTED] wrote: I think on_each_cpu has a serious bug now that hrtimers has been integrated. Basically, there are many callsites of clock_was_set, none of which actually know the current interrupt state

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Rusty Russell wrote: On Thu, 2007-03-01 at 03:34 -0800, Zachary Amsden wrote: What would be really, really nice would be to statically check all callsites that issue irq disables actually keep irqs disabled. Presumably, there was a reason they disabled irqs, and re-enabling them

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: On Thu, 01 Mar 2007 03:34:18 -0800 Zachary Amsden [EMAIL PROTECTED] wrote: Why is it a bug? Because there's a deadlock where this CPU is waiting for CPU A to take the IPI, but CPU A is waiting (with interrupts disabled) for this CPU to take an IPI

Re: Bug in on_each_cpu?

2007-03-01 Thread Zachary Amsden
Andrew Morton wrote: The handler for smp_call_function() is called with local interrupts disabled (from the IPI handler). So to provide a consistent call environment for that handler, on_each_cpu() will also disable local interrupts when making the direct call on this CPU. Similarly the

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Russell [EMAIL PROTECTED] Cc: Zachary Amsden [EMAIL PROTECTED] --- include/asm-i386/paravirt.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) === --- a/include/asm-i386/paravirt.h +++ b/include/asm-i386/paravirt.h

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Jeremy Fitzhardinge wrote: Fix a few clobbers to include the return register. The clobbers set is the set of all registers modified (or may be modified) by the code snippet, regardless of whether it was deliberate or accidental. Signed

Re: [patch 12/26] Xen-paravirt_ops: Fix patch site clobbers to include return register

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Things like what? Do you mean the %[foo] asm parameter syntax? I think those versions are no longer supported - Arjan posted a patch a few days ago to convert a pile of asms to this form. Or do you mean something else? I meant

[PATCH 0/9] Bugfix patches for i386/vmi/paravirt-ops

2007-03-01 Thread Zachary Amsden
Andi, Linus, we have some critical bugfixes for the VMI paravirt-ops code. Please apply. If there are objections to certain pieces, they can be reworked, but they are pretty much all needed for correctness. We are hoping to get these in the next 2.6.21-rc release. We had quite a few

[PATCH 1/9] Vmi timer fixes round two.patch

2007-03-01 Thread Zachary Amsden
. This is useful as a last minute workaround, or testing measure. 4) The code to skip the IO_APIC timer testing (no_timer_check) should be conditional on IO_APIC, not SMP, since UP kernels can have this configured in as well. Signed-off-by: Dan Hecht [EMAIL PROTECTED] Signed-off-by: Zachary Amsden

[PATCH 2/9] Sched clock paravirt op fix.patch

2007-03-01 Thread Zachary Amsden
ashamedly admit I hacked in to try to get this to work earlier, and then even got in the wrong units. Please apply. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r d58e6ddfdfa9 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Thu Feb 15 23:52:41 2007 -0800 +++ b/arch/i386

[PATCH 3/9] Vmi cpu cycles.patch

2007-03-01 Thread Zachary Amsden
the guest can make accurate time calculations with the cycle counters. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r b8b315c897bb arch/i386/kernel/vmi.c --- a/arch/i386/kernel/vmi.cTue Feb 27 14:04:43 2007 -0800 +++ b/arch/i386/kernel/vmi.cTue Feb 27 14:06:46 2007 -0800 @@ -874,6

[PATCH 5/9] Paravirt drop udelay op

2007-03-01 Thread Zachary Amsden
of misvirtualization bugs, and Alan and Pavel argued pretty strongly against it. We were the only client, and now want to clean up this cruft. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 135d1b73c878 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 16:23:56 2007

[PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
for this header. This patch is absolutely required for HIGHPTE kernels to operate properly with VMI. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 87bf6b2d338d arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c Tue Feb 27 14:14:34 2007 -0800 +++ b/arch/i386/kernel/paravirt.c

[PATCH 8/9] Vmi apic ops.diff

2007-03-01 Thread Zachary Amsden
done. Basically, we should never assume that the ROM implements a specific set of functions, and always allow fallback to the native implementation. This is critical for future compatibility. Signed-off-by: Anthony Liguori [EMAIL PROTECTED] Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff

[PATCH 9/9] Vmi smp fixes.patch

2007-03-01 Thread Zachary Amsden
Critical fixes for SMP. Fix a couple functions which needed to be __devinit and fix a bogus parameter to AP startup that just so happened to work because the low virtual mapping of memory was still established. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r baf2e278a482 arch/i386

[PATCH 6/9] Pit override.patch

2007-03-01 Thread Zachary Amsden
is the time init function used for native hardware. Paravirt guests have the chance to override this when they setup the paravirt-ops table, and should need no change. Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 2ae8eb19b227 arch/i386/kernel/paravirt.c --- a/arch/i386/kernel/paravirt.c

[PATCH 7/9] Fix nohz compile.patch

2007-03-01 Thread Zachary Amsden
this is done in the common infrastructure. This actually fixes a timer bug as well, that was caused by do_settimeofday no longer being callable with interrupts disabled due to the use of on_each_cpu(). Signed-off-by: Zachary Amsden [EMAIL PROTECTED] diff -r 5d41588419ab arch/i386/Kconfig --- a/arch/i386

Re: [PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Hm, I don't think this interface will work for Xen. In Xen, whenever a pagetable page gets mapped, it must be mapped RO. map_pt_hook gets called after the mapping has already been created, so its too late for Xen. I was planning on

Re: [PATCH 4/9] Vmi fix highpte

2007-03-01 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Jeremy Fitzhardinge wrote: Hm, I don't think this interface will work for Xen. In Xen, whenever a pagetable page gets mapped, it must be mapped RO. map_pt_hook gets called after the mapping has already been created, so its too late for Xen. I was planning on

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: It would be really great if one could write a ROM by just specifying a GetRelocationInfo function that always returns rel.type == NONE. Right now, there are a half a dozen or so ops that have to be implemented b/c of the vmi_get_function stuff. Yes, I need to clean

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native version of the apic write

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native version of the apic write

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: It would be really great if one could write a ROM by just specifying a GetRelocationInfo function that always returns rel.type == NONE. Right now, there are a half a dozen or so ops that have to be implemented b/c of the vmi_get_function stuff. Yes, I need to clean

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Zachary Amsden
Andi Kleen wrote: /* +* Temporary hack: zero gs now that we've saved it so that Xen +* doesn't try to reload the old value after changing the GDT +* during the context switch. This can go away once Xen has +* been taught to only reload %gs when it

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-21 Thread Zachary Amsden
Christoph Lameter wrote: On Sat, 17 Feb 2007, Andi Kleen wrote: That was always its intention. It's not a direct interface to a hypervisor, but an somewhat abstracted interface to a "hypervisor driver" I thought that hypervisor driver was some binary blob that can be directly

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-21 Thread Zachary Amsden
Christoph Lameter wrote: On Sat, 17 Feb 2007, Andi Kleen wrote: That was always its intention. It's not a direct interface to a hypervisor, but an somewhat abstracted interface to a hypervisor driver I thought that hypervisor driver was some binary blob that can be directly

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Zachary Amsden
Andi Kleen wrote: /* + * Temporary hack: zero gs now that we've saved it so that Xen + * doesn't try to reload the old value after changing the GDT + * during the context switch. This can go away once Xen has + * been taught to only reload %gs when it absolutely must. +

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-21 Thread Zachary Amsden
Christoph Lameter wrote: On Sat, 17 Feb 2007, Andi Kleen wrote: That was always its intention. It's not a direct interface to a hypervisor, but an somewhat abstracted interface to a hypervisor driver I thought that hypervisor driver was some binary blob that can be directly accessed

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Zachary Amsden
Andi Kleen wrote: /* +* Temporary hack: zero gs now that we've saved it so that Xen +* doesn't try to reload the old value after changing the GDT +* during the context switch. This can go away once Xen has +* been taught to only reload %gs when it

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-16 Thread Zachary Amsden
Christoph Lameter wrote: On Fri, 16 Feb 2007, Zachary Amsden wrote: Yes, but that is just because the Xen hooks happens to be near the last part of the merge. VMI required some special hooks, as do both Xen and lhype (I think ... Rusty can correct me if lhype's puppy's have precluded

Re: [Xen-devel] Re: [patch 14/21] Xen-paravirt: Add XEN config options and disableunsupported config options.

2007-02-16 Thread Zachary Amsden
Keir Fraser wrote: On 16/2/07 17:46, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: Keir Fraser wrote: This initial patchset does not include save/restore support anyway, so in fact it would be consistent to have CONFIG_PREEMPT configurable. I'm sure that we are going to have some

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-16 Thread Zachary Amsden
Christoph Lameter wrote: On Fri, 16 Feb 2007, Zachary Amsden wrote: For the most part, it doesn't disturb VMware or KVM. Xen does need some additional functionality in paravirt-ops because they took a different design choice - direct page tables instead of shadow page tables

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-16 Thread Zachary Amsden
Christoph Lameter wrote: On Thu, 15 Feb 2007, Jeremy Fitzhardinge wrote: This patch series implements the Linux Xen guest in terms of the paravirt-ops interface. The features in implemented this patch series I am thoroughly confused. Maybe that is because I have not been following

Re: [Xen-devel] Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.

2007-02-16 Thread Zachary Amsden
Keir Fraser wrote: On 16/2/07 10:19, "Zachary Amsden" <[EMAIL PROTECTED]> wrote: Doesn't stop_machine_run already take care of getting you out of all kernel threads? So you can only be sleeping, not preempted, in which case, this might not be an issue? It ensu

Re: [Xen-devel] Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.

2007-02-16 Thread Zachary Amsden
Keir Fraser wrote: On 16/2/07 07:25, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: Oh, so that's why it doesn't break when CONFIG_PREEMPT=y. In which case that preempt_disable() I spotted is wrong-and-unneeded. Why doesn't Xen work with preemption?? I've forgotten the details.

Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.

2007-02-16 Thread Zachary Amsden
3.0.4 but it's a dom0 only thing so it doesn't appear in this patchset. Ok but we still need to get the failure to user space for domU instead of trying what works on real hardware and failing. Eric Acked-by: Zachary Amsden <[EMAIL PROTECTED]> - To unsubscribe from this list: s

Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.

2007-02-16 Thread Zachary Amsden
3.0.4 but it's a dom0 only thing so it doesn't appear in this patchset. Ok but we still need to get the failure to user space for domU instead of trying what works on real hardware and failing. Eric Acked-by: Zachary Amsden [EMAIL PROTECTED

Re: [Xen-devel] Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.

2007-02-16 Thread Zachary Amsden
Keir Fraser wrote: On 16/2/07 10:19, Zachary Amsden [EMAIL PROTECTED] wrote: Doesn't stop_machine_run already take care of getting you out of all kernel threads? So you can only be sleeping, not preempted, in which case, this might not be an issue? It ensures that no (non

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-16 Thread Zachary Amsden
Christoph Lameter wrote: On Fri, 16 Feb 2007, Zachary Amsden wrote: For the most part, it doesn't disturb VMware or KVM. Xen does need some additional functionality in paravirt-ops because they took a different design choice - direct page tables instead of shadow page tables

Re: [patch 00/21] Xen-paravirt: Xen guest implementation for paravirt_ops interface

2007-02-16 Thread Zachary Amsden
Christoph Lameter wrote: On Fri, 16 Feb 2007, Zachary Amsden wrote: Yes, but that is just because the Xen hooks happens to be near the last part of the merge. VMI required some special hooks, as do both Xen and lhype (I think ... Rusty can correct me if lhype's puppy's have precluded

<    5   6   7   8   9   10   11   12   13   14   >