hen resize the raw image:
qmeu-img resize dst.raw newsize
You can also resize before converting, it does not matter if you resize
before or after.
Note that you will have to grow the pv/lv/filessystem inside the guest to
use the additional space.
Nir
On Wed, Jun 19, 2024 at 8:40 PM Nir Soffer wrote:
> - Need to run all block tests
>
Stale note, make check pass
On Wed, Jun 19, 2024 at 8:40 PM Nir Soffer wrote:
> - Need to run all block tests
>
Stale note, make check pass
ff -u before.out after.out
--- before.out 2024-06-19 20:24:09.234083713 +0300
+++ after.out 2024-06-19 20:24:20.526165573 +0300
@@ -3,13 +3,13 @@
1.0M /tmp/test.raw
defaults - write zeroes unmap
-0 /tmp/test.raw
+1.0M /tmp/test.raw
defaults - write actual zeros
1.0M /tmp/test.raw
discard
ff -u before.out after.out
--- before.out 2024-06-19 20:24:09.234083713 +0300
+++ after.out 2024-06-19 20:24:20.526165573 +0300
@@ -3,13 +3,13 @@
1.0M /tmp/test.raw
defaults - write zeroes unmap
-0 /tmp/test.raw
+1.0M /tmp/test.raw
defaults - write actual zeros
1.0M /tmp/test.raw
discard
we punched holes by default. I'm not sure this is a good
change in behavior.
- Need to run all block tests
- Not sure that we have tests covering unmapping, we may need new tests
- We may need new tests to cover this change
Signed-off-by: Nir Soffer
---
Changes since v1:
- Replace the incorrect
we punched holes by default. I'm not sure this is a good
change in behavior.
- Need to run all block tests
- Not sure that we have tests covering unmapping, we may need new tests
- We may need new tests to cover this change
Signed-off-by: Nir Soffer
---
Changes since v1:
- Replace the incorrect
s the inverse setting would stop hole
> punching.
Punching holes is used both for discard (e.g. fstrim in the guest) and for
writing zeros.
I think that discard should work only when you set discard=unmap or
disacard=on, but writing zeros should always punch holes unless you set
discard=off. I don’t think this behavior is documented now but it should be, at
least the intent to keep images sparse when possible.
Nir
> On 19 Jun 2024, at 11:16, Kevin Wolf wrote:
>
> Am 18.06.2024 um 23:24 hat Nir Soffer geschrieben:
>> Set has_discard only when BDRV_O_UNMAP is not set. With this users that
>> want to keep their images fully allocated can disable hole punching
>> when writin
> On 19 Jun 2024, at 11:16, Kevin Wolf wrote:
>
> Am 18.06.2024 um 23:24 hat Nir Soffer geschrieben:
>> Set has_discard only when BDRV_O_UNMAP is not set. With this users that
>> want to keep their images fully allocated can disable hole punching
>> when writin
ng we removed the NetBeans
> IDE-specific files and use their gradle plug-in (with somewhat mixed
> results). See https://bugs.openjdk.org/browse/JDK-8223375
>
> FWIW, there is an open issue to do the same for Eclipse, but I think it
> hasn't been looked at in a while. Nir is the assigne
It has been a while since I tried a clean import of jfx, but the
instructions in
https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse
seem correct, unless something changed. What you describe is written there.
Only the initial import requires a gradle build, and after
s fixed by this:
https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00198.html
I think the change needs more work to keep the default behavior since most
users
want sparse images, but it seems to do what you want - keeping images thick.
Nir
by
default. We needs tests for keeping images non-sparse.
Signed-off-by: Nir Soffer
---
block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index be25e35ff6..acac2abadc 100644
--- a/block/file-posix.c
+++ b/block/file
by
default. We needs tests for keeping images non-sparse.
Signed-off-by: Nir Soffer
---
block/file-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index be25e35ff6..acac2abadc 100644
--- a/block/file-posix.c
+++ b/block/file
I have Intel CPU and have never installed Steam. I switched to Xorg for
now because between this bug and bug 1876632, Wayland is not usable.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2063827
On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both
Hi, folks
At IETF 119, Jen Likova presented [1] the ESP Echo Protocol draft [2].
The conversation in the room was lively, but did not look like the kind of
consensus that we just confirm on the list.
So rather than starting an adoption call now, we’d like to encourage people to
discuss it on
map* (diffuse, specular, emissive,
normal), not *per material*. By the way, filtering is also a sampler
state, like addressing, so at the very least addressing can be added there.
- Nir
[1]
https://learn.microsoft.com/en-us/windows/win32/direct3d9/texture-addressing-modes
[2]
https://learn.
I have the same issue with NVIDA GeForce 4080 and driver 535.171.04 on
Ubuntu 24.04 with Wayland. Problem is that if I update to a newer driver
(which fixes the issue) I get another bug with letters and icons
disappearing after return from suspend (described here:
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev
wrote:
>> This issue is reproducible with and without `--mac-sign`. jpackage will
>> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
>> using pseudo-identity "_-_". This is why jpackage tries to sign added files
>>
On Sat, 25 May 2024 01:12:56 GMT, Alexander Matveev
wrote:
> > For your example. This almost seems like an Apple bug if you can add a
> > directory to the Contents directory but not a file?
>
> Not sure if it is an Apple bug.
Can this be reported to Apple somehow?
-
PR Comment:
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote:
>> Checked code and fixed the gramatical error in Transition files:
>> s/interval/intervals
>>
>> Fill and Stroke Transition had correct grammatical form already, so those
>> were untouched. I couldn't find any other instances of this
On Wed, 29 May 2024 06:53:40 GMT, Lukasz Kostyra wrote:
> Checked code and fixed the gramatical error in Transition files:
> s/interval/intervals
>
> Fill and Stroke Transition had correct grammatical form already, so those
> were untouched. I couldn't find any other instances of this error
Resending the vote on the mailing list because I sent it only to Kevin.
Vote: YES
On Thu, May 23, 2024 at 2:38 AM Nir Lisker wrote:
> Vote: YES
>
> On Thu, May 23, 2024 at 2:24 AM Kevin Rushforth <
> kevin.rushfo...@oracle.com> wrote:
>
>> I hereby nominate J
On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable`
On Sat, 25 May 2024 21:39:24 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable`
On Sat, 25 May 2024 20:40:39 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable`
On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 690:
>>
>>> 688: changed, it smoothly transitions to the new value over a
>>> period of time. Implicit transitions are supported
>>> 689:
On Sat, 25 May 2024 20:37:44 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java
>> line 277:
>>
>>> 275: * @since 23
>>> 276: */
>>> 277: public enum StepPosition {
>>
>> I think it would be helpful to include (or link to)
On Mon, 31 Jul 2023 18:10:46 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java
>> line 319:
>>
>>> 317: * The output time value is determined by the {@link StepPosition}.
>>> 318: *
>>> 319: * @param intervals the number of
On Fri, 24 May 2024 11:18:35 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable`
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Sat, 18 May 2024 14:24:49 GMT, Kevin Rushforth wrote:
> Maybe it's worth changing "adds any new" to "adds, removes, or modifies any"?
This looks like a good idea.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605798488
On Fri, 17 May 2024 14:58:41 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 addi
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu
On Wed, 15 May 2024 20:08:10 GMT, John Hendrikx wrote:
>> or is it? :-)
>
> Isn't this automatic? Seems weird you could integrate without these passing.
> or is it? :-)
Looks to me like it is...
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
>
Hello,
I see that dependency scanning is supported for Maven pom files, however,
many projects use Gradle as their dependency management tool. Has Gradle
support been considered?
Best,
Nir
On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra wrote:
>> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
>> no longer needed.
>>
>> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
>> changed the type to explicitly use
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
(11 bytes) @
0x01b44b9ad260 [0x01b44b9ad220+0x0040]
#
# No core dump will be written. Minidumps are not enabled by default on client
versions of Windows
#
# An error report file with more information is saved as:
# C:\Users\Nir\git\jfx\tests\performance\3DLighting\hs_err
/javase/21/core/restricted-methods.html
>>
>> But one thing to watch out for with FFM is startup + warm up time.
>> I struggled a lot with that in using FFM for just one library in the
>> java.desktop module.
>>
>> -phil
>>
>> On 4/22/24 9:12 AM, Nir Lisker
Sorry, we bumped to Java 21 in JavaFX 22 I think since we preserve the N-1
rule.
On Mon, Apr 22, 2024 at 6:03 PM Nir Lisker wrote:
> I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
> with 21. I suggested initially to bump to Java 22 exactly for FFM as it's
> ve
I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
with 21. I suggested initially to bump to Java 22 exactly for FFM as it's
very useful for JavaFX, but was told we shouldn't since it's not an LTS
version.
I have no idea how long the work on Wayland will take including the
urn new Size(size, size);
> }
>
>
> 2) Callbacks
>
> @Override
> protected void _invokeLater(Runnable runnable) {
> MemorySegment call = GSourceFunc.allocate(p -> {
> runnable.run();
> return 0;
> }, Arena.ofAuto());
>
> g_idle_add(call, MemorySegm
eed this to hook the events with wl_registry_add_listener, but
> currently the code generation for this is not working.
>
>
>
>
>
> Em dom., 21 de abr. de 2024 às 16:39, Nir Lisker
> escreveu:
>
>> What are wl_ types? jextract only supports c headers.
>>
>> On Sun, Apr 21, 20
What are wl_ types? jextract only supports c headers.
On Sun, Apr 21, 2024 at 10:31 PM Thiago Milczarek Sayão <
thiago.sa...@gmail.com> wrote:
> Hi,
>
> I did a small test app to explore Wayland client and portals (for Robot
> and dialogs such as file open/save).
>
>
I didn't find such memory leaks in my application, though I don't do stage
handling. What I would look at is where the `stage` reference in the lambda
is coming from. You say you have a list of open stages. When you close a
stage, do you remove the references to that stage from all places? What
On Thu, Apr 18, 2024 at 5:20 PM Daniel P. Berrangé
wrote:
> On Thu, Apr 18, 2024 at 05:07:24PM +0300, Nir Soffer wrote:
> > We are using minikube vms, which require adding the user to to libvirt
> > group[1].
> > We use `virsh -c qemu:///system` for debugging these vms
, and they cannot require a password or any
complicated
setup.
[1] https://github.com/kubernetes/minikube/issues/3467
Nir
___
Users mailing list -- users@lists.libvirt.org
To unsubscribe send an email to users-le...@lists.libvirt.org
On Thu, 28 Mar 2024 22:21:32 GMT, drmarmac wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
>> line 166:
>>
>>> 164: sm.startAtomic();
>>> 165:
>>> 166: final List removed = new
>>> ArrayList<>(c.getRemovedSize());
>>
>> I wonder
On Wed, 27 Mar 2024 23:18:43 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java
>> line 773:
>>
>>> 771: .collect(Collectors.toList());
>>> 772:
>>> 773:
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
Looks li
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Whitespace?
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
I
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added gradle script
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Wed, 27 Mar 2024 09:11:56 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last
On Wed, 27 Mar 2024 12:23:47 GMT, Marius Hanl wrote:
>> I'd say .forEach() is used correctly here, according to docs, it guarantees
>> execution of the side-effects (add to removed list & clear index), just not
>> in any particular order. This way we avoid multiple iteration.
>
> Another idea
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renam
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
I can, but it will
e, it is not enough
to copy the disk data a is,
you want to modify it to remove vmware bits and add the ovirt bits -
virt-v2v does all this for you.
Nir
___
Users mailing list -- users@ovirt.org
To unsubscribe send an email to users-le...@ovirt.org
Privacy S
l not clean up quickly
after a bad client disconnects uncleanly without ending the transfer.
Unfortunately I don't remember the which
timeout should be modified on the engine side, maybe Arik or Albert can
help with this.
Nir
___
Users mailing list --
On Wed, Mar 20, 2024 at 12:06 PM Shafi Mohammed
wrote:
> Hi Guys ,
>
> Thanks for the Info .
>
> I am trying to migrate my data from local to Storage domain . But it
> requires twice the effort in terms of space and time to copy the data to
> the local file system and then upload the disk to it
On Tue, 19 Mar 2024 22:28:54 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 383:
>>
>>> 381: runAndWait(() -> {
>>> 382: for (Window w : new ArrayList<>(Window.getWindows())) {
>>> 383: w.hide();
>>
>> I think you can use
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
tests/system/src/test/java/test/util/Util.java line 383:
> 381:
On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte wrote:
> Executing the LightingSample manually fails with an exception
I think the package names of the main and resources weren't aligned.
> The copyright year new files should be 2024 only. Some new files have more
> than one copyright year.
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with five additional
commits since the last revision:
- Added spacing
- Renamed constant
- Updated benchmark reset message
- Simplified models creation
- Rev
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Be
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
copyright headers
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Undo files move
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
Hi, Rob
The first question whenever someone proposes a bis document is, of course, “are
you volunteering to edit?”
Jokes aside, it’s always a question of whether or not it is worth the effort.
Not just for whoever is editing, but the usual effort associated with any
document, such as WG
On Sat, 9 Mar 2024 06:48:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
lations on your new AD role! Thank you for your leadership in
> the WG.
>
> Yoav (Nir): Despite these transitions, thank you for your continued service
> as co-chair in the WG!
>
> Deb isn't going too far from ACME. After the AD transition in Brisbane, the
> responsible AD fo
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> -
Update for the 3D lighting test tool as described in the JBS issue.
-
Commit messages:
- Whitespaces
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1387/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1387=00
Issue: https://bugs.openjdk.org/browse/JDK-8327179
Hi Dirk,
JavaFX has some input validation support in terms of focus control and
rejecting invalid characters. Can you explain what your proposal adds? Are
there JBS issues asking for this?
Thanks,
Nir
On Fri, Mar 1, 2024, 13:50 Dirk Lemmermann wrote:
> Hi everyone,
>
>
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
On Thu, 29 Feb 2024 11:46:11 GMT, Nir Lisker wrote:
> This pull request contains a backport of commit
> [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull request has
This pull request contains a backport of commit
[d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport d9645730f1e76e95e0bb93ceaeb5550390bf95c1
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I would
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Wed, 28 Feb 2024 14:21:55 GMT, Kevin Rushforth wrote:
> One other thing I noticed is that the file names have spaces in them, which
> is not a best practice and causes problems for scripts. Can you change all
> spaces to _ in the names of the newly-added files?
Yes. What about folders?
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Tue, 27 Feb 2024 12:13:09 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri
On Tue, 27 Feb 2024 11:24:08 GMT, Ambarish Rapte wrote:
> PhongMaterial is not suitable for surfaces that reflect or refract the
> incident light.
But it does reflect the incident light as explained in the paragraphs before.
-
PR Review Comment:
On Tue, 27 Feb 2024 11:53:35 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Sat, 24 Feb 2024 09:53:01 GMT, Nir Lisker wrote:
> Backport of commit
> [b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull request has now been integrated.
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
1 - 100 of 10117 matches
Mail list logo
