https://github.com/JDevlieghere approved this pull request.
LGMT modulo nits.
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -182,6 +187,11 @@ class CommandInterpreterRunOptions {
void SetSpawnThread(bool spawn_thread) {
m_spawn_thread = spawn_thread ? eLazyBoolYes : eLazyBoolNo;
}
+ bool GetAllowRepeats() const { return DefaultToNo(m_allow_repeats); }
JDevlieghere
@@ -72,6 +72,14 @@ class LLDB_API SBCommandInterpreterRunOptions {
void SetSpawnThread(bool);
+ bool GetAllowRepeats() const;
+
+ // By default, RunCommandInterpreter will discard repeats if the
+ // IOHandler being used is not interactive. Setting AllowRepeats to true
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/94518
>From 44e8cab5d45a87eb1ea2076c498abe5be423eb1c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 5 Jun 2024 11:24:01 -0700
Subject: [PATCH] [lldb][api-test] Add API test for
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/94679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/94794
>From 40fd912a328cd9f7918a9f9c12f8cfd97094fc2f Mon Sep 17 00:00:00 2001
From: Julian Lettner
Date: Fri, 7 Jun 2024 09:20:23 -0700
Subject: [PATCH 1/2] [lldb] Use `Address` to setup breakpoint
Use `Address` (instead
@@ -235,18 +234,13 @@ Breakpoint *ReportRetriever::SetupBreakpoint(ModuleSP
module_sp,
if (!symbol->ValueIsAddress() || !symbol->GetAddressRef().IsValid())
return nullptr;
- Target = process_sp->GetTarget();
- addr_t symbol_address =
@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() {
if (!process_sp)
return;
- lldb::ModuleSP module_sp = GetRuntimeModuleSP();
-
Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint(
- module_sp, process_sp,
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b01ac5137c28fa5e1b44a5d850cb7a6ace7d8799
dd02ca52d3cdad42c549bf66b4c05aca8fa93f62 --
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/93913
>From 9b18a5c4132cf093fc9b32f6b4dcfe406d485e3d Mon Sep 17 00:00:00 2001
From: Artem Yurchenko
Date: Thu, 6 Jun 2024 20:20:19 -0400
Subject: [PATCH] enforce the unbraced `extern ` invariant
Quoting 9.11.8:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Julian Lettner (yln)
Changes
Use `Address` (instead of `addr_t`) to setup
breakpoint in `ReportRetriever::SetupBreakpoint`.
This is cleaner and the breakpoint should now
survive re-running of the binary.
rdar://124399066
---
Full diff:
https://github.com/yln created https://github.com/llvm/llvm-project/pull/94794
Use `Address` (instead of `addr_t`) to setup
breakpoint in `ReportRetriever::SetupBreakpoint`.
This is cleaner and the breakpoint should now
survive re-running of the binary.
rdar://124399066
>From
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/94786
>From bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 7 Jun 2024 11:17:26 -0700
Subject: [PATCH 1/3] Add AllowRepeats to SBCommandInterpreterRunOptions.
This is
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
temyurchenko wrote:
> Hmm... I don't have a great idea. Is using it not enough to get it to be
> emitted? I see here we don't seem to cause them to be emitted:
> https://godbolt.org/z/nYzMca7Te
Yes, I get the same result. I also tried adding a test in `DeclPrinterTest`,
but it doesn't lookup
erichkeane wrote:
> > I see the 2nds commit doesn't add any tests! Please make it do so
>
> I've tried and I'm not quite sure how to do it. The issue is we need to test
> AST printing of «implicitly declared» functions, such as builtins and
> functions instrumented by lldb, such as `log` for
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with nit.
https://github.com/llvm/llvm-project/pull/94786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -93,15 +93,20 @@ class CommandInterpreterRunOptions {
/// \param[in] add_to_history
///If \b true add the commands to the command history. If \b false, don't
///add them.
+ /// \param[in] process_repeats
+ ///If \b true then process empty lines as repeat
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/93913
>From a54036c0fdc1a875f40a274d502dd96651a35ae3 Mon Sep 17 00:00:00 2001
From: Artem Yurchenko
Date: Thu, 6 Jun 2024 20:20:19 -0400
Subject: [PATCH] enforce the unbraced `extern ` invariant
Quoting 9.11.8:
temyurchenko wrote:
> I see the 2nds commit doesn't add any tests! Please make it do so
I've tried and I'm not quite sure how to do it. The issue is we need to test
AST printing of «implicitly declared» functions, such as builtins and functions
instrumented by lldb, such as `log` for logging;
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/94786
>From bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 7 Jun 2024 11:17:26 -0700
Subject: [PATCH 1/2] Add AllowRepeats to SBCommandInterpreterRunOptions.
This is
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b653357141030620ce3e70ea939efbcb71d40657...bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b653357141030620ce3e70ea939efbcb71d40657
bcd8c81c5fbc249886c53d8a2d1bc21a3f9e1ffd --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This is useful if you have a transcript of a user session and want to rerun
those commands with RunCommandInterpreter. The same functionality is also
useful in testing.
I'm adding it primarily for the second
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/94786
This is useful if you have a transcript of a user session and want to rerun
those commands with RunCommandInterpreter. The same functionality is also
useful in testing.
I'm adding it primarily for the
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/94679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xgupta wrote:
> The change LGTM, but I have a few suggestions regarding the title and
> description:
>
> * Retitle the PR to something like "[lldb] Remove dead code block (NFC)"
> or something that conveys the intent/outcome. The modified file and line
> number are already part of the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shivam Gupta (xgupta)
Changes
lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:290:19: performance:
Ineffective call of function 'substr' because a prefix of the string is
assigned to itself. Use resize() or pop_back() instead.
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94785
Fix #91211
>From 6ec5b1a005b7551f2857b30e2461d297e7febfa3 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:44:49 +0530
Subject: [PATCH] [LLDB][NFC] Fix a cppcheck warning in
https://github.com/JDevlieghere requested changes to this pull request.
Similar concern as
https://github.com/llvm/llvm-project/pull/94775#issuecomment-2155285000
https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
https://github.com/JDevlieghere requested changes to this pull request.
Similar comment as
https://github.com/llvm/llvm-project/pull/94775#issuecomment-2155285000
https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shivam Gupta (xgupta)
Changes
Fix #89710
---
Full diff: https://github.com/llvm/llvm-project/pull/94783.diff
1 Files Affected:
- (modified) lldb/source/Host/linux/Host.cpp (+1-1)
``diff
diff --git
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94783
Fix #89710
>From 3fe606e8e9a9eb8df336ac48995eaa52b659aad1 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:37:08 +0530
Subject: [PATCH] [LLDB][NFC] Fix a cppcheck warning in
JDevlieghere wrote:
@clayborg that's a cool idea. We might be able to use that to implement
`GetOpcodeDataSize`. That would definitely be a separate PR though.
https://github.com/llvm/llvm-project/pull/94679
___
lldb-commits mailing list
JDevlieghere wrote:
The change LGTM, but I have a few suggestions regarding the title and
description:
- Retitle the PR to something like "[lldb] Remove dead code block (NFC)" or
something that conveys the intent/outcome. The modified file and line number
are already part of the commit and
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shivam Gupta (xgupta)
Changes
Source code analyser cppcheck says:
lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:89:11:
warning: Identical inner 'if' condition is always true.
[identicalInnerCondition]
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94779
Source code analyser cppcheck says:
lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h:89:11:
warning: Identical inner 'if' condition is always true.
[identicalInnerCondition]
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Shivam Gupta (xgupta)
Changes
Fixes #85985
lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition
leads to a dead code block. [oppositeInnerCondition]
---
Full diff:
https://github.com/xgupta created
https://github.com/llvm/llvm-project/pull/94775
Fixes #85985
lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition
leads to a dead code block. [oppositeInnerCondition]
>From da77334ac60233e688812e39480f58bbe1a251eb Mon Sep 17 00:00:00
Author: Felipe de Azevedo Piovezan
Date: 2024-06-07T10:14:58-07:00
New Revision: adcf33f8fbcc0f068bd4b8254994b16dda525009
URL:
https://github.com/llvm/llvm-project/commit/adcf33f8fbcc0f068bd4b8254994b16dda525009
DIFF:
felipepiovezan wrote:
@oontvoo I'm going to revert this for now as the incremental bots are our first
line of defense against failures
https://github.com/llvm/llvm-project/pull/94625
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/94679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Looks good to me as long as the data is correct. Cleans up the code nicely.
It would be possible to encode the argument values using DW_FORM enumerations
with variadic macros. If we move the `OPERANDS, ARITY` to the end and have
ARITY come first:
```
walter-erquinigo wrote:
Jonas' suggestion is pretty good. Please do that. Probably something like this
would work
`
def collect_console(timeout_secs=10, check_interval_secs=1):
...
`
Then you can just update every caller of this function to just do
`collect_console()`
felipepiovezan wrote:
Oops, I commented on the old PR instead of the new one, so let me copy paste it
here:
@oontvoo I think this broke the bots again:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/5341/console
Would you mind reverting it until you have a chance to look
felipepiovezan wrote:
Would you mind reverting it until you have a chance to look at the failures?
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
felipepiovezan wrote:
@oontvoo I think this broke the bots again:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/5341/console
https://github.com/llvm/llvm-project/pull/87550
___
lldb-commits mailing list
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/94625
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2024-06-07T11:27:52-04:00
New Revision: 35fa2ded2ac52151be22c206fc92b983d1fd8e30
URL:
https://github.com/llvm/llvm-project/commit/35fa2ded2ac52151be22c206fc92b983d1fd8e30
DIFF:
https://github.com/llvm/llvm-project/commit/35fa2ded2ac52151be22c206fc92b983d1fd8e30.diff
@@ -59,25 +59,29 @@ DAP::DAP()
DAP::~DAP() = default;
void DAP::PopulateExceptionBreakpoints() {
- exception_breakpoints = {};
- if (lldb::SBDebugger::SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
-exception_breakpoints->emplace_back("cpp_catch", "C++ Catch",
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/94625
>From bbaa8ef4434a1d97a31a5dd7cbfc3cdfebcbe41d Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 6 Jun 2024 10:17:06 -0400
Subject: [PATCH 1/6] Reapply "[lldb][lldb-dap] Cleanup breakpoint filters."
(#93739)
@@ -59,25 +59,29 @@ DAP::DAP()
DAP::~DAP() = default;
void DAP::PopulateExceptionBreakpoints() {
- exception_breakpoints = {};
- if (lldb::SBDebugger::SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
-exception_breakpoints->emplace_back("cpp_catch", "C++ Catch",
-
https://github.com/JDevlieghere approved this pull request.
LGTM without the redundant check.
https://github.com/llvm/llvm-project/pull/94625
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/94625
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -65,16 +58,60 @@ DAP::DAP()
DAP::~DAP() = default;
+void DAP::PopulateExceptionBreakpoints() {
+ exception_breakpoints = {};
+ if (lldb::SBDebugger::SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
+exception_breakpoints->emplace_back("cpp_catch", "C++ Catch",
+
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94679
>From 63fd7a008900fea3bb609ac018f8401f04f07703 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 6 Jun 2024 10:14:34 -0700
Subject: [PATCH 1/4] [lldb] Encode number of operands for DWARF
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/94625
>From bbaa8ef4434a1d97a31a5dd7cbfc3cdfebcbe41d Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 6 Jun 2024 10:17:06 -0400
Subject: [PATCH 1/5] Reapply "[lldb][lldb-dap] Cleanup breakpoint filters."
(#93739)
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext
_context) {
LLDB_INVALID_ADDRESS);
}
+static int GetSoftwareBreakpointSize(const ArchSpec ,
+ lldb::addr_t next_flags)
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/90075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
A few small nits. I defer to Pavel and Jason for the functional changes.
https://github.com/llvm/llvm-project/pull/90075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext
_context) {
LLDB_INVALID_ADDRESS);
}
+static int GetSoftwareBreakpointSize(const ArchSpec ,
+ lldb::addr_t next_flags)
JDevlieghere wrote:
@aabhinavg Please let me know when you've changed the GitHub private e-mail
address setting and I'd be happy to merge this for you.
https://github.com/llvm/llvm-project/pull/92565
___
lldb-commits mailing list
JDevlieghere wrote:
> The problem is that the console hasn't had enough time to collect the logs
> after the process was terminated. This fix will keep collecting the logs
> until the "exited with status..." log has been collected so that we can check
> it. The caller could specify 10.0
@@ -65,16 +58,60 @@ DAP::DAP()
DAP::~DAP() = default;
+void DAP::PopulateExceptionBreakpoints() {
+ exception_breakpoints = {};
+ if (lldb::SBDebugger::SupportsLanguage(lldb::eLanguageTypeC_plus_plus)) {
+exception_breakpoints->emplace_back("cpp_catch", "C++ Catch",
+
erichkeane wrote:
I see the 2nds commit doesn't add any tests! Please make it do so, else LGTM
(plus might want to do a 'merge' commit to reset the CI to a more stable state).
https://github.com/llvm/llvm-project/pull/93913
___
lldb-commits mailing
https://github.com/Michael137 approved this pull request.
LGTM, thanks for the tests
https://github.com/llvm/llvm-project/pull/94744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
I should add that I'm pretty sure the index entries pointing to signature
declaration DIEs were not the cause of crashes in @ZequanWu CLs, after creating
the test case (what I think is the worst possible situation) and stepping
through the code, I realized that these DIEs would
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This makes sure we try to process declaration DIEs that are erroneously present
in the index. Until bd5c6367bd7, clang was emitting index entries for
declaration DIEs with DW_AT_signature attributes. This
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/94744
This makes sure we try to process declaration DIEs that are erroneously present
in the index. Until bd5c6367bd7, clang was emitting index entries for
declaration DIEs with DW_AT_signature attributes. This makes
https://github.com/ita-sc updated
https://github.com/llvm/llvm-project/pull/90075
>From b30ddc631ccc02b0bf1de6f1d98065199ed0b82d Mon Sep 17 00:00:00 2001
From: Ivan Tetyushkin
Date: Fri, 7 Jun 2024 11:23:24 +0300
Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded
instruction
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/94672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/94672
>From 3f91ecacdcf1eedc95b72e8a85591e60a863431e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 6 Jun 2024 23:38:03 +0400
Subject: [PATCH 1/2] [lldb] Fix TestModuleLoadedNotifys API test to work
https://github.com/ita-sc updated
https://github.com/llvm/llvm-project/pull/90075
>From 936846a18f31bba09f08d73195fe4945ef3508d3 Mon Sep 17 00:00:00 2001
From: Ivan Tetyushkin
Date: Fri, 7 Jun 2024 11:23:24 +0300
Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded
instruction
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext
_context) {
LLDB_INVALID_ADDRESS);
}
+static int GetSoftwareWatchpointSize(const ArchSpec ,
ita-sc wrote:
Fixed, changed to
https://github.com/ita-sc updated
https://github.com/llvm/llvm-project/pull/90075
>From 11ecb22c9473a2eee135ba0373e3890b9389851a Mon Sep 17 00:00:00 2001
From: Ivan Tetyushkin
Date: Fri, 7 Jun 2024 11:23:24 +0300
Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded
instruction
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
8ef5c98e9f9276f09c590e22ab88a20ae86f3859...a8ee2a2ee75fcfac96a45796d0675eaa89c1aca6
@@ -115,8 +148,23 @@ Status
NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping(
emulator_up->SetWriteMemCallback();
emulator_up->SetWriteRegCallback();
- if (!emulator_up->ReadInstruction())
-return Status("Read instruction failed!");
+ if
@@ -0,0 +1,27 @@
+"""
+Test that we can set up software breakpoint even if we failed to decode and
execute instruction
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext
_context) {
LLDB_INVALID_ADDRESS);
}
+static int GetSoftwareWatchpointSize(const ArchSpec ,
+ lldb::addr_t next_flags)
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext
_context) {
LLDB_INVALID_ADDRESS);
}
+static int GetSoftwareWatchpointSize(const ArchSpec ,
+ lldb::addr_t next_flags)
https://github.com/ita-sc updated
https://github.com/llvm/llvm-project/pull/90075
>From a8ee2a2ee75fcfac96a45796d0675eaa89c1aca6 Mon Sep 17 00:00:00 2001
From: Ivan Tetyushkin
Date: Fri, 7 Jun 2024 11:23:24 +0300
Subject: [PATCH] Fix setting breakpoint for undecoded instruction
Copy gdb
@@ -118,6 +118,6 @@ def test_launch_notifications(self):
# On Linux we get events for ld.so, [vdso], the binary and then all
libraries.
avg_solibs_added_per_event = round(
-float(total_solibs_added) / float(total_modules_added_events)
+
@@ -118,6 +118,6 @@ def test_launch_notifications(self):
# On Linux we get events for ld.so, [vdso], the binary and then all
libraries.
avg_solibs_added_per_event = round(
-float(total_solibs_added) / float(total_modules_added_events)
+
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/94455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-06-07T08:39:10+02:00
New Revision: 90b9922df2d8fb65a33eb9abd002fa9262863b5b
URL:
https://github.com/llvm/llvm-project/commit/90b9922df2d8fb65a33eb9abd002fa9262863b5b
DIFF:
https://github.com/llvm/llvm-project/commit/90b9922df2d8fb65a33eb9abd002fa9262863b5b.diff
temyurchenko wrote:
This is a relanding of #93131.
The first commit is the same, the second commit presents and fixes the issue
from the linked discussion.
cc @erichkeane, @AaronBallman, @gulfemsavrun.
(I can't set the reviewers myself)
https://github.com/llvm/llvm-project/pull/93913
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/93913
>From fac45476736cd04f044f046fd0df9e59450a926b Mon Sep 17 00:00:00 2001
From: Artem Yurchenko
Date: Wed, 22 May 2024 23:41:35 -0400
Subject: [PATCH 1/2] [clang][AST] fix ast-print of `extern ` with >=2
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5f243b3fffca42ed320529a54aefd86087aa85f8
db1eb9b69f2ed961a586d15d165acd000bb728c4 --
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/93913
>From fac45476736cd04f044f046fd0df9e59450a926b Mon Sep 17 00:00:00 2001
From: Artem Yurchenko
Date: Wed, 22 May 2024 23:41:35 -0400
Subject: [PATCH 1/2] [clang][AST] fix ast-print of `extern ` with >=2
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94679
>From 63fd7a008900fea3bb609ac018f8401f04f07703 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 6 Jun 2024 10:14:34 -0700
Subject: [PATCH 1/4] [lldb] Encode number of operands for DWARF
@@ -694,197 +694,197 @@ HANDLE_DW_FORM(0x1f21, GNU_strp_alt, 0, GNU)
HANDLE_DW_FORM(0x2001, LLVM_addrx_offset, 0, LLVM)
// DWARF Expression operators.
-HANDLE_DW_OP(0x03, addr, 2, DWARF)
-HANDLE_DW_OP(0x06, deref, 2, DWARF)
-HANDLE_DW_OP(0x08, const1u, 2, DWARF)
JDevlieghere wrote:
> I'm also not sure the number of operands is ever useful without having the
> encoding ready, but maybe for DIExpression it actually is (because there we
> always use the same encoding).
Yeah, I came to the same conclusion, which is why LLDB isn't using the data. I
Author: Alex Langford
Date: 2024-06-06T14:25:53-07:00
New Revision: ba7f52ccf42fd481a1b309fe76863729fdd18c1c
URL:
https://github.com/llvm/llvm-project/commit/ba7f52ccf42fd481a1b309fe76863729fdd18c1c
DIFF:
https://github.com/llvm/llvm-project/commit/ba7f52ccf42fd481a1b309fe76863729fdd18c1c.diff
1201 - 1300 of 89525 matches
Mail list logo
