[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

JDevlieghere wrote: The number of operands comes directly from Table 7.6 in the DWARF 5 spec. I'm less confident in the _arity_ which required me to consult the description of the operations. I think I got them right and everything covered by the LLDB test suite still passes, but I would

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/9] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

bulbazord wrote: Fix: https://github.com/llvm/llvm-project/pull/94683 https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestStatisticsAPI after 9293fc798152 (PR #94683)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94683.diff 1 Files Affected: - (modified) lldb/test/API/functionalities/stats_api/TestStatisticsAPI.py (+4-3) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Fix TestStatisticsAPI after 9293fc798152 (PR #94683)

https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/94683 None >From fe74a42c27731098c00f563d2f080e07003d888e Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Thu, 6 Jun 2024 13:47:50 -0700 Subject: [PATCH] [lldb] Fix TestStatisticsAPI after 9293fc798152 ---

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR extends Dwarf.def to include the number of operands and the arity (the number of entries on the DWARF stack) and use it from the LLDB DWARF expression evaluator. --- Patch is 42.88 KiB,

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

llvmbot wrote: @llvm/pr-subscribers-objectyaml Author: Jonas Devlieghere (JDevlieghere) Changes This PR extends Dwarf.def to include the number of operands and the arity (the number of entries on the DWARF stack) and use it from the LLDB DWARF expression evaluator. --- Patch is 42.88

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94679 This PR extends Dwarf.def to include the number of operands and the arity (the number of entries on the DWARF stack) and use it from the LLDB DWARF expression evaluator. >From

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

bulbazord wrote: Ah, I see there was a test for this that I missed. I've gotten an email about it, taking a look now. ``` Failed Tests (1): lldb-api :: functionalities/stats_api/TestStatisticsAPI.py ``` https://github.com/llvm/llvm-project/pull/94671

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9293fc7 - [lldb] Include memory stats in statistics summary (#94671)

Author: Alex Langford Date: 2024-06-06T13:18:06-07:00 New Revision: 9293fc7981526eaca0a28012f2e5963fff1b830b URL: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b DIFF: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b.diff

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/kusmour approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The different build configuration and target Linux system can load a different number of .so libraries (2 and more). As example, Linux x86_64 host shows the following loaded modules: ``` Loaded files:

[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/94672 The different build configuration and target Linux system can load a different number of .so libraries (2 and more). As example, Linux x86_64 host shows the following loaded modules: ``` Loaded files:

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes The summary already includes other size information, e.g. total debug info size in bytes. The only other way I can get this information is by dumping all statistics which can be quite large. Adding it to

[Lldb-commits] [lldb] [lldb] Include memory stats in statistics summary (PR #94671)

https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/94671 The summary already includes other size information, e.g. total debug info size in bytes. The only other way I can get this information is by dumping all statistics which can be quite large. Adding it to the

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

jimingham wrote: There was one comment that should probably be removed. This looks okay to me at this stage. https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/94553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d09231a - [lldb/crashlog] Remove aarch64 requirement on crashlog tests (#94553)

Author: Med Ismail Bennani Date: 2024-06-06T12:17:00-07:00 New Revision: d09231a422f052d6f6f44913fad610728a7c266b URL: https://github.com/llvm/llvm-project/commit/d09231a422f052d6f6f44913fad610728a7c266b DIFF:

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -1089,6 +1089,154 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::Expected ValueObject::GetValueAsAPSInt() { + // Make sure the type can be converted to an APSInt. + if (!GetCompilerType().IsInteger() && +

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate( // the stack by the called expression may be used as return values by prior // agreement between the calling and called expressions. case DW_OP_call2: - if (error_ptr) -

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice deleted https://github.com/llvm/llvm-project/pull/87197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3141,15 +3141,15 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { +if (!type.IsInteger()) { + m_error.SetErrorString("target type must be an integer"); + return GetSP(); +}

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char *name, TypeSP _sp) { return valobj_sp; } +lldb::addr_t ValueObject::GetLoadAddress() { + lldb::addr_t addr_value = LLDB_INVALID_ADDRESS; + lldb::TargetSP target_sp = GetTargetSP(); + if

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/8] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } +%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) { + if (!($input == Py_None || +

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } +%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) { + if (!($input == Py_None || +

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } +%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) { + if (!($input == Py_None || +

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -476,6 +475,32 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } +%typemap(in) (lldb::CommandOverrideCallback callback, void *baton) { + if (!($input == Py_None || +

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -1099,6 +1099,19 @@ static void LLDBSwigPythonCallPythonSBDebuggerTerminateCallback(lldb::user_id_t } } +static bool LLDBSwigPythonCallPythonSBCommandInterpreterSetCommandOverrideCallback(void *baton, const char **argv) { + bool b = false; bulbazord

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -0,0 +1,30 @@ +from typing_extensions import override +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +class CommandOverrideCallback(TestBase): +def setUp(self): +

[Lldb-commits] [lldb] [lldb][api-test] Add API test for SBCommandInterpreter::CommandOverrideCallback (PR #94518)

@@ -0,0 +1,30 @@ +from typing_extensions import override +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +class CommandOverrideCallback(TestBase): +def setUp(self): +

[Lldb-commits] [lldb] Reapply PR/87550 (PR #94625)

https://github.com/oontvoo edited https://github.com/llvm/llvm-project/pull/94625 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command): result.SetError(str(e)) return +# To avoid breaking previous users, we should keep supporting previous flag +# even if we don't use them / advertise them

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

@@ -3,7 +3,7 @@ # RUN: mkdir -p %t.dir # RUN: yaml2obj %S/Inputs/interactive_crashlog/multithread-test.yaml > %t.dir/multithread-test # RUN: %lldb -b -o 'command script import lldb.macosx.crashlog' \ -# RUN: -o 'crashlog -a -i -s -t %t.dir/multithread-test

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/94553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/94553 >From 46eb924da3dcee4b43f22f0002cc21d3c01fb2f3 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Tue, 4 Jun 2024 20:36:53 -0700 Subject: [PATCH 1/2] [lldb/crashlog] Remove aarch64 requirement on

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/bulbazord approved this pull request. Makes sense to me. Removing the aarch64 requirement is an excellent change since many testing machines are x86_64  https://github.com/llvm/llvm-project/pull/94553 ___ lldb-commits mailing

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3141,15 +3141,15 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { +if (!type.IsInteger()) { + m_error.SetErrorString("target type must be an integer"); + return GetSP(); +}

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jimingham wrote: I will get to this, WWDC is close upon us so we're all rather busy at present. Jim > On Jun 6, 2024, at 8:27 AM, jeffreytan81 ***@***.***> wrote: > > > @jimingham , let me know any other > comments/thoughts you have. > > — > Reply to this

[Lldb-commits] [lldb] Reapply PR/87550 (PR #94625)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/94625 >From bbaa8ef4434a1d97a31a5dd7cbfc3cdfebcbe41d Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 6 Jun 2024 10:17:06 -0400 Subject: [PATCH 1/4] Reapply "[lldb][lldb-dap] Cleanup breakpoint filters." (#93739)

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

@@ -2345,11 +2345,6 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , if (!die) return false; - ParsedDWARFTypeAttributes attrs(die); labath wrote: In case anyone's wondering, Putting this check back in would prevent the crash from

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

labath wrote: PSA: I've reverted Zequan's patch due to other bugs, so this change is now uncommitted again. Since this could go in as a separate change, I'm going to recreate a patch for it tomorrow (running out of time today), including the fix from #94400, if someone doesn't beat me to it.

[Lldb-commits] [lldb] 7fdbc30 - Revert "[lldb][DebugNames] Only skip processing of DW_AT_declarations for class/union types"

Author: Pavel Labath Date: 2024-06-06T16:08:58Z New Revision: 7fdbc30b445286f03203e16d0be067c25c6f0df0 URL: https://github.com/llvm/llvm-project/commit/7fdbc30b445286f03203e16d0be067c25c6f0df0 DIFF: https://github.com/llvm/llvm-project/commit/7fdbc30b445286f03203e16d0be067c25c6f0df0.diff LOG:

[Lldb-commits] [lldb] de3f1b6 - [lldb] Test case for the bug in #92328

Author: Pavel Labath Date: 2024-06-06T16:10:22Z New Revision: de3f1b6d68ab8a0e827db84b328803857a4f60df URL: https://github.com/llvm/llvm-project/commit/de3f1b6d68ab8a0e827db84b328803857a4f60df DIFF: https://github.com/llvm/llvm-project/commit/de3f1b6d68ab8a0e827db84b328803857a4f60df.diff LOG:

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -618,6 +631,24 @@ class ValueObject { virtual lldb::ValueObjectSP CastPointerType(const char *name, lldb::TypeSP _sp); + /// Return the target load address assocaited with this value object. cmtice wrote:

[Lldb-commits] [lldb] 67aaa9f - [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (#94558)

Author: Jonas Devlieghere Date: 2024-06-06T08:54:37-07:00 New Revision: 67aaa9f9974993f360cc0dabffd73b51c030d775 URL: https://github.com/llvm/llvm-project/commit/67aaa9f9974993f360cc0dabffd73b51c030d775 DIFF:

[Lldb-commits] [lldb] [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (PR #94558)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94556 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a76290d - [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (#94556)

Author: Jonas Devlieghere Date: 2024-06-06T08:54:20-07:00 New Revision: a76290d6acedb4dcdd431cdd21f057255117f8d3 URL: https://github.com/llvm/llvm-project/commit/a76290d6acedb4dcdd431cdd21f057255117f8d3 DIFF:

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

jeffreytan81 wrote: @jimingham , let me know any other comments/thoughts you have. https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

DavidSpickett wrote: Thanks for the fix! These small mistakes are always annoying when you're going through a complicated log. https://github.com/llvm/llvm-project/pull/94611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/94611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d9e6a56 - [lldb] Fix ThreadPlanStepOverRange name in log message (#94611)

Author: Marianne Mailhot-Sarrasin Date: 2024-06-06T15:05:55+01:00 New Revision: d9e6a563206cea4e682d4c52eccf24178d7d8343 URL: https://github.com/llvm/llvm-project/commit/d9e6a563206cea4e682d4c52eccf24178d7d8343 DIFF:

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

DavidSpickett wrote: Ah ignore that, the function is in fact `DoPlanExplainsStop`, I was looking at the class name. https://github.com/llvm/llvm-project/pull/94611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

https://github.com/DavidSpickett approved this pull request. I think there a `LOG` macro that adds the function name but I forget exactly what, this LGTM as is. https://github.com/llvm/llvm-project/pull/94611 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3015,11 +3017,12 @@ llvm::Expected ValueObject::CastDerivedToBaseType( lldb::TargetSP target = GetTargetSP(); // The `value` can be a pointer, but GetChildAtIndex works for pointers too. - lldb::ValueObjectSP inner_value; + lldb::ValueObjectSP inner_value =

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

@@ -3138,13 +3141,13 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { val_byte_size = temp.value(); if (is_pointer) { -if (type.IsBoolean() && type_byte_size < val_byte_size) { +if (!type.IsBoolean() && type_byte_size < val_byte_size) {

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/7] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Marianne Mailhot-Sarrasin (mariannems) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94611.diff 1 Files Affected: - (modified) lldb/source/Target/ThreadPlanStepOverRange.cpp (+1-1) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Fix ThreadPlanStepOverRange name in log message (PR #94611)

https://github.com/mariannems created https://github.com/llvm/llvm-project/pull/94611 None >From b17a12f78f19e59bce7ee52308502f2eeea4e8cd Mon Sep 17 00:00:00 2001 From: Marianne Mailhot-Sarrasin Date: Wed, 5 Jun 2024 15:56:12 -0400 Subject: [PATCH] [lldb] Fix ThreadPlanStepOverRange name in

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/6] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (PR #94558)

https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/94556 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

https://github.com/DavidSpickett approved this pull request. LGTM Thanks for working on this. Last time I tried to do this sort of conversion I went for llvm::Expected, and it quickly spiraled into a mountain of changes that I gave up on in the end.

[Lldb-commits] [lldb] a6cc363 - [lldb] Disable TestPtyServer API test when remote testing (#94587)

Author: Dmitry Vasilyev Date: 2024-06-06T10:02:27+01:00 New Revision: a6cc363b2743a264eb06e46cac05c3c9c92e3ef7 URL: https://github.com/llvm/llvm-project/commit/a6cc363b2743a264eb06e46cac05c3c9c92e3ef7 DIFF:

[Lldb-commits] [lldb] [lldb] Disable TestPtyServer API test when remote testing (PR #94587)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/94587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable TestPtyServer API test when remote testing (PR #94587)

https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable TestPtyServer API test when remote testing (PR #94587)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The local PTY is not available for the remotely executed lldb-server to pass the test. Also, in general, we cannot execute the local lldb-server instance because it could be compiled for the different

[Lldb-commits] [lldb] [lldb] Disable TestPtyServer API test when remote testing (PR #94587)

https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/94587 The local PTY is not available for the remotely executed lldb-server to pass the test. Also, in general, we cannot execute the local lldb-server instance because it could be compiled for the different

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

medismailben wrote: FWIW, this was already approved in https://reviews.llvm.org/D141658 but I've updated it slightly to match to current version of the crashlog script. https://github.com/llvm/llvm-project/pull/94575 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch makes interactive mode as the default when using the crashlog command. It replaces the existing `-i|--interactive` flag with a new `-m|--mode` option, that can either be `interactive`

[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/94575 This patch makes interactive mode as the default when using the crashlog command. It replaces the existing `-i|--interactive` flag with a new `-m|--mode` option, that can either be `interactive` or

[Lldb-commits] [lldb] [lldb/crashlog] Always load Application Specific Backtrace Thread images (PR #94259)

https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/94259 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 86dddbe - [lldb/crashlog] Always load Application Specific Backtrace Thread images (#94259)

Author: Med Ismail Bennani Date: 2024-06-05T20:22:36-07:00 New Revision: 86dddbe3b54eae22db6e208e6bc1c3cda9b7e149 URL: https://github.com/llvm/llvm-project/commit/86dddbe3b54eae22db6e208e6bc1c3cda9b7e149 DIFF:

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6ca0f44 - [lldb] Fix inconsistencies in DWARFExpression errors (#94554)

Author: Jonas Devlieghere Date: 2024-06-05T19:47:49-07:00 New Revision: 6ca0f44cd89aa802c306c303764eabf83a7f5029 URL: https://github.com/llvm/llvm-project/commit/6ca0f44cd89aa802c306c303764eabf83a7f5029 DIFF:

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (PR #94558)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94558.diff 1 Files Affected: - (modified) lldb/source/Expression/DWARFExpression.cpp (+17-31) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Refactor ResolveLoadAddress to return an llvm::Expected (NFC) (PR #94558)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94558 None >From 6bb911ab3ee8a9f9d10662ed41442be85da9df14 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 5 Jun 2024 19:42:50 -0700 Subject: [PATCH] [lldb] Refactor ResolveLoadAddress to return an

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94556.diff 1 Files Affected: - (modified) lldb/source/Expression/DWARFExpression.cpp (+56-74) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Refactor ReadRegisterValueAsScalar to return an llvm::Error (NFC) (PR #94556)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94556 None >From b20884bc0db2a0cb0bb928beb629670d8c86369f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 5 Jun 2024 19:36:39 -0700 Subject: [PATCH] [lldb] Refactor ReadRegisterValueAsScalar to

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch make all errors start with a lowercase letter and removes trailing periods and newlines. This fixes inconsistencies between error messages and facilitate concatenating them. --- Patch

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate( if (pick_idx < stack.size()) stack.push_back(stack[stack.size() - 1 - pick_idx]); else { -if (error_ptr) - error_ptr->SetErrorStringWithFormat( - "Index %u out of range for

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94554 This patch make all errors start with a lowercase letter and removes trailing periods and newlines. This fixes inconsistencies between error messages and facilitate concatenating them. >From

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This PR removes the `target-aarch64` requirement on the crashlog tests to exercice them on Intel bots and make image loading single-threaded temporarily while implementing a fix for a deadlock

[Lldb-commits] [lldb] [lldb/crashlog] Remove aarch64 requirement on crashlog tests (PR #94553)

https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/94553 This PR removes the `target-aarch64` requirement on the crashlog tests to exercice them on Intel bots and make image loading single-threaded temporarily while implementing a fix for a deadlock issue when

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

https://github.com/jimingham approved this pull request. This is much nicer. I would actually prefer we returned names that are "" rather than nullptr, but in any case I agree there's no particular reason to make that a contract. https://github.com/llvm/llvm-project/pull/94455

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

@@ -46,75 +46,116 @@ lldb::ValueObjectSP ValueObjectConstResultImpl::Dereference(Status ) { return m_impl_backend->ValueObject::Dereference(error); } -ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex( -size_t idx, bool synthetic_array_member, int32_t

[Lldb-commits] [lldb] [lldb] Split ValueObject::CreateChildAtIndex into two functions (PR #94455)

@@ -46,75 +46,116 @@ lldb::ValueObjectSP ValueObjectConstResultImpl::Dereference(Status ) { return m_impl_backend->ValueObject::Dereference(error); } -ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex( -size_t idx, bool synthetic_array_member, int32_t

<    9   10   11   12   13   14   15   16   17   18   >