[Lldb-commits] [lldb] [lldb-dap][test] Fix `readMemory` test (PR #109057)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109057 So far, the test case was also testing the offset -1. This test cases failed if the string is immediately at the beginning of the memory region, though, and the offset -1 hence belonged to a different memo

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-17 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-17 Thread Jason Molenda via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-17 Thread Jason Molenda via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-17 Thread Jason Molenda via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-17 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread via lldb-commits
https://github.com/serby2000 updated https://github.com/llvm/llvm-project/pull/108948 >From 30e1a6fdc39f637095eec89584f6b163bc53037d Mon Sep 17 00:00:00 2001 From: Serby Date: Tue, 17 Sep 2024 12:19:36 +0300 Subject: [PATCH 1/2] vscode-lldb - Add Environment configuration for the lldb-dap proc

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @serby2000 do you have the necessary permissions to merge this? Or does one of us need to press the button? https://github.com/llvm/llvm-project/pull/108948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > I actually wrote this for a team that already has their own viewer. We've > suggested that they upstream that as well. Is that viewer in VS-Code or in some other editor? (Trying to avoid duplicating effort, so I don't accidentally implement the same thing) https://github

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-17 Thread Louis Dionne via lldb-commits
ldionne wrote: > Do you have an idea how we could de-risk this change? E.g., would do you have > a couple more scenarios in mind for which I should add test cases? Are there > similar patterns to the `operator()` which I should also cover in test cases? What I could imagine is to drive this v

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

2024-09-17 Thread Vy Nguyen via lldb-commits
@@ -682,17 +683,51 @@ PacketStatus DAP::GetNextObject(llvm::json::Object &object) { } bool DAP::HandleObject(const llvm::json::Object &object) { + auto start_time = std::chrono::steady_clock::now(); const auto packet_type = GetString(object, "type"); if (packet_type ==

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread via lldb-commits
@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" dlav-sc wrote: yep, addressed https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 2fc70cf82a7e67bde2d4fb35d2457d2812b34273 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/4] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

2024-09-17 Thread Jennifer Phillips via lldb-commits
jennphilqc wrote: > Given this, I think we should take the best parts of both PRs 🙂 What do you > think about the following path forward? > > * rebase this PR on top of [[lldb-dap] Support inspecting memory  > #104317](https://github.com/llvm/llvm-project/pull/104317) > * scope this PR down to

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

2024-09-17 Thread Alex Langford via lldb-commits
bulbazord wrote: > Do we have a sense of whether it's just a broken test, or if the PR broke > some functionality? We tested the change on some internal scenarios and it > showed good improvement, so we'd like to cherry-pick this patch (or a new > patch). I'm not sure yet, I haven't had time

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/108948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-17 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/107485 >From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 5 Sep 2024 15:51:35 -0700 Subject: [PATCH 1/8] [lldb-dap] Add feature to remember last non-empty expression.

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2d13302d3851747a023ffecc6388585e888cd0e9 60045b710e1102d6f220dfd4367f997b73bb64df --e

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2d13302d3851747a023ffecc6388585e888cd0e9...60045b710e1102d6f220dfd4367f997b73bb64df lldb/

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Tom Yang (zhyty) Changes Somewhat recently, we made the change to hide the behavior to save LLDB session history to the transcript buffer behind the flag `interpreter.save-transcript`. By default, `interpreter.save-transcript` is false. Se

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-17 Thread Tom Yang via lldb-commits
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/109020 Somewhat recently, we made the change to hide the behavior to save LLDB session history to the transcript buffer behind the flag `interpreter.save-transcript`. By default, `interpreter.save-transcript` is false.

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

2024-09-17 Thread via lldb-commits
royitaqi wrote: Do we have a sense of whether it's just a broken test, or if the PR broke some functionality? We tested the change on some internal scenarios and it showed good improvement, so we'd like to cherry-pick this patch (or a new patch). https://github.com/llvm/llvm-project/pull/106

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Will look at this properly tomorrow but just looking at the title, I'm surprised that https://github.com/llvm/llvm-project/pull/88812 did not also fix this. Perhaps putfile and install are different paths. https://github.com/llvm/llvm-project/pull/108996 __

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-17 Thread Michael Buch via lldb-commits
@@ -0,0 +1,13 @@ +# Tests that we show the first non-STL frame when +# a verbose_trap triggers from within the STL. + +# UNSUPPORTED: system-windows +# +# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap-in-stl-nested.cpp -o %t.out +# RUN: %lldb -b -s %s %t.out | FileCheck %s --chec

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-17 Thread Walter Erquinigo via lldb-commits
@@ -1390,7 +1414,10 @@ llvm::json::Value CreateVariable(lldb::SBValue v, int64_t var_ref, object.try_emplace("variablesReference", 0); if (v.GetDeclaration().IsValid()) -object.try_emplace("declarationLocationReference", var_ref); +object.try_emplace("declaratio

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-17 Thread Walter Erquinigo via lldb-commits
@@ -4087,32 +4114,64 @@ void request_variables(const llvm::json::Object &request) { void request_locations(const llvm::json::Object &request) { llvm::json::Object response; FillResponse(request, response); - auto arguments = request.getObject("arguments"); + auto *argume

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-17 Thread Walter Erquinigo via lldb-commits
@@ -1611,16 +1624,17 @@ void request_evaluate(const llvm::json::Object &request) { VariableDescription desc(value); EmplaceSafeString(body, "result", desc.GetResult(context)); EmplaceSafeString(body, "type", desc.display_type_name); - if (value.MightHave

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (dlav-sc) Changes Lldb documentation says that during remote debugging lldb client should check the existence of the desired executable file on the remote target and only if the file is missing copy it there. There is no such check in

[Lldb-commits] [lldb] [lldb] add a check using an MD5 hash for whether a file needs to be installed on the remote target (PR #108996)

2024-09-17 Thread via lldb-commits
https://github.com/dlav-sc created https://github.com/llvm/llvm-project/pull/108996 Lldb documentation says that during remote debugging lldb client should check the existence of the desired executable file on the remote target and only if the file is missing copy it there. There is no such ch

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-17 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,13 @@ +# Tests that we show the first non-STL frame when +# a verbose_trap triggers from within the STL. + +# UNSUPPORTED: system-windows +# +# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap-in-stl-nested.cpp -o %t.out +# RUN: %lldb -b -s %s %t.out | FileCheck %s --chec

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-17 Thread Adrian Prantl via lldb-commits
@@ -16,6 +16,31 @@ using namespace llvm; using namespace lldb; using namespace lldb_private; +/// The 0th frame is the artificial inline frame generated to store +/// the verbose_trap message. So, starting with the current parent frame, +/// find the first frame that's not ins

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-17 Thread via lldb-commits
cmtice wrote: > > > Is the plan to get the DIL data structures merged before the rest of the > > > patch series is up for review? I think it'd be great to see how the > > > infrastructure introduced here will be used > > > > > > There are 3 major pieces to the DIL implementation (soon to be 4

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: If folks could close any of their comments that have now been addressed, it would be much easier to determine what is left to do. We're going for the "most thorough review" record here :) Thanks for sticking with it @dlav-sc . https://github.com/llvm/llvm-project/pull/993

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread David Spickett via lldb-commits
@@ -279,6 +279,9 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, .setMCJITMemoryManager(std::make_unique(*this)) .setOptLevel(llvm::CodeGenOptLevel::Less); + if (triple.isRISCV64()) DavidSpickett wrote: This shou

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread David Spickett via lldb-commits
@@ -1011,6 +1011,135 @@ void RuntimeDyldELF::resolveBPFRelocation(const SectionEntry &Section, } } +static void applyUTypeImmRISCV(uint8_t *InstrAddr, uint32_t Imm) { DavidSpickett wrote: Does this still need to be done? https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread David Spickett via lldb-commits
@@ -0,0 +1,96 @@ +""" +Test RISC-V expressions evaluation. +""" DavidSpickett wrote: Are these tests going to be removed then? On the grounds that existing tests in the test suite will cover these scenarios. https://github.com/llvm/llvm-project/pull/99336 _

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread via lldb-commits
https://github.com/serby2000 updated https://github.com/llvm/llvm-project/pull/108948 >From 30e1a6fdc39f637095eec89584f6b163bc53037d Mon Sep 17 00:00:00 2001 From: Serby Date: Tue, 17 Sep 2024 12:19:36 +0300 Subject: [PATCH 1/2] vscode-lldb - Add Environment configuration for the lldb-dap proc

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/108948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
@@ -78,6 +78,15 @@ "scope": "resource", "type": "string", "description": "The log path for lldb-dap (if any)" +}, + "lldb-dap.environment": { vogelsgesang wrote: Use whitespaces instead of tabs for indentatio

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: I've disabled this on Windows for now but please address the issue generally. Testing memory region overlaps is tricky. I did it for memory tagging by hoping that the kernel would allocate pages in the right order, which worked for at least simulated systems. Pavel recentl

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread via lldb-commits
@@ -124,6 +124,9 @@ class ABISysV_riscv : public lldb_private::RegInfoBasedABI { using lldb_private::RegInfoBasedABI::RegInfoBasedABI; // Call CreateInstance // instead. bool m_is_rv64; // true if target is riscv64; fa

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-17 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 08b0bb18e46be06ddf6397455382c5b75bc3b757 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] ab38ec9 - [lldb][lldb-dap] Disable read memory test on Windows

2024-09-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-17T12:51:46Z New Revision: ab38ec9ac312460e4f71c8ad3f50b9b5723469f6 URL: https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6 DIFF: https://github.com/llvm/llvm-project/commit/ab38ec9ac312460e4f71c8ad3f50b9b5723469f6.diff LOG

[Lldb-commits] [lldb] [lldb][FrameRecognizer] Display the first non-std frame on verbose_trap (PR #108825)

2024-09-17 Thread Egor Zhdan via lldb-commits
egorzhdan wrote: This is a great UX improvement, thanks! https://github.com/llvm/llvm-project/pull/108825 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: The test case is failing on Windows, for reasons not related to it being Windows but due to data layout. The const string is placed at the start of a region: ``` (lldb) p rawptr (const char *) 0x7ff77fcb5000 "dead" (lldb) memory region --all <...> [0x7ff77fc61000-0x

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-17 Thread Andrew Savonichev via lldb-commits
asavonic wrote: > Our idea is summarized in > https://discourse.llvm.org/t/rfc-lldb-more-reliable-completion-of-record-types/77442. > Basically the goal is to guarantee that a call to `getDefinition`, _will_ > fetch the definition. This is something that Clang already does, but we just > neve

[Lldb-commits] [lldb] b39a100 - [lldb][lldb-dap] Remove unused includes in memory test

2024-09-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-17T09:30:14Z New Revision: b39a100ff4ec16f1f9cafcc48ea7fed920726650 URL: https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650 DIFF: https://github.com/llvm/llvm-project/commit/b39a100ff4ec16f1f9cafcc48ea7fed920726650.diff LOG

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Serban (serby2000) Changes Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are needed to be able to use lldb-dap in vscode This PR adds a way to set the environment for the lldb-dap process using configuration. ---

[Lldb-commits] [lldb] [LLDB][lldb-dap][vscode-lldb] Add Environment configuration for the lldb-dap process (PR #108948)

2024-09-17 Thread via lldb-commits
https://github.com/serby2000 created https://github.com/llvm/llvm-project/pull/108948 Frequently, environment variables such as `LLDB_USE_NATIVE_PDB_READER` are needed to be able to use lldb-dap in vscode This PR adds a way to set the environment for the lldb-dap process using configuration.

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/108870 >From 60b26a50218e20431dd645b93d341403ff5b2ee4 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 17:34:11 + Subject: [PATCH 1/2] [lldb][libc++] Hide all libc++ implementation det

[Lldb-commits] [lldb] [lldb/DWARF] Cache negative results of variable parsing (PR #108810)

2024-09-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Are there cases where we fail to `ParseVariableDIE` the first time around but could succeed later on in the debug sessions? This comment seems to suggest that's possible: https://github.com/llvm/llvm-project/blob/bbab5e47c17c0ebc9dfe20f43c8aeaae95f37b9e

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-17 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Is the plan to get the DIL data structures merged before the rest of the > > patch series is up for review? I think it'd be great to see how the > > infrastructure introduced here will be used > > There are 3 major pieces to the DIL implementation (soon to be 4, once I've

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-17 Thread Michael Buch via lldb-commits
Michael137 wrote: When you're stopped in a frame and you have libc++ frames above you in the backtrace, you're either stopped in a callback (like `std::function`, `std::make_unique`, `std::sort`), or you're deliberately stepping into libc++ code. For the latter, you probably don't want to hide

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-17 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > [...] like I said I'm a bit scared of it being too aggressive. Yes, this is also my main concern here. E.g., for `std::ranges::sort`, it already turns out to be slightly too aggressive, as discussed in the commit message and the test case comment. The "`std::ranges::sort`

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Now that #102928 landed, this commit is also ready for review https://github.com/llvm/llvm-project/pull/104589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang ready_for_review https://github.com/llvm/llvm-project/pull/104589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 79684ccb2b6312b0938de73641e89d7cd29ce1a8 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH] [lldb-dap] Implement value locations for function poi

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/104589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From 72c725469268d0bd39666d20f94404f81a0cb7ad Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH] [lldb-dap] Implement value locations for function poi

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: The above test failure above is in `lld`, not `lldb`. I don't see how this could have been caused by my change to `lldb-dap` https://github.com/llvm/llvm-project/pull/102928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-16 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/106443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes ## Context We have a customer reporting scenario that expanding "this" pointer for a non-trivial class method context takes more than **70~90 seconds**. This is a linux target with .debug_names index table enabl

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/108907 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/5] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-16 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. https://github.com/llvm/llvm-project/pull/108663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Thanks so much for putting together the patch for this. Yeah enabling these registers only when the thread flavor is available is not that simple, and I don't think the consequence of including them with zero values in all cases is bad one. Most general users will not be

[Lldb-commits] [lldb] Improve type and namespace lookup using parent chain (PR #108907)

2024-09-16 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/108907 ## Context We have a customer reporting scenario that expanding "this" pointer for a non-trivial class method context takes more than **70~90 seconds**. This is a linux target with .debug_names index table

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-09-16 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/5111 Here is the relevant pi

[Lldb-commits] [lldb] 0cc2cd7 - [lldb-dap] Provide `declarationLocation` for variables (#102928)

2024-09-16 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-17T02:18:52+02:00 New Revision: 0cc2cd781594aec741f7262df7a48d73a7d09a18 URL: https://github.com/llvm/llvm-project/commit/0cc2cd781594aec741f7262df7a48d73a7d09a18 DIFF: https://github.com/llvm/llvm-project/commit/0cc2cd781594aec741f7262df7a48d73a7d09a18

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/102928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106470 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/4] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/102928 >From 7dfcc909b97efe61e3af8bb9468ddc973f19b52d Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Sat, 10 Aug 2024 23:59:55 + Subject: [PATCH] [lldb-dap] Implement declaration locations This comm

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 34a856d47322cd35a7b568a335adbcd804f2302d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/3] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-09-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/102928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support frame recognizer regexp on mangled names. (PR #105756)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @adrian-prantl Now that https://github.com/llvm/llvm-project/pull/105695 is merged, do you still want to open a follow-up pull request to change the assert-recognizer and the verbose-trap-recognizer to use `ePreferMangled`? https://github.com/llvm/llvm-project/pull/105756 _

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

2024-09-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/108309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0975e2a - [LLDB][Minidump] Add a progress bar to minidump (#108309)

2024-09-16 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-09-16T15:13:35-07:00 New Revision: 0975e2ac58b6d62429d51df54911fb4d03dcda05 URL: https://github.com/llvm/llvm-project/commit/0975e2ac58b6d62429d51df54911fb4d03dcda05 DIFF: https://github.com/llvm/llvm-project/commit/0975e2ac58b6d62429d51df54911fb4d03dcda05.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

2024-09-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/108309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-16 Thread via lldb-commits
cmtice wrote: > Is the plan to get the DIL data structures merged before the rest of the > patch series is up for review? I think it'd be great to see how the > infrastructure introduced here will be used There are 3 major pieces to the DIL implementation (soon to be 4, once I've got the lexe

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-16 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 141b8cec8c266c7857c38e5da76ab538ac35c706 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3acb1ea - [lldb-dap] Support inspecting memory (#104317)

2024-09-16 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-16T22:56:20+02:00 New Revision: 3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e URL: https://github.com/llvm/llvm-project/commit/3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e DIFF: https://github.com/llvm/llvm-project/commit/3acb1eac5eb6ef4e60dd64b7845615e076cc6a3e

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-16 Thread Louis Dionne via lldb-commits
https://github.com/ldionne commented: This feels like a good idea, but I am also a bit scared of hiding too much stuff and making it difficult to figure out what's going wrong from a stack trace. It's not rational, I have no evidence to back this up and perhaps this is only fear of unknown. F

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-16 Thread Saleem Abdulrasool via lldb-commits
@@ -1,81 +1,59 @@ NDK_ROOT := $(shell dirname $(CC))/../../../../.. -ifeq "$(findstring 64, $(ARCH))" "64" - # lowest 64-bit API level - API_LEVEL := 21 -else ifeq "$(ARCH)" "i386" - # clone(2) declaration is present only since this api level - API_LEVEL

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-16 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Thanks for doing the modification. LGTM https://github.com/llvm/llvm-project/pull/104317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] lldb: get lldb API tests working with newer Android NDKs (PR #106443)

2024-09-16 Thread Andrew Rogers via lldb-commits
andrurogerz wrote: @labath there have been no additional comments; is there anyone specifically you'd like me to seek feedback from? @JDevlieghere would you have a moment to take a look at this PR soon? I really appreciate it. @compnerd FYI https://github.com/llvm/llvm-project/pull/106443 __

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-16 Thread Tobias Hieta via lldb-commits
tru wrote: /cherry-pick adf44d5c3ea03569f019740e1140c3205810b3fa 2bcab9ba7139cfa96c85433fa85b29c8a6d7008b https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6d3f6c2170dd60e86743c205e33ead2f455656b4...f0ffdc6f1d999dc3c774f1d42d03db286705c1b5 lldb

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-libcxx Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit changes the libc++ frame recognizer to hide implementation details of libc++ more aggressively. The applied heuristic is rather straightforward: We consider

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-09-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/108870 This commit changes the libc++ frame recognizer to hide implementation details of libc++ more aggressively. The applied heuristic is rather straightforward: We consider every function name starting with `_

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-16 Thread Michael Buch via lldb-commits
Michael137 wrote: Is the plan to get the DIL data structures merged before the rest of the patch series is up for review? I think it'd be great to see how the infrastructure introduced here will be used https://github.com/llvm/llvm-project/pull/95738 ___

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-09-16 Thread via lldb-commits
cmtice wrote: Ping? Anybody? https://github.com/llvm/llvm-project/pull/95738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

2024-09-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. https://github.com/llvm/llvm-project/pull/108719 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

2024-09-16 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/108719 >From 9f41e2a32f1800a9d98a749cf109d9a3072e2210 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Sat, 14 Sep 2024 14:23:01 -0700 Subject: [PATCH] [lldb][intel-pt] Fix build error on conversion from llvm::Error to S

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-16 Thread via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

<    1   2   3   4   5   6   7   8   9   10   >