[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: None (gbMattN) Changes Fixes issue #105960 If a member in a struct is also a struct, accessing a member partway through this inner struct currently causes a false positive. This is because when checking aliasing, the acce

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN created https://github.com/llvm/llvm-project/pull/108385 Fixes issue #105960 If a member in a struct is also a struct, accessing a member partway through this inner struct currently causes a false positive. This is because when checking aliasing, the access offset i

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Mehdi Amini via llvm-branch-commits
@@ -558,8 +558,8 @@ func.func @deinterleave(%a: vector<4xf32>) -> (vector<2xf32>, vector<2xf32>) { // CHECK-LABEL: func @deinterleave_scalar // CHECK-SAME: (%[[ARG0:.+]]: vector<2xf32>) -// CHECK: %[[EXTRACT0:.*]] = spirv.CompositeExtract %[[ARG0]][0 : i32] : vector<2x

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Mehdi Amini via llvm-branch-commits
https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/108381 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-spirv @llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) Changes PR #106760 aligned the handling of dropped block arguments and dropped op results. The two helper functions that insert source mate

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/108381 PR #106760 aligned the handling of dropped block arguments and dropped op results. The two helper functions that insert source materializations for uses of replaced block arguments / op results that s

[llvm-branch-commits] [llvm] release/19.x: [AVR] Fix 16-bit LDDs with immediate overflows (#104923) (PR #106993)

2024-09-12 Thread via llvm-branch-commits
aykevl wrote: I think it's up to the release managers now to merge this PR. https://github.com/llvm/llvm-project/pull/106993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-br

[llvm-branch-commits] [compiler-rt] [TySan] Fixed false positive when accessing offset member variables (PR #95387)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/95387 >From 8099113d68bd7c47c29f635bb10a048ddb99833b Mon Sep 17 00:00:00 2001 From: Matthew Nagy Date: Fri, 28 Jun 2024 16:12:31 + Subject: [PATCH] [TySan] Fixed false positive when accessing global object's membe

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Cache `UnresolvedMaterializationRewrite` (PR #108359)

2024-09-12 Thread Mehdi Amini via llvm-branch-commits
https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/108359 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Cache `UnresolvedMaterializationRewrite` (PR #108359)

2024-09-12 Thread Mehdi Amini via llvm-branch-commits
@@ -935,8 +909,10 @@ struct ConversionPatternRewriterImpl : public RewriterBase::Listener { /// to modify/access them is invalid rewriter API usage. SetVector replacedOps; - /// A set of all unresolved materializations. - DenseSet unresolvedMaterializations; + /// A ma

[llvm-branch-commits] [compiler-rt] [TySan] Fixed false positive when accessing offset member variables (PR #95387)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/95387 >From 8099113d68bd7c47c29f635bb10a048ddb99833b Mon Sep 17 00:00:00 2001 From: Matthew Nagy Date: Fri, 28 Jun 2024 16:12:31 + Subject: [PATCH 1/2] [TySan] Fixed false positive when accessing global object's m

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Cache `UnresolvedMaterializationRewrite` (PR #108359)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-core Author: Matthias Springer (matthias-springer) Changes The dialect conversion maintains a set of unresolved materializations (`UnrealizedConversionCastOp`). Turn that set into a `DenseMap` that maps from ops to `UnresolvedMaterializationRewrit

[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] Dialect conversion: Cache `UnresolvedMaterializationRewrite` (PR #108359)

2024-09-12 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/108359 The dialect conversion maintains a set of unresolved materializations (`UnrealizedConversionCastOp`). Turn that set into a `DenseMap` that maps from ops to `UnresolvedMaterializationRewrite *`. This i

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread via llvm-branch-commits
https://github.com/cor3ntin reopened https://github.com/llvm/llvm-project/pull/107214 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread via llvm-branch-commits
cor3ntin wrote: @tru done https://github.com/llvm/llvm-project/pull/107214 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread via llvm-branch-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/107214 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread via llvm-branch-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/107214 >From 8290ce0998788b6a575ed7b4988b093f48c25b3d Mon Sep 17 00:00:00 2001 From: cor3ntin Date: Tue, 3 Sep 2024 20:36:15 +0200 Subject: [PATCH] [Clang] Fix handling of placeholder variables name in init captures

[llvm-branch-commits] [llvm] release/19.x: [AVR] Fix 16-bit LDDs with immediate overflows (#104923) (PR #106993)

2024-09-12 Thread Patryk Wychowaniec via llvm-branch-commits
Patryk27 wrote: @benshi001 / @aykevl, is there something we can do to push this forward or it's waiting for someone else? https://github.com/llvm/llvm-project/pull/106993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://

[llvm-branch-commits] [sanitizer] Allow to override GetDTLSRange (PR #108348)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/108348 And rename it into __sanitizer_get_dtls_size. The test will be in a separate patch, as I expected reverts of the test. ___ llvm-branch-commits mailing list llvm-

[llvm-branch-commits] Test (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/108349 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] ecd542d - Revert "Reland "[amdgpu] Add llvm.amdgcn.init.whole.wave intrinsic" (#108054)…"

2024-09-12 Thread via llvm-branch-commits
Author: Diana Picus Date: 2024-09-12T09:51:27+02:00 New Revision: ecd542d0e8ee3a37e979ff761ab3c633bcda5baf URL: https://github.com/llvm/llvm-project/commit/ecd542d0e8ee3a37e979ff761ab3c633bcda5baf DIFF: https://github.com/llvm/llvm-project/commit/ecd542d0e8ee3a37e979ff761ab3c633bcda5baf.diff L

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/6] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/5] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-11 Thread Pengcheng Wang via llvm-branch-commits
https://github.com/wangpc-pp approved this pull request. LGTM. This fixes a bug that exists for a long time. https://github.com/llvm/llvm-project/pull/108288 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/4] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -2421,11 +2433,14 @@ std::error_code DataAggregator::writeBATYAML(BinaryContext &BC, const uint32_t InputOffset = BAT->translate( FuncAddr, OutputAddress - FuncAddr, /*IsBranchSrc=*/true); const unsigned BlockIndex = getBlock(InputOff

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, aaupov wrote: Replaced with `collectInlineTree` https://github.com/llvm/ll

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -246,10 +270,32 @@ template <> struct MappingTraits { } }; +namespace bolt { +struct PseudoProbeDesc { + std::vector GUID; + std::vector Hash; + std::vector GUIDHash; // Index of hash for that GUID in Hash aaupov wrote: > > // Index of hash for that

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -158,15 +164,35 @@ template <> struct MappingTraits { std::vector()); YamlIO.mapOptional("succ", BBP.Successors, std::vector()); -YamlIO.mapOptional("pseudo_probes", BBP.PseudoProbes, +YamlIO.mapOptional("probes", BB

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, + const MCDecodedPseudoProbeInlineTree *Root) { + auto getHa

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices + // Assume BlockMask == 1

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices aaupov wrot

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices aaupov wrot

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -158,15 +164,35 @@ template <> struct MappingTraits { std::vector()); YamlIO.mapOptional("succ", BBP.Successors, std::vector()); -YamlIO.mapOptional("pseudo_probes", BBP.PseudoProbes, +YamlIO.mapOptional("probes", BB

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -158,15 +164,35 @@ template <> struct MappingTraits { std::vector()); YamlIO.mapOptional("succ", BBP.Successors, std::vector()); -YamlIO.mapOptional("pseudo_probes", BBP.PseudoProbes, +YamlIO.mapOptional("probes", BB

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices + // Assume BlockMask == 1

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices wlei-llvm w

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, wlei-llvm wrote: Is it possible to give a more explicit name? when I saw th

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, + const MCDecodedPseudoProbeInlineTree *Root) { + auto getHa

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -95,24 +95,30 @@ template <> struct MappingTraits { namespace bolt { struct PseudoProbeInfo { - llvm::yaml::Hex64 GUID; - uint64_t Index; - uint8_t Type; + uint32_t InlineTreeIndex = 0; + uint64_t BlockMask = 0; // bitset with probe indices + // Assume BlockMask == 1

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, + const MCDecodedPseudoProbeInlineTree *Root) { + auto getHa

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -2421,11 +2433,14 @@ std::error_code DataAggregator::writeBATYAML(BinaryContext &BC, const uint32_t InputOffset = BAT->translate( FuncAddr, OutputAddress - FuncAddr, /*IsBranchSrc=*/true); const unsigned BlockIndex = getBlock(InputOff

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -246,10 +270,32 @@ template <> struct MappingTraits { } }; +namespace bolt { +struct PseudoProbeDesc { + std::vector GUID; + std::vector Hash; + std::vector GUIDHash; // Index of hash for that GUID in Hash wlei-llvm wrote: Give another name? IIUC, it

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Lei Wang via llvm-branch-commits
@@ -58,8 +60,164 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::getInlineTree(const MCPseudoProbeDecoder &Decoder, + const MCDecodedPseudoProbeInlineTree *Root) { + auto getHa

[llvm-branch-commits] [mlir] [mlir][GPU] Plumb range information through the NVVM lowerings (PR #107659)

2024-09-11 Thread Krzysztof Drewniak via llvm-branch-commits
@@ -209,7 +209,12 @@ struct GPULaneIdOpToNVVM : ConvertOpToLLVMPattern { ConversionPatternRewriter &rewriter) const override { auto loc = op->getLoc(); MLIRContext *context = rewriter.getContext(); -Value newOp = rewriter.create(loc, rewriter.getI

[llvm-branch-commits] [compiler-rt] 22b522a - Update sanitizer_tls_get_addr.cpp

2024-09-11 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2024-09-11T17:29:21-07:00 New Revision: 22b522a32d76c6c471707ceb6b9b4dcb9407db27 URL: https://github.com/llvm/llvm-project/commit/22b522a32d76c6c471707ceb6b9b4dcb9407db27 DIFF: https://github.com/llvm/llvm-project/commit/22b522a32d76c6c471707ceb6b9b4dcb9407db27.diff L

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Only parse probes for profiled functions in profile-write-pseudo-probes mode (PR #106365)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/106365 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Only parse probes for profiled functions in profile-write-pseudo-probes mode (PR #106365)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/106365 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][NFC] Rename profile-use-pseudo-probes (PR #106364)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/106364 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][NFC] Rename profile-use-pseudo-probes (PR #106364)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/106364 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match functions with pseudo probes (PR #100446)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/100446 >From 56b45b104a2ab2dbc4ab8e9643c90092894b579e Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Wed, 24 Jul 2024 11:29:22 -0700 Subject: [PATCH 1/5] Comment Created using spr 1.3.4 --- bolt/include/bolt/Profile/

[llvm-branch-commits] [llvm] [BOLT] Match functions with pseudo probes (PR #100446)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/100446 >From 56b45b104a2ab2dbc4ab8e9643c90092894b579e Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Wed, 24 Jul 2024 11:29:22 -0700 Subject: [PATCH 1/4] Comment Created using spr 1.3.4 --- bolt/include/bolt/Profile/

[llvm-branch-commits] [llvm] [BOLT] Match functions with pseudo probes (PR #100446)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/100446 >From 56b45b104a2ab2dbc4ab8e9643c90092894b579e Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Wed, 24 Jul 2024 11:29:22 -0700 Subject: [PATCH 1/4] Comment Created using spr 1.3.4 --- bolt/include/bolt/Profile/

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Rafael Auler via llvm-branch-commits
https://github.com/rafaelauler approved this pull request. LG https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][NFC] Rename profile-use-pseudo-probes (PR #106364)

2024-09-11 Thread Rafael Auler via llvm-branch-commits
https://github.com/rafaelauler approved this pull request. Makes sense, LG https://github.com/llvm/llvm-project/pull/106364 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bra

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-11 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (llvmbot) Changes Backport 866b93e6b33fac9a4bc62bbc32199bd98f434784 Requested by: @jonathonpenix --- Full diff: https://github.com/llvm/llvm-project/pull/108288.diff 2 Files Affected: - (modified) llvm/lib/Target/RISCV/RI

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-11 Thread via llvm-branch-commits
llvmbot wrote: @wangpc-pp What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/108288 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-11 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/108288 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-11 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/108288 Backport 866b93e6b33fac9a4bc62bbc32199bd98f434784 Requested by: @jonathonpenix >From e9246648ae352b514bad7570f0509b1337217619 Mon Sep 17 00:00:00 2001 From: Jonathon Penix Date: Wed, 11 Sep 2024 09:53:11 -0700

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-11 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-09-11 Thread Ilya Biryukov via llvm-branch-commits
ilya-biryukov wrote: Just wanted to give a short update that I'm still on it, but it takes longer than I initially anticipated. I've got entangled into a few spaghetti-like dependencies and untangling them takes a bit of time... I should be much closer now, hope to share something tomorrow. h

[llvm-branch-commits] [llvm] [AMDGPU] Fix sign confusion in performMulLoHiCombine (PR #106977)

2024-09-11 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > I am unsure what ROCm is in this case and what that would mean for LLVM users > if this fix is not included. GPU compute stack. Current ROCm releases are basing off of the LLVM release branches (in the past they were more random branch points) https://github.com/llvm/llvm-pro

[llvm-branch-commits] [llvm] [AMDGPU] Fix sign confusion in performMulLoHiCombine (PR #106977)

2024-09-11 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/106977 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-11 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/107466 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Introduce custom loop nest generation for loops in workshare construct (PR #101445)

2024-09-11 Thread via llvm-branch-commits
https://github.com/jeanPerier approved this pull request. Looks reasonable to me. https://github.com/llvm/llvm-project/pull/101445 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-11 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > I'm working on getting some runtime numbers now, sorry for the delay. No need to say sorry, I really appreciate your help! 😃 https://github.com/llvm/llvm-project/pull/107548 ___ llvm-branch-commits mailing list llvm-branch-commits@

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-11 Thread Luke Lau via llvm-branch-commits
lukel97 wrote: I collected the stats on the number of memcmps that were inlined, it looks like we're able to expand a good chunk of them: ``` Program expand-memcmp.NumMemCmpCalls expand-memcmp.NumMemCmpInlined

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-11 Thread Dimitry Andric via llvm-branch-commits
https://github.com/DimitryAndric approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108147 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [compiler-rt] [profile] Change __llvm_profile_counter_bias type to match llvm (PR #107362)

2024-09-11 Thread Petr Hosek via llvm-branch-commits
petrhosek wrote: I agree, while the risk is low, this issue has existed for several releases so it should fine do delay the fix a bit further. https://github.com/llvm/llvm-project/pull/107362 ___ llvm-branch-commits mailing list llvm-branch-commits@li

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-10 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (llvmbot) Changes Backport 6dbdb84 Requested by: @philnik777 --- Full diff: https://github.com/llvm/llvm-project/pull/108147.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaExprCXX.cpp (+2-1) - (modified) clang/test/SemaCX

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-10 Thread via llvm-branch-commits
llvmbot wrote: @DimitryAndric What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/108147 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-10 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/108147 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-10 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/108147 Backport 6dbdb84 Requested by: @philnik777 >From 94ceefd28c894b52a760a8127c414e2f1b7d3165 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Wed, 11 Sep 2024 08:47:24 +0200 Subject: [PATCH] [Clang] Fix crash

[llvm-branch-commits] [compiler-rt] 00b2d78 - Revert "[scudo] Fix the logic of MaxAllowedFragmentedPages (#107927)"

2024-09-10 Thread via llvm-branch-commits
Author: ChiaHungDuan Date: 2024-09-10T18:55:12-07:00 New Revision: 00b2d78142495605c0c01f9228620a96b5b949d3 URL: https://github.com/llvm/llvm-project/commit/00b2d78142495605c0c01f9228620a96b5b949d3 DIFF: https://github.com/llvm/llvm-project/commit/00b2d78142495605c0c01f9228620a96b5b949d3.diff

[llvm-branch-commits] [compiler-rt] eceac8e - Revert "Revert "[sanitizer] Add CHECKs to validate calculated TLS range" (#10…"

2024-09-10 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2024-09-10T17:46:05-07:00 New Revision: eceac8e53357b8d91f047f7a5fe954d987e05e53 URL: https://github.com/llvm/llvm-project/commit/eceac8e53357b8d91f047f7a5fe954d987e05e53 DIFF: https://github.com/llvm/llvm-project/commit/eceac8e53357b8d91f047f7a5fe954d987e05e53.diff L

[llvm-branch-commits] [compiler-rt] a7d156a - Revert "[sanitizer] Add CHECKs to validate calculated TLS range (#107941)"

2024-09-10 Thread via llvm-branch-commits
Author: Florian Mayer Date: 2024-09-10T16:12:46-07:00 New Revision: a7d156a7021ba9d72648a1c68668deb08a75a7ab URL: https://github.com/llvm/llvm-project/commit/a7d156a7021ba9d72648a1c68668deb08a75a7ab DIFF: https://github.com/llvm/llvm-project/commit/a7d156a7021ba9d72648a1c68668deb08a75a7ab.diff

[llvm-branch-commits] [llvm] 7ff656c - Revert "[llvm-lit] Process ANSI color codes in test output when formatting (#…"

2024-09-10 Thread via llvm-branch-commits
Author: Henrik G. Olsson Date: 2024-09-10T15:13:50-07:00 New Revision: 7ff656c48487213e52d9035f28877482d2cd86e2 URL: https://github.com/llvm/llvm-project/commit/7ff656c48487213e52d9035f28877482d2cd86e2 DIFF: https://github.com/llvm/llvm-project/commit/7ff656c48487213e52d9035f28877482d2cd86e2.di

[llvm-branch-commits] [libcxx] 72cfc74 - Revert "[libc++][string] Remove potential non-trailing 0-length array (#105865)"

2024-09-10 Thread via llvm-branch-commits
Author: Daniel Thornburgh Date: 2024-09-10T14:07:49-07:00 New Revision: 72cfc74a7c5cea78b174b668f6accaa955742a51 URL: https://github.com/llvm/llvm-project/commit/72cfc74a7c5cea78b174b668f6accaa955742a51 DIFF: https://github.com/llvm/llvm-project/commit/72cfc74a7c5cea78b174b668f6accaa955742a51.d

[llvm-branch-commits] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/3] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] d92f149 - Revert "Revert "[amdgpu] Add llvm.amdgcn.init.whole.wave intrinsic" (#108054)"

2024-09-10 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2024-09-10T09:52:01-07:00 New Revision: d92f149c714225128f2fcc4eac7cc8d5febfb0bf URL: https://github.com/llvm/llvm-project/commit/d92f149c714225128f2fcc4eac7cc8d5febfb0bf DIFF: https://github.com/llvm/llvm-project/commit/d92f149c714225128f2fcc4eac7cc8d5febfb0bf.diff L

[llvm-branch-commits] [llvm] 55c2b8c - Revert "[amdgpu] Add llvm.amdgcn.init.whole.wave intrinsic (#105822)"

2024-09-10 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2024-09-10T09:49:58-07:00 New Revision: 55c2b8c9cb9ebf9308746226abb7110431367015 URL: https://github.com/llvm/llvm-project/commit/55c2b8c9cb9ebf9308746226abb7110431367015 DIFF: https://github.com/llvm/llvm-project/commit/55c2b8c9cb9ebf9308746226abb7110431367015.diff L

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-10 Thread via llvm-branch-commits
R-Goc wrote: Indeed depending on specific optimizations sometimes there is a crash and sometimes there isn't. There are cases where clang 17 won't compile but clang 18 will, or where clang 20 will compile but clang 18 won't. Or none will compile at all. https://github.com/llvm/llvm-project/p

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-10 Thread Jessica Clarke via llvm-branch-commits
https://github.com/jrtc27 approved this pull request. This should be low risk. If the condition holds, it would previously dereference an invalid iterator, and either crash immediately thanks to assertions or use whatever junk's in memory. Now it will treat it the same as if there's an immedia

<    4   5   6   7   8   9   10   11   12   13   >