drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Gustavo-A-R-Silva/wifi-iwlwifi-mvm-Use-__counted_by-and-avoid-Wfamnae-warning
On 13/09/24 10:12, Jürgen Groß wrote:
On 13.09.24 10:07, Gustavo A. R. Silva wrote:
Hi all,
Friendly ping: who can take this, please? 🙂
I can carry it via the Xen tree.
Sounds good. :)
Thank you!
--
Gustavo
On 13/09/24 10:12, Jürgen Groß wrote:
On 13.09.24 10:07, Gustavo A. R. Silva wrote:
Hi all,
Friendly ping: who can take this, please? 🙂
I can carry it via the Xen tree.
Sounds good. :)
Thank you!
--
Gustavo
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
-Gustavo
On 21/08/24 22:16, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the rest
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
-Gustavo
On 07/08/24 17:19, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in order to avoid ending up with a flexible-array member in the
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
-Gustavo
On 21/08/24 22:16, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the rest
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
--
Gustavo
On 21/08/24 02:50, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
--
Gustavo
On 21/08/24 02:50, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the
Hi all,
Friendly ping: who can take this, please? 🙂
Thanks
--
Gustavo
On 15/08/24 21:54, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in order to avoid ending up with a flexible-array member in the
Hi all,
Friendly ping: who can take this, please? :)
Thanks
--
Gustavo
On 15/08/24 21:00, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in order to avoid ending up with a flexible-array member in the
[..]
- struct sdhci_cdns_phy_param phy_params[];
+ struct sdhci_cdns_phy_param phy_params[] __counted_by(count);
It seems there is no such `count` member in the structure[1].
Since `counted_by` hasn't been released in GCC yet. Please, make
sure to build-test any `counted_by` patch
Hi!
One day, I watched a video from Greg: https://youtu.be/LLBrBBImJt4, and I started wondering if maybe I could contribute to the Linux kernel.
If you are interested in security, fixing Coverity issues is a great way to
contribute to the kernel. Here are some presentations that you might fin
On 02/09/24 06:46, Simon Horman wrote:
ethtool_puts() is the preferred method for copying ethtool strings.
And ethtool_puts() is already used to copy ethtool strings in
igc_ethtool_get_strings(). With this patch igc_ethtool_get_strings()
uses it for all such cases.
In general, the compiler ca
pnfs_block_deviceaddr with a single volume.
Signed-off-by: Thorsten Blum
Looks good --`nr_volumes` is updated just before accessing `volumes[]`.
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
fs/nfsd/blocklayout.c| 6 ++
fs/nfsd/blocklayoutxdr.h | 2 +-
2 files changed, 3
On 27/08/24 02:22, Johannes Berg wrote:
On Tue, 2024-08-06 at 12:08 -0600, Gustavo A. R. Silva wrote:
+++ b/include/net/ieee80211_radiotap.h
@@ -24,31 +24,36 @@
* struct ieee80211_radiotap_header - base radiotap header
*/
struct ieee80211_radiotap_header
On 22/08/24 11:27, Kees Cook wrote:
On Wed, Aug 21, 2024 at 02:16:21PM -0600, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the rest of the
On 22/08/24 11:27, Kees Cook wrote:
On Wed, Aug 21, 2024 at 02:16:21PM -0600, Gustavo A. R. Silva wrote:
Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
a flexible structure where the size of the flexible-array member
is known at compile-time, and refactor the rest of the
On 21/08/24 15:06, Andy Shevchenko wrote:
On Wed, Aug 21, 2024 at 02:59:34PM -0600, Gustavo A. R. Silva wrote:
On 21/08/24 14:26, Andy Shevchenko wrote:
On Thu, Feb 02, 2023 at 07:32:00PM -0600, Gustavo A. R. Silva wrote:
One-element arrays are deprecated, and we are replacing them with
henko
Closes:
https://lore.kernel.org/linux-hardening/zszngfnewocpd...@black.fi.intel.com/
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/marvell/mwifiex/fw.h | 2 +-
drivers/net/wireless/marvell/mwifiex/scan.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
On 21/08/24 14:26, Andy Shevchenko wrote:
On Thu, Feb 02, 2023 at 07:32:00PM -0600, Gustavo A. R. Silva wrote:
One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element arrays with flexible-array
members in multiple structures
: warning: structure containing a
flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a
: warning: structure containing a
flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a
containing a flexible array member
is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/xen/pci.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index
containing a flexible array member
is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/xen/pci.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/xen/pci.c b/drivers/xen/pci.c
index
end of another structure [-Wflex-array-member-not-at-end]
drivers/nfc/pn533/usb.c:275:38: warning: structure containing a flexible array
member is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/nfc/pn533/usb.c | 1 -
1 file
On 08/08/24 12:51, Kees Cook wrote:
On Wed, Aug 07, 2024 at 09:19:07AM -0600, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in order to avoid ending up with a flexible-array member in the
middle of
-by: Thorsten Blum
Looks good.
Reviewed-by: Gustavo A. R. Silva
Thanks
-Gustavo
---
Changes in v2:
- Take struct size changes into account and do not subtract 2 additional
bytes after feedback from Gustavo A. R. Silva
- Compare the binaries before and after the conversion and add a note
On 16/08/24 07:58, Thorsten Blum wrote:
Replace the deprecated one-element arrays with flexible-array members
in the structs filesystem_attribute_info and filesystem_device_info.
Notice that this also affects the size of the involved structs.
I encourage you to study some of the patches th
of another
structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
.../net/wireless/intel/iwlwifi/fw/api/tdls.h | 4 +-
.../net/wireless/intel/iwlwifi/fw/api/tx.h| 61 ++-
.../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 8 ++-
drivers/net/wireless
/intel/iwlwifi/dvm/commands.h:2426:27: warning: structure
containing a flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
.../net/wireless/intel/iwlwifi/dvm/commands.h | 154 +-
1 file changed, 78
flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
drivers/net/wireless/mediatek/mt76/mt7915/mcu.h:58:37: warning: structure
containing a flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A
structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intel/iwlegacy/3945.c| 2 +-
drivers/net/wireless/intel/iwlegacy/3945.h| 6 +-
.../net/wireless/intel/iwlegacy/4965-mac.c| 2 +-
.../net/wireless/intel/iwlegacy/commands.h
/cxgb4_tc_u32_parse.h:245:27: warning:
structure containing a flexible array member is not at the end of another
structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h | 2 +-
1 file changed, 1 insertion(+), 1
layout of the
flexible structure.
This new tagged struct will be used to fix problematic declarations
of middle-flex-arrays in composite structs[1].
[1] https://git.kernel.org/linus/d88cabfd9abc
Signed-off-by: Gustavo A. R. Silva
---
include/uapi/linux/pkt_cls.h | 23 +--
1
Small patch series aimed at fixing a -Wflex-array-member-not-at-end
warning by creating a new tagged struct within a flexible structure.
We then use this new struct type to fix a problematic middle-flex-array
declaration in a composite struct.
Gustavo A. R. Silva (2):
UAPI: net/sched: Use
On 09/08/24 20:21, Jeff Johnson wrote:
On 8/9/2024 9:20 AM, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice
that `struct
-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
Changes in v2:
- Fix use of keylen variable.
.../net/wireless/intel/iwlwifi/fw/api/sta.h | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 126 --
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2
-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
.../net/wireless/intel/iwlwifi/fw/api/sta.h | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 126 --
drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 2 +-
include/net/mac80211.h| 2
containing a
flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath12k/core.h | 4 +++-
drivers/net/wireless/ath/ath12k/dp.h | 12
2 files changed, 3 insertions(+), 13
-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/ath11k/core.h | 4 +++-
drivers/net/wireless/ath/ath11k/dp.h | 23 ---
2 files changed, 3 insertions(+), 24 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.h
b/drivers/net/wireless/ath/ath11k/core.h
index
potential bugs in the future.
So, with these changes, fix the following warning:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h:245:27: warning:
structure containing a flexible array member is not at the end of another
structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R
is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
Changes in v2:
- Remove flex array. (Jakub).
net/sched/act_ct.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index
On 08/08/24 20:46, Jakub Kicinski wrote:
On Mon, 5 Aug 2024 09:35:46 -0600 Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice
that `struct
sert()` to ensure that the memory layout for both
the flexible structure and the tagged struct is the same after any
changes.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/marvell/mwl8k.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/marvell/mwl8k.c
b/d
tic_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
drivers/crypto/nx/nx-842.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/nx/nx-842.h b/drivers/crypto/n
tic_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
drivers/crypto/nx/nx-842.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/nx/nx-842.h b/drivers/crypto/n
to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/net
ded within these tagged structs.
So, we use `static_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
net/smc/smc_clc.h | 4
1 file changed, 4 insertions(+)
diff --git
tic_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
drivers/crypto/intel/qat/qat_common/qat_bl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/intel/qat/
ese tagged structs.
So, we use `static_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
security/integrity/integrity.h | 4
1 file changed, 4 insertions(+)
diff --git
tic_assert()` to ensure that the memory layout for
both the flexible structure and the tagged struct is the same after
any changes.
Signed-off-by: Gustavo A. R. Silva
---
fs/smb/common/smb2pdu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/smb/common/smb2pdu.h b/fs/smb/common/smb2p
.../chelsio/cxgb4/cxgb4_tc_u32_parse.h| 2 +-
include/uapi/linux/pkt_cls.h | 23 +++
Took me a minute to realize you're changing uAPI.
Please fix the subject.
What would be a preferred subject?
--
Gustavo
On 08/08/24 09:00, Thorsten Blum wrote:
Add the __counted_by compiler attribute to the flexible array member
entries to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.
Signed-off-by: Thorsten Blum
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
@@ -48,7 +51,7 @@ struct glink_msg {
struct glink_defer_cmd {
struct list_head node;
- struct glink_msg msg;
+ struct glink_msg_hdr msg;
u8 data[];
};
Instead of this change (and the container_of() uses below), I think you
can just simply drop "data" here. I don'
.
Signed-off-by: Thorsten Blum
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
kernel/rcu/tree.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index e641cc681901..76d8d75dd8b3 100644
--- a/kernel/rcu/tree.c
+++ b/kernel
is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/rpmsg/qcom_glink_native.c | 42 +--
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg
structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/intel/ipw2x00/libipw.h | 46 -
1 file changed, 18 insertions(+), 28 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/libipw.h
b/drivers/net/wireless/intel/ipw2x00
]
drivers/net/wireless/virtual/mac80211_hwsim.c:767:42: warning: structure
containing a flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ath/wil6210/txrx.c | 2 +-
drivers/net/wireless
On 06/08/24 03:42, Igor Russkikh wrote:
On 8/5/2024 5:32 PM, Gustavo A. R. Silva wrote:
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally. Move the conflicting declaration to
the end of the structure. Notice that `struct
/perf_event.h:289:41: warning: structure containing a
flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
arch/x86/events/amd/core.c | 4 +++-
arch/x86/events/core.c | 4 +++-
arch/x86/events/intel/ds.c | 4
bugs in the future.
So, with these changes, fix the following warning:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32_parse.h:245:27: warning:
structure containing a flexible array member is not at the end of another
structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
warning:
./drivers/net/ethernet/chelsio/cxgb4/cxgb4.h:1215:29: warning: structure
containing a flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 7 ---
1 file
warning:
net/sched/act_ct.c:57:29: warning: structure containing a flexible array member
is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
net/sched/act_ct.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net
flexible array member is not at the end of another
structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/aquantia/atlantic/aq_hw.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_hw.h
/fun_dev.c:550:43: warning: structure
containing a flexible array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/ethernet/fungible/funcore/fun_dev.c | 17 +++--
1 file changed, 7 insertions(+), 10
ble array member is not at the end of another structure
[-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva
---
sound/soc/sof/sof-audio.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sof/sof-audio.h b/sound/soc/sof/sof-audio.h
index 49be02234
alloc()'.
Signed-off-by: Dmitry Antipov
Reviewed-by: Gustavo A. R. Silva
Thanks
-Gustavo
---
v3: one more style nit (Jakub)
https://lore.kernel.org/netdev/20240731165029.5f4b4...@kernel.org
v2: style (Jakub), title and commit message (Gustavo) adjustments
https://lore.kern
ext4_expand_inode_array() as suggested by Gustavo A. R. Silva
- Use struct_size() and struct_size_t() instead of offsetof()
- Link to v1:
https://lore.kernel.org/linux-kernel/20240729110454.346918-3-thorsten.b...@toblux.com/
Changes in v3:
- Use struct_size() instead of struct_size_t() as suggested by Kees Cook
size()' to simplify the math used in 'kzalloc()'. >
Signed-off-by: Dmitry Antipov
Looks correct.
Reviewed-by: Gustavo A. R. Silva
---
include/net/sock_reuseport.h | 2 +-
net/core/sock_reuseport.c| 7 +++
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/in
x27;s count data type.
Compile-tested only.
Signed-off-by: Thorsten Blum
---
Changes in v2:
- Adjust ext4_expand_inode_array() as suggested by Gustavo A. R. Silva
- Use struct_size() and struct_size_t() instead of offsetof()
- Link to v1:
https://lore.kernel.org/linux-kernel/20240729110454.346
On 29/07/24 05:04, Thorsten Blum wrote:
Add the __counted_by compiler attribute to the flexible array member
inodes to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.
This change seems to be incomplete. The relationship between `count` and
accesses to `inode
Hi all,
On 26/07/24 14:07, Linus Walleij wrote:
Hi Haoyu,
On Wed, Jul 24, 2024 at 11:12 AM Haoyu Li wrote:
Dear Linux Developers for GPIO SUBSYSTEM,
We are curious about the use of `struct ljca_gpio_packet *packet` in the
function `ljca_gpio_config`
(https://elixir.bootlin.com/linux/v6.10
t;sglen" after allocation.
Fixes: b85178611c11 ("dmaengine: ti: omap-dma: Annotate struct omap_desc with
__counted_by")
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Peter Ujfalusi
Cc: Vinod Koul
Cc: dmaeng...@vger.kernel.org
---
drive
egister() was missed. Set "num_nodes" after allocation.
Fixes: dd4904f3b924 ("interconnect: qcom: Annotate struct icc_onecell_data with
__counted_by")
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Georgi Djakov
Cc: linux...@vger.k
uot;
index "0" will not be considered valid during the initialization for loop.
Fix this by setting lli_size immediately after allocation (similar to
how this is handled in stm32_mdma_alloc_desc() for the node/count
relationship).
Fixes: f561ec8b2b33 ("dmaengine: Add STM32 DMA
s: gpio: Annotate struct gpio_leds_priv with
__counted_by")
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Lee Jones
Cc: Pavel Machek
Cc: linux-l...@vger.kernel.org
---
drivers/leds/leds-gpio.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletio
[1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Brian King
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-s...@vger.kernel.org
---
drivers/scsi/ipr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
SPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks!
--
Gustavo
---
Cc: Sathya Prakash
Cc: Sreekanth Reddy
Cc: Suganath Prabu Subramani
Cc: "Gustavo A. R. Silva"
Cc: mpt-fusionlinux@broadcom.com
Cc: linux-s...@vger.kernel.org
_data.pIocPg3->PhysDisk[i].PhysDiskNum,
No binary differences are present after this conversion.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Sathya Prakash
Cc: Sreekanth Reddy
Cc: Suganath Prabu Su
a.pIocPg2->RaidVolume[i].VolumeID ==
id)
mptspi.c: for (i=0; i < ioc->raid_data.pIocPg2->NumActiveVolumes; i++) {
mptspi.c: if (ioc->raid_data.pIocPg2->RaidVolume[i].VolumeID ==
id) {
No binary differences are present after this conversion.
Link: https://github.com/K
buffer->Path[i].PhysDiskID;
mptbase.c: phys_disk->Path[i].PhysDiskBus =
buffer->Path[i].PhysDiskBus;
No binary differences are present after this conversion.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
No binary differences are present after this conversion.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks!
--
Gustavo
---
Cc: Sathya Prakash
Cc: Sreekanth Reddy
Cc: Suganath Prabu Subramani
Cc: "Gustavo A. R. Silva&qu
hub.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks!
--
Gustavo
---
Cc: Sathya Prakash
Cc: Sreekanth Reddy
Cc: Suganath Prabu Subramani
Cc: "Gustavo A. R. Silva"
Cc: mpt-fusionlinux@broadcom.com
Cc: linux-s...@vger.kernel.org
(AAC_MAX_HRRQ - 1) * sizeof(struct _rrq),
+ AAC_MAX_HRRQ * sizeof(struct _rrq),
struct_size_t() can be used here?
In any case:
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
0, 0, 0, NULL, NULL, NULL, NULL, N
size = sizeof(struct aac_ciss_phys_luns_resp) +
- (AAC_MAX_TARGETS - 1) * sizeof(struct _ciss_lun);
+ AAC_MAX_TARGETS * sizeof(struct _ciss_lun);
I think this is a good candidate for struct_size().
In any case:
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
rst MR_HOST_DEVICE_LIST_ENTRY.
Yeah, clearing that fist entry seems odd/buggy. So, this patch is probably
even fixing a bug. :)
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Kashyap Desai
Cc: Su
: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Shivasharan S
Cc: Chandrakanth patil
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: megaraidlinux@broadcom.com
Cc: linux-s...@vger.kernel.org
---
drivers/scsi/megaraid/megar
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Sathya Prakash Veerichetty
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Sreekanth Reddy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Ranjan Kumar
Cc: mpi3mr-linuxdrv@broadcom.com
Cc: linux-s...@vger.kern
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Sathya Prakash Veerichetty
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Sreekanth Reddy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Ranjan Kumar
Cc: mpi3mr-linuxdrv@broadcom.com
Cc: linux-s...@vger.kern
-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Sathya Prakash Veerichetty
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Sreekanth Reddy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: "Gustavo A. R. Silva"
Cc: Ranjan Kumar
Cc
-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: Sathya Prakash Veerichetty
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Sreekanth Reddy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: "Gustavo A. R. Silva"
Cc: Ranjan Kumar
Cc
On 10/07/24 17:32, Gustavo A. R. Silva wrote:
On 10/07/24 16:55, Kees Cook wrote:
While efi_memory_attributes_table_t::entry isn't used directly as an
array, it is used as a base for pointer arithmetic. The type is wrong
as it's not technically an array of efi_memory_desc_t
efi_memory_desc_t entry[];
a candidate for future __counted_by(num_entries * desc_size) ? :p
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
} efi_memory_attributes_table_t;
typedef struct {
s change.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
Reviewed-by: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: David Sterba
Cc: linux-fsde...@vger.kernel.org
---
fs/affs/amigaffs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/
: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: David Sterba
Cc: linux-fsde...@vger.kernel.org
---
fs/affs/amigaffs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
index 09dc23a644df..1b973a669d23 100644
--- a/fs/affs/amigaffs.h
: Gustavo A. R. Silva
Thanks
--
Gustavo
---
Cc: David Sterba
Cc: linux-fsde...@vger.kernel.org
---
fs/affs/amigaffs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/amigaffs.h b/fs/affs/amigaffs.h
index 81fb396d4dfa..5509fbc98bc0 100644
--- a/fs/affs/amigaffs.h
;pages" to a flexible
array.
No binary differences are present after this conversion.
Link: https://github.com/KSPP/linux/issues/79 [1]
Signed-off-by: Kees Cook
---
Cc: Hans de Goede
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: "Gustavo A. R. Silva"
Cc: linux-hardening@vger
ship.
Signed-off-by: Kees Cook
---
Cc: Stanimir Varbanov
Cc: Vikash Garodia
Cc: "Bryan O'Donoghue"
Cc: Mauro Carvalho Chehab
Cc: "Gustavo A. R. Silva"
Cc: linux-me...@vger.kernel.org
Cc: linux-arm-...@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Reviewe
---
Cc: Stanimir Varbanov
Cc: Vikash Garodia
Cc: "Bryan O'Donoghue"
Cc: Mauro Carvalho Chehab
Cc: "Gustavo A. R. Silva"
Cc: linux-me...@vger.kernel.org
Cc: linux-arm-...@vger.kernel.org
Cc: linux-hardening@vger.kernel.org
Reviewed-by: Gustavo A. R. Silva
Thanks
-
On 09/07/24 12:20, Mirsad Todorovac wrote:
On 7/9/24 01:44, Gustavo A. R. Silva wrote:
On 7/8/24 14:22, Kees Cook wrote:
Modern (fortified) memcpy() prefers to avoid writing (or reading) beyond
the end of the addressed destination (or source) struct member:
In function
1 - 100 of 1796 matches
Mail list logo
