Re: [tipc-discussion] TIPC Communication

2022-06-15 Thread Hoang Huu Le
Hi, Please take an example at: https://sourceforge.net/p/tipc/tipcutils/ci/master/tree/demos/connection_demo/ Regards, Hoang > -Original Message- > From: Røysland, Jonas Gjendem via tipc-discussion > > Sent: Tuesday, June 14, 2022 8:22 PM > To: tipc-discussion@lists.sourceforge.net >

Re: [tipc-discussion] [PATCH] tipc: fix use-after-free Read in tipc_named_reinit

2022-06-12 Thread Hoang Huu Le
Hi Jon, Ying, Just remind in case you guys missed this email thread. Thanks, Hoang > -Original Message- > From: Hoang Le > Sent: Tuesday, June 7, 2022 2:35 PM > To: jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; Tung Quang > Nguyen ; >

Re: [tipc-discussion] [PATCH net-next] tipc: remove inputq from tipc_bc_base

2022-06-06 Thread Hoang Huu Le
> -Original Message- > From: Xin Long > Sent: Tuesday, June 7, 2022 12:57 AM > To: tipc-discussion@lists.sourceforge.net > Subject: Re: [tipc-discussion] [PATCH net-next] tipc: remove inputq from > tipc_bc_base > > fix Jon's email address. > > On Mon, Jun 6, 2022 at 1:52 PM Xin Long

Re: [tipc-discussion] [PATCH net] tipc: use a write lock for keepalive_intv instead of a read lock

2022-03-29 Thread Hoang Huu Le
age- > From: Niels Dossche > Sent: Tuesday, March 29, 2022 11:12 PM > To: tipc-discussion@lists.sourceforge.net > Cc: net...@vger.kernel.org; Jon Maloy ; Ying Xue > ; David S. Miller > ; Jakub Kicinski ; Paolo Abeni > ; Hoang Huu Le > ; Niels Dossche > Subject:

Re: [tipc-discussion] Setting Node Address

2021-09-22 Thread Hoang Huu Le
From: Andy Stec Sent: Thursday, September 23, 2021 10:14 AM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net Subject: Re: Setting Node Address Which command is still supported, is it 'tipc node set address'? I'm getting operation not permitted error when I use 'tipc node set address

Re: [tipc-discussion] Setting Node Address

2021-09-22 Thread Hoang Huu Le
Let's use 'tipc node set identity' instead. However, that command is still support as legacy, this means you can continue using it in your application. > -Original Message- > From: Andy Stec via tipc-discussion > Sent: Thursday, September 23, 2021 8:16 AM > To:

Re: [tipc-discussion] Strange behavior in socket.c::tipc_sk_enqueue()

2021-09-08 Thread Hoang Huu Le
> -Original Message- > From: Jon Maloy > Sent: Thursday, September 9, 2021 5:42 AM > To: Hoang Huu Le ; > tipc-discussion@lists.sourceforge.net; Tung Quang Nguyen > ; Xin Long ; Ying Xue > > Cc: Huy Xuan Nhat Hoang > Subject: Re: Strange behavior i

Re: [tipc-discussion] Strange behavior in socket.c::tipc_sk_enqueue()

2021-09-06 Thread Hoang Huu Le
> -Original Message- > From: Jon Maloy > Sent: Wednesday, September 1, 2021 7:39 AM > To: Hoang Huu Le ; > tipc-discussion@lists.sourceforge.net; Tung Quang Nguyen > ; Xin Long ; Ying Xue > > Cc: Huy Xuan Nhat Hoang > Subject: Re: Strange behavior in socket.c::

Re: [tipc-discussion] [PATCH net-next] tipc: Return the correct errno code

2021-08-02 Thread Hoang Huu Le
Hi Zheng, The patch was being merged by accident. Will have you planning to revert it? We need to do ASAP since calling path tipc_node_xmit() -> tipc_link_xmit() broken as side effect. Thanks, hoang > -Original Message- > From: zhengyongjun > Sent: Friday, June 4, 2021 8:35 AM > To:

Re: [tipc-discussion] Strange behavior in socket.c::tipc_sk_enqueue()

2021-07-28 Thread Hoang Huu Le
Hi Jon, Let's enjoy your vacation. Our new team member (CCed) will take a look at it. Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Wednesday, July 28, 2021 6:20 AM > To: tipc-discussion@lists.sourceforge.net; Tung Quang Nguyen > ; Hoang Huu Le > ; X

[tipc-discussion] FW: [syzbot] KASAN: use-after-free Read in tipc_recvmsg

2021-07-22 Thread Hoang Huu Le
Hi Xin, I think the issue caused by your patch: f4919ff59c282 ("tipc: keep the skb in rcv queue until the whole data is read) 1976 if (!skb_cb->bytes_read) 1977 tsk_advance_rx_queue(sk); <-- skb free-ed here 1978 1979 if (likely(!connected) ||

Re: [tipc-discussion] [net-next v2 0/3] tipc: some small cleanups

2021-04-14 Thread Hoang Huu Le
Series Tested-by: Hoang Le > -Original Message- > From: jma...@redhat.com > Sent: Thursday, April 8, 2021 3:59 AM > To: tipc-discussion@lists.sourceforge.net > Cc: Tung Quang Nguyen ; Hoang Huu Le > ; Tuong Tong Lien > ; jma...@redhat.com; ma...@donjonn.com; &g

Re: [tipc-discussion] [net-next 3/4] tipc: refactor function tipc_sk_anc_data_recv()

2021-03-31 Thread Hoang Huu Le
> -Original Message- > From: jma...@redhat.com > Sent: Thursday, March 25, 2021 10:56 PM > To: tipc-discussion@lists.sourceforge.net > Cc: Tung Quang Nguyen ; Hoang Huu Le > ; Tuong Tong Lien > ; jma...@redhat.com; ma...@donjonn.com; > l...@redhat.com

Re: [tipc-discussion] [iproute2-next] tipc: add support for the netlink extack

2021-03-25 Thread Hoang Huu Le
> -Original Message- > From: David Ahern > Sent: Thursday, March 25, 2021 10:08 AM > To: Hoang Huu Le ; net...@vger.kernel.org; > tipc-discussion@lists.sourceforge.net; > jma...@redhat.com; ma...@donjonn.com; ying@windriver.com; Tuan Anh Vo > ; Tung Quang &g

[tipc-discussion] [net-next v2 2/2] tipc: clean up warnings detected by sparse

2021-03-11 Thread Hoang Huu Le
:expected struct tipc_aead [noderef] __rcu *__tmp net/tipc/crypto.c:1201:9:got struct tipc_aead * [...] v2: switch to use the keyword "__always_inline" for inline function Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/crypto.c | 13 +- net/tipc/moni

[tipc-discussion] [net-next v2 1/2] tipc: convert dest node's address to network order

2021-03-11 Thread Hoang Huu Le
From: Hoang Le (struct tipc_link_info)->dest is in network order (__be32), so we must convert the value to network order before assigning. The problem detected by sparse: net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)

[tipc-discussion] [net-next 2/2] tipc: clean up warnings detected by sparse

2021-03-10 Thread Hoang Huu Le
:expected struct tipc_aead [noderef] __rcu *__tmp net/tipc/crypto.c:1201:9:got struct tipc_aead * [...] Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/crypto.c | 12 - net/tipc/monitor.c | 63 ++ net/tipc/node.c| 5 3

[tipc-discussion] [net-next 1/2] tipc: convert dest node's address to network order

2021-03-10 Thread Hoang Huu Le
From: Hoang Le (struct tipc_link_info)->dest is in network order (__be32), so we must convert the value to network order before assigning. The problem detected by sparse: net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)

[tipc-discussion] [net-next] tipc: remove duplicated code in tipc_msg_create

2021-01-25 Thread Hoang Huu Le
Remove a duplicate code checking for header size in tipc_msg_create() as it's already being done in tipc_msg_init(). Signed-off-by: Hoang Huu Le --- net/tipc/msg.c | 4 1 file changed, 4 deletions(-) diff --git a/net/tipc/msg.c b/net/tipc/msg.c index 2aca86021df5..e9263280a2d4 100644

[tipc-discussion] [net-next v2 1/2] tipc: convert dest node's address to network order

2021-01-18 Thread Hoang Huu Le
From: Hoang Le (struct tipc_link_info)->dest is in network order (__be32), so we must convert the value to network order before assigning. The problem detected by sparse: net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types)

[tipc-discussion] [net-next v2 2/2] tipc: clean up warnings detected by sparse

2021-01-18 Thread Hoang Huu Le
:expected struct tipc_aead [noderef] __rcu *__tmp net/tipc/crypto.c:1201:9:got struct tipc_aead * [...] Signed-off-by: Hoang Huu Le --- net/tipc/crypto.c | 12 - net/tipc/monitor.c | 63 ++ net/tipc/node.c| 5 3 files changed, 58

[tipc-discussion] [net-next] tipc: clean up warnings detected by sparse

2021-01-14 Thread Hoang Huu Le
: sparse: warning: cast to restricted __be32 [...] --- Signed-off-by: Hoang Huu Le --- net/tipc/crypto.c | 12 ++-- net/tipc/monitor.c| 32 net/tipc/netlink_compat.c | 2 +- net/tipc/node.c | 5 + 4 files changed, 28 insertions

[tipc-discussion] [net] tipc: fix NULL deref in tipc_link_xmit()

2021-01-05 Thread Hoang Huu Le
From: Hoang Le The buffer list can have zero skb as following path: tipc_named_node_up()->tipc_node_xmit()->tipc_link_xmit(), so we need to check the list before casting an _buff. Fault report: [] tipc: Bulk publication failure [] general protection fault, probably for non-canonical [#1]

[tipc-discussion] [net-next] tipc: do sanity check payload of a netlink message

2020-12-11 Thread Hoang Huu Le
From: Hoang Le We initialize nlmsghdr without any payload in tipc_nl_compat_dumpit(), then, result of calling parse attributes always fails and return with '-EINVAL' error. To fix error returning when parsing attributes of a netlink message, we do a sanity check the length of message payload.

Re: [tipc-discussion] BUG: rwlock bad magic on CPU, kworker/0:LINE/NUM, ADDR

2020-12-09 Thread Hoang Huu Le
Hi Jon, See my inline comment … Regards, Hoang From: Jon Maloy Sent: Wednesday, December 9, 2020 5:22 PM To: Hoang Huu Le Cc: tipc-discussion@lists.sourceforge.net; tipc-dek Subject: Fwd: BUG: rwlock bad magic on CPU, kworker/0:LINE/NUM, ADDR Hi Hoang, This was the one I had in mind. To me

[tipc-discussion] [net-next] tipc: support 128bit node identity for peer removing

2020-12-02 Thread Hoang Huu Le
From: Hoang Le We add the support to remove a specific node down with 128bit node identifier, as an alternative to legacy 32-bit node address. example: $tipc peer remove identiy <1001002|1677> Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/node.c | 21 ++--- 1

[tipc-discussion] [net-next] tipc: support 128bit node identity for peer removing

2020-12-01 Thread Hoang Huu Le
From: Hoang Le We add the support to remove a specific node down with 128bit node identifier, as an alternative to legacy 32-bit node address. example: $tipc peer remove identiy <1001002|1677> Signed-off-by: Hoang Le --- net/tipc/node.c | 21 ++--- 1 file changed, 18

[tipc-discussion] [net] tipc: fix incompatiable mtu of transmission

2020-11-26 Thread Hoang Huu Le
From: Hoang Le In commit 682cd3cf946b6 ("tipc: confgiure and apply UDP bearer MTU on running links"), we introduced a function to change UDP bearer MTU and applied this new value across existing per-link. However, we did not apply this new MTU value at node level. This lead to packet dropped at

Re: [tipc-discussion] [net] tipc: re-configure queue limit for broadcast link

2020-10-14 Thread Hoang Huu Le
, Hoang > -Original Message- > From: Jakub Kicinski > Sent: Thursday, October 15, 2020 7:47 AM > To: Hoang Huu Le > Cc: tipc-discussion@lists.sourceforge.net; jma...@redhat.com; > ma...@donjonn.com; ying@windriver.com; > net...@vger.kernel.org > Subject: Re: [net]

[tipc-discussion] [next v2] tipc: fix incorrect setting window for bcast link

2020-10-14 Thread Hoang Huu Le
fix window 50) However, when setting maximum window variable via command, the window variable was re-initialized to unexpect value (i.e 32). We fix this by updating the fix window for broadcast as we stated. Fixes: 16ad3f4022bb ("tipc: introduce variable window congestion control") Sign

[tipc-discussion] [net] tipc: re-configure queue limit for broadcast link

2020-10-13 Thread Hoang Huu Le
the function to re-calculate queue limit of the broadcast link. Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/bcast.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index 940d176e0e87..c77fd13e2777 100644 --- a/net/tipc/bcast.c

Re: [tipc-discussion] [net] tipc: fix incorrect setting window for bcast link

2020-10-12 Thread Hoang Huu Le
> -Original Message- > From: Jon Maloy > Sent: Tuesday, October 13, 2020 6:39 AM > To: Hoang Huu Le ; > tipc-discussion@lists.sourceforge.net; ma...@donjonn.com; > ying@windriver.com > Subject: Re: [net] tipc: fix incorrect setting window for bcast link > &

[tipc-discussion] [net-next] tipc: remove dead code in tipc_net and relatives

2020-10-08 Thread Hoang Huu Le
dist_queue is no longer used since commit 37922ea4a310 ("tipc: permit overlapping service ranges in name table") Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 2 -- net/tipc/core.h | 3 --- net/tipc/name_distr.c | 19 --- 3 files changed, 24 deletion

Re: [tipc-discussion] [net] tipc: fix NULL pointer dereference in tipc_named_rcv

2020-10-08 Thread Hoang Huu Le
l_lock); lock(>lock#2); lock(>nametbl_lock); *** DEADLOCK *** Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Friday, October 9, 2020 1:01 AM > To: Jakub Kicinski ; Hoang Huu Le > Cc: ma...@donjonn.com; ying@windriver.com; > tipc-discuss

Re: [tipc-discussion] [net-next] tipc: introduce smooth change to replicast

2020-10-08 Thread Hoang Huu Le
Hi Jon, See my inline comment. Thanks, Hoang > -Original Message- > From: Jon Maloy > Sent: Friday, October 9, 2020 1:27 AM > To: Hoang Huu Le ; ma...@donjonn.com; > ying@windriver.com; tipc- > discuss...@lists.sourceforge.net > Subject: Re: [net-next] tipc: in

Re: [tipc-discussion] tipc.py

2020-10-08 Thread Hoang Huu Le
Hi Jon, I've done at: https://sourceforge.net/p/tipc/tipcutils/merge-requests/8/ Please take time to review it. Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Monday, October 5, 2020 10:44 PM > To: Hoang Huu Le ; > tipc-discussion@lists.sourceforge.net;

[tipc-discussion] [net] tipc: fix NULL pointer dereference in tipc_named_rcv

2020-10-08 Thread Hoang Huu Le
[] CR2: [] ---[ end trace 65c276a8e2e2f310 ]--- To fix this, we need to grab the lock of the 'namedq' list on both path calling. Fixes: cad2929dc432 ("tipc: update a binding service via broadcast") Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/name_distr.c | 10

[tipc-discussion] [net-next] tipc: introduce smooth change to replicast

2020-10-07 Thread Hoang Huu Le
had reached. We now introduce a smooth change to replicast if the broadcast link has reach to the limit of queue. Signed-off-by: Hoang Huu Le --- net/tipc/link.c | 5 - net/tipc/node.c | 12 ++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/net/tipc/link.c b/n

[tipc-discussion] [net-next] tipc: fix NULL pointer dereference in tipc_named_rcv

2020-10-07 Thread Hoang Huu Le
[] CR2: [] ---[ end trace 65c276a8e2e2f310 ]--- To fix this, we need to grab the lock of the 'namedq' list on both path calling. Fixes: cad2929dc432 ("tipc: update a binding service via broadcast") Signed-off-by: Hoang Huu Le --- net/tipc/name_distr.c | 10 +-

Re: [tipc-discussion] tipc.py

2020-10-04 Thread Hoang Huu Le
Hi Jon, I will make an effort on this. Do you think we need to keep these APIs compatibility work with Python2 or completely remove out? Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Saturday, October 3, 2020 5:59 AM > To: Hoang Huu Le ; >

Re: [tipc-discussion] tipc.py

2020-10-01 Thread Hoang Huu Le
Hi Jon, I've done this a long time ago: 5057f8bb4de0 tipcutils: introduce python api Basically, it works with Python 2. Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Friday, October 2, 2020 4:56 AM > To: tipc-discussion@lists.sourceforge.net; tipc-dek > ; Xin Long ;

Re: [tipc-discussion] [net] tipc: fix incorrect setting window for bcast link

2020-10-01 Thread Hoang Huu Le
Hi Jon, See my inline comment. Regards, Hoang > -Original Message- > From: Jon Maloy > Sent: Friday, October 2, 2020 4:40 AM > To: Hoang Huu Le ; > tipc-discussion@lists.sourceforge.net; ma...@donjonn.com; > ying@windriver.com; Xin Long > Subject: Re: [net

[tipc-discussion] [net-next] tipc: re-configure queue limit for broadcast link

2020-10-01 Thread Hoang Huu Le
the function to re-calculate queue limit of the broadcast link. Signed-off-by: Hoang Huu Le --- net/tipc/bcast.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index abac9443b4d9..bc566b304571 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c

[tipc-discussion] [net] tipc: fix incorrect setting window for bcast link

2020-09-30 Thread Hoang Huu Le
This lead to the window for broadcast link had effect as unexpect value (i.e the window size is constantly 32). We fix this by updating the window for broadcast as its configuration. Signed-off-by: Hoang Huu Le --- net/tipc/bcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ti

[tipc-discussion] [net-next v3] tipc: fix a deadlock when flushing scheduled work

2020-09-04 Thread Hoang Huu Le
5aa7e0385f6a5d0f...@syzkaller.appspotmail.com Fixes: fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode") Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 8 net/tipc/core.h | 1 + net/tipc/net.c | 10 +- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/net/tip

[tipc-discussion] [net-next v2 2/2] tipc: fix use-after-free in tipc_bcast_get_mode

2020-09-03 Thread Hoang Huu Le
b126c1...@syzkaller.appspotmail.com Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 6 ++ net/tipc/core.h | 10 ++ net/tipc/net.c | 21 + 3 files changed, 25 insertions(+), 12 deletions(-) diff --git a/net/tipc/core.c b/net/tipc/core.c index 4f6dc74adf45..f81b80e7 100644 ---

[tipc-discussion] [net-next v2 1/2] Revert "tipc: fix use-after-free in tipc_bcast_get_mode"

2020-09-03 Thread Hoang Huu Le
lock((wq_completion)events); *** DEADLOCK *** [...] We need to find out another solution to fix the original issue. Reported-by: syzbot+d5aa7e0385f6a5d0f...@syzkaller.appspotmail.com Fixes: fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode") Signed-off-by: Hoang Huu L

Re: [tipc-discussion] [PATCH] tipc: fix use-after-free in tipc_bcast_get_mode

2020-09-02 Thread Hoang Huu Le
Hi Jon, Below solution does not fully resolve the issue. I'm finding out another solution. Regards, Hoang -Original Message- From: Jon Maloy Sent: Tuesday, September 1, 2020 8:53 PM To: Hoang Huu Le ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Cc

[tipc-discussion] [net-next] Revert "tipc: fix use-after-free in tipc_bcast_get_mode"

2020-08-31 Thread Hoang Huu Le
lock((wq_completion)events); *** DEADLOCK *** [...] We need to find out another solution to fix the original issue. Reported-by: syzbot+d5aa7e0385f6a5d0f...@syzkaller.appspotmail.com Fixes: fdeba99b1e58 ("tipc: fix use-after-free in tipc_bcast_get_mode") Signed-off-by: Hoang Huu L

Re: [tipc-discussion] [net-next] tipc: fix use-after-free in tipc_bcast_get_mode

2020-08-31 Thread Hoang Huu Le
Thanks for pointing that out. I will revert the patch and submit another solution. -Original Message- From: Eric Dumazet Sent: Tuesday, September 1, 2020 12:08 AM To: Hoang Huu Le ; jma...@redhat.com; ma...@donjonn.com; net...@vger.kernel.org; tipc-discussion@lists.sourceforge.net Cc

[tipc-discussion] [net-next] tipc: fix use-after-free in tipc_bcast_get_mode

2020-08-26 Thread Hoang Huu Le
b126c1...@syzkaller.appspotmail.com Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tipc/core.c b/net/tipc/core.c index 4f6dc74adf45..37d8695548cf 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c @@ -109,6 +109,11 @@ stati

[tipc-discussion] [net-next] tipc: fix use-after-free in tipc_bcast_get_mode

2020-08-26 Thread Hoang Huu Le
b126c1...@syzkaller.appspotmail.com Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tipc/core.c b/net/tipc/core.c index 4f6dc74adf45..37d8695548cf 100644 --- a/net/tipc/core.c +++ b/net/tipc/core.c @@ -109,6 +109,11 @@ stati

[tipc-discussion] [iproute2-next] tipc: support 128bit node identity for peer removing

2020-08-26 Thread Hoang Huu Le
. Acked-by: Jon Maloy Signed-off-by: Hoang Huu Le --- tipc/peer.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/tipc/peer.c b/tipc/peer.c index f6380777033d..f14ec35e6f71 100644 --- a/tipc/peer.c +++ b/tipc/peer.c

[tipc-discussion] [PATCH] tipc: fix use-after-free in tipc_bcast_get_mode

2020-08-25 Thread Hoang Huu Le
y been freed) Reported-by: syzbot+6ea1f7a8df64596ef...@syzkaller.appspotmail.com Reported-by: syzbot+e9cc557752ab126c1...@syzkaller.appspotmail.com Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/tipc/core.c b/net/tipc/core.c

[tipc-discussion] [PATCH] tipc: fix use-after-free in tipc_bcast_get_mode

2020-08-25 Thread Hoang Huu Le
y been freed) Reported-by: syzbot+6ea1f7a8df64596ef...@syzkaller.appspotmail.com Reported-by: syzbot+e9cc557752ab126c1...@syzkaller.appspotmail.com Signed-off-by: Hoang Huu Le --- net/tipc/bcast.c | 1 + net/tipc/core.c | 1 + net/tipc/core.h | 1 + net/tipc/net.c | 3 +++ 4 files chan

[tipc-discussion] [iproute2-next v2] tipc: support 128bit node identity for peer removing

2020-08-24 Thread Hoang Huu Le
. Signed-off-by: Hoang Le Signed-off-by: Hoang Huu Le --- tipc/peer.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/tipc/peer.c b/tipc/peer.c index f6380777033d..f14ec35e6f71 100644 --- a/tipc/peer.c +++ b/tipc/peer.c

[tipc-discussion] [iproute2-next] tipc: support 128bit node identity for peer removing

2020-08-24 Thread Hoang Huu Le
1cbcd7ca down invalid network address, syntax: Z.C.N error: No such device or address Solution: We add the support to remove a specific node down with 128bit node identifier, as an alternative to legacy 32-bit node address. Signed-off-by: Hoang Le Signed-off-by: Hoang Huu Le

[tipc-discussion] [iproute2-next] tipc: fixed a compile warning in tipc/link.c

2020-07-08 Thread Hoang Huu Le
Fixes: 5027f233e35b ("tipc: add link broadcast get") Signed-off-by: Hoang Huu Le --- tipc/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tipc/link.c b/tipc/link.c index ba77a20152ea..192736eaa154 100644 --- a/tipc/link.c +++ b/tipc/link.c @@ -217,7 +217,7

Re: [tipc-discussion] [next-net v6] tipc: update a binding service via broadcast

2020-06-09 Thread Hoang Huu Le
-Original Message- From: Jon Maloy Sent: Monday, June 8, 2020 8:33 PM To: Hoang Huu Le ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Subject: Re: [next-net v6] tipc: update a binding service via broadcast On 6/6/20 11:10 PM, Hoang Huu Le wrote

Re: [tipc-discussion] [net-next] tipc: update a binding service via broadcast

2020-06-07 Thread Hoang Huu Le
Thanks Jon! Hoang -Original Message- From: Jon Maloy Sent: Monday, June 8, 2020 8:57 AM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net; tipc-dek Subject: Re: [tipc-discussion] [net-next] tipc: update a binding service via broadcast In case you are not aware of this, check

Re: [tipc-discussion] [net-next] tipc: update a binding service via broadcast

2020-06-07 Thread Hoang Huu Le
-Original Message- From: Jon Maloy Sent: Monday, June 8, 2020 2:14 AM To: tipc-discussion@lists.sourceforge.net Subject: Re: [tipc-discussion] [net-next] tipc: update a binding service via broadcast On 6/7/20 3:03 PM, Jon Maloy wrote: > > > On 6/7/20 12:24 AM, Hoang Huu

Re: [tipc-discussion] [next-net v6] tipc: update a binding service via broadcast

2020-06-07 Thread Hoang Huu Le
-Original Message- From: Jon Maloy Sent: Monday, June 8, 2020 2:12 AM To: Hoang Huu Le ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Subject: Re: [next-net v6] tipc: update a binding service via broadcast On 6/6/20 11:10 PM, Hoang Huu Le wrote

[tipc-discussion] [net-next] tipc: update a binding service via broadcast

2020-06-06 Thread Hoang Huu Le
ial synchronization and sequence number check, and delivered unconditionally. Therefore, we add another 'is_not_legacy' bit to all new messages so that those can be distinguished from legacy messages and the latter delivered directly. Signed-off-by: Hoang Huu Le Acked-by: Jon Maloy --- net/tipc/bcas

Re: [tipc-discussion] [next-net v6] tipc: update a binding service via broadcast

2020-06-06 Thread Hoang Huu Le
-Original Message- From: Jon Maloy Sent: Friday, June 5, 2020 8:03 PM To: Hoang Huu Le ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Subject: Re: [next-net v6] tipc: update a binding service via broadcast On 6/5/20 3:52 AM, Hoang Huu Le wrote

[tipc-discussion] [next-net v6] tipc: update a binding service via broadcast

2020-06-05 Thread Hoang Huu Le
ast v5: - never use broadcast if there is a single node not understanding it - always use broadcast otherwise - add sequence numbering to non-bulk messages v6: update Jon's comment Signed-off-by: Hoang Huu Le Acked-by: Jon Maloy --- net/tipc/bcast.c | 6 +-- net/tipc/bcas

Re: [tipc-discussion] [net-next] tipc: update a binding service via broadcast

2020-06-04 Thread Hoang Huu Le
Hi Jon, See my inline comment. Regards, Hoang -Original Message- From: Jon Maloy Sent: Thursday, June 4, 2020 8:42 PM To: Hoang Huu Le ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Subject: Re: [net-next] tipc: update a binding service via

Re: [tipc-discussion] FW: [PATCH 2/2] tipc: update a binding service via broadcast

2020-06-04 Thread Hoang Huu Le
From: Jon Maloy Sent: Thursday, June 4, 2020 8:59 PM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net; tipc-dek ; Tuong Tong Lien ; Xin Long ; Tung Quang Nguyen ; Ying Xue Subject: Re: FW: [PATCH 2/2] tipc: update a binding service via broadcast On 6/4/20 5:14 AM, Hoang Huu Le

[tipc-discussion] [net-next] tipc: update a binding service via broadcast

2020-06-04 Thread Hoang Huu Le
ode not understanding it - always use broadcast otherwise - add sequence numbering to non-bulk messages Signed-off-by: Hoang Huu Le --- net/tipc/bcast.c | 6 +-- net/tipc/bcast.h | 4 +- net/tipc/link.c | 2 +- net/tipc/msg.h| 40 +++ net/t

Re: [tipc-discussion] FW: [PATCH 2/2] tipc: update a binding service via broadcast

2020-06-04 Thread Hoang Huu Le
broadcast Added more recipients. Forwarded Message Subject: Re: FW: [PATCH 2/2] tipc: update a binding service via broadcast Date: Fri, 29 May 2020 12:08:02 -0400 From: Jon Maloy <mailto:jma...@redhat.com> To: Hoang Huu Le <mailto:hoang.h...@dektech.com.au>, ma...

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

2020-06-02 Thread Hoang Huu Le
-Original Message- From: Jon Maloy Sent: Tuesday, June 2, 2020 8:37 PM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net Cc: Tung Quang Nguyen ; Tuong Tong Lien ; ma...@donjonn.com; x...@redhat.com; ying@windriver.com; parthasarathy.bhuvara...@gmail.com Subject: Re

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

2020-06-01 Thread Hoang Huu Le
Hi Jon, See my comment inline. Hoang -Original Message- From: Jon Maloy Sent: Monday, June 1, 2020 7:40 PM To: Hoang Huu Le ; tipc-discussion@lists.sourceforge.net Cc: Tung Quang Nguyen ; Tuong Tong Lien ; ma...@donjonn.com; x...@redhat.com; ying@windriver.com

Re: [tipc-discussion] [ ] tipc: update a binding service via broadcast

2020-06-01 Thread Hoang Huu Le
Hi Jon, There is a concern in function tipc_node_broadcast. See my comment inline. Regards, Hoang -Original Message- From: jma...@redhat.com Sent: Friday, May 29, 2020 10:34 PM To: tipc-discussion@lists.sourceforge.net Cc: Tung Quang Nguyen ; Hoang Huu Le ; Tuong Tong Lien ; jma

Re: [tipc-discussion] [PATCH RFC] tipc: make peer node cleanup timer configurable

2020-04-14 Thread Hoang Huu Le
Hi Tuong, The 'node_cleanup' is not clear in meaning. I'd prefer using 'node_cleanup_time_secs'. I think we should use 'milliseconds' for more popular than 'seconds' in proc/sysctl. Regards, Hoang -Original Message- From: Tuong Tong Lien Sent: Tuesday, April 14, 2020 2:30 PM To:

Re: [tipc-discussion] [PATCH RFC 2/4] tipc: add back link trace events

2020-03-27 Thread Hoang Huu Le
Yes, I got the same results. Hoang -Original Message- From: Jon Maloy Sent: Friday, March 27, 2020 8:43 PM To: Tuong Tong Lien ; ma...@donjonn.com; ying@windriver.com; tipc-discussion@lists.sourceforge.net Cc: tipc-...@dektech.com.au Subject: Re: [tipc-discussion] [PATCH RFC 2/4]