https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-05-02T15:20:17-07:00
New Revision: 954d00e87cdd77d0e9e367be52e62340467bd779
URL:
https://github.com/llvm/llvm-project/commit/954d00e87cdd77d0e9e367be52e62340467bd779
DIFF:
https://github.com/llvm/llvm-project/commit/954d00e87cdd77d0e9e367be52e62340467bd779.diff
@@ -169,25 +173,28 @@ kern_return_t DNBArchMachARM64::GetGPRState(bool force) {
(thread_state_t)_state.context.gpr, );
if (DNBLogEnabledForAny(LOG_THREAD)) {
uint64_t *x = _state.context.gpr.__x[0];
+
+#if defined(DEBUGSERVER_IS_ARM64E)
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90808
>From 8145e9faaa52209f9800d473fb75f7cfbd2a1185 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 1 May 2024 18:06:50 -0700
Subject: [PATCH 1/2] [lldb] [debugserver] address preprocessor warning, extra
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/90808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90808
In DNBArchImplARM64.cpp I'm doing
And the preprocessor warns that this is not defined behavior. This checks if
ptrauth_calls is available and if this is being compiled 64-bit (i.e. arm64e),
and defines a
jasonmolenda wrote:
> On the face of it
>
> > When we have an unset high memory address mask, and we are told to set low-
> > and high-memory to the same new address mask, maintain the high memory mask
> > as unset in Process. The same thing is done with the
> > SBProcess::SetAddressMask API
@@ -1465,6 +1465,20 @@ class Process : public
std::enable_shared_from_this,
/// platforms where there is a difference (only Arm Thumb at this time).
lldb::addr_t FixAnyAddress(lldb::addr_t pc);
+ /// Retrieve the actual address masks for high memory code/data,
+ ///
@@ -1465,6 +1465,20 @@ class Process : public
std::enable_shared_from_this,
/// platforms where there is a difference (only Arm Thumb at this time).
lldb::addr_t FixAnyAddress(lldb::addr_t pc);
+ /// Retrieve the actual address masks for high memory code/data,
+ ///
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90533
>From 3c272e99326a287f0a61c1f8c2c7ee790e1aeb48 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 29 Apr 2024 16:45:36 -0700
Subject: [PATCH 1/2] [lldb] Be conversative about setting highmem address
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90533
The most common case with address masks/addressable bits is that we have one
value/mask that applies across the entire address space, for code and data. On
AArch64, we can have separate masks for high and
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90140
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/90144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90144
>From 3b66943d9c49fd5e71c2eb136b5bb3311e932bbc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 25 Apr 2024 15:51:44 -0700
Subject: [PATCH 1/2] [lldb] Add SBValue::GetValueAsAddress API
I previously
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90144
I previously added this API via https://reviews.llvm.org/D142792 in 2023, along
with changes to the ValueObject class to treat pointer types as addresses, and
to annotate those ValueObjects with the
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90140
Jonas upstreamed recognition of DW_TAG_LLVM_ptrauth_type
https://reviews.llvm.org/D130215 but it isn't recognized as a type qualifier
tag in DWARFASTParserClang::ParseTypeFromDWARF.
>From
https://github.com/jasonmolenda approved this pull request.
Yes please, very long overdue, I've felt bad about not trying to do something
here myself.
https://github.com/llvm/llvm-project/pull/89587
___
lldb-commits mailing list
https://github.com/jasonmolenda approved this pull request.
This looks good, thanks for the revisions.
https://github.com/llvm/llvm-project/pull/88792
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda wrote:
Skimming DynamicLoaderPOSIXDYLD (as it is written today), it looks like
attach/launch call `SetRendezvousBreakpoint()` which (1) loads ld.so into lldb
if it isn't already there, and (2) sets the breakpoint to be notified about
future binaries loading. It loads ld.so via
https://github.com/jasonmolenda approved this pull request.
Looks good, please land it. Thanks for the pings and rewriting the test case!
https://github.com/llvm/llvm-project/pull/82603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -655,9 +655,10 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
_sp,
const addr_t addr = core_range.range.start();
const addr_t size = core_range.range.size();
auto data_up = std::make_unique(size, 0);
+Status read_error;
@@ -655,9 +655,10 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
_sp,
const addr_t addr = core_range.range.start();
const addr_t size = core_range.range.size();
auto data_up = std::make_unique(size, 0);
+Status read_error;
jasonmolenda wrote:
The lldb change part of this PR looks good to me.
https://github.com/llvm/llvm-project/pull/88312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Hi sorry @kovdan01 I missed this one in the emails. You're using an lldb which
was built without the `LLVM_TARGETS_TO_BUILD` including X86, and running that
lldb on an x86 corefile, got it. I have low confidence how well lldb will work
in this situation, e.g. inferior
https://github.com/jasonmolenda approved this pull request.
This looks good to me.
https://github.com/llvm/llvm-project/pull/88442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Looks good.
https://github.com/llvm/llvm-project/pull/88047
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-04-08T18:56:39-07:00
New Revision: 41dc04e5283adef9979cad2b126ab3e6c156034a
URL:
https://github.com/llvm/llvm-project/commit/41dc04e5283adef9979cad2b126ab3e6c156034a
DIFF:
https://github.com/llvm/llvm-project/commit/41dc04e5283adef9979cad2b126ab3e6c156034a.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/88073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
An example of the difference in the output this makes for `script help
(lldb.SBProcess)`. Old:
```
| PutSTDIN(self, src)
| Writes data into the current process's stdin. API client specifies a
Python
| string as the only argument.
```
new:
```
|
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/88073
Some of the SB API method description docstrings for swing are annotated as
`%feature("autodoc")` - but `"autodoc"` annotations are only to substitute a
string showing the arguments and return variables -
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
I developed & tested this on aarch64 linux, the only system I have here that
runs this shell test. It's a little trickier to test on macOS, we basically
only use compact_unwind and it's in the executable binary, not the dSYM
SymbolFile.
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/86770
In
commit 2f63718f8567413a1c596bda803663eb58d6da5a
Author: Jason Molenda
Date: Tue Mar 26 09:07:15 2024 -0700
[lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (#86603)
I
Author: Jason Molenda
Date: 2024-03-26T10:54:26-07:00
New Revision: 29318abe1d2c55e8543255d70f26ac93261b74a4
URL:
https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4
DIFF:
https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4.diff
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86603
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/86603
>From b6fcac7d6bb48b7fb665034712407c9ad7e4053a Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 25 Mar 2024 16:47:11 -0700
Subject: [PATCH] [lldb] Don't clear a Module's UnwindTable when adding a
jasonmolenda wrote:
I've seen this ubsan error every time I run the testsuite for years, i just
finally sat down and figured out what was going on.
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/86359
>From 47bf1259289986cdc0df706aa40a18e58e94eee5 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Fri, 22 Mar 2024 16:31:07 -0700
Subject: [PATCH] [lldb] [ObjectFileMachO] LLVM_COV is not mapped into
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/86359
It is possible to gather code coverage in a firmware environment, where the
__LLVM_COV segment will not be mapped in memory but does exist in the binary,
see
https://github.com/jasonmolenda approved this pull request.
Thanks for fixing this, I hadn't been paying attention to the separation when I
added this method.
https://github.com/llvm/llvm-project/pull/85858
___
lldb-commits mailing list
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/84998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Thanks for all the helpful comments as always, David. I updated the test case
to fix the issues you identified and added comments that I think make it
clearer that it is testing both a live process and a corefile.
https://github.com/llvm/llvm-project/pull/84998
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/84998
>From 4278537c262b01b1d6432391bd9d8017eb96c60a Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 12 Mar 2024 17:09:30 -0700
Subject: [PATCH 1/2] [lldb] [Mach-O] ProcessMachCore needs to strip TBI data
Author: Jason Molenda
Date: 2024-03-12T17:19:46-07:00
New Revision: e2468bf16a0c1f63a39aa417c15c03ebd77fab9e
URL:
https://github.com/llvm/llvm-project/commit/e2468bf16a0c1f63a39aa417c15c03ebd77fab9e
DIFF:
https://github.com/llvm/llvm-project/commit/e2468bf16a0c1f63a39aa417c15c03ebd77fab9e.diff
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/84998
Darwin AArch64 application processors are run with Top Byte Ignore mode enabled
so metadata may be stored in the top byte, it needs to be ignored when
reading/writing memory. David Spickett handled this
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/84872
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/84872
The first half of this patch is a long-standing annoyance, if I attach to
debugserver with lldb while it is waiting for an lldb connection, the syscall
is interrupted and it doesn't retry, debugserver
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/84607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Looks good. I see the PR test for "Test documentation build" is failing, but
that's an issue with the bot and pexpect.
https://github.com/llvm/llvm-project/pull/84630
___
lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/84607
Walter Erquinigo added optional instruction annotations for x86 instructions in
2022 for the `thread trace dump instruction` command, and code to
DisassemblerLLVMC to add annotations for instructions that
jasonmolenda wrote:
nb: this got a bot failure on the arm-linux-ubuntu bot,
```
mask = process.GetAddressMask(lldb.eAddressMaskTypeAny)
process.SetAddressMask(lldb.eAddressMaskTypeCode, mask | 0x3)
self.assertEqual(
0x02950001F694,
Author: Jason Molenda
Date: 2024-03-06T10:58:03-08:00
New Revision: 04a271ebe4c2421f34a4fbf34c328df9f111
URL:
https://github.com/llvm/llvm-project/commit/04a271ebe4c2421f34a4fbf34c328df9f111
DIFF:
https://github.com/llvm/llvm-project/commit/04a271ebe4c2421f34a4fbf34c328df9f111.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/83663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> Still not sure this is the ideal API but we can't know that until someone
> (aka you :) ) has used it for a bit, so let's get this in.
Thanks for all the help in finishing this one. I think this approach with
enums to select the different types/ranges, with defaulted
@@ -0,0 +1,130 @@
+"""Test Python APIs for setting, getting, and using address masks."""
+
+import os
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class AddressMasksTestCase(TestBase):
+
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83663
>From c993c7cc7c1669ca7d06e52f1a1ff8dbefe9ebc9 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 29 Feb 2024 17:02:42 -0800
Subject: [PATCH 1/5] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83663
>From c993c7cc7c1669ca7d06e52f1a1ff8dbefe9ebc9 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 29 Feb 2024 17:02:42 -0800
Subject: [PATCH 1/4] [lldb] Add SBProcess methods for get/set/use address
jasonmolenda wrote:
I pushed an update to this PR where I have the base class Fix methods in
ABI.cpp ignore the highmem masks completely, I added highmem mask use when it's
a highmem address and they are set to the AArch64ABI class so all the AArch64
ABI plugins are checking this. I changed
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83663
>From c993c7cc7c1669ca7d06e52f1a1ff8dbefe9ebc9 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 29 Feb 2024 17:02:42 -0800
Subject: [PATCH 1/3] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda approved this pull request.
https://github.com/llvm/llvm-project/pull/83889
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> > is about how TestAddressMasks.py assumes all Fix*Address implementations
> > will handle a low and high memory address mask. The test currently assumes
> > they do
>
> I'm not sure it makes much difference unless handling low/high produces a
> large amount of
@@ -138,6 +134,21 @@ void Symtab::Dump(Stream *s, Target *target, SortOrder
sort_order,
}
} break;
+case eSortOrderBySize: {
+ s->PutCString(" (sorted by size):\n");
+ DumpSymbolHeader(s);
+
+ std::multimap> size_map;
+ for (const Symbol :
jasonmolenda wrote:
After debugging, updating, and testing on aarch64-unbuntu, x86_64-macos, and
arm64-macos, I have created a new PR with this commit plus an additional commit
to fix the issues I found on the different platforms.
https://github.com/llvm/llvm-project/pull/83663
jasonmolenda wrote:
@DavidSpickett I spent a little time debugging this on aarch64-ubuntu and also
testing on x86_64-macos (which has no address masks at all). This PR has the
original commit from https://github.com/llvm/llvm-project/pull/83095 and then a
second commit with the changes I
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/83663
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/83663
[lldb] Add SBProcess methods for get/set/use address masks (#83095)
I'm reviving a patch from phabracator, https://reviews.llvm.org/D155905
which was approved but I wasn't thrilled with all the API I was
jasonmolenda wrote:
I think I'm going open a new PR with the base class address masking added to
the patch. I think having these API and the unwritten caveat is "they may be
no-ops if you're using an ABI that doesn't do FixAddress" is going to confuse
people. I still want to investigate why
jasonmolenda wrote:
It does occur to me that I'm going to need to only run this API test on targets
which have a FixAddress method in their ABI, the base class own't do it. Maybe
it should have a base class impl that can be overridden, and use the Process
masks if they are set. (they're all
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/82593
>From 0ba4e6402969028fa6152c366a56063a56acded1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 21 Feb 2024 22:48:36 -0800
Subject: [PATCH 1/3] [lldb] [debugserver] fix qLaunchSuccess error, add
jasonmolenda wrote:
Temporarily reverted this change while I investigate why the tests failed on
all the linux bots (lldb-x86_64-debian, lldb-arm-ubuntu, lldb-aarch64-ubuntu),
I'll build up in a VM and debug.
https://github.com/llvm/llvm-project/pull/83095
Author: Jason Molenda
Date: 2024-02-29T17:29:24-08:00
New Revision: e8ce864a36ba02ddb63877905d49f1e9ac60b544
URL:
https://github.com/llvm/llvm-project/commit/e8ce864a36ba02ddb63877905d49f1e9ac60b544
DIFF:
https://github.com/llvm/llvm-project/commit/e8ce864a36ba02ddb63877905d49f1e9ac60b544.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Going back to this PR, @bulbazord @clayborg and I agreed that having a single
method for sending error reply packets, which correctly encode the error string
it if is available and extended-error-responses has been enabled, would be
worth modifying all the error returns,
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/82593
>From 0ba4e6402969028fa6152c366a56063a56acded1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 21 Feb 2024 22:48:36 -0800
Subject: [PATCH 1/3] [lldb] [debugserver] fix qLaunchSuccess error, add
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/9] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/82593
>From 0ba4e6402969028fa6152c366a56063a56acded1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 21 Feb 2024 22:48:36 -0800
Subject: [PATCH 1/2] [lldb] [debugserver] fix qLaunchSuccess error, add
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/8] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,18 +33,26 @@ void AddressableBits::SetHighmemAddressableBits(
m_high_memory_addr_bits = highmem_addressing_bits;
}
+addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
+ assert(addressable_bits <= sizeof(addr_t) * 8);
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/7] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/6] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/5] [lldb] Add SBProcess methods for get/set/use address
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/4] [lldb] Add SBProcess methods for get/set/use address
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+
jasonmolenda wrote:
Thanks for the second round of feedback @hawkinsw . Let me try to read the
Doxygen docs a little more closely tonight and see if the references I threw in
there might actually do what I hoped they would. I briefly looked at the
Doxygen docs to see the Grouping feature
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/3] [lldb] Add SBProcess methods for get/set/use address
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ ///
@@ -407,6 +407,117 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ ///
jasonmolenda wrote:
Thanks so much for reading through these @DavidSpickett and @hawkinsw !
@adrian-prantl and @JDevlieghere suggested using a doxygen group for this set
of methods and having the long definitions of `type` and `addr_range` a single
time, referring back to them from the
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/2] [lldb] Add SBProcess methods for get/set/use address
1 - 100 of 1158 matches
Mail list logo
