[jira] [Assigned] (SUBMARINE-1152) Submarine UI support i18n

2022-11-14 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1152: --- Assignee: Zhao-Wei Liu > Submarine UI support i

[jira] [Assigned] (SUBMARINE-1152) Submarine UI support i18n

2022-11-14 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1152: --- Assignee: (was: Zhao-Wei Liu) > Submarine UI support i

[jira] [Assigned] (SUBMARINE-1348) Fix implicit Optional check style issues for mypy

2022-11-14 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1348: --- Assignee: Zhao-Wei Liu > Fix implicit Optional check style issues for m

[jira] [Assigned] (SUBMARINE-1295) Add XGBoost Support to Seldon

2022-07-18 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1295: --- Assignee: Zhao-Wei Liu > Add XGBoost Support to Sel

[jira] [Created] (SUBMARINE-1295) Add XGBoost Support to Seldon

2022-07-18 Thread Zhao-Wei Liu (Jira)
Zhao-Wei Liu created SUBMARINE-1295: --- Summary: Add XGBoost Support to Seldon Key: SUBMARINE-1295 URL: https://issues.apache.org/jira/browse/SUBMARINE-1295 Project: Apache Submarine Issue

[jira] [Resolved] (SUBMARINE-1280) Design model serving UI/UX

2022-06-20 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu resolved SUBMARINE-1280. - Resolution: Done The UI design is finished and listed in Google Doc. > Design mo

[jira] (SUBMARINE-1280) Design model serving UI/UX

2022-06-20 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1280 ] Zhao-Wei Liu deleted comment on SUBMARINE-1280: - was (Author: JIRAUSER286598): The UI design is finished and listed in Google Doc. > Design model serving UI

[jira] [Commented] (SUBMARINE-1280) Design model serving UI/UX

2022-06-20 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556645#comment-17556645 ] Zhao-Wei Liu commented on SUBMARINE-1280: - The UI design is finished

[jira] [Assigned] (SUBMARINE-1255) Add XGBoost support to MLJob

2022-06-20 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1255: --- Assignee: Zhao-Wei Liu > Add XGBoost support to ML

[jira] [Assigned] (SUBMARINE-1235) Display test coverage in PR check progress

2022-06-20 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu reassigned SUBMARINE-1235: --- Assignee: Zhao-Wei Liu > Display test coverage in PR check progr

[jira] [Updated] (SUBMARINE-1280) Design model serving UI/UX

2022-06-06 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1280: Description: Design model serving UI/UX. [https://docs.google.com/document/d

[jira] [Updated] (SUBMARINE-1280) Design model serving UI/UX

2022-06-06 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1280: Description: Design model serving UI/UX. [https://docs.google.com/document/d

[jira] [Created] (SUBMARINE-1280) Design model serving UI/UX

2022-05-29 Thread Zhao-Wei Liu (Jira)
Zhao-Wei Liu created SUBMARINE-1280: --- Summary: Design model serving UI/UX Key: SUBMARINE-1280 URL: https://issues.apache.org/jira/browse/SUBMARINE-1280 Project: Apache Submarine Issue Type

[jira] [Created] (SUBMARINE-1269) Add codecov badget

2022-05-02 Thread Zhao-Wei Liu (Jira)
Zhao-Wei Liu created SUBMARINE-1269: --- Summary: Add codecov badget Key: SUBMARINE-1269 URL: https://issues.apache.org/jira/browse/SUBMARINE-1269 Project: Apache Submarine Issue Type: New

[jira] [Updated] (SUBMARINE-1235) Display test coverage in PR check progress

2022-04-25 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1235: Summary: Display test coverage in PR check progress (was: Trigger testing coverage

[jira] [Updated] (SUBMARINE-1235) Trigger testing coverage check in PR check progress

2022-04-25 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1235: Description: * Check code coverage report can be updated to SonaCloud * Add CodeCov

[jira] [Updated] (SUBMARINE-1255) Add XGBoost support to MLJob

2022-04-11 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1255: Summary: Add XGBoost support to MLJob (was: Add XGBoost support from Kubeflow

[jira] [Updated] (SUBMARINE-1255) Add XGBoost support from Kubeflow training operator

2022-04-09 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1255: Component/s: experiment > Add XGBoost support from Kubeflow training opera

[jira] [Updated] (SUBMARINE-1255) Add XGBoost support from Kubeflow training operator

2022-04-09 Thread Zhao-Wei Liu (Jira)
[ https://issues.apache.org/jira/browse/SUBMARINE-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao-Wei Liu updated SUBMARINE-1255: Fix Version/s: 0.8.0 > Add XGBoost support from Kubeflow training opera

[jira] [Created] (SUBMARINE-1255) Add XGBoost support from Kubeflow training operator

2022-04-09 Thread Zhao-Wei Liu (Jira)
Zhao-Wei Liu created SUBMARINE-1255: --- Summary: Add XGBoost support from Kubeflow training operator Key: SUBMARINE-1255 URL: https://issues.apache.org/jira/browse/SUBMARINE-1255 Project: Apache

Re: [PATCH v3] c++: warn on undefined casts from Base to Derived ref/ptr [PR96765]

2022-03-27 Thread Zhao Wei Liew via Gcc-patches
- Handle reference casts and add new tests. - Warn if resolves_to_fixed_type_p > 0 to handle more general cases. v1: https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591683.html - Add new warning flag. - Use resolves_to_fixed_type_p. From 261fcff504d2a4971a501747979b1b424d6b09e4 Mon Sep 17 00:

[jira] [Created] (SUBMARINE-1235) Trigger testing coverage check in PR check progress

2022-03-25 Thread Zhao-Wei Liu (Jira)
Zhao-Wei Liu created SUBMARINE-1235: --- Summary: Trigger testing coverage check in PR check progress Key: SUBMARINE-1235 URL: https://issues.apache.org/jira/browse/SUBMARINE-1235 Project: Apache

Re: [PATCH v2] c++/96765: warn when casting Base* to Derived* in Base ctor/dtor

2022-03-16 Thread Zhao Wei Liew via Gcc-patches
Thanks for the review. I've tested and uploaded a new patch v2 with the requested changes. On Thu, 17 Mar 2022 at 09:20, Jason Merrill wrote: > > On 3/14/22 02:36, Zhao Wei Liew via Gcc-patches wrote: > > > This patch adds a warning when casting "this" to

Re: [PATCH][v2] tree-optimization: Fold (type)X / (type)Y [PR103855]

2022-03-16 Thread Zhao Wei Liew via Gcc-patches
ntext and for example > can look at SSA uses. I had wanted to do something similar to handle all integral trunc_divs, but I'm not sure where/how to start. It seems out of my league at this moment. I'll gladly explore it after this change though! From f5f768b55f6cadcd9eba459561abfc1d7e28f94e Mo

[PATCH] c++/96765: warn when casting "this" to Derived* in Base ctor/dtor

2022-03-13 Thread Zhao Wei Liew via Gcc-patches
nux-gnu. Appreciate reviews and feedback. Thanks! From c70e087c7ee9db7497da293f8a85891abe895d9a Mon Sep 17 00:00:00 2001 From: Zhao Wei Liew Date: Tue, 22 Feb 2022 16:03:17 +0800 Subject: [PATCH] c++: warn when casting "this" to Derived* in Base ctor/dtor [PR96765] Casting "this"

Re: [PATCH v7] c++: Add diagnostic when operator= is used as truth cond [PR25689]

2022-03-13 Thread Zhao Wei Liew via Gcc-patches
erator=() calls. 2. Use INDIRECT_REF_P to filter implicit operator=() calls. 3. Use cp_get_callee_fndecl_nofold. 4. Add spaces before (. From 28f884d51a56889e84acba970a5aac9da8b24d99 Mon Sep 17 00:00:00 2001 From: Zhao Wei Liew Date: Tue, 15 Feb 2022 17:44:29 +0800 Subject: [PATCH] c++: Add diagnostic when o

[PATCH][RFC] c++/96765: warn when casting Base* to Derived* in Base ctor/dtor

2022-02-22 Thread Zhao Wei Liew via Gcc-patches
x27;t seem to find an appropriate flag. Maybe I should place it under -Wextra or -Wall? Appreciate any feedback on the aforementioned doubts or otherwise. Thanks, and have a great day! From 8a1f352f3db06faf264bc823387714a4a9e638b6 Mon Sep 17 00:00:00 2001 From: Zhao Wei Liew Date: Tue, 22 Feb

Re: [PATCH] tree-optimization: [PR103855] Fold (type)X / (type)Y

2022-02-21 Thread Zhao Wei Liew via Gcc-patches
On Tue, 22 Feb 2022 at 11:57, Zhao Wei Liew wrote: > > Hi, > > This is a partial optimization for PR103855. > > Initially, I looked into optimizing RTL generation or a more complex > GIMPLE transformation so that we could optimize other cases as well, > such as ((unsigne

[PATCH] tree-optimization: [PR103855] Fold (type)X / (type)Y

2022-02-21 Thread Zhao Wei Liew via Gcc-patches
look into that change, I've decided to implement this simpler match.pd transformation. Greatly appreciate any feedback on this patch or guidance for implementing the more advanced optimizations! Thanks, Zhao Wei 0001-tree-optimization-PR103855-Fold-type-X-type-Y.patch Description: Binary data

Re: [PATCH] tree-optimization: [PR103855] Fold (type)X / (type)Y

2022-02-19 Thread Zhao Wei Liew via Gcc-patches
> On 19 Feb 2022, at 5:36 PM, Zhao Wei Liew wrote: > > This pattern converts (trunc_div (convert a) (convert b)) to > (convert (trunc_div a b)) when: > > 1. type, a, and b all have unsigned integeral types > 2. a and b have the same type precision > 3. type has ty

[PATCH] tree-optimization: [PR103855] Fold (type)X / (type)Y

2022-02-19 Thread Zhao Wei Liew via Gcc-patches
-off-by: Zhao Wei Liew PR tree-optimization/103855 gcc/ChangeLog: * match.pd: Add pattern for (type)X / (type)Y. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/divide-8.c: New test. * gcc.dg/tree-ssa/divide-9.c: New test. --- gcc/match.pd

Re: [PATCH v7] c++: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-17 Thread Zhao Wei Liew via Gcc-patches
On Fri, 18 Feb 2022 at 08:32, Zhao Wei Liew wrote: > > > >>> +/* Test non-empty class */ > > >>> +void f2(B b1, B b2) > > >>> +{ > > >>> + if (b1 = 0); /* { dg-warning "suggest parentheses" } */ > > >>> +

Re: [PATCH v7] c++: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-17 Thread Zhao Wei Liew via Gcc-patches
On Thu, 17 Feb 2022 at 00:59, Jason Merrill wrote: > > On 2/16/22 02:16, Zhao Wei Liew wrote: > > On Wed Feb 16, 2022 at 4:06 AM +08, Jason Merrill wrote: > >>> Ah, I see. I found it a bit odd that gcc-commit-mklog auto-generated a > >>> subject with &quo

Re: [PATCH v7] c++: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-15 Thread Zhao Wei Liew via Gcc-patches
1.C. 2. Refactor added logic to a function (is_assignment_overload_ref_p). 3. Use REFERENCE_REF_P instead of INDIRECT_REF_P. v1: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590158.html Changes since v1: 1. Use CALL_EXPR_OPERATOR_SYNTAX to avoid warnings for explicit operator=() calls.

Re: [PATCH] c++: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-15 Thread Zhao Wei Liew via Gcc-patches
On Wed Feb 16, 2022 at 4:06 AM +08, Jason Merrill wrote: > > Ah, I see. I found it a bit odd that gcc-commit-mklog auto-generated a > > subject with "c:", > > but I just went with it as I didn't know any better. Unfortunately, I > > can't change it now on the current thread. > > That came from th

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-15 Thread Zhao Wei Liew via Gcc-patches
On Wed, 16 Feb 2022 at 00:30, Zhao Wei Liew wrote: > On Tue, 15 Feb 2022 at 21:05, Jason Merrill wrote: > > >> > > >> I agree. However, I can't seem to call extract_call_expr directly > > >> because it calls gcc_assert > > >> t

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-15 Thread Zhao Wei Liew via Gcc-patches
s_assignment_op_expr_p): Add function to check if an expression is a call to an op= operator expression. (maybe_convert_cond): Handle the case of a op= operator expression for the -Wparentheses diagnostic. gcc/testsuite/ChangeLog: * g++.dg/warn/Wparentheses

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-15 Thread Zhao Wei Liew via Gcc-patches
On Tue, 15 Feb 2022 at 13:13, Jason Merrill wrote: > > On 2/14/22 21:30, Zhao Wei Liew wrote: > > On 14/02/2022, Jason Merrill wrote: > >>> > >>> +/* Returns true if EXPR is a reference to an implicit > >>> + call to operator=(). */ > >>

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-14 Thread Zhao Wei Liew via Gcc-patches
On 14/02/2022, Jason Merrill wrote: >> >> +/* Returns true if EXPR is a reference to an implicit >> + call to operator=(). */ >> +static bool >> +is_assignment_overload_ref_p (tree expr) >> +{ >> + if (expr == NULL_TREE || !REFERENCE_REF_P (expr)) >> +return false; > > This will only warn a

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-11 Thread Zhao Wei Liew via Gcc-patches
On Fri, 11 Feb 2022 at 20:47, Jason Merrill wrote: > > > > On the other hand, for empty classes, it seems that a COMPOUND_EXPR > > is built in build_over_call under the is_really_empty_class guard (line > > 9791). > > I don't understand the tree structure that I should identify though. > > Could

Re: [PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-10 Thread Zhao Wei Liew via Gcc-patches
On Fri, 11 Feb 2022 at 00:14, Jason Merrill wrote: > > On 2/9/22 21:18, Zhao Wei Liew via Gcc-patches wrote: > > Hi! > > > > I wrote a patch for PR 25689, but I feel like it may not be the ideal > > fix. Furthermore, there are some standing issues with the patch for

[PATCH] c: Add diagnostic when operator= is used as truth cond [PR25689]

2022-02-09 Thread Zhao Wei Liew via Gcc-patches
Hi! I wrote a patch for PR 25689, but I feel like it may not be the ideal fix. Furthermore, there are some standing issues with the patch for which I would like tips on how to fix them. Specifically, there are 2 issues: 1. GCC warns about if (a.operator=(0)). That said, this may not be a major is

Re: [PATCH] match.pd: Fix up 1 / X for unsigned X optimization [PR104280]

2022-01-29 Thread Zhao Wei Liew via Gcc-patches
Sincere apologies for the issues. I wasn't aware of the need for a cast but after reading the PRs, I understand that now. On the other hand, the incorrect test case was simply a major oversight on my part. I'll be sure to be more careful next time. Thanks for the fixes!

[PATCH v3] match.pd: Simplify 1 / X for integer X [PR95424]

2022-01-19 Thread Zhao Wei Liew via Gcc-patches
This patch implements an optimization for the following C++ code: int f(int x) { return 1 / x; } int f(unsigned int x) { return 1 / x; } Before this patch, x86-64 gcc -std=c++20 -O3 produces the following assembly: f(int): xor edx, edx mov eax, 1 idiv edi ret f(unsigned

[PATCH v2] match.pd: Simplify 1 / X for integer X [PR95424]

2022-01-06 Thread Zhao Wei Liew via Gcc-patches
This patch implements an optimization for the following C++ code: int f(int x) { return 1 / x; } int f(unsigned int x) { return 1 / x; } Before this patch, x86-64 gcc -std=c++20 -O3 produces the following assembly: f(int): xor edx, edx mov eax, 1 idiv edi ret f(unsigned

Re: [PATCH] match.pd: Simplify 1 / X for integer X [PR95424]

2022-01-06 Thread Zhao Wei Liew via Gcc-patches
On Wed, 5 Jan 2022 at 17:55, Richard Biener wrote: > On Wed, Jan 5, 2022 at 10:42 AM Jakub Jelinek wrote: > > > > On Wed, Jan 05, 2022 at 10:38:53AM +0100, Richard Biener via Gcc-patches > wrote: > > > On Wed, Jan 5, 2022 at 10:18 AM Zhao Wei Liew > wrote: >

Re: [PATCH] match.pd: Simplify 1 / X for integer X [PR95424]

2022-01-05 Thread Zhao Wei Liew via Gcc-patches
simplifying it here as well, but I'm not sure how to do the unsigned cast. Besides that, thanks for the rest of your suggestions! I'm testing the changes and will post a v2 soon. On Wed, 5 Jan 2022 at 16:18, Richard Biener wrote: > > On Wed, Jan 5, 2022 at 7:15 AM Zhao Wei L

[PATCH] match.pd: Simplify 1 / X for integer X [PR95424]

2022-01-04 Thread Zhao Wei Liew via Gcc-patches
match.pd/95424: Simplify 1 / X for integer X This patch implements an optimization for the following C++ code: int f(int x) { return 1 / x; } int f(unsigned int x) { return 1 / x; } Before this patch, x86-64 gcc -std=c++20 -O3 produces the following assembly: f(int): xor edx, edx

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2022-01-04 Thread Zhao Wei Liew via Phabricator via lldb-commits
zwliew updated this revision to Diff 396579. zwliew added a comment. Fixed rebase and diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleO

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2022-01-04 Thread Zhao Wei Liew via Phabricator via lldb-commits
zwliew added a comment. Herald added a subscriber: JDevlieghere. Oh no...I'm so sorry. Didn't mean to cause this large diff. Trying to fix it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 __

[Lldb-commits] [PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2022-01-04 Thread Zhao Wei Liew via Phabricator via lldb-commits
zwliew updated this revision to Diff 396578. zwliew added a comment. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, arjunp, sdasgup3, luke957, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, Chia-hungDuan, armkevincheng, ormris, foad, eric-k256,

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2021-12-30 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396579. zwliew added a comment. Fixed rebase and diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleO

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2021-12-30 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396578. zwliew added a comment. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, arjunp, sdasgup3, luke957, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, Chia-hungDuan, armkevincheng, ormris, foad, eric-k256,

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2021-12-30 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added a comment. Herald added a subscriber: JDevlieghere. Oh no...I'm so sorry. Didn't mean to cause this large diff. Trying to fix it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 __

[PATCH] D116371: [clang-format] Support inheriting from more than 1 parents in the fallback case

2021-12-29 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396580. zwliew added a comment. Herald added a subscriber: cfe-commits. Rebased on master for context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116371/new/ https://reviews.llvm.org/D116371 Files: clang/l

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2021-12-29 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added a comment. Thanks for the review. I've moved the unrelated change to https://reviews.llvm.org/D116371 instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

2021-12-29 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396519. zwliew retitled this revision from "[clang-format] Rebased on master: Add option to specify explicit config file" to "[clang-format] Add option to explicitly specify a config file". zwliew edited the summary of this revision. zwliew added a comment. A

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-12-28 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + zwliew wrote: > HazardyKnusperkeks wrote: > > zwliew wrote: > > > HazardyKnusperkeks wrote: > >

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-28 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); HazardyKnusperkeks wrote: > zwliew wrote: > > Is there a reason for this to be limited to 1? I

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-28 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396458. zwliew added a comment. Support inheritance in a chain of more than 1 parents I made the following changes: 1. Refactor the code for loading and parsing configs into a separate function 2. Add a new test case (9.1.2) to test the case mentioned in ht

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-28 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added a comment. In D72326#3211701 , @HazardyKnusperkeks wrote: > Do you plan to refactor something for this review, or do you think you are > done? Then I will look at it again as a whole. I'm going to try refactoring the code for loading and pa

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-12-28 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + HazardyKnusperkeks wrote: > zwliew wrote: > > HazardyKnusperkeks wrote: > > > zwliew wrote: > >

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-27 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3276 + // Check for explicit config filename + if (StyleName.startswith_insensitive("file:")) { +auto StyleNameFile = StyleName.substr(5); HazardyKnusperkeks wrote: > zwliew wrote: > > Fo

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-12-27 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + HazardyKnusperkeks wrote: > zwliew wrote: > > Is there a reason behind limiting the number of c

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396274. zwliew added a comment. Add a test for inheritance from parent config with base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.r

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); Is there a reason for this to be limited to 1? I came across this case during testing, but I c

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396273. zwliew added a comment. Support inheritance from parent configs via `BasedOnStyle: InheritParentConfig` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files:

[PATCH] D116299: [clang-format] Apply multiple children configs on fallback style

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew created this revision. zwliew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow multiple children configs to be applied on top of the fallback style. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116299 File

[PATCH] D116298: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew created this revision. zwliew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify a specific config file using --style=file:path/to/config/file Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116298 Files: c

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + Is there a reason behind limiting the number of children configs to 1 in this case? When the f

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-24 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added a comment. On further thought, the logic for `loadConfigFile()` looks incomplete. It does not properly handle the `InheritParentConfig` argument for `BasedOnStyle`. In fact, `loadConfigFile()` should probably use the same logic as that for `-style=file`. I can look into making this

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-24 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added a comment. Hi, I'd like to help to get this patch accepted and merged. I have a few suggestions/questions below, and I can help make any changes to the patch if needed! Comment at: clang/docs/ClangFormatStyleOptions.rst:35 +When using ``-style=file:, :program:`

[dpdk-dev] [PATCH] net/ixgbe: enable x550 flexible byte filter

2018-12-16 Thread Zhao Wei
There is need for users to use flexible byte filter on x550. This patch enable it. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_fdir.c | 9 +- drivers/n

[PATCH] Documentation: cpufreq: Correct a typo

2018-10-31 Thread Zhao Wei Liew
Fix a typo in the admin-guide documentation for cpufreq. Signed-off-by: Zhao Wei Liew --- Documentation/admin-guide/pm/cpufreq.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/pm/cpufreq.rst b/Documentation/admin-guide/pm/cpufreq.rst index

[dpdk-dev] [PATCH v3] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao Wei
In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info

[dpdk-dev] [PATCH v2] net/i40e: fix FDIR check programming status error

2018-07-12 Thread Zhao Wei
In i40e FDIR PMD code for checking programming status function i40e_check_fdir_programming_status(), the initial value of return value ret should be set to -1 not 0, because if DD bit of I40E_RX_DESC_STATUS_DD is not write back, this function will return 0 to upper function, this give an error info

[dpdk-dev] [PATCH v7] net/fm10k: add support for check descriptor status APIs

2018-07-02 Thread Zhao Wei
rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status are supported by fm10K. Signed-off-by: Wei Zhao --- v2: -fix DD check error in tx descriptor v3: -fix DD check index error v4: -fix error in RS bit list poll v5: -rebase code to branch and delete useless variable v6: -change relea

Re: How to create new principal and keytab for new service ?

2016-03-28 Thread Zhao Wei ZW Shen
Jeff, You just need implement the Kerberos Descriptor (kerberos.json). Ambari will help to create principals and distribute the keytab file. Regards, Zhaowei Shen From: Jeff Zhang To: u...@ambari.apache.org, Ambari Date: 2016-03-28 下午 06:38 Subject:How to create new principa

Kerveros version that Ambari supports

2016-03-19 Thread Zhao Wei ZW Shen
Hello~ I wanna enable Kerberos on my Ambari Cluster. Can anyone tell me the Kerberos version that Ambari supports? It seems Ambari will uses 1.10.3 by default. Regards, Zhaowei Shen

Re:Re: How to get Ambari server host in status function of service control script

2016-01-07 Thread Zhao Wei ZW Shen
You can get the Ambari server info from Agent conf file (e.g. /etc/ambari-agent/conf/ambari-agent.ini). Btw, there is link about HUE integration with Ambari ( https://developer.ibm.com/hadoop/blog/2015/10/27/how-to-install-hue-3-9-on-top-of-biginsights-4-1/ ). Regards, Zhaowei Shen From: "Zh

How to delete/update the Configuration type resource

2016-01-05 Thread Zhao Wei ZW Shen
Hi Experts, I can create and view the Configuration resource with Rest smoothly (POST and GET). But I found I cannot update/delete the Configuration that I created with Rest. Someone can coach me for this? It is appreciated. e.g. I can create the following Configuration with the cmd. How can I

How to delete/update the Configuration type resource

2016-01-05 Thread Zhao Wei ZW Shen
Hi Experts, I can create and view the Configuration resource with Rest smoothly (POST and GET). But I found I cannot update/delete the Configuration that I created with Rest. Someone can coach me for this? It is appreciated. e.g. I can create the following Configuration with the cmd. How can I

Re: Add service component question

2015-12-22 Thread Zhao Wei ZW Shen
ostRoles": {"state": "INSTALLED"}}' http://`hostname -f`:8080/api/v1/clusters/c1/hosts/c6401.ambari.apache.org/host_components/APP_TIMELINE_SERVER -- Thanks Jaimin From: Zhao Wei ZW Shen Sent: Tuesday, December 22, 2015 6:40 PM To: user@ambari.apache.org S

Add service component question

2015-12-22 Thread Zhao Wei ZW Shen
Hi Expects, Does Ambari support to add a new component definition with Rest API? I wanna  add and update a service component with Rest. Regards, Micle

SUPPLY: GEARBOX, REDUCER

2015-09-19 Thread zhao wei
Sell: China Shenzhen ZHAOWEI Machinery & Electronics Co. Ltd engages in designing, manufacturing and marketing all kinds of electric motors. They are mainly suitable for the following applications: smart home application used in smart kitchen and laundry, medical instrument for personal care,

aeou

2014-10-24 Thread Zhao Wei
-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [R] SPSS import problem

2008-03-12 Thread Zhao, Wei (Cancer Center)
I had a similar problem when read one of my spss.sav with long variable label. But when I read another spss.sav with short label the same way, I don't have problem. Seems like R only allows variable labels of lengths 1...255 as your error message showed. WZ -Original Message- From: [EMAI

[R] Import SPSS.por file

2008-03-05 Thread Zhao, Wei (Cancer Center)
Dear all, I try to import a SPSS.por dataset with about 6000 cases and 650 variables with R commander and got error messages: 'Error: /temp/t.por" use.value.labels=true, max.value.label=inf, 'Error: data is not data frame and cannot be attached' Any comment? Thanks in advan

[R] (no subject)

2008-03-05 Thread Zhao, Wei (Cancer Center)
Dear all, I try to import a SPSS.por dataset with about 6000 cases and 650 variables with R commander and got error messages: 'Error: /temp/t.por" use.value.labels=true, max.value.label=inf, 'Error: data is not data frame and cannot be attached' Any comment? Thanks in advan

[PHP-DEV] CVS Account Request: zhaowei

2006-12-14 Thread zhao wei
improve mailparse extension -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: how many debian guys in nanjing

2004-09-14 Thread Zhao Wei
åäçæèåãäæçååäãååã On Mon, 13 Sep 2004 10:22:13 +0800, Arthur Zhang <[EMAIL PROTECTED]> wrote: > æåäæïçäçéèåäåïïï > > > > > On Fri, 10 Sep 2004 19:13:59 +0800, Zhao Wei <[EMAIL PROTECTED]> wrote: > > èæääãèäçäéèåääåçæååäåï:) > > æäæä meetup èäèåï >

Re: ÎÒµÄstardictΪʲô²»ÄÜ·¢Òô

2004-09-10 Thread Zhao Wei
sigh. there're still problems with gmail and chinese! :( ççæçèåèæäæ On Thu, 9 Sep 2004 23:07:35 +0800 (CST), [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > ÃÃÃÂÂÃÂÂ > ÃÃÃÂÃÃÂÃÃÃDebian 3.0r2 > testingÃÂÃÃstardict2.4.3ÂÂÂÃstardict.sourceforge.netÂÃWyabdcRealPeopleTTSÂÂÃÃÂÃÂ

how many debian guys in nanjing

2004-09-10 Thread Zhao Wei
èæääãèäçäéèåääåçæååäåï:) æäæä meetup èäèåï -- http://advogato.org/person/zhaoway

Re: gmail和这个list的 问题

2004-09-07 Thread Zhao Wei
èälistæççåäåïåææäççèæççèãæääéã On Tue, 7 Sep 2004 15:31:53 +0800, Wang WenRui <[EMAIL PROTECTED]> wrote: > èéçäåæäéæIn-Reply-ToåMessage-IDåïååäMUAéæææééçã > ååïgmailéèdebian-user,debian-develçconversationææåçïæææ > èèèälistã > > Around 15 o'clock

Re: gmail 和这个list的问题

2004-09-07 Thread Zhao Wei
ååèæèäéæçéé On Tue, 7 Sep 2004 16:03:11 +0800, Jungle Ji <[EMAIL PROTECTED]> wrote: > äåçåèæåïæèåäèé subject > èèåäåäçæã > > On Tue, 7 Sep 2004 15:21:59 +0800, Zhao Wei <[EMAIL PROTECTED]> wrote: > > åååçgmailäèæèälistäçääçåæconversationææçãäçéæäæèäl

gmail和这个list的问题

2004-09-07 Thread Zhao Wei
åååçgmailäèæèälistäçääçåæconversationææçãäçéæäæèälistéçäçéééæçåï -- http://advogato.org/person/zhaoway

Re: Xpdf的中文显示问

2004-09-06 Thread Zhao Wei
> newblue <[EMAIL PROTECTED]> wrote: > > > æçåçådebian woodyïçèçåçxpdfï woody åèçåæçèäã -- http://advogato.org/person/zhaoway

Re: LINUX Expo Shanghai

2004-08-31 Thread Zhao Wei
çåæåääæåääèæçæååïåäææçäæäåï -- http://advogato.org/person/zhaoway

Re: how to input Chinese in Emacs for windows

2004-02-24 Thread ZHAO Wei
[EMAIL PROTECTED] ;) wrote: > ,[ 加到.emacs里面 ] > | ;;; Use Native IMEs !! ;) > | (set-terminal-coding-system 'chinese-iso-8bit) > | (set-keyboard-coding-system 'chinese-iso-8bit) > | (setq locale-coding-system 'chinese-iso-8bit) > ` > > BTW, 在这里问这种问题不太适合吧? 为什么不合适?

Re: how to input Chinese in Emacs for windows

2004-02-24 Thread ZHAO Wei
Ben Luo wrote: > Li Yue wrote: > >>hi, >>装了Emacs for windows,想问问怎么在emacs中输入中文? >>谢谢先! >>liyue > > 只能用Emacs自带的中文输入法。而且只能一个字,一个字的输入。 > 在Linux下可以用Chinput输入 我在 gnome-terminal 里面用 emacs -nw 用 fcitx 输入中文

  1   2   >