Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

2003-07-08 Thread Ryan Underwood
Hi Takashi, On Tue, Jul 08, 2003 at 12:50:05PM +0200, Takashi Iwai wrote: One issue is to note, I don't know if this is a problem with the ad1848 driver in general or what; if I cat a 11025hz mono 8-bit file to /dev/dsp, the sound comes out very swwwllly. But using aplay,

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

2003-07-08 Thread Takashi Iwai
At Tue, 8 Jul 2003 12:01:21 -0500, Ryan Underwood wrote: Takashi, Please amend the previous patch. I forgot breaks in snd_ad1848_thinkpad_twiddle. The behavior would be to always fall through to enabling the device. ok fixed. Takashi

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

2003-07-08 Thread Takashi Iwai
At Tue, 8 Jul 2003 08:58:21 -0500, Ryan Underwood wrote: Hi Takashi, On Tue, Jul 08, 2003 at 12:50:05PM +0200, Takashi Iwai wrote: One issue is to note, I don't know if this is a problem with the ad1848 driver in general or what; if I cat a 11025hz mono 8-bit file to /dev/dsp,

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

2003-07-08 Thread Takashi Iwai
At Tue, 8 Jul 2003 12:32:29 -0500, Ryan Underwood wrote: Hi Takashi, On Tue, Jul 08, 2003 at 07:27:06PM +0200, Takashi Iwai wrote: The results are pasted below -- what is strange is that aplay identifies the file as 11025Hz but apparently the OSS driver thinks it is 8000Hz data.

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions [PATCH]]

2003-07-07 Thread Ryan Underwood
Hi Takashi, On Thu, Jul 03, 2003 at 02:29:01PM +0200, Takashi Iwai wrote: At Wed, 2 Jul 2003 15:29:55 -0500, Ryan Underwood wrote: 1) What is ALSA's policy on module options? For example, would it be okay to add an option like thinkpad to the ad1848 module, so that inserting it with

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions

2003-07-03 Thread Takashi Iwai
At Wed, 2 Jul 2003 15:29:55 -0500, Ryan Underwood wrote: 1) What is ALSA's policy on module options? For example, would it be okay to add an option like thinkpad to the ad1848 module, so that inserting it with thinkpad=1 would cause the necessary ports to be prodded? this looks like a

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions

2003-07-03 Thread Takashi Iwai
At Wed, 2 Jul 2003 13:50:07 -0500, Ryan Underwood wrote: So, my question to alsa-devel is, what should be the proper way to do this fix? I could just do something like the following: ... try init ... else { /* if the chip remained busy, let's see if we have a Thinkpad that needs

Re: [Alsa-devel] cs4248 / thinkpad 755 / 755c , patch suggestions

2003-07-03 Thread Ryan Underwood
Hi Takashi, On Thu, Jul 03, 2003 at 02:29:01PM +0200, Takashi Iwai wrote: At Wed, 2 Jul 2003 15:29:55 -0500, Ryan Underwood wrote: 1) What is ALSA's policy on module options? For example, would it be okay to add an option like thinkpad to the ad1848 module, so that inserting it with