Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-25 Thread Jaroslav Kysela
On Mon, 24 Nov 2003, Takashi Iwai wrote: > At Mon, 24 Nov 2003 13:51:50 +0100, > I wrote: > > > > At Mon, 24 Nov 2003 13:36:42 +0100, > > I wrote: > > > > > > meanwhile, i'm trying to implement: > > > > > > (4) allow prepare callback to sleep with a special flag. > > > > > > this will be usefu

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-25 Thread Takashi Iwai
At Tue, 25 Nov 2003 12:51:11 +0100 (CET), Jaroslav wrote: > > On Mon, 24 Nov 2003, Takashi Iwai wrote: > > > At Mon, 24 Nov 2003 13:51:50 +0100, > > I wrote: > > > > > > At Mon, 24 Nov 2003 13:36:42 +0100, > > > I wrote: > > > > > > > > meanwhile, i'm trying to implement: > > > > > > > > (4) a

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Takashi Iwai
At Mon, 24 Nov 2003 13:51:50 +0100, I wrote: > > At Mon, 24 Nov 2003 13:36:42 +0100, > I wrote: > > > > meanwhile, i'm trying to implement: > > > > (4) allow prepare callback to sleep with a special flag. > > > > this will be useful for other drivers, too, such as vx and korg1212 > > drivers wh

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Takashi Iwai
At Mon, 24 Nov 2003 13:36:42 +0100, I wrote: > > meanwhile, i'm trying to implement: > > (4) allow prepare callback to sleep with a special flag. > > this will be useful for other drivers, too, such as vx and korg1212 > drivers which require the handshaking. > but what i'm doing is still a hack,

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Takashi Iwai
At Mon, 24 Nov 2003 13:10:55 +0100 (MET), Clemens Ladisch wrote: > > Takashi Iwai wrote: > > > Clemens Ladisch wrote: > > > > > > - initialize active_mask and unlink_mask each time before URBs are > > > started > > > > we still need to check here whether the urbs are really free, since > > a pa

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Clemens Ladisch
Takashi Iwai wrote: > Clemens Ladisch wrote: > > > > - initialize active_mask and unlink_mask each time before URBs are > > started > > we still need to check here whether the urbs are really free, since > a path like trigger stop -> prepare -> trigger_start is possible. > in this case, the oper

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Takashi Iwai
At Mon, 24 Nov 2003 08:46:08 +0100 (MET), Clemens Ladisch wrote: > > > - don't clear active_mask bits until it's clear that the URB is _not_ > resubmitted, to prevent a race with unlinking > - initialize active_mask and unlink_mask each time before URBs are > started we still need to check h

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-11-24 Thread Takashi Iwai
At Mon, 24 Nov 2003 08:46:08 +0100 (MET), Clemens Ladisch wrote: > > > - don't clear active_mask bits until it's clear that the URB is _not_ > resubmitted, to prevent a race with unlinking > - initialize active_mask and unlink_mask each time before URBs are > started we still need to check h

Re: [Alsa-devel] [PATCH] usbaudio fixes

2003-06-20 Thread Takashi Iwai
At Thu, 19 Jun 2003 09:00:47 +0200 (METDST), Clemens Ladisch wrote: > > > I botched my previous patch for the UA-5: the altsettings of the audio > interface would be ignored because bInterfaceSubClass isn't set to > USB_SUBCLASS_AUDIO_STREAMING on that device. This patch corrects this. > > And s