Re: [Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug (2nd try)

2003-12-03 Thread Takashi Iwai
At Tue, 02 Dec 2003 17:41:13 -0800, Steve deRosier wrote: Takashi, I've completed my changes on the serial-u16550 driver. I have implemented most of your suggestions to my previous patch. Now: * There is a user selectable flag droponfull. Set to 1 and any new bytes delivered to

[Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug (2nd try)

2003-12-02 Thread Steve deRosier
Takashi, I've completed my changes on the serial-u16550 driver. I have implemented most of your suggestions to my previous patch. Now: * There is a user selectable flag droponfull. Set to 1 and any new bytes delivered to the driver after the buffer fills up will be discarded until the

Re: [Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug

2003-11-03 Thread Steve deRosier
Takashi Iwai wrote: At Thu, 30 Oct 2003 13:33:37 -0800, Steve deRosier wrote: Takashi, Thanks for your response. I've addressed your issues below. Let's discuss this and if necessary I'll modify my fix. 1. Move all checks of buffer overflow and such to the actual buffer write and read

Re: [Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug

2003-10-31 Thread Takashi Iwai
At Thu, 30 Oct 2003 13:33:37 -0800, Steve deRosier wrote: Takashi, Thanks for your response. I've addressed your issues below. Let's discuss this and if necessary I'll modify my fix. 1. Move all checks of buffer overflow and such to the actual buffer write and read routines. This

Re: [Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug

2003-10-30 Thread Steve deRosier
Takashi, Thanks for your response. I've addressed your issues below. Let's discuss this and if necessary I'll modify my fix. 1. Move all checks of buffer overflow and such to the actual buffer write and read routines. This makes the buffer routines more robust and encaspulates buffer

[Alsa-devel] [PATCH] serial-u16550 driver. Fixes buffer blocking bug

2003-10-29 Thread Steve deRosier
I am submitting a patch to the serial-u16550 driver fix a bug that we have encountered. Basically, when using the SNDRV_SERIAL_GENERIC adaptor in the serial-u16550 MIDI driver, if the device becomes unplugged or some other condition where the device stops signaling CTS, the send buffer backs