Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-16 Thread Takashi Iwai
At Sat, 15 May 2004 23:37:47 +0200, Giuliano Pochini wrote: On Fri, 14 May 2004 12:37:46 +0200 Takashi Iwai [EMAIL PROTECTED] wrote: prepare and trigger callbacks are already in irq-disabled. i.e. you need only spin_lock() in them. Does it mean that ALSA acquires the lock only

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-14 Thread Takashi Iwai
At Thu, 13 May 2004 20:57:51 +0200, Giuliano Pochini wrote: On Mon, 10 May 2004 17:08:49 +0200 Takashi Iwai [EMAIL PROTECTED] wrote: prepare and trigger callbacks are already in irq-disabled. i.e. you need only spin_lock() in them. Does it mean that ALSA acquires the lock only when

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-13 Thread Giuliano Pochini
On Mon, 10 May 2004 17:08:49 +0200 Takashi Iwai [EMAIL PROTECTED] wrote: prepare and trigger callbacks are already in irq-disabled. i.e. you need only spin_lock() in them. Does it mean that ALSA acquires the lock only when it calls PCM callbacks, that is trigger(), etc., are atomic only wrt

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-13 Thread Giuliano Pochini
On 10-May-2004 Takashi Iwai wrote: prepare and trigger callbacks are already in irq-disabled. i.e. you need only spin_lock() in them. [...] Fine. I moved SetSampleRate() from prepare() to the hw_params() callback because it may need to reload the firmware. -- Giuliano.

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-10 Thread Giuliano Pochini
On 10-May-2004 Takashi Iwai wrote: Some drivers use spin_lock_irq() a lot, while others always use spin_lock_irqsave(). I can't see the difference. When it's safe using the _irq() version ? Only when you know that you are not in interrupt context. also, not in the context which already

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-10 Thread Takashi Iwai
At Mon, 10 May 2004 16:51:24 +0200 (CEST), Giuliano Pochini wrote: On 10-May-2004 Takashi Iwai wrote: Some drivers use spin_lock_irq() a lot, while others always use spin_lock_irqsave(). I can't see the difference. When it's safe using the _irq() version ? Only when you know

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-10 Thread Clemens Ladisch
Giuliano Pochini wrote: Some drivers use spin_lock_irq() a lot, while others always use spin_lock_irqsave(). I can't see the difference. When it's safe using the _irq() version ? Only when you know that you are not in interrupt context. Regards, Clemens

Re: [Alsa-devel] spin_lock_irqwhat ?

2004-05-10 Thread Takashi Iwai
At Mon, 10 May 2004 10:31:07 +0200 (METDST), Clemens Ladisch wrote: Giuliano Pochini wrote: Some drivers use spin_lock_irq() a lot, while others always use spin_lock_irqsave(). I can't see the difference. When it's safe using the _irq() version ? Only when you know that you are not in

[Alsa-devel] spin_lock_irqwhat ?

2004-05-08 Thread Giuliano Pochini
Some drivers use spin_lock_irq() a lot, while others always use spin_lock_irqsave(). I can't see the difference. When it's safe using the _irq() version ? -- Giuliano. --- This SF.Net email is sponsored by Sleepycat Software Learn