Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-05 Thread Jaroslav Kysela
On Tue, 3 Feb 2004, James Courtier-Dutton wrote: I attach a patch that fixes alsa-lib. All it does it call snd_pcm_start() just before snd_pcm_wait() and due to the if statement just above it, will only happen when the buffer is going to be filled, therefore ensuring that even if

Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-05 Thread Glenn Maynard
On Thu, Feb 05, 2004 at 12:01:28PM +0100, Jaroslav Kysela wrote: My point is, I don't think setting start_threshold to buffer_size is even wrong at all. Some people might want the buffer to be full before it starts, and my patch allows for that. It's not wrong semantics. I see - it's

Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-05 Thread Jaroslav Kysela
On Thu, 5 Feb 2004, Glenn Maynard wrote: On Thu, Feb 05, 2004 at 12:01:28PM +0100, Jaroslav Kysela wrote: My point is, I don't think setting start_threshold to buffer_size is even wrong at all. Some people might want the buffer to be full before it starts, and my patch allows for

Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-05 Thread Glenn Maynard
On Thu, Feb 05, 2004 at 08:38:23PM +0100, Jaroslav Kysela wrote: Otherwise, programs will work on some hardware and not others, which is a case that should be minimized as much as possible; it's these kinds of subtle differences that make it very hard to write reliable (sound, video, etc)

Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-05 Thread James Courtier-Dutton
Jaroslav Kysela wrote: On Thu, 5 Feb 2004, Glenn Maynard wrote: On Thu, Feb 05, 2004 at 12:01:28PM +0100, Jaroslav Kysela wrote: My point is, I don't think setting start_threshold to buffer_size is even wrong at all. Some people might want the buffer to be full before it starts, and my patch

Re: [PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-03 Thread James Courtier-Dutton
Jaroslav Kysela wrote: On Mon, 2 Feb 2004, James Courtier-Dutton wrote: James Courtier-Dutton wrote: Once thing I have noticed, is that with the alc650, we used to have VRA (alsa 0.9.8), but the 1.0.2 intel8x0 driver ignores the VRA and fixes itself at 48000. So, before I never needed the

[PATCH] Fixes: Re: [Alsa-devel] intel8x0 has stopped working.

2004-02-02 Thread James Courtier-Dutton
James Courtier-Dutton wrote: Once thing I have noticed, is that with the alc650, we used to have VRA (alsa 0.9.8), but the 1.0.2 intel8x0 driver ignores the VRA and fixes itself at 48000. So, before I never needed the sample rate converters, but as it now fixes the rate at 48000, I need the