Re: amflush and .tmp files in holding directory

2017-11-22 Thread Nathan Stratton Treadway
On Wed, Nov 22, 2017 at 09:35:48 -0500, Jean-Louis Martineau wrote: > We want to flush the .tmp files. > > They are partial dump and they may contains important files, so we want > to flush them. > amrecover never restore from partial dump, but they can be manually > restored. Ah, got it. In

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-22 Thread Jean-Louis Martineau
Nathan, I committed the attached patch, It fix all the issues I saw. Can you try to use the SVN or GIT repository? they have other fixes. SVN: 1. svn checkout svn://svn.code.sf.net/p/amanda/code/amanda/branches/3_5 amanda-3-5 2. cd amanda-3-5 3. ./autogen 4. ./configure 5. make

Re: "vaulting run" amdump email report issues -- driver.c "nodump" option

2017-11-22 Thread Jean-Louis Martineau
On 22/11/17 12:56 AM, Nathan Stratton Treadway wrote: > On Mon, Nov 20, 2017 at 11:45:07 -0500, Jean-Louis Martineau wrote: > > Nathan, > > > > I was too fast to write the first patch, and you are completely right. > > > > I committed the attached patch,now amflush use the --no-dump argument > >

Re: amflush and .tmp files in holding directory

2017-11-22 Thread Jean-Louis Martineau
Nathan, We want to flush the .tmp files. They are partial dump and they may contains important files, so we want to flush them. amrecover never restore from partial dump, but they can be manually restored. Jean-Louis On 21/11/17 08:33 PM, Nathan Stratton Treadway wrote: > On Mon, Nov 20,

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-22 Thread Jean-Louis Martineau
Nathan, search_holding_disk should not take the pid file. Jean-Louis On 21/11/17 06:49 PM, Nathan Stratton Treadway wrote: > On Tue, Nov 21, 2017 at 12:57:00 -0500, Nathan Stratton Treadway wrote: > > > I do not see how Amanda::Util::setup_application call code in > holding.c > > > > To be

Re: amflush run while amdump underway tries to flush .tmp files

2017-11-22 Thread Jean-Louis Martineau
For amdump, it is the planner that create the pid file, it must put its ppid in it (amdump process) (done in holding.c) For amflush, it is amflush that create the pid file, it must put its pid in it (done in Holding.pm) In both case, the driver call cleanup_holding to remove the pid, you are