Re: Should we support building utilities without building player?

2011-12-20 Thread Bart Cerneels
On Mon, Dec 19, 2011 at 00:15, Matěj Laitl ma...@laitl.cz wrote: Hi amarok-devel, while trying to solve Gentoo bug 390831 [1] I've found that it is currently (master branch) impossible to build Amarok utilities (amarokcollectionscanner and amarok_afttagger) without building the player itself.

[amarok/strohel-for-2.6] src: Get rid of UpdateCapability entirely - it was no longer used

2011-12-20 Thread Matěj Laitl
Git commit 2e73dd379d51a5df37e996cd392b98fd66191daf by Matěj Laitl. Committed on 10/12/2011 at 17:51. Pushed by laitl into branch 'strohel-for-2.6'. Get rid of UpdateCapability entirely - it was no longer used UpdateCapability was deprecated and thanks to previous commits, all UpdateCapability

Re: [amarok/strohel-for-2.6] src: Get rid of UpdateCapability entirely - it was no longer used

2011-12-20 Thread Bart Cerneels
+1 While I understand there were good arguments made for the use of the rather complicated Capability pattern, it clearly was applied to eagerly. We need to think about code readability (and clarity of architecture) and maintainability for the long run. On Tue, Dec 20, 2011 at 13:09, Matěj Laitl

Request for review: my patch queue for 2.6

2011-12-20 Thread Matěj Laitl
Hi Amarockers, already annouced on IRC, repeating here: please review strohel-for-2.6 branch [1] that I've pushed to Amarok git repo. [1] http://quickgit.kde.org/?p=amarok.gita=shortlogh=refs/heads/strohel- for-2.6 Most of the commits touch just media devices, but some of them affect Amarok as

Re: Request for review: my patch queue for 2.6

2011-12-20 Thread Bart Cerneels
Just make sure you squash the commits that belong together :) And don't forget to Changelog in the same commit! On Tuesday, December 20, 2011, Matěj Laitl ma...@laitl.cz wrote: Hi Amarockers, already annouced on IRC, repeating here: please review strohel-for-2.6 branch [1] that I've pushed to

Fwd: how to connect amarok player with empathy chat engine

2011-12-20 Thread Myriam Schweingruber
FYI, please do not forget to Cc the sender as this came in trough the web form. Regards, Myriam -- Forwarded message -- From: Gagan Naidu gagan.globi...@gmail.com Date: Tue, Dec 20, 2011 at 18:11 Subject: how to connect amarok player with empathy chat engine To: ama...@kde.org