Re: [amarok] /: CollectionLocation: make associated collection pointer non-const

2012-01-21 Thread Kevin Funk
On Saturday 21 January 2012, 01:39, Matěj Laitl wrote: Git commit 99a7d0b5bb541ed6400213d81cc7683935666514 by Matěj Laitl. Committed on 20/01/2012 at 15:21. Pushed by laitl into branch 'master'. CollectionLocation: make associated collection pointer non-const CollectionLocation is used to

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Jaime Torres Amate
On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 http://git.reviewboard.kde.org/r/103741/diff/1/?file=47490#file47490line643 I don't understand this. Do not add a new playlist if there were no playlists previously?

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Jaime Torres Amate
On Jan. 20, 2012, 10:53 a.m., Matěj Laitl wrote: src/browsers/playlistbrowser/PlaylistBrowserModel.cpp, line 643 http://git.reviewboard.kde.org/r/103741/diff/1/?file=47490#file47490line643 I don't understand this. Do not add a new playlist if there were no playlists previously?

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-21 Thread Volker Christian
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736/ --- (Updated Jan. 20, 2012, 11:41 a.m.) Review request for Amarok and Bart

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103752/#review9975 --- No obvious technical issues. However, I am wondering: Is there

Re: Review Request: Avoid the crash @ QtGroupingProxy::addSourceRow

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103741/#review9977 --- I agree. This patch looks wrong. beginInsertRows(.., 0, 0);

Re: Review Request: Rework transcoding: CollectionLocation asks user, not caller of prepareCopy()

2012-01-21 Thread Matěj Laitl
On Jan. 21, 2012, 11:56 a.m., Ralf Engels wrote: No obvious technical issues. However, I am wondering: Is there really a transcoding capability? I mean, we should be able to transcode everything independent of the collection it's in. Also, I don't like the concept of the

Re: Review Request: Enable find as you type support in the playlist

2012-01-21 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102442/#review9982 --- Been thinking about it. It's a nice functionality, but also