Re: Review Request: Bug 173814 - JJ: add keyboard shortcut for Edit Track Information...

2012-02-14 Thread Bart Cerneels
On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote: src/playlist/PlaylistDock.cpp, line 327 http://git.reviewboard.kde.org/r/103960/diff/1/?file=49412#file49412line327 Is there any specific reason this call is here? Jasneet Bhatti wrote: I was unable to completely understand

Re: Continuous integration for Amarok on build.kde.org

2012-02-14 Thread Matěj Laitl
On 13. 2. 2012 Torgny Nyblom wrote: http://build.kde.org/view/EXTRAGEAR/ Here it is Please let me know if there is anymore I can help with. Superbe, thank you very much. I will look at the test failures and determine where is the problem - the tests all pass when I run them locally.

Re: Review Request: Bug 173814 - JJ: add keyboard shortcut for Edit Track Information...

2012-02-14 Thread Jasneet Bhatti
On Feb. 13, 2012, 8:40 a.m., Matěj Laitl wrote: src/playlist/PlaylistDock.cpp, line 327 http://git.reviewboard.kde.org/r/103960/diff/1/?file=49412#file49412line327 Is there any specific reason this call is here? Jasneet Bhatti wrote: I was unable to completely understand