Review Request: Add composer button to wikipedia applet

2012-03-18 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/ --- Review request for Amarok. Description --- Adds a new composer

Re: Review Request: Implemented Bug 214721 - Enable bookmark marker to be moved

2012-03-18 Thread Jasneet Bhatti
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104307/ --- (Updated March 17, 2012, 9:02 a.m.) Review request for Amarok.

GSoC : Implement MediaArtStorageSpec

2012-03-18 Thread Jasneet Bhatti
I'm interested in working on Project: Implement MediaArtStorageSpec as a GSoC project. I've read the information on the links provided on the page https://bugs.kde.org/show_bug.cgi?id=296049 . What more do I need to study and how should I go about working on this ?

Re: Review Request: Fix bug 295275

2012-03-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104321/#review11528 --- Hmm, my understanding why the code was there: 1) User starts

Re: GSoC : Implement MediaArtStorageSpec

2012-03-18 Thread Teo Mrnjavac
On Sat, Mar 17, 2012 at 18:46, Jasneet Bhatti jazneetbha...@gmail.com wrote: I'm interested in working on Project: Implement MediaArtStorageSpec as a GSoC project. I've read the information on the links provided on the page https://bugs.kde.org/show_bug.cgi?id=296049 . What more do I need to

Re: Review Request: Add composer button to wikipedia applet

2012-03-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/#review11530 --- The patch looks good, thanks for it! There are 2 smaller

Re: Fisheye is down, insanity as well

2012-03-18 Thread Myriam Schweingruber
2012/3/18 Olivier Bédard olivi...@kollide.net: All up now Yes for insanity, thank you, but amarok.be/fisheye is still not accessible. I assume this is still the address in use, right? Regards, Myriam -- Proud member of the Amarok and KDE Community Protect your freedom and join the Fellowship

Re: Fisheye is down, insanity as well

2012-03-18 Thread Teo Mrnjavac
On Sun, Mar 18, 2012 at 12:09, Myriam Schweingruber myr...@kde.org wrote: 2012/3/18 Olivier Bédard olivi...@kollide.net: All up now Yes for insanity, thank you, but amarok.be/fisheye is still not accessible. I assume this is still the address in use, right? Regards, Myriam

Re: Review Request: Fix bug 295275

2012-03-18 Thread Sam Lade
On March 18, 2012, 10:11 a.m., Matěj Laitl wrote: Hmm, my understanding why the code was there: 1) User starts to drag tracks from a collection tree view: CollectionTreeItemModelBase::mimeData() has following code: AmarokMimeData *mimeData = new AmarokMimeData();

Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Daniel Dewald
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104330/ --- Review request for Amarok. Description --- Removes some unnecessary

Re: Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104330/#review11540 --- I've tried the patch. Previously the spectrum analyzer said:

Re: Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Daniel Dewald
On March 18, 2012, 2:10 p.m., Matěj Laitl wrote: I've tried the patch. Previously the spectrum analyzer said: no sample buffer support. Now it pretends it is working but shows nothing or just some corrupted image that doesn't update. Following messages appear in debug output:

Re: Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

2012-03-18 Thread Matěj Laitl
On March 18, 2012, 2:10 p.m., Matěj Laitl wrote: I've tried the patch. Previously the spectrum analyzer said: no sample buffer support. Now it pretends it is working but shows nothing or just some corrupted image that doesn't update. Following messages appear in debug output:

Re: Review Request: Restore heuristics to guess whether album is a compilation

2012-03-18 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104294/#review11582 --- Are the unit test running? There is one specific scenario