Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: > > Could you please explain what are the benefits (direct, current - not > > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, > > MergedTreeItem split? Where exactly is avoids code duplication? > > Lucas Gomes wrote: > Ok,

[Tomahawk Integration] Fifth week of GSoC

2012-06-01 Thread Lucas Lira Gomes
Hi everyone, I've fixed some bugs in the database synchronisation and done some research about how collections work. I believe that all corner cases that would require a sync between amarok and tomahawk data are now covered ;}. Also, I had git pulled some small changes to libtomahawk and they're a

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: > > Could you please explain what are the benefits (direct, current - not > > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, > > MergedTreeItem split? Where exactly is avoids code duplication? Ok, first ignore revision five. I