Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-26 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review28114 --- Could a developer please look at this? - Myriam Schweingruber

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-02-26 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review28117 --- Hi, thanks for the patch and sorry for delays while reviewing

Re: Review Request 108907: Added transcoding for opus format

2013-02-26 Thread Martin Brodbeck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108907/#review28125 --- Ship it! Ship It! - Martin Brodbeck On Feb. 26, 2013, 8:08

Re: [amarok] src: Refactoring: Using the same delegate almost everywhere in the browser

2013-02-26 Thread Matěj Laitl
On 22. 2. 2013 Ralf Engels wrote: Git commit 730583c601404719102ba92f72d07ab9ae14ade1 by Ralf Engels. Refactoring: Using the same delegate almost everywhere in the browser After using Amarok a couple of days with this patch I must say it was worth the effort. I have found another round of

Re: [amarok] src: Refactoring: Using the same delegate almost everywhere in the browser

2013-02-26 Thread Ralf Engels
Am Dienstag, 26. Februar 2013, 13:29:53 schrieb Matěj Laitl: On 22. 2. 2013 Ralf Engels wrote: Git commit 730583c601404719102ba92f72d07ab9ae14ade1 by Ralf Engels. Refactoring: Using the same delegate almost everywhere in the browser After using Amarok a couple of days with this patch I

Re: Trying to solve bug 240409

2013-02-26 Thread Abhinandan Ramprasath
On Mon, Feb 25, 2013 at 10:21 AM, Sergey Ivanov 123k...@gmail.com wrote: Hi. Actually you can get much more data using TagLib. Fields mentioned by you can be obtained using unified TagLib API, It works for all metadata containers. You you need to get some extra data, you have to dig It by

Re: Review Request 109157: Amarok buildsystem cleanup preview

2013-02-26 Thread Matěj Laitl
On Feb. 25, 2013, 9:48 p.m., Edward Hades Toroshchin wrote: Why do you want the intermediate libs at all? Matěj Laitl wrote: In general, all points mentioned in http://www.cmake.org/Wiki/CMake/Tutorials/Object_Library#Motivation hold here, especially This approach is easy to use