Re: CUE sheets in collection still not working :(

2013-04-15 Thread Lukáš Lalinský
I'm not sure how exactly are chapters stored in MP4 files, but I don't expect it to be a too large change. I don't see a reason why it would be not possible to implement it as a part of the GSoC project. Btw, there has been a post on the TagLib mailing list about implementing the CHAP frame on

Re: CUE sheets in collection still not working :(

2013-04-15 Thread Bart Cerneels
On Sun, Apr 14, 2013 at 12:11 PM, Matěj Laitl ma...@laitl.cz wrote: On 11. 4. 2013 Myriam Schweingruber wrote: Hi all, This is just a reminder for https://bugs.kde.org/show_bug.cgi?id=187587 This is a long standing bug and the one with the highest amount of votes: 751 It would be

Re: CUE sheets in collection still not working :(

2013-04-15 Thread Abhinandan Ramprasath
I'm still working on the patch for the mp4 chapter support. The one I submitted the other day was kind of incomplete and realized my mistakes and it turned out be way bigger than I anticipated. I would love to take this up as a GSOC project. Since, I got really involved in this one and because of

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Alberto Villa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105290/#review31088 --- - Alberto Villa On Sept. 26, 2012, 12:26 a.m., Alberto Villa

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Alberto Villa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105290/ --- (Updated April 15, 2013, 12:51 p.m.) Review request for Amarok and Sergey

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Alberto Villa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105290/#review31090 --- src/musicbrainz/MusicBrainzTags.cpp

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-15 Thread Anmol Ahuja
On April 14, 2013, 6 p.m., Matěj Laitl wrote: src/core-impl/collections/daap/DaapMeta.cpp, lines 77-85 http://git.reviewboard.kde.org/r/109817/diff/4/?file=138512#file138512line77 Please remove this now redundant method - the base implementation + custom notPlayableReason() will

Re: Review Request 109817: JJ 313649 - No warning if there are no permissions to read file

2013-04-15 Thread Matěj Laitl
On April 14, 2013, 12:30 p.m., Matěj Laitl wrote: src/core-impl/collections/daap/DaapMeta.cpp, lines 77-85 http://git.reviewboard.kde.org/r/109817/diff/4/?file=138512#file138512line77 Please remove this now redundant method - the base implementation + custom notPlayableReason()

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 15, 2013, 9:25 p.m.) Review request for Amarok. Changes

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
On April 14, 2013, 7:08 p.m., Matěj Laitl wrote: src/dialogs/EqualizerDialog.cpp, lines 100-102 http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100 code style: no space between if and ( ooppss !!! - Harsh

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: src/EngineController.cpp, line 793 http://git.reviewboard.kde.org/r/108995/diff/2/?file=119751#file119751line793 How am I suppose to stage changes in a line ( line 791 ) in which a variable is first renamed and then get deleted ?

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Matěj Laitl
On April 14, 2013, 1:38 p.m., Matěj Laitl wrote: src/dialogs/EqualizerDialog.cpp, lines 100-102 http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100 code style: no space between if and ( Harsh Gupta wrote: ooppss !!! I'll fix it while committin, no

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Harsh Gupta
On April 14, 2013, 7:08 p.m., Matěj Laitl wrote: src/dialogs/EqualizerDialog.cpp, lines 100-102 http://git.reviewboard.kde.org/r/108995/diff/4/?file=138625#file138625line100 code style: no space between if and ( Harsh Gupta wrote: ooppss !!! Matěj Laitl wrote: I'll

Jenkins build became unstable: amarok_master #342

2013-04-15 Thread KDE CI System
See http://build.kde.org/job/amarok_master/342/changes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

2013-04-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31119 --- This review has been submitted with commit

Jenkins build is back to stable : amarok_master #343

2013-04-15 Thread KDE CI System
See http://build.kde.org/job/amarok_master/343/changes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 109758: Asx playlist implementation.

2013-04-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109758/ --- (Updated April 15, 2013, 9:27 p.m.) Status -- This change has been

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Alberto Villa
On April 15, 2013, 10:47 p.m., Matěj Laitl wrote: Thanks for the update, glad to see it. I'm just trying out the code, however I got a deadlock - I just clicked Expand Unchosen after or during the lookup, backtrace: #0 syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:39 #1

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Matěj Laitl
On April 15, 2013, 12:54 p.m., Alberto Villa wrote: src/musicbrainz/MusicBrainzTags.cpp, line 588 http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588 Is this too hacky? Matěj Laitl wrote: Calling sort( ... Qt::Descending_or_how_it_is_called ) on the

Re: Review Request 105290: Make MusicBrainz tagger more accurate and easy to use

2013-04-15 Thread Alberto Villa
On April 15, 2013, 12:54 p.m., Alberto Villa wrote: src/musicbrainz/MusicBrainzTags.cpp, line 588 http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588 Is this too hacky? Matěj Laitl wrote: Calling sort( ... Qt::Descending_or_how_it_is_called ) on the

Review Request 110036: WIP - Simple equalizer scripting

2013-04-15 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/ --- Review request for Amarok. Summary (updated) - WIP -