Re: Review Request 111212: Kill long running scripts

2013-06-26 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111212/#review35095 --- src/amarokconfig.kcfg

Re: Review Request 111212: Kill long running scripts

2013-06-26 Thread Anmol Ahuja
On June 26, 2013, 1:42 p.m., Mark Kretschmann wrote: src/amarokconfig.kcfg, line 583 http://git.reviewboard.kde.org/r/111212/diff/3/?file=165737#file165737line583 Please do actually remove the options, including the GUI for them too. I'm sorry, I don't know how I could've left

Re: [amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

2013-06-26 Thread Sven Krohlas
heya, Matěj Laitl wrote: So what is your preference what should happen on double-click? a), b) or c), or do you suggest some d)? How/if ever should we take KDE's settings (single vs. double click) into account? imho: there are reasonable use cases for immediate playing, there are reasonable

[amarok] src/playlist: PlaylistController: revert double-clicking to append start playing if not already

2013-06-26 Thread Matěj Laitl
Git commit a036b39f164ebe8e5060f4ea48bf8854ba6aa87e by Matěj Laitl. Committed on 26/06/2013 at 20:18. Pushed by laitl into branch 'master'. PlaylistController: revert double-clicking to append start playing if not already I dislike this behaviour strongly, but it is fair to level the playing

[amarok] src/browsers: Collection Browser: revert to showing Various Artists even under Artist level [RFC]

2013-06-26 Thread Matěj Laitl
Git commit c336d3777393a177c340f487d14508a6788e519a by Matěj Laitl. Committed on 26/06/2013 at 19:54. Pushed by laitl into branch 'master'. Collection Browser: revert to showing Various Artists even under Artist level [RFC] I don't like this, because it is illogical and shows some of your

Re: [amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

2013-06-26 Thread Myriam Schweingruber
On Wed, Jun 26, 2013 at 9:34 PM, Matěj Laitl ma...@laitl.cz wrote: On 16. 6. 2013 Myriam Schweingruber wrote: Options for the activate (double or single click, per configuration, if we so choose) action; feel free to suggest more: a) append track to playlist and start playing perhaps a