D11192: Ported playdar collection away from qjson

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This ports the playdar collection from qjson to QJsonDocument and QJsonObject. Also removes the unneeded dependency o

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Malte Veerman
malteveerman added a comment. In D11170#222062 , @heikobecker wrote: > While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is rel

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Heiko Becker
heikobecker added a comment. While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.) REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11

D11171: Port NetworkAccessManager to new signal/slot syntax

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This adds some template code to enable using NetworkAccessManager with member function pointers. REPOSITORY R181 A

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Using the new macro gets rid of some deprecation warnings and reduces the used disk space. Needs KPackage >= 5.41. R

D11169: Another QUrl fix

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Just another small QUrl fix that slipped through the cracks last time. REPOSITORY R181 Amarok BRANCH master REV

Re: Amarok 2.9.0 "Hibernaculum" released

2018-03-09 Thread Mark Kretschmann
So if you don't want to go through the hassle of checking it out from Git, you could simply delete that one line in the source code, as indicated by Heiko's linked patch. Sorry for the trouble :) Mark On Fri, Mar 9, 2018 at 8:42 AM, Heiko Becker wrote: > Hello Michał, > > On 03/08/18 12:57, M