D11349: Reactivate wikipedia applet

2018-03-18 Thread Malte Veerman
malteveerman updated this revision to Diff 29856. malteveerman added a comment. Changed fileUrl() to filePath(). Builds now with older KPackage. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11349?vs=29578&id=29856 BRANCH master REVISION DETAIL https:

D11349: Reactivate wikipedia applet

2018-03-18 Thread Heiko Becker
heikobecker added a comment. The method is only available since kpackage-5.42.0. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11349 To: malteveerman, #amarok, markey Cc: heikobecker, markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, tbettler, Sma

D11349: Reactivate wikipedia applet

2018-03-18 Thread Mark Kretschmann
markey requested changes to this revision. markey added a comment. This revision now requires changes to proceed. Fails to build here: /home/mark/devel/src/amarok/src/context/AppletModel.cpp: In member function ‘QUrl Context::AppletModel::imageUrl(const QString&, const QString&)’: /home