D11534: Some small changes and fixes

2018-03-25 Thread Malte Veerman
malteveerman added a comment. There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11534 To: malteveerman, #amarok, mark

D11534: Some small changes and fixes

2018-03-25 Thread Heiko Becker
heikobecker added inline comments. INLINE COMMENTS > Logger.h:61 > +template class... FuncArgs> > +void newProgressOperation( KJob *job, const QString &text, Object > *obj = nullptr, Func slot = nullptr, Qt::ConnectionType type = > Qt::AutoConnection, FuncArgs... args ) > +

D11534: Some small changes and fixes

2018-03-25 Thread Mark Kretschmann
This revision was automatically updated to reflect the committed changes. Closed by commit R181:16d825772150: Some small changes and fixes (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11534?vs=30067&id=30529 R

D11534: Some small changes and fixes

2018-03-25 Thread Mark Kretschmann
markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11534 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar