Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

> On June 21, 2016, 12:42 a.m., Olivier Churlaud wrote: > > Ship It! > > Olivier Churlaud wrote: > It should work with new version: it's a must. If people complain about > older version being broken, then we can see. But archlinux won't be able to > ship

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

> On June 21, 2016, 12:42 a.m., Olivier Churlaud wrote: > > Ship It! It should work with new version: it's a must. If people complain about older version being broken, then we can see. But archlinux won't be able to ship Amarok without this fix.

Re: Review Request 128265: Fix compilation with ffmpeg 3.0

/diff/ Testing --- Compiles Thanks, Olivier Churlaud

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126682/#review96762 --- Ship it! Ship It! - Olivier Churlaud On Jan. 9, 2016

Review Request 128265: Fix compilation with ffmpeg 3.0

--- Change deprecated code See: https://ffmpeg.org/pipermail/ffmpeg-cvslog/2013-December/071930.html Diffs - src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b Diff: https://git.reviewboard.kde.org/r/128265/diff/ Testing --- Compiles Thanks, Olivier Churlaud

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote: > > Looks well, one minor thing below - unrelated change. > > > > Also please mention: > > BUG: 348313 > > ..in the commit message and include a ChangeLog entry in the patch. > > Olivier Churlaud

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

marked as submitted. Review request for Amarok and Myriam Schweingruber. Changes --- Submitted with commit 8c15258b28870b6d9990b24f87ce913e2049bac8 by Olivier CHURLAUD to branch master. Bugs: 349313 https://bugs.kde.org/show_bug.cgi?id=349313 Repository: amarok Description

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

viewboard.kde.org/r/128248/#review96755 --- On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

iew - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96712 --- On June 19, 2016, 11:44 a.m., Olivier

Review Request 128248: Remove non SSL option for Wikipedia applet

don't want to mess my install. Thanks, Olivier Churlaud

Re: Review Request 126171: Compare directories finishing by trailing slash

marked as submitted. Review request for Amarok, Maximilian Kossick and Ralf Engels. Changes --- Submitted with commit 8c8392e95455bd9bf83fa4ddc910f9835351aa3b by Olivier CHURLAUD to branch kf5. Repository: amarok Description --- [This goes on the KF5 branch] After porting KUrl

Port to KF5: Just bored

is on my mind. Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.churlaud.com

Re: [KF5 Port] Threads don't exit with Application

Hi, I found the problem: m_directoryWatcher->abort(); is never triggered, because ~SqlCollection() is never called. I don't know why, and as usual, I have no idea of how the whole thing was thought. Can someone give some help on this? Thank you Olivier Le 29/11/2015 20:29, Oliv

[KF5 Port] Threads don't exit with Application

I tried to find why Amarok does not exit without being killed. Here is the backtrace of the threads... I have no idea of how to solve this... There are several one but I put just a part, because all others repeat themselves like the 8th. Any input would be very welcomed Thx Thread 8

Fwd: [beta] Scripts: Any notable changes?

Hi, I'm wondering if there is no notable changes in the way Amarok handle scripts. On the beta version, AmaroKontrol is now crashing Amarok. I know that it's a third-party software, but I think the crash must be because of some changes in our scripts engin... Thanks Olivier

Fwd: Re: Custom shell/container in plasma for applications

:Olivier Churlaud <oliv...@churlaud.com> Répondre à :kde-de...@kde.org Pour : kde-de...@kde.org I forgot to say: if you want to try it, please use the branch of plasma-framework mart/customShell Cheers Olivier Le 26/11/2015 22:07, Olivier Churlaud a écrit : Hi, with th

Re: Review Request 126128: Port EqualizerDialog

marked as submitted. Review request for Amarok and Ralf Engels. Changes --- Submitted with commit b0fd33cf4a25d18364e7f6fb6fef5decae24c173 by Olivier CHURLAUD to branch kf5. Repository: amarok Description --- EqualizerDialog is now a QDialog Diffs - src/dialogs

Review Request 126171: Compare directories finishing by trailing slash

.html Diffs - src/core-impl/collections/db/MountPointManager.cpp e14cb18 Diff: https://git.reviewboard.kde.org/r/126171/diff/ Testing --- Build, and folders saved in the database Thanks, Olivier Churlaud ___ Amarok-devel mailing list

Re: Review Request 126005: Began to port tests

> On nov. 15, 2015, 2:11 après-midi, Olivier Churlaud wrote: > > Any comments/reviews? ping ? - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#re

Re: Review Request 126005: Began to port tests

> On nov. 15, 2015, 2:11 après-midi, Olivier Churlaud wrote: > > Any comments/reviews? > > Olivier Churlaud wrote: > ping ? I added some people who wrote the Tests... - Olivier --- This is an automaticall

[Port to KF5] Time to work on contexts

about how to replace QtScripts... But this is not for now :) Cheers! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http

Re: Review Request 126128: Port EqualizerDialog

atically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88772 ------- On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote: > > --- > This is a

Re: Review Request 126128: Port EqualizerDialog

nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88699 --- On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote: > > --- > This is an automat

Review Request 126128: Port EqualizerDialog

. Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: [KF5 Port] Impossible to run since update to 5.16

QML code (I hope I can reach rengels...) Cheers Olivier Le 21/11/2015 10:22, Olivier Churlaud a écrit : I removed ~/.local/share/amarok and... I can't run anymore all the tests: tests/testsqlcollection: error while loading shared libraries: ../../../../../src/core-impl/storage/sql

Re: [KF5 Port] Impossible to run since update to 5.16

I didn't know so I share with you (in case): ctest 31,31 -V (or -VV) is the command to run the test 31 and get the details of what failed and what not. I get a lot of errors with the bitrates: any ideas of why I get 257 instead of 256? Cheers Olivier Le 21/11/2015 16:36, Olivier Churlaud

[KF5 Port] To the seniors: Path of directories

a directory, if no trailing slash, add one) in line 235 I would say. Please tell me what solution is better, else I'll try the 3rd one and see what happens. Cheers Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv

Re: [KF5 Port] Impossible to run since update to 5.16

I removed ~/.local/share/amarok and... I can't run anymore all the tests: tests/testsqlcollection: error while loading shared libraries: ../../../../../src/core-impl/storage/sql/mysqlestorage/amarok_storage-mysqlestorage.so: cannot open shared object file: No such file or directory ... I

Deprecation of QtScript

work is still hidden here" Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.ch

[KF5 Port] Impossible to run since update to 5.16

or directory and the application crashes where it didn't before Can you check on your side please? -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com

Re: Review Request 126005: Began to port tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#review88383 --- Any comments/reviews? - Olivier Churlaud On nov. 9, 2015

Re: Review Request 126005: Beginned to port tests

- testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 126005: Began to port tests

- testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 126005: Began to port tests

> On nov. 9, 2015, 1:12 après-midi, Olivier Churlaud wrote: > > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp, line 401 > > <https://git.reviewboard.kde.org/r/126005/diff/1/?file=415876#file415876line401> > > > > This line doesn't concern the

Re: Review Request 126005: Beginned to port tests

ment60476> This comment should be removed. tests/dynamic/TestDynamicModel.cpp <https://git.reviewboard.kde.org/r/126005/#comment60478> this caused a segfault. Removing it solve the issue but causes a memory leak - Olivier Churlaud On nov. 9, 2015, 1:08 après-midi, Oliv

Porting to KF5: DBus policies

ok::Mpris2( this ); and is the order important? Thx Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.ch

Re: [KF5Port] Next-bug: mysql ?

s you can see the only difference comes from the last '/'. Solutions: What should I do? Do I hardcode 'm_foundDirectories.contains( path+'/') ? I tried and it works.. Do you have a better solution? I'll try to find the difference with 2.8, but I'd like to know what I should do. Cheers Olivier

Re: Porting to KF5: DBus policies

relevant? Cheers Olivier Le 07/11/2015 23:00, Olivier Churlaud a écrit : Hi, Since there are some problem to quit the app, I dug a little in the DBus of Amarok. I have several questions: 1) Why are we using org.mpris.MediaPlayer2.amarok ? Should we go to org.kde.amarok? (To me it would make

Re: [Senior Devs] Amarok and SQL queries

Le 01/11/2015 18:15, Soren Harward a écrit : On Sun, Nov 1, 2015 at 6:15 AM, Olivier Churlaud <oliv...@churlaud.com> wrote: I wonder: why are the mysql libraries directly used and not the Qt framework (QSqlQueries and so on)? IIRC, it's entirely historical. For a handful of reasons tha

Re: Review Request 125872: threadweaver issue solved

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87691 --- Ship it! Ship It! - Olivier Churlaud On oct. 29, 2015, 6

New branch KF5_Kuniqueapp

... If you want, play around with this new branch. We are still working on this with Rishabh Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com

Re: Fwd: segfault(kf5 port olivier )

-- From: *RISHABH GUPTA* <rishabh9...@gmail.com <mailto:rishabh9...@gmail.com>> Date: Fri, Oct 23, 2015 at 1:51 PM Subject: segfault(kf5 port olivier ) To: amarok-devel@kde.org <mailto:amarok-devel@kde.org> Message: 2Date: Tue, 20 Oct 2015 22:50:25 +0200 From

Re: [KF5 port] Source of sigfault found, not understood

Le 23/10/2015 01:32, Soren Harward a écrit : On Wed, Oct 21, 2015 at 7:42 AM Myriam Schweingruber > wrote: UserRole and GroupRole are not exactly the same thing, will this not make the Playlist behave differently? Not

Re: [Port KF5] Why we get so many segfault...

Hi, Le 22/10/2015 18:22, Aditya Sharma a écrit : Hello, Sorry for not being able to get back to you on IRC. I have been busy with another project of mine at my university for quite some time now. If a method was virtual before and is pure virtual now then one can't

Re: [Port KF5] Why we get so many segfault...

Hi, once again I was wrong. The issue is triggered according to what you comment in the listForLevel() function (the one I was talking about sooner)... But what exactly and why? I'm still searching... Olivier Le 22/10/2015 20:03, Olivier Churlaud a écrit : Hi, Le 22/10/2015 18:22, Aditya

Re: [KF5 port] Source of sigfault found, not understood

Hi > Le 21 oct. 2015 à 13:42, Myriam Schweingruber <myr...@pharma-traduction.ch> a > écrit : > > Hi Olivier, > >> On Wed, Oct 21, 2015 at 12:39 PM, Olivier Churlaud <oliv...@churlaud.com> >> wrote: >> I think I found the source of the error: >

Re: [KF5 port] Source of sigfault found, not understood

this? Cheers Olivier Le 21/10/2015 11:30, Olivier Churlaud a écrit : Hi, the error I was tracking occures in src/playlist/proxymodels/GroupingProxy.cpp Meta::TrackPtr prevTrack = prevIndex.data( TrackRole ).value();// Invalid index is OK: Meta::TrackPtr thisTrack = thisIndex.data

[Port KF5] Plugins

rt QT_PLUGIN_PATH=/home/olivier/Projets/bin_amarok/lib64/plugins Then you get a segfault. backtrace : https://paste.kde.org/pudfq87od trace: https://paste.kde.org/p8huiotxh The next step is to correct this... Cheers! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual

Re: Review Request 125593: removed the Line that deleted m_args

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125593/#review86663 --- Ship it! Ship It! - Olivier Churlaud On oct. 11, 2015, 3

Re: Applying Churlaud's patch - KF5/Qt5

Hi there, Le 03/10/2015 22:23, Aditya Sharma a écrit : I applied Olivier's patch from the Review Board. He has still not committed anything so I proceeded anyway with his patch. I'll commit anyway today, so that everyone can work from the same basis... If at the end, someone thinks it's not

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125519/#review86342 --- Ship it! Ship It! - Olivier Churlaud On oct. 4, 2015, 7

Re: Applying Churlaud's patch - KF5/Qt5

I commit my patch now, please commit yours afterwards so that we don't mess up everything :) Olivier Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

Hi, Ship It! Please commit on my behalf. I don't have a dev account :) Then request one ! https://techbase.kde.org/Contribute/Get_a_Contributor_Account#How_to_get_read-write_access_to_git.2Fsvn Cheers, Olivier ___ Amarok-devel mailing

Re: KF5 Port Status

Hi, Le 25/09/2015 11:23, Myriam Schweingruber a écrit : Hi Aditya, On Thu, Sep 24, 2015 at 3:44 PM, Aditya Sharma wrote: So finally I am over with my University Exams and have a lot of time up my sleeve. Nice :) What's the current porting status ? Normally

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

25, 2015, 10:42 après-midi) > > > Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam > Schweingruber. > > > Repository: amarok > > > Description > --- > > We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installing &g

Re: kf5port(olivier)

; a écrit: >> >> Message: 3 >> Date: Mon, 14 Sep 2015 14:55:30 +0200 >> From: Olivier Churlaud <oliv...@churlaud.com> >> To: amarok-devel@kde.org >> Subject: Re: kf5port(olivier) >> Message-ID: <55f6c3c2.8050...@churlaud.com> >> Content-Type: t

Re: Playlists

Le 15/09/2015 17:12, Soren Harward a écrit : On Tue, Sep 15, 2015 at 10:14 AM, Olivier Churlaud <oliv...@churlaud.com> wrote: 1) Does the Automatic Playlist Generator work on your system? Nothing happens here, it may be broken. I pushed some fixes a couple months ago, but the origin/kf5

Playlists

to choose fast there. (without having to type ' added:<4w ' ) Thank you ! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: h

Re: KF5 port continued

Le 14/09/2015 13:29, Aditya Sharma a écrit : thanks Somsubhra for making the port compile. I compiled it and got a segfault related to liblastfm. Please note that the Qt5 liblastfm is called liblastfm5.so, I changed this for lastfm & mygpo-qt in CMakeLists Exactly what

Re: kf5port(olivier)

rvices/opmldirectory/OpmlDirectoryInfoParser.cpp f6ac752 >> >> Diff: https://git.reviewboard.kde.org/r/125126/diff/ >> >> >> Testing >> --- >> >> It compiles 100%, and there is

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

> On sep. 13, 2015, 6:59 après-midi, Olivier Churlaud wrote: > > Regarding the code, everything seems fine. Now the real question is about > > the shortcuts. Are they really good? Logical? > > > > I'm not the one to judge on this. But a Shift+E for instance might

Re: Kf5 port(olivier)

> Le 14 sept. 2015 à 10:51, RISHABH GUPTA <rishabh9...@gmail.com> a écrit : > > >> -- >> >> Message: 3 >> Date: Sun, 13 Sep 2015 17:59:49 - >> From: "Olivier Churlaud" <oliv...@churlaud.com&

Re: kf5 port(olivier)

Le 14/09/2015 00:21, Aditya Sharma a écrit : Hi, Hey ! Then apply the last diff from the review board and see if you can help me to cgo further and clean it up. ;) Applied your last diff, using patch -p1 < patch.txt But the Segmentation fault remains the same. The same

Re: kf5 port(olivier)

why this happen, I'll do this on my side too. Cheers, Olivier Thanks, Olivier Churlaud thanks, rishabh ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listi

Re: kf5 port(olivier)

here's the output http://pastebin.com/5StyEUth Huuu Wait, it's not possible. My segfault doesn't happen in handleCliArgs() but way after... It means that I left a bug, that works on my system but not yours OR that something is wrong on your side. Please investigate why this happen, I'll

Re: Amarok-devel Digest, Vol 104, Issue 15

Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st) Your log is very interesting, what debugger do you use? With gdb, I can't get such a deep description (but I may not know how to use it well). With

Re:Port KF5

Here is my full log : http://pastebin.com/Z28JJERv I think you didn't apply the diff well Le 13/09/2015 18:52, Olivier Churlaud a écrit : Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st) Your log

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

question is about the shortcuts. Are they really good? Logical? I'm not the one to judge on this. But a Shift+E for instance might have bad repercussions (if you type Editors in the search field, what happens? Is the slot triggered?) If Mamarok says it's ok, then ship it. - Olivier Churlaud

Re: Preparing to move to Phabricator

Hey, great news! Did you already request a Project repo / space for Amarok? It's way more user friendly than bugzilla :) Cheers, Olivier Le 12/09/2015 13:34, Myriam Schweingruber a écrit : Dear all, KDE is preparing to move to http://phabricator.kde.org to replace the current systems

Time for QML

is completely different since the view (QML) is totally separated from the functions. So there will be a lot of reprogramming to do... If you have some knowledge in qml, please let me know!! Have fun! Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125076/#review85199 --- Ship it! Ship It! - Olivier Churlaud On sep. 6, 2015, 7

Porting to KF5: help needed on KServiceTypeTrader

Hi, I'm looking for the help of someone who is better than I am with the KDE libs. I began to port the main files out of KDE4. I now have this problem: /KServiceTypeTrader: serviceType "Amarok/Plugin" not found/ It happens in the file src/PluginManager, in findPlugins(). I'm quite

Re: Porting to KF5: help needed on KServiceTypeTrader

Sorry for this, the problem was due to the wrong kdemacros.h in headers (the KDE4 instead of KF5 one) Olivier Le 11/09/2015 17:41, Olivier Churlaud a écrit : Hi, I'm looking for the help of someone who is better than I am with the KDE libs. I began to port the main files out of KDE4. I

Review Request 125126: Port of main.cpp and App class

correct or not. http://pastebin.com/naduYv8M There are still some small things that aren't port. (for instance calling a second instance to use the --play, -r,...) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Fwd: Playlist usability

instead of the user support list. Regards, Myriam -- Forwarded message -- From: Olivier Churlaud <oliv...@churlaud.com> Date: Wed, Sep 9, 2015 at 3:31 PM Subject: Playlist usability To: ama...@kde.org Hi, I'm trying to find if some of the features that I'm l

Re: KF5 port continued

/amarpokpkg.cpp (not perfect but still something) to port the main.cpp file. After this, launching the minimal Amarok and debugging it will be easier. Have fun! Cheers, Olivier Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv

Re: kf5 port continued(stefan derkits)

Hi Rishabh, If you are in a safe environment (I mean that you don't risk to break some existing configurations), try a make install and to start amarok. It should fail. Le 07/09/2015 18:56, RISHABH GUPTA a écrit : Message: 1 Date: Sun, 6 Sep 2015 02:22:43 +0200 From: Stefan

Re: Idea for the porting

Le 29/08/2015 21:40, Olivier Churlaud a écrit : Hi, Today I read a harsh discussion on #amarok.devel. I'm not going to talk about it, but about an idea I get. Please tell me whether you agree on it, or not. I think we should port it first as a minimal version that...play music. We know

Idea for the porting

relevant? For splitting the job, and having a full port (and maybe maintainers?) it would be, IMO, a real gain. Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http

Re: amarok port to kf5

Le 20/08/2015 20:17, RISHABH GUPTA a écrit : hello olivier, Hi! Through amarok-devel mailing list i came to know that you are helping out aroonav in the porting process.I would like to do the same but for that i need some help which would help me getting started .I read the mails between

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

Hi, while reading this I ask myself if it complies with the HiG ( https://techbase.kde.org/Projects/Usability/HIG). For instance Ctrl+A, Ctrl+Shift+C... Furthermore, i'm not sure it's relevant to impose this. It should just be editable in the shortkeys edition window. It's just what I think

Help for porting to QML

the other classes from context. Please let me know: you could port the file directly and give it to me as a model, or help me on IRC. It would be really appreciate, and you'd gain my eternal gratitude :D Cheers Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual

Re: Help for porting to QML

Btw I forgot to say, on irc, I'm ochurlaud :) Le 12/08/2015 12:09, Olivier Churlaud a écrit : Hi, Could someone help me to port, say Context::Applet (src/context/applet.{cpp|h}) ? I don't know how to begin. Since I can't test it directly, I'm afraid to break something if I start from

Re: Review Request 124678: porting Amarok to KF5 - 3 Commits

/lastfm/meta/LastFmMeta.cpp 46aa8fe tests/TestExpression.h cfa2a0c tests/TestQStringx.h 8cf14c3 tests/TestSmartPointerList.h 72c95aa tests/TestSmartPointerList.cpp 8e9865b Diff: https://git.reviewboard.kde.org/r/124678/diff/ Testing --- Thanks, Olivier Churlaud

Re: Review Request 124678: porting Amarok to KF5 - 3 Commits

Le 11/08/2015 07:00, Aroonav Mishra a écrit : Hello Olivier, Hi I tried getting in touch with you on IRC about this. On 10 August 2015 at 04:55, Olivier Churlaud oliv...@churlaud.com mailto:oliv...@churlaud.com wrote: @Aroonav: it's specially for you... tell me what I'm supposed

Review Request 124678: porting Amarok to KF5 - 3 Commits

tests/TestSmartPointerList.h 72c95aa tests/TestSmartPointerList.cpp 8e9865b Diff: https://git.reviewboard.kde.org/r/124678/diff/ Testing --- Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org

Re: Review Request 124678: porting Amarok to KF5 - 3 Commits

or directory that I don't understand. Thx Olivier Le 10/08/2015 01:13, Olivier Churlaud a écrit : This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124678/ Review request for Amarok. By Olivier Churlaud. *Repository: * amarok Description It's my first

Re: Review Request 124678: porting Amarok to KF5 - 3 Commits

://git.reviewboard.kde.org/r/124678/diff/ Testing --- Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Helping porting to KF5 - to Aroonav

Hi , thx for your answers! Le 07/08/2015 20:40, Aroonav Mishra a écrit : But right now the biggest concern is the code in src/context on which the view of the application depends. I think that it will have to be ported to QML as KF5 only supports widgets in QML. It will be really nice if

Helping porting to KF5 - to Aroonav

for your answers. Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.churlaud.com