D10526: Port core application away from kdelibs4

markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok, markey Cc: heikobecker, asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, paul, yaohanchen, malteveerman, cochise, tbettler, Smar, ricktimmis,

D10526: Port core application away from kdelibs4

markey accepted this revision. markey added a comment. This revision is now accepted and ready to land. Looks good to me. Builds and works fine too. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok, markey Cc: heikobecker,

D10526: Port core application away from kdelibs4

heikobecker added a comment. In D10526#207631 , @asturmlechner wrote: > fwitw I've build-tested the patch and it builds and starts up fine. Same here, and it also fixes some issues I experienced earlier. REPOSITORY R181 Amarok

D10526: Port core application away from kdelibs4

asturmlechner added a comment. fwitw I've build-tested the patch and it builds and starts up fine. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc: asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, yaohanchen,

D10526: Port core application away from kdelibs4

malteveerman edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc: asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, yaohanchen, malteveerman, progwolff, cochise, tbettler, Smar,

D10526: Port core application away from kdelibs4

asturmlechner added a comment. I guess this was really meant as '...away from kdelibs4support' instead of kdelibs4, hence the confusion. But yes it is targeting the correct branch. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc:

D10526: Port core application away from kdelibs4

stikonas added a comment. > ! In D10526#207232 , @markey wrote: > The Amarok-KF5 development is in a different branch from master, so it's independent. Any work done in the KF5 branch has no influence on the KDE 4 Amarok code, so that could

D10526: Port core application away from kdelibs4

markey added a comment. In D10526#206680 , @spettini wrote: > Can I suggest we release 2.9 as planned, with the current state and maybe > some more bugfixes, before integrating this patch? Once migration to kf5 is > complete, and new

Re: D10526: Port core application away from kdelibs4

Can I suggest we release 2.9 as planned, with the current state and maybe some more bugfixes, before integrating this patch? Once migration to kf5 is complete, and new patches will be needed for that, we may start thinking about a 3.0. Stefano On Thu, Feb 15, 2018 at 6:15 AM, Malte Veerman

D10526: Port core application away from kdelibs4

spettini added a comment. Can I suggest we release 2.9 as planned, with the current state and maybe some more bugfixes, before integrating this patch? Once migration to kf5 is complete, and new patches will be needed for that, we may start thinking about a 3.0. REPOSITORY R181 Amarok

D10526: Port core application away from kdelibs4

malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This patch ports the core app away from kdelibs4 to pure qt5/kf5. Kdelibs4 classes that don't have an equivalent in