D11170: Use new kpackage_install_bundled_package macro

2018-05-09 Thread Mark Kretschmann
markey accepted this revision. markey added a comment. This revision is now accepted and ready to land. Restricted Application removed a project: Amarok. Restricted Application added a subscriber: amarok-devel. Ubuntu 18.04 is now released, and your patch builds fine with it. REPOSITORY R181

D11170: Use new kpackage_install_bundled_package macro

2018-05-09 Thread Mark Kretschmann
markey closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11170 To: malteveerman, #amarok, markey Cc: amarok-devel, markey, heikobecker, #amarok

D11170: Use new kpackage_install_bundled_package macro

2018-04-05 Thread Malte Veerman
malteveerman updated this revision to Diff 31425. malteveerman added a comment. Just a rebase. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11170?vs=29062&id=31425 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11170 AFFECTED FILES CMa

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Malte Veerman
malteveerman added a comment. In D11170#222062 , @heikobecker wrote: > While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is rel

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Heiko Becker
heikobecker added a comment. While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.) REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11

D11170: Use new kpackage_install_bundled_package macro

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY Using the new macro gets rid of some deprecation warnings and reduces the used disk space. Needs KPackage >= 5.41. R