This revision was automatically updated to reflect the committed changes.
Closed by commit R181:12d7ecbfe6e8: Port NetworkAccessManager to new
signal/slot syntax (authored by malteveerman, committed by markey).
REPOSITORY
R181 Amarok
CHANGES SINCE LAST UPDATE
markey accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R181 Amarok
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11171
To: malteveerman, #amarok, markey
Cc: markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise,
tbettler,
malteveerman updated this revision to Diff 29438.
malteveerman added a comment.
Previous diff relied on a function of QMetaObject added in Qt 5.10. This now
works with older versions of Qt, too.
REPOSITORY
R181 Amarok
CHANGES SINCE LAST UPDATE
markey requested changes to this revision.
markey added a comment.
This revision now requires changes to proceed.
This does not build for me (GCC 7.2.0).
Error: https://pastebin.com/5Pmk1ELp
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D11171
To: malteveerman,
malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.
REVISION SUMMARY
This adds some template code to enable using NetworkAccessManager with member
function pointers.
REPOSITORY
R181