D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor, heikobecker Cc: heikobecker, yurchor, amarok-devel

D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Andreas Sturmlechner
asturmlechner added a comment. This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while. REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor,

D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Heiko Becker
heikobecker accepted this revision. heikobecker added a comment. Yeah, that didn't happen for me as well, but QSP is actually used (line 75). REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor,

D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Andreas Sturmlechner
asturmlechner added a comment. -c /var/tmp/portage/media-sound/amarok-/work/amarok-/src/main.cpp /var/tmp/portage/media-sound/amarok-/work/amarok-/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]

D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Yuri Chornoivan
yurchor added a comment. Is it really needed? It seems that build factory can build Amarok even without this include. https://build.kde.org/job/Extragear/job/amarok/ Thanks in advance for your answer. REPOSITORY R181 Amarok REVISION DETAIL

D18674: Add missing QStandardPaths to fix build

2019-02-02 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Amarok, markey. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 AFFECTED FILES