D24413: Fix Increase/Decrease Volume shortcuts

wbauer closed this revision. wbauer added a comment. Commited with https://invent.kde.org/multimedia/amarok/commit/87c56f8a130b2ddf183922015ce5bb31173bd912 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24413 To: wbauer, #amarok, schweingruber Cc: heikobecker, schwe

D24413: Fix Increase/Decrease Volume shortcuts

wbauer added a comment. Herald added a project: Amarok. Ok, as it was accepted, and there were no further comments since my last question whether I should change it, I'm just going to commit it now. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24413 To: wbauer, #a

D24413: Fix Increase/Decrease Volume shortcuts

wbauer added a comment. In D24413#550948 , @heikobecker wrote: > I'm always easy to confuse about pointers and const, but isn't ec a const pointer to a const object? So calling ec->increaseVolume() as a non-const function) wouldn't really work

D24413: Fix Increase/Decrease Volume shortcuts

heikobecker added a comment. In D24413#542042 , @wbauer wrote: > In D24413#542035 , @ognarb wrote: > > > Since the method is only one line long, why not using lambda instead here? > > > Be

D24413: Fix Increase/Decrease Volume shortcuts

schweingruber accepted this revision. schweingruber added a comment. This revision is now accepted and ready to land. I'm ok with it, unless better suggestions pop up :-) REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24413 To: wbauer, #amarok, schweingruber Cc: schw

D24413: Fix Increase/Decrease Volume shortcuts

wbauer added a comment. Ping? Btw, I mainly followed what was done for the stop() action in commit 1b81541e , where a new `regularStop()` slot was created for similar reasons AIUI. Further suggestions how to

D24413: Fix Increase/Decrease Volume shortcuts

wbauer added a comment. In D24413#542035 , @ognarb wrote: > Since the method is only one line long, why not using lambda instead here? Because I couldn't get it to compile successfully, I got this error: In lambda function passing 'const

D24413: Fix Increase/Decrease Volume shortcuts

ognarb added a comment. Since the method is only one line long, why not using lambda instead here? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24413 To: wbauer, #amarok Cc: ognarb, amarok-devel, #amarok

D24413: Fix Increase/Decrease Volume shortcuts

wbauer created this revision. wbauer added a reviewer: Amarok. wbauer added a project: Amarok. Herald removed a project: Amarok. wbauer requested review of this revision. REVISION SUMMARY `EngineController::increaseVolume( int ticks )` and `EngineController::decreaseVolume( int ticks )` take an

D24413: Fix Increase/Decrease Volume shortcuts

wbauer added a comment. PS: I think the argument is 0 because QAction::triggered() has a `bool checked` argument. But Qt's new signal/slots syntax doesn't support default arguments anyway, according to the docs. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24413