Herald added a project: Amarok.
Herald removed a subscriber: Amarok.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D24817
To: nicolamori, amarok-devel, heikobecker
Cc: asturmlechner, malteveerman, heikobecker, amarok-devel, jfowkes, pgomes,
nicolamori, jyasi, mfraser,
nicolamori added a comment.
@heikobecker The bindings are extracted from the source of QCad; they are
statically placed in their code base, with one folder for each Qt version; if
there are more Qt versions sharing the same bindings then the bindings are
present only for one version and for
heikobecker requested changes to this revision.
heikobecker added a comment.
This revision now requires changes to proceed.
How are those bindings generated? I assume they change depending on the used
Qt version? Could it be feasible to convince cmake to generate them during
build time?
nicolamori added a reviewer: amarok-devel.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D24817
To: nicolamori, amarok-devel
Cc: malteveerman, heikobecker, #amarok, amarok-devel
nicolamori added a comment.
I just uploaded a new revision with installation rules for the bindings
shared libraries. I also checked the QCAD license: they release the code under
GPLv3 with no exceptions (as far as I understood) for the bindings code, so I
guess there's no licensing issue
nicolamori updated this revision to Diff 74024.
nicolamori added a comment.
- scripting: add installation rule for qt script bindings plugin libraries.
- scripting: add readme file with credits to QCAD project.
REPOSITORY
R181 Amarok
CHANGES SINCE LAST UPDATE
nicolamori added a comment.
Hi Heiko, I know that QtScript is EOL but I don't have the knowledge nor
spare time to do more than this ATM. I never contributed to Amarok nor any
other KDE project, and also my experience with Qt is limited to some simple
GUI. Nevertheless, I hope that this
heikobecker added a comment.
Nice! I don't want to discourage you, but while QtScript is still there it
has been deprecated. Perhaps this still makes sense as a intermediate step, but
at some point this should be ported to the QJS* classes from Qt5Qml (e.g. like
done for kio
nicolamori created this revision.
Herald added subscribers: amarok-devel, Amarok.
nicolamori requested review of this revision.
REVISION SUMMARY
Restore the loading of Qt bindings and import bindings into the Amarok code
base.
The bindings files are added unmodified as extracted from the
