D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

vmatare added a comment. In D28284#676180 , @macfanplx wrote: > whats the common sense of using different names for the same product? MariaDB is the same as MySql, just different names; core and everything else stays the same. I don't

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

macfanplx added a comment. whats the common sense of using different names for the same product? MariaDB is the same as MySql, just different names; core and everything else stays the same. REPOSITORY R181 Amarok BRANCH mysqle-split-for-phab REVISION DETAIL

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

malteveerman added inline comments. INLINE COMMENTS > wbauer wrote in FindMySQLe.cmake:45 > > Although, I just noticed that it actually does that below (in line#73ff) if > > (NOT MYSQLE_LIBRARIES), so maybe it would just be enough to remove the > > set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) here

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added inline comments. INLINE COMMENTS > wbauer wrote in FindMySQLe.cmake:45 > Right, that's exactly what I was referring to in my last comment, and what > the openSUSE patch I mentioned (which originally was taken from Arch) is > supposed to fix. > > I.e. instead of

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added inline comments. INLINE COMMENTS > malteveerman wrote in FindMySQLe.cmake:45 > This breaks embedded for me. The embedded storage plugin silently links > against libmysqlclient and then fails when initializing. > It's a problem that exists independently of this revision but I

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

malteveerman added inline comments. INLINE COMMENTS > FindMySQLe.cmake:45 > +# below. > +set(MYSQLE_LIBRARIES ${MYSQL_LIBRARIES}) > +else() This breaks embedded for me. The embedded storage plugin silently links against libmysqlclient and then fails when initializing. It's

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. One thing I should note though: we do use a patch to fix things on openSUSE currently, but that's not a problem of this change. I plan to propose our patch upstream anyway (I originally took it from Arch Linux and didn't really understand why it is needed),

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. Sorry if you were waiting for me. It's good to go in from my side. I actually built mariadb-connector-c without mysql support here as a test, and it still worked fine. Although, there has been a change to master meanwhile that you probably should integrate:

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH mysqle-split-for-phab REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner marked an inline comment as done. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner updated this revision to Diff 78497. asturmlechner added a comment. re-add accidentally removed required includes to FindMySQLe.cmake REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28284?vs=78487=78497 BRANCH mysqle-split-for-phab REVISION

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. In D28284#634644 , @wbauer wrote: > On openSUSE, it doesn't enable MySQLe anymore: > >-- Found MySQL: -L/usr/lib64 -lmariadb > /usr/bin/mysql_config: unrecognized option '--libmysqld-libs' > -- Performing

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

wbauer added a comment. On openSUSE, it doesn't enable MySQLe anymore: -- Found MySQL: -L/usr/lib64 -lmariadb /usr/bin/mysql_config: unrecognized option '--libmysqld-libs' -- Performing Test HAVE_MYSQL_OPT_EMBEDDED_CONNECTION -- Performing Test

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner created this revision. asturmlechner added reviewers: Amarok, heikobecker, wbauer. Herald added a project: Amarok. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REVISION SUMMARY - Previously, MariaDB lib was only found w/ distro provided