D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
pgomes marked an inline comment as done. pgomes added inline comments. INLINE COMMENTS > heikobecker wrote in TokenDropTarget.cpp:211 > Any particular reason to change this? Admittedly it doesn't really matter, > given nothing is promoted as external library. No particular reason. I reverted

D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
pgomes added a comment. In D28593#645766 , @heikobecker wrote: > Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716 Yes, this seems to be the same

D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
This revision was automatically updated to reflect the committed changes. Closed by commit R181:96eaac4fc099: Fix copying and moving files to collection (authored by pgomes). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28593?vs=79405=79865#toc REPOSITORY R181 Amarok CHANGES SINCE

D28593: Fix copying and moving files to collection

2020-04-11 Thread Heiko Becker
heikobecker added a comment. Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28593 To: pgomes, #amarok, amarok-devel, heikobecker

D28593: Fix copying and moving files to collection

2020-04-11 Thread Heiko Becker
heikobecker accepted this revision. heikobecker added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TokenDropTarget.cpp:211 > > -Q_EMIT changed(); > +emit changed(); > } Any particular reason to change this? Admittedly it doesn't really matter,

D28593: Fix copying and moving files to collection

2020-04-05 Thread Pedro Gomes
pgomes created this revision. pgomes added reviewers: Amarok, amarok-devel. pgomes created this object with edit policy "Administrators". pgomes added projects: Amarok, Qt 5 Porting. pgomes requested review of this revision. REVISION SUMMARY The importation of files to collections was not