Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-08 Thread Matěj Laitl
On March 8, 2012, 1:14 p.m., Bart Cerneels wrote: I feel you should still show the file path in the confirmation dialog. After all, you might have duplicates you want to remove and can't be sure which copy it is. The latest version shows it in all cases. (or you talk about prettyUrl()

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-08 Thread Bart Cerneels
On March 8, 2012, 1:14 p.m., Bart Cerneels wrote: I feel you should still show the file path in the confirmation dialog. After all, you might have duplicates you want to remove and can't be sure which copy it is. Matěj Laitl wrote: The latest version shows it in all cases. (or

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review11247 --- This review has been submitted with commit

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review11213 --- It is good that you factored the common code to its own

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/ --- (Updated March 7, 2012, 10:30 p.m.) Review request for Amarok. Changes

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review11219 --- Ship it! Good! I will push this tomorrow. - Matěj Laitl On

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/ --- (Updated March 7, 2012, 11:12 p.m.) Review request for Amarok. Changes

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-03-07 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/ --- (Updated March 7, 2012, 11:39 p.m.) Review request for Amarok. Changes

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2012-01-16 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/#review9875 --- Sorry for the late response. Still a nice patch, except for

Re: Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2011-09-11 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/ --- (Updated Sept. 10, 2011, 10:26 p.m.) Review request for Amarok. Changes

Review Request: Fix for bug 263693: The Delete Tracks dialog is misleading/ambiguous

2011-08-09 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102236/ --- Review request for Amarok. Summary --- Fix for bug 263693. When the